fix(editor): overview rows ask first, no empty save, board 31 icons
U2 Task 6 review by self: - The overview stays shown during a selection (A3): its rows and view rows now go through the drawing guard, so a started move or redraw asks before a click there drops it (R-12). Was a regression: the column was unreachable while selected before Task 6. - The edit form compares and merges trimmed names and colour: a space typed alone is no change and writes no `update`. - A layer opened with no opener (reload, Forward) returns the focus to its row on close. - Board 31 A: icons on « Modifier », « Modifier la forme » (the shape's glyph), « Marquer comme relu »; « Supprimer » as red text with its trash icon. - Tests: overview row and view row ask during a started move; a row asks during a started redraw; whitespace-only save; unnamed link read rows; focus back to the row with no opener. Dead helpers removed (tests/helpers openProperties, e2e propertiesDialog). Mapping: the point-edit « Enter on the selected row … asks first » test (which replaced « Toutes les annotations asks first ») keeps its place; the overview-row path it did not cover now has its own test.
This commit is contained in:
1 parent
cd794f3c39
commit
ebcf2723a0
10 files changed
+145
-25
No files matched your search
@@ -48,6 +48,11 @@ export function useDialogOpening(
|
||||
const opened = useRef<{ id: string; by: OpenedBy } | null>(null)
|
||||
const latest = useRef(layer)
|
||||
latest.current = layer
|
||||
// A layer opened by a reload or a Forward has no opener: its row is the way back.
|
||||
const shown = layer?.view?.id
|
||||
if (shown && opened.current?.id !== shown) {
|
||||
opened.current = { id: shown, by: 'drawing' }
|
||||
}
|
||||
const open: OpenDialog = (id, by) => {
|
||||
const go = () => {
|
||||
opened.current = { id, by }
|
||||
|
||||
Reference in new issue
Block a user