docs(docs): R4 final fix wave as built, results and trial step
Busy look, stopped-engine tone, focus when no retry is left, board 30 deviation fixed, cleanup name check, write-budget row as R4's own, row C built by R4 pending the owner's validation, exact results of the wave.
This commit is contained in:
1 parent
3bea19f16b
commit
e79118cecf
4 files changed
+53
-27
No files matched your search
@@ -213,6 +213,7 @@ Finding 6 (an opening guillemet can end a line, « version / 1 » orphan in the
|
||||
checked by the review: the card's badges and working copy action, the owner's layout (deduced from the code), the
|
||||
English wording, the 0 or 1 sheet link, distinct dates, hover, screen reader output.
|
||||
|
||||
2026-11-17: R4 built against board 30 (`docs/development/V1-2-6_U1_CORRECTIONS.md` §R4 « As built 2026-11-17 »). Known
|
||||
deviation, pending the design review, not fixed: at 1 280 px the network card stacks « Réessayer » above « Consulter »
|
||||
(the card's width wraps the button row), where board 30 draws them side by side.
|
||||
2026-11-17: R4 built against board 30 (`docs/development/V1-2-6_U1_CORRECTIONS.md` §R4 « As built 2026-11-17 »). The
|
||||
deviation the design review found is fixed (R4 final fix wave): at 1 280 px the network card stacked « Réessayer » above
|
||||
« Consulter » (the card's width wrapped the button row by a few pixels); the failure row now narrows its buttons'
|
||||
padding, so both sit side by side as on board 30, 44 px high, the wrap kept as the fallback.
|
||||
@@ -648,11 +648,13 @@ l'action, puis l'attendu. Étapes 1 à 5 à 1 280 px, étape 6 sur un téléphon
|
||||
onglet « Network » (« Réseau »), réglez « No throttling » sur « Offline ». Remplacez « sandbox » par le nom noté
|
||||
à l'étape 1. Attendez environ 7 secondes : la lecture de la date est retentée trois fois avant d'abandonner, et la
|
||||
carte attend la fin de ces essais. Attendu : la carte saine montre une ligne ambrée avec l'icône « pas de réseau »
|
||||
et « Connexion au serveur impossible. Vérifiez votre réseau. », puis « Réessayer » et « Consulter ». Remettez
|
||||
et « Connexion au serveur impossible. Vérifiez votre réseau. », puis « Réessayer » et « Consulter » côte à côte
|
||||
(à 1 280 px aussi). Remettez
|
||||
« No throttling » (en ligne), puis cliquez « Réessayer ». Attendu : pendant l'essai, la ligne et le bouton restent
|
||||
en place ; puis la ligne disparaît, les compteurs et la vignette apparaissent, et le focus passe sur « Consulter »
|
||||
de cette carte. Si vous cliquez « Réessayer » encore hors ligne, la ligne revient après environ 7 secondes et le
|
||||
focus reste sur « Réessayer ».
|
||||
en place, le bouton grisé ; puis la ligne disparaît, les compteurs et la vignette apparaissent, et le focus passe
|
||||
sur « Consulter » de cette carte. Si vous cliquez « Réessayer » encore hors ligne, la ligne ne disparaît pas : rien
|
||||
ne change pendant environ 7 secondes (le bouton est grisé), puis le bouton redevient normal et le focus reste sur
|
||||
« Réessayer ».
|
||||
5. Anglais. Action : passez l'interface en « EN » et refaites l'étape 2. Attendu : « Integrity check failed: this
|
||||
version cannot be displayed. »
|
||||
6. Téléphone (375 px). Action : refaites les étapes 2 et 4 à 375 px (sur un téléphone, l'étape 4 demande les outils
|
||||
@@ -660,8 +662,8 @@ l'action, puis l'attendu. Étapes 1 à 5 à 1 280 px, étape 6 sur un téléphon
|
||||
carte par ligne, la phrase passe à la ligne, « Réessayer » et « Consulter » font au moins 44 px de haut, aucun
|
||||
défilement horizontal.
|
||||
|
||||
Écart connu, en attente de la revue graphique : à 1 280 px, la carte réseau empile « Réessayer » au-dessus de
|
||||
« Consulter », alors que la planche 30 les dessine côte à côte (`docs/design/README.md`).
|
||||
L'écart relevé par la revue graphique (à 1 280 px, la carte réseau empilait « Réessayer » au-dessus de
|
||||
« Consulter ») est corrigé : les deux boutons sont côte à côte, comme sur la planche 30 (`docs/design/README.md`).
|
||||
|
||||
Limites connues de R4 :
|
||||
- Si le moteur lui-même ne se charge pas, chaque carte affiche sa ligne « moteur » avec son propre « Réessayer » ; un
|
||||
|
||||
@@ -814,33 +814,44 @@ only what it created) binding. Contract `.claude/tasks/contracts/2026-11-17-r4-c
|
||||
- Other failures (R-2, R-4, R-5): warning tone (the amber of board 30's network card, ink text, no new token), the
|
||||
existing text (`catalogue.failure.<kind>`; `access_denied.title` « Accès non autorisé » for `denied`; the core's
|
||||
text for `core_unavailable`), glyph `wifi-off` for `network` and `alert` otherwise, « Réessayer » for that card
|
||||
only. No retry once the engine stopped for good. A `core_unavailable` retry calls `coreRuntime().retry()` before
|
||||
reloading; a version that traps the core spends one of the tab's three recoveries per click, as on the sheet page.
|
||||
only. Once the engine stopped for good the core line has no « Réessayer » and takes the error tone, as on the
|
||||
sheet page. A `core_unavailable` retry calls `coreRuntime().retry()` before reloading; a version that traps the
|
||||
core spends one of the tab's three recoveries per click, as on the sheet page. Two calls in the same tick start
|
||||
one attempt (a ref set by the first call, cleared when its attempt settles).
|
||||
- Main view not drawable (D2): a version that passes but whose main view the core refuses to compose keeps its
|
||||
counts and shows the existing `catalogue.failure.view` in a neutral `info` line (no role, no retry). The engine
|
||||
failing there (`core_unavailable`, `internal`) is the core line with its retry. Nothing is silent any more.
|
||||
- Announcements and focus (R-3): the lines are not live regions (no burst when several cards fail at load). During
|
||||
a retry the line and « Réessayer » stay mounted, the button `aria-disabled`, the card `aria-busy`, clicks ignored.
|
||||
a retry the line and « Réessayer » stay mounted, the button `aria-disabled` and greyed with a wait cursor
|
||||
(`aria-disabled:opacity-60 aria-disabled:cursor-wait`, no new wording), the card `aria-busy`, clicks ignored.
|
||||
A retry that fails again keeps the focus on « Réessayer » and a visually hidden polite region, empty at load and
|
||||
cleared at each attempt, says the line again. On success the focus moves to the card's « Consulter » only if it
|
||||
was on that card's removed « Réessayer » or on `body`.
|
||||
cleared at each attempt, says the line again. The region stays mounted once a retry ran, even when the new
|
||||
failure offers no retry (network, then `fingerprint_mismatch` or `caps`; the core, then stopped for good), so the
|
||||
line it ends on is said. When an attempt settles without its « Réessayer » (success, or a failure with no retry
|
||||
left), the focus moves to the card's « Consulter » only if it was on that card's removed « Réessayer » or on
|
||||
`body`.
|
||||
- `Notice` gains the tone `warning`, `icon?` and `live?` (default true); its existing call sites keep their role
|
||||
and glyph (test). `Icon` gains `wifi-off`. `Card` passes an optional `aria-busy` (outside the plan's file list,
|
||||
needed by R-3, accepted at review).
|
||||
- Browser proof (`apps/app/e2e/shell/catalogue-integrity.spec.ts`, `BROWSER_TESTS.md`): one sound and one altered
|
||||
sheet seeded per run (`storedFingerprint: '0'.repeat(64)`), integrity in fr and en at desktop and 375 px, network
|
||||
in fr on both projects (one version aborted, `route.fallback()` for the rest, the card remounted by search, never a
|
||||
reload). Cleanup (D4, ruling below): each own sheet archived by id through `private.set_sheet_status` as the seed
|
||||
owner, then read back; the own `catalog_reader` grant revoked by id and read back; no statement matches by pattern.
|
||||
reload; both buttons on one row). Cleanup (D4, ruling below): each own sheet's name read by its captured id and
|
||||
compared exactly with the name the run seeded (« R4 <tag> saine » / « … altérée »; a different name archives
|
||||
nothing and fails the run), then the sheet archived by id through `private.set_sheet_status` as the seed owner and
|
||||
read back; the own `catalog_reader` grant revoked by id and read back; no statement matches by pattern. Every id
|
||||
written into a statement, `seedGrant`'s account id included, goes through `capturedId` (`e2e/support/records.ts`).
|
||||
- D4 ruling: archive, not soft delete. The owner authorised a soft deletion, but the application never deletes a
|
||||
sheet that had a published version (§6.9, `delete_anatomical_sheet`), so a deleted row with published history is
|
||||
a state no screen can reach. Archiving is reachable, takes the sheet out of the catalogue and stays inside the
|
||||
authorisation. Cost: the archived test sheets stay in the admin sheet list under « Archivée », tagged « R4 <tag> ».
|
||||
- Rust by default (R-8): sorting closed kinds into lines is display formatting; one class C row in
|
||||
`RUST_ARCHITECTURE_REVIEW.md` Part II.
|
||||
- One deviation from board 30, recorded in `docs/design/README.md`: on desktop the network card stacks
|
||||
« Réessayer » above « Consulter » where the board draws them side by side (the card's width wraps the row).
|
||||
Pending the design review, not fixed.
|
||||
- Board 30 deviation found at the design review, fixed in the final fix wave: on desktop (1280 px, three columns,
|
||||
a card about 288 px wide) the network card stacked « Réessayer » above « Consulter » where the board draws them
|
||||
side by side. The failure row now narrows the padding of its buttons (`*:px-3`, that row only; « Consulter »
|
||||
keeps its look elsewhere, the wrap stays as the fallback): at 1280 px « Réessayer » (102 px) and « Consulter »
|
||||
(125 px) sit on one row, 44 px high, and the network e2e checks it on both projects.
|
||||
|
||||
Results (exact; nothing that failed is called green):
|
||||
|
||||
@@ -851,6 +862,11 @@ Results (exact; nothing that failed is called green):
|
||||
| `catalogue-integrity.spec.ts` alone on the sandbox (`dadd8e5`) | 6 passed, 0 failed, 0 skipped, 0 flaky, twice (once with temporary screenshot lines, once as committed) |
|
||||
| `catalogue.spec.ts` alone after the support change | 8 passed, 0 failed, 0 skipped, 0 flaky |
|
||||
| Data guard before and after the runs (read-only) | 0 removed, 0 changed, 81 added (27 sheets, 43 versions, 11 grants). The 8 « R4 … » sheets read back archived (one `anatomical_sheet.archived` audit row each), the 4 own grants revoked (`e2e cleanup`) |
|
||||
| Final fix wave: app unit suite (at `3bea19f`) | 1775 tests in 138 files passed (+4: retry ending with no retry left, two calls in one tick, engine stopped for good, two cards on the core) |
|
||||
| Final fix wave: `pnpm typecheck`, `pnpm lint`, `pnpm build` | exit 0 (build: the usual chunk-size notice only) |
|
||||
| Final fix wave: `catalogue-integrity.spec.ts` alone | 6 passed, 0 failed, 0 skipped, 0 flaky, twice (once with temporary screenshot lines, once as committed at `3bea19f`) |
|
||||
| Final fix wave: `catalogue.spec.ts` alone (`seedGrant` changed) | 8 passed, 0 failed, 0 skipped, 0 flaky |
|
||||
| Final fix wave: data guard (read-only, before and after its three runs) | 0 removed, 0 changed, 81 added (27 sheets, 43 versions, 11 grants), all the runs' own: 8 « R4 … » sheets read back archived (name checked before each archive), 4 own grants revoked (`e2e cleanup`), the rest from `catalogue.spec.ts` and the warm-up as before |
|
||||
| Catalogue census of the sandbox (read-only, 2026-11-17, below) | 164 entries: 160 pass and compose their main view, 4 `fingerprint_mismatch` (anomaly A) |
|
||||
| `pnpm check:all` | not yet run |
|
||||
|
||||
@@ -871,14 +887,21 @@ Limits (accepted, recorded):
|
||||
without a date.
|
||||
- D2: the view line reuses `catalogue.failure.view`, a text written for the sheet page (« Cette vue ne peut pas être
|
||||
affichée : … »); no card-specific wording was asked for.
|
||||
- Sandbox accumulation: each spec run adds 2 to the seed owner's row in `private.catalog_write_budgets` (created by
|
||||
the first run, 8 of 300 per hour after the R4 runs, outside the data guard); the spec's reader accounts stay (as
|
||||
- Sandbox accumulation: the seed owner's row in `private.catalog_write_budgets` is R4's own, not pre-existing
|
||||
data: there was none before R4, its first run created it, and every later run updates that same row (4 archives
|
||||
per run, counted per hour and per day; 8 of 300 per hour and 8 of 2,000 per day after the final fix wave's two
|
||||
runs, outside the data guard); the spec's reader accounts stay (as
|
||||
every suite's, BLK-015); `catalogue.spec.ts` still leaves its published sheets listed and the global warm-up its
|
||||
« Fiche e2e … » sheet and `sheet_editor` grant per invocation (existing accumulation, BLK-015, RR-13).
|
||||
- Every card loads its version at mount: with 164 entries the sandbox catalogue is slow to settle (with RR-13).
|
||||
- Unit only: the engine stopped for good in a card (`cardFailure` test), and two cards failing on the core at once.
|
||||
Not checked in a browser: `aria-busy` and `aria-disabled` during an attempt, a screen reader reading the polite
|
||||
region.
|
||||
- Unit only (rendered cards on the fake client, not in a browser): the engine stopped for good in a card (error
|
||||
tone, no « Réessayer »); two cards failing on the core (one retry restarts the engine once and reloads that card
|
||||
only, the other keeps its line and its « Réessayer »); a retry ending on a failure with no retry left (focus on
|
||||
« Consulter », the polite region says the new line); two retry calls in one tick (one attempt); no blob URL
|
||||
created after the card left during an attempt. Not checked in a browser: `aria-busy`, `aria-disabled` and the
|
||||
greyed button during an attempt, a screen reader reading the polite region.
|
||||
- The cleanup's name check (D4 identity) is proved by the archives that passed (each row's name matched); the
|
||||
refusal path (a different name archives nothing) is not exercised by a test.
|
||||
|
||||
## 4. Order and dependencies
|
||||
|
||||
@@ -894,7 +917,7 @@ depend on the working-copy slot.
|
||||
|---|---|---|
|
||||
| A. Fictitious fingerprints | Worker stand-ins publish with `'a'.repeat(64)`: `packages/supabase/tests/sandbox/sheet-fixtures.ts:115` (`openRound`), `sheets-concurrency.sandbox.ts:168`, `sheets-perf.sandbox.ts:169`. Seven published or deprecated versions on the sandbox fail `check_published`; the owner opened three of them on 2026-11-09. | Compute the real fingerprint through the core as the catalogue e2e does (`fingerprintOf`), never weaken the publish gate or the reader's check. |
|
||||
| B. Working copy never archived | (a) `packages/supabase/tests/sandbox/sheets-admin.sandbox.ts` created the historical sheet's working copy (`8c315a12-…`, 2026-11-08 21:00:30) and never archived it; the single slot then disables « Créer une copie de travail » (`WorkingCopyAction.tsx:88`). (b) Even on a fresh stack `editor-equine.spec.ts` flips the slot while `admin.spec.ts:717` runs in parallel. Only the historical sheet offers the action, so the test depended on shared state. | FIXED (owner, 2026-11-12, option 1): the dialog's axe, layout and keyboard checks run on the real component in `e2e/ui/working-copy.spec.ts`; `admin.spec.ts` keeps the historical page and checks the button state against its reason; the sandbox suite archives only the copies it created (`returning id` checked) and each cleanup step runs independently. Limit: the dialog is no longer checked in its real server context by this accessibility test. Open: the creation branch of the cleanup is not yet run on a fresh stack. `editor-equine.spec.ts` still archives and restores pre-existing copies on every run. |
|
||||
| C. Silent card failure | Section 3, R4. | Show the failure, never hide or route around it. CLOSED by R4 (2026-11-17, §R4 « As built »): the card says its failure inside itself, « Consulter » kept, the check unchanged. The four sandbox entries it shows failing are anomaly A, still open. |
|
||||
| C. Silent card failure | Section 3, R4. | Show the failure, never hide or route around it. Built by R4 (2026-11-17, §R4 « As built »), closes on the owner's validation: the card says its failure inside itself, « Consulter » kept, the check unchanged. The four sandbox entries it shows failing are anomaly A, still open. |
|
||||
|
||||
## 6. Arbitrations
|
||||
|
||||
|
||||
Reference in new issue
Block a user