fix(supabase): sheet-assets e2e can no longer reach DEV

The runner read the DEV keys from supabase status and targeted
http://127.0.0.1:54321 (two read-only incidents on 2026-11-01). It now
refuses, before building or any request, every URL but the sandbox gateway
and every key not issued by the sandbox; no DEV URL, port or key remains.
Same bytes as the V1-2 runner; that branch brings the sandbox command.
This commit is contained in:
bchanot committed 2026-11-02 00:24:02 +01:00
1 parent 9135d73cfa
commit e24e747d90
3 files changed
+33 -14

No files matched your search

+26 -11
View File
@@ -1,8 +1,10 @@
#!/usr/bin/env bash
# `pnpm e2e:sheet-assets`: the sheet-asset upload tool against the LOCAL Supabase stack (R5.5,
# docs/development/SUPABASE.md §3.1). Needs `pnpm db:start`. Run by hand: it uploads the equine
# draft drawing to the local bucket and confirms its row (idempotent; a rerun changes nothing).
# The keys are read from `pnpm supabase status`, held in variables, never printed.
# `pnpm e2e:sheet-assets` (= `pnpm db:sandbox sheet-assets-e2e`): the sheet-asset upload tool against the
# throwaway SANDBOX stack (docs/development/SUPABASE.md §3.1, §5.1), never DEV. It uploads the equine draft
# drawing to the sandbox bucket and confirms its row (idempotent; a rerun changes nothing).
# The runner (scripts/db-sandbox.sh) starts the gateway and passes SUPABASE_URL, SUPABASE_SERVICE_ROLE_KEY
# and SUPABASE_ANON_KEY in the environment; this script refuses anything else before building or any
# request, and never prints a key.
#
# Checks: --check writes nothing; a first run uploads and confirms; a rerun has nothing to do;
# the anon key and a wrong key are refused; a destination that is not a local stack is refused
@@ -10,17 +12,30 @@
set -uo pipefail
cd "$(dirname "$0")/.."
SANDBOX_URL=http://127.0.0.1:57800
SERVICE=${SUPABASE_SERVICE_ROLE_KEY:-}
ANON=${SUPABASE_ANON_KEY:-}
# A key is accepted only when its JWT payload names the sandbox issuer; nothing is printed.
sandbox_key() { printf '%s' "$1" | python3 -I -c '
import base64, json, sys
try:
p = sys.stdin.read().split(".")[1]
sys.exit(0 if json.loads(base64.urlsafe_b64decode(p + "=" * (-len(p) % 4))).get("iss") == "db-sandbox" else 1)
except Exception:
sys.exit(1)'; }
if [ "${SUPABASE_URL:-}" != "$SANDBOX_URL" ] || ! sandbox_key "$SERVICE" || ! sandbox_key "$ANON"; then
echo "sheet-assets-e2e: refused, nothing was run. Sandbox only: the sandbox gateway URL and sandbox-issued" >&2
echo "keys, set by pnpm db:sandbox sheet-assets-e2e where that runner exists; it never targets DEV." >&2
exit 2
fi
. scripts/rust-env.sh
SEED=supabase/seed/anatomical-sheets/equine/draft
BIN=target/release/upload-sheet-assets
FAIL=0
env -u SUPABASE_SERVICE_ROLE_KEY cargo build --release --locked -q -p faunosteo-core --features upload --bin upload-sheet-assets || exit 2
STATUS=$(bash scripts/supabase.sh status -o json 2>/dev/null) || { echo "stack not running (pnpm db:start)"; exit 2; }
field() { printf '%s' "$STATUS" | python3 -c "import json,sys;print(json.load(sys.stdin)['$1'])"; }
SERVICE=$(field SERVICE_ROLE_KEY)
ANON=$(field ANON_KEY)
LOCAL=http://127.0.0.1:54321
LOCAL=http://127.0.0.1:57800
# expect <name> <expected exit> <url> <key> <args...>; output kept to grep, keys never echoed.
expect() {
@@ -42,8 +57,8 @@ expect "rerun" 0 "$LOCAL" "$SERVICE" "$SEED"
grep -q "nothing to do" <<<"$LAST" && echo "PASS rerun has nothing to do" || { echo "FAIL rerun did work"; FAIL=1; }
expect "anon key refused" 1 "$LOCAL" "$ANON" "$SEED"
expect "wrong key refused" 1 "$LOCAL" "not-a-valid-key" "$SEED"
expect "https refused" 1 "https://127.0.0.1:54321" "$SERVICE" "$SEED"
expect "non-local host refused" 1 "http://example.test:54321" "$SERVICE" "$SEED"
expect "https refused" 1 "https://127.0.0.1:57800" "$SERVICE" "$SEED"
expect "non-local host refused" 1 "http://example.test:57800" "$SERVICE" "$SEED"
expect "no port refused" 1 "http://127.0.0.1" "$SERVICE" "$SEED"
expect "unreachable port" 3 "http://127.0.0.1:9" "$SERVICE" "$SEED"
expect "folder outside the seed" 1 "$LOCAL" "$SERVICE" --check crates/core/src