fix(editor): sign-out and shell links ask the drawing guard first

With a started move, sign-out and an in-app link now ask « Abandonner
le déplacement ? » (R-12) through the page's own question, registered by
the draft route in leaveGuardStore (`ask`; the shell imports no editor
module). The generic leave and sign-out dialogs cover only sheet-level
unsaved work; with both pending the drawing asks first, then the sheet
question, as useLeaveConfirm orders them. A move with nothing started
arms nothing (it ends); a started one still guards a reload.

Tests: sign-out and link with a started move (alone and with sheet
changes), the history jump with only a move and after dirty layers, a
section entry and « Tout afficher ».
This commit is contained in:
bchanot committed 2026-11-17 19:25:04 +01:00
1 parent 44de465c6d
commit e01d8519ea
8 files changed
+311 -26

No files matched your search

@@ -10,6 +10,14 @@ import { useAuthStore } from '@/state/authStore'
import { useLocaleStore } from '@/state/localeStore'
import { fr } from '@/i18n/fr'
import { fakeUser } from '../helpers/fakeSupabase'
import DrawingGuardDialog from '@/components/editor/annotations/DrawingGuardDialog'
import { guardDrawing } from '@/editor/annotations/drawingGuard'
import {
resetWork,
setModePreview,
startMove,
} from '@/editor/annotations/workStore'
import { useLeaveGuardStore } from '@/state/leaveGuardStore'
const user = fakeUser()
const OTHER = 'bbbbbbbb-0000-0000-0000-000000000002'
@@ -101,3 +109,54 @@ describe('SignOutButton', () => {
expect(screen.queryByRole('dialog')).toBeNull()
})
})
describe('SignOutButton and a started move on the drawing (R-12)', () => {
const STORED = { type: 'circle' as const, cx: 1, cy: 2, r: 3 }
beforeEach(() => {
useLeaveGuardStore.getState().setAsk(guardDrawing)
startMove('a', 'doc')
setModePreview({ ...STORED, cx: 9 }, STORED)
})
afterEach(() => {
useLeaveGuardStore.getState().setAsk(null)
resetWork()
})
function mountWithGuard() {
render(
<MemoryRouter>
<SignOutButton />
<DrawingGuardDialog />
</MemoryRouter>,
)
}
const question = () =>
screen.queryByRole('dialog', { name: 'Abandonner le déplacement ?' })
it('asks the drawing question, never the sign-out text; « Continuer » stays', async () => {
mountWithGuard()
await click()
expect(question()).not.toBeNull()
expect(screen.queryByText(fr['shell.sign_out_loss_title'])).toBeNull()
await userEvent.click(screen.getByRole('button', { name: 'Continuer' }))
expect(signOut).not.toHaveBeenCalled()
})
it('« Abandonner » signs out when nothing else is at stake', async () => {
mountWithGuard()
await click()
await userEvent.click(screen.getByRole('button', { name: 'Abandonner' }))
await waitFor(() => expect(signOut).toHaveBeenCalledTimes(1))
})
it('with unsaved sheet changes too: the drawing first, then the sheet question', async () => {
useEditorStore.setState({ unsaved: true })
mountWithGuard()
await click()
expect(screen.queryByText(fr['shell.sign_out_loss_title'])).toBeNull()
await userEvent.click(screen.getByRole('button', { name: 'Abandonner' }))
expect(
await screen.findByText(fr['shell.sign_out_loss_title']),
).toBeTruthy()
expect(signOut).not.toHaveBeenCalled()
})
})