From de2dfb392e44083dd4c2d696ba80ba611b53967d Mon Sep 17 00:00:00 2001 From: bchanot Date: Sun, 1 Nov 2026 02:01:50 +0100 Subject: [PATCH] chore(memory): V1-2.2 owner decisions evidence, BDR-091, LRN-103/104 --- .../2026-11-01-v1-2-2-decisions-evidence.md | 78 +++++++++++++++++++ .claude/memory/decisions.md | 10 +++ .claude/memory/journal.md | 3 + .claude/memory/learnings.md | 14 ++++ .claude/tasks/TODO.md | 7 ++ .../contracts/2026-11-01-v1-2-2-decisions.md | 59 ++++++++++++++ 6 files changed, 171 insertions(+) create mode 100644 .claude/audits/2026-11-01-v1-2-2-decisions-evidence.md create mode 100644 .claude/tasks/contracts/2026-11-01-v1-2-2-decisions.md diff --git a/.claude/audits/2026-11-01-v1-2-2-decisions-evidence.md b/.claude/audits/2026-11-01-v1-2-2-decisions-evidence.md new file mode 100644 index 00000000..112c8675 --- /dev/null +++ b/.claude/audits/2026-11-01-v1-2-2-decisions-evidence.md @@ -0,0 +1,78 @@ +# V1-2.2 owner decisions of 2026-11-01: evidence + +Owner brief « V1-2.2 : décisions et poursuite des corrections » on `f1bb19b`. Owner answers during the +run: threshold 4 CSS px at 320 × 568 (the proposed 6 px refused the validated equine); « the visible +wins » on the editor canvas only. Contract `.claude/tasks/contracts/2026-11-01-v1-2-2-decisions.md`. +Commits `4f52f5e` (lot B), `e677150` (R4.1 manifest), `9c606aa` (junctions), `96b9978` (visible size, +frame range). Tools `.claude/audits/2026-11-01-v1-2-2-decisions-tools/`. Details RUST.md §12.12, §12.13. + +## 1. Lot B as approved, isolation re-checked + +- Working tree before commit = `.claude/audits/2026-10-30-v1-2-2-lot-b-isolation.patch`, identical + (index lines aside). +- Census `nothing_the_reader_keeps_changes_the_layer_or_the_halo`: the reader's 77 allowed attributes + (structural ones aside) on the root and a descendant group, 17 descendant `style` values; layer and halo + byte-identical to a plain drawing, root = namespaces + frame. +- Browser probe, full-frame opaque magenta rectangle (last drawing child) with 21 candidate styles (15 kept + by the reader, 6 removed for a function call), Chromium 156 / Firefox 157 / WebKit 27.2, canvas and PDF: + magenta count equal to the unstyled control inside the frame, 13/13 point hits; positive control (rectangle + after the layer) 100 % magenta, 0/13 hits. +- Correction to the 2026-10-30 evidence: a descendant `style` may set `pointer-events` or `cursor` (the + attributes are not kept); it acts on the drawing only, below the layer. + +## 2. References + +| Reference | Change | +|---|---| +| R3 `highlight.json` (36), R3 canvas goldens, `canvas.*.layers.json` | frozen files unedited; compared under `with_isolated_layer` / `withIsolatedLayer` / `withDeclaredHitboxes`, plus `with_canvas_passes` / `withCanvasPasses` for the canvas only (junctions) | +| R4.1 `pdf/r3/real/manifest.json` call 1 `svgSha256` | edited `a9a3155c…2c11` → `45fd4aaf…fc7f` (`e677150`); call 2 unchanged; `pdf-export.session.test.ts` 5/5 | +| R4 PDF digests, step6 goldens, N-1 copies, seed review drawings, equine drawing + fingerprint, R3 `layer.json`, `sanitiser.json` | unchanged: `git diff --stat f1bb19b..96b9978` over `crates/core/tests/{oracles,conformance,fixtures,pdf}`, `apps/app/tests/fixtures`, `packages/core-wasm/tests/n-1`, `supabase/seed` lists the manifest's one line only | + +## 3. Junctions, « the visible wins » (canvas only) + +- Click spec, 6 projects (Chromium 1280 / 375 touch / 320 touch, Firefox 1280, WebKit 1280 / 375 touch): + 99 passed, 0 fixme. On `e677150` the junction and disc tests fail in all 6 (12 failures). +- Junction test: `c7-t1`, `l6-s1`, `t18-l1`, fore fetlock, centre + 4 points towards the disc edge, real + clicks or taps. Disc test: every twin of main and head, 100 % of samples inside 95 % of the radius record + the topmost disc. Zone test: every zone and the trigger, 100 % of samples 2 px inside, away from discs. +- WebKit snaps taps and clicks to whole CSS px (measured: tap at 100.1 lands right of an edge at 100.4, + click at 100.9 left of it); a real press keeps 1.5 px of margin, below it the browser's hit test answers. +- The five `fixme` = one test × five projects; now unmarked in six. + +## 4. Scale bypass and frame range + +- Measured editor at 320 × 568 (Chromium): main box 286 × 310, detail 254.9 × 191.1. Equine at 320: + junctions 4.97 px, other main points 6.07, head 15.1, smallest zone side 13.1. 6 px refused at 320, 360, + 375 px. +- `sheet_marker_visibility` 9 tests: equine accepted; horse `viewBox` × 100 refused with its 19 main markers + (`marker_too_small`); × 1 000 no usable frame; threshold × 1.24 accepted, × 1.25 the 3 junctions, + × 1.52 the 13 points; disc vs hitbox; detail box; curves and arcs; every range bound at its limit and past; + view_box; drawing transforms never change the measure. `sheet_frame` 13, frame unit test (NaN, ∞). +- Rust vs browsers (hitbox layout): equine and thresholds ≤ 8.2e-5 relative, ≤ 0.014 px (Chromium, + WebKit); Firefox ≤ 0.4 % (1/60 px app units); far edge 10⁵ / 10⁶ spans drawn raw: 0.14 / 11 px centre + error (why the 256 ratio). Painted pixels by span: WebKit nothing from 2⁻⁷, Chromium 0.46 px at 2⁻¹⁴ and + nothing at 2⁻²⁰, Firefox exact; floor set at 1 unit (first value 2⁻²⁰ withdrawn on this measure). + +## 5. Gates on the final HEAD `76ead95` + +- Mutations: on `96b9978`, `2026-11-01-v1-2-2-mutations-decisions.py` 29 killed + F5 survived (equivalent: the aspect + rule refuses a zero span), `2026-10-30-v1-2-2-mutations-three-medium.py` 26 killed, 6 anchors moved (re-anchored in + the new script, killed): 55 killed. N8 (path number bound, `76ead95`) killed. Total 56 killed, 1 equivalent. +- `pnpm check:all` on `76ead95` passed (01:49 → 01:57): cargo 2 289 passed (worker 49 in Docker), 0 failed, 3 ignored; + clippy -D warnings; ts-rs no drift; cargo-deny; RustSec ok; wasm; typecheck; core-wasm 65, supabase 128, app 566; + lint; build; e2e:ui 125; app image; worker:test; worker:image `run --check`. Also passed on `96b9978`. +- `pnpm e2e:shell` on the isolated sandbox stack (never DEV): 86 passed on `96b9978` and on `76ead95`. +- WASM 574 233 B gzip -9 (budget 600 000, margin 25 767 B, 4.3 %); Vite gzip 584.84 kB. + +## 6. Independent reviews (fresh, Opus) + +- Verifier on `96b9978`: ECARTS(4). D1, D3, D4, D5 met. D2 and D7: §12.12 transform table rows 1 and 3 stale (fixed in + `76ead95`). D6 unverifiable inside its brief (gates above). FLOOR `.skip(1)` = `Iterator::skip` (contract clarification + added). Former MEDIUMs (1) root property, (2) hitbox stroke, (3) frame and scale bypass, (4) offset slack: closed. + MEDIUM path numbers past f32 (fixed `76ead95`). LOW: lot B commit carried the RUST.md probe and reference passages. +- Security on `96b9978`: PASS, semgrep 0. MEDIUM path numbers past f32 (fixed `76ead95`, re-review on the fix: PASS, + LOWs informational: rotation reduced in f32, relative commands accumulated in f64, sub-normal arc radius). + MEDIUM open, owner decision: zone without interior (zero-winding path, near-collinear polygon) passes the 4 px rule + and is hit only on its 2-unit stroke. LOW: twin fully covering an earlier twin (no rule), NaN inside `Bounds::add` + (unreachable since the bound), 1e-12 epsilons sound through the span floor, frame walk before the caps + (pre-existing). diff --git a/.claude/memory/decisions.md b/.claude/memory/decisions.md index c3311faa..f57f21a2 100644 --- a/.claude/memory/decisions.md +++ b/.claude/memory/decisions.md @@ -676,3 +676,13 @@ Also kept by owner: per-document-instance prefix required on top of per-view pre **Rationale**: owner had already lifted Illustrator requirement; earlier brief wording ("Illustrator obligatoire pour revendiquer la compatibilité Illustrator") read as A6 blocker. Compatibility claim stays evidence-bound: no export, no claim. **Alternatives**: keep Illustrator required (rejected by owner: blocks step on tool not owned); fabricate or emulate exports (forbidden: VectorCraft not equivalent, never fake fixtures). + +## BDR-091 — V1-2.2 view frame: one Rust rule, out_of_frame refusal (2026-11-01) (2026-11-01) +- **Status**: accepted +**Context**: V1-2.2 three MEDIUM, defect 3 (owner brief 2026-10-30). View without `view_box` framed by drawing root `viewBox`; shifting it + translating content back kept horse identical, all 19 main markers off frame, accepted. + +**Decision**: one Rust rule `anatomy::frame::view_frame` = view `view_box`, else drawing `viewBox` read with SVG grammar. Same frame for both composers (canvas, PDF), server verdict, PreviewSheet. Annotation not entirely inside (edges incl., curves/arcs on shape, unreadable path data refused) → issue `annotation.geometry.out_of_frame`, verdict `verification.validation.out_of_frame`; no usable frame → `view.frame.unknown`. Document never rewritten. Owner validated 2026-11-01. + +**Alternatives**: cap on viewBox dims (rejected: bypass by scale); document owning main frame (heavier model change); TS-side check (rejected: Rust by default, one definition). + +**Extension 2026-11-01** (same rule, owner brief « décisions »): frame usable only within browser-faithful range (edges ≤ 2^20, span ≥ 1, aspect ≤ 100, far edge ≤ 256 spans); marker visible size ≥ 4 CSS px at 320 × 568 → `verification.validation.marker_too_small`. RUST.md §12.11, §12.13. diff --git a/.claude/memory/journal.md b/.claude/memory/journal.md index ff8d9944..1bb054a0 100644 --- a/.claude/memory/journal.md +++ b/.claude/memory/journal.md @@ -494,3 +494,6 @@ R5.4: `draft/{labels,changelog,review_report,drawing,overlay,app_review,svg_comp ## 2026-10-31 - V1-2.2 three MEDIUM: lot A frame rule committed 0c87c7f..9e49ed1 (check:all green faa53c7); lot B isolation+hitbox built, uncommitted, patch in audits, R3 oracles pass under declared transforms, R4.1 manifest digest fails. Security PASS + MEDIUM scale bypass, verifier ECARTS(2) fixed. Junction-point overlap found. STOP: owner authorisation. + +## 2026-11-01 +- V1-2.2 N (owner 2026-11-01): lot B committed 4f52f5e, R4.1 call-1 svgSha256 e677150, visible wins canvas-only 9c606aa, marker_too_small 4 px @320x568 + frame range 96b9978, path numbers ±2^20 76ead95. check:all + e2e:shell green on 76ead95, 56 mutants killed, 1 equivalent. Open: zone without interior (MEDIUM, owner). STOP at checkpoint. diff --git a/.claude/memory/learnings.md b/.claude/memory/learnings.md index a789a3b6..56d981c8 100644 --- a/.claude/memory/learnings.md +++ b/.claude/memory/learnings.md @@ -709,3 +709,17 @@ Supersedes [[LRN-100]]. **Context**: any shell-written file holding backticks: Rust/TS doc comments, markdown, commit bodies, python snippets passed via `python3 - <