From ddf34ada1f51d9fb4f970d29e58d2d53cf8fb1ac Mon Sep 17 00:00:00 2001 From: bchanot Date: Fri, 20 Nov 2026 17:04:47 +0100 Subject: [PATCH] =?UTF-8?q?chore(memory):=20BDR-124=20+=20LRN-146=20+=20LR?= =?UTF-8?q?N-147=20+=20BLK-016=20=E2=80=94=20ship-feature=20U2=20trial=20a?= =?UTF-8?q?djustments?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .claude/memory/blockers.md | 7 +++++++ .claude/memory/decisions.md | 9 +++++++++ .claude/memory/learnings.md | 10 ++++++++++ 3 files changed, 26 insertions(+) diff --git a/.claude/memory/blockers.md b/.claude/memory/blockers.md index c817e329..cb966992 100644 --- a/.claude/memory/blockers.md +++ b/.claude/memory/blockers.md @@ -125,3 +125,10 @@ Evidence: interleaved A/B admin.spec alone, pre-R2 worktree 65a8fd3 vs HEAD 52aa Solution: none applied (owner: no reset, no deletion of pre-existing data, pagination stays in RR-13). Rerun admin.spec alone only as diagnosis, never as gate. Close when RR-13 paginates grant list (or run-scoped fixture cleanup approved) and admin.spec green on sandbox. Refs: `docs/development/BROWSER_TESTS.md` §6, `V1-2-6_U1_CORRECTIONS.md` §R2, BDR-115, LRN-133. - **Status (2026-11-13)**: open: R2 finish 2026-11-13 sweep, admin.spec A0 + admin screens still Target crashed, same signature; shell chrome changed, no A/B cap rerun on this branch; pagination stays RR-13 + +## BLK-016 — Criterion 32: chips on several rows overflow pinned column (2026-11-20) +- **Status**: open +**Friction:** criterion 32 e2e with 8 long-named views fails: stuck column bottom past window, `expected 64.3 to be less than or equal to 0.5`-class overflow (1024×768 64.3 px, 1180×820 53.3, 1180×700 76.0, 1280×800 24.3); near page end column top under strip. +**Real cause:** pinned column CSS budget (`--edit-column-parts`, index.css) counts ONE chip row since U2 Task 17; each extra row ~38 px (derived). +**Solution:** owner 2026-11-20: single horizontally scrolling chip row (finger swipe, no page sideways scroll, keyboard reach, active view clear, discreet off-screen hint, no drawing-gesture regression); mockup before code. Test parked `test.fixme` in `editor-geometry.spec.ts`. +**Status note:** open until mockup validated and implemented. diff --git a/.claude/memory/decisions.md b/.claude/memory/decisions.md index 61632265..bde2db05 100644 --- a/.claude/memory/decisions.md +++ b/.claude/memory/decisions.md @@ -1003,6 +1003,7 @@ Alternatives: write-now + delete on abandon (two undo steps, rejected); fold exi **Rationale:** selection without dialog keeps successive shape corrections cheap; skeleton stays visible; list stays keyboard path. **Alternatives:** orientation rules 1 and 6 literal (dialog per click), dialog over drawing, column removed (rejected by owner choice). **Next:** U2 technical plan + challengers, owner gate before code. No merge, DEV unchanged. +- **Status (2026-11-20)**: accepted, amended 2026-11-20 by BDR-124 (coarse handle marks, − bubble placement, add buttons arm tools) ## BDR-123 — U2 plan validated: D1 repair coords until U5, D2 zoom hint, mode guard when started (2026-11-17) (2026-11-17) - **Status**: accepted @@ -1010,3 +1011,11 @@ Alternatives: write-now + delete on abandon (two undo steps, rejected); fold exi **Rationale:** precision without accidental insert; no silent loss of started work. **Alternatives:** RepairDialog redone in U2 (rejected: rare, redesign of decision 7); all « + » always shown (rejected: mis-tap inserts); silent cancel of modes (corrected by owner). **Next:** execute plan Tasks 1-10; owner trial on `pnpm db:trial` before U2 closure. No merge, DEV unchanged. +- **Status (2026-11-20)**: accepted, completed 2026-11-20 by BDR-124 (D2 unchanged: hit radius kept) + +## BDR-124 — U2 trial amendments: add buttons arm tools, lighter coarse marks, open-side bubble, one chip row (2026-11-20) +- **Status**: accepted +**Decision:** owner tablet trial 2026-11-20 amends BDR-122 (handle look, board 05/13) and BDR-123 (D2 unchanged). Add buttons « Ajouter … »: one pointer press (detail 1) arms tool, second single press disarms behind R-12 guard, detail 2 ignored, Enter/Space keep C7 centre path; Enter on drawing while armed places at centre; sr-only polite status; explicit « Placer au centre » command approved (to build). Coarse marks lighter: vertex 14 (chosen 18), « + » 18, « − » mark 32×26 inside unchanged 44×36 hit; hit radius 22 unchanged so D2 threshold + R-18 hint unchanged. « − » bubble on open side of vertex (bisector of larger angle, 30° turns, 8-px steps to 32), hit rect clear of shown « + » hit circles, bounded to visible part; 3 corner cases of 9 261 panned placements accepted. Criterion 32 several chip rows: owner picks ONE horizontally scrolling chip row, mockup before code. +**Rationale:** owner pressed the text button (C7 path) expecting click-then-dialog; old bubble straight above masked neighbour « + » (45/63 equine vertices at ×2.25); taps need hit area, not big marks. +**Alternatives:** hide neighbour « + » while vertex chosen (rejected: loses insert); « − » in strip (rejected: far from finger, board 05); keep text button = centre only (rejected by owner); chips budget per row or accept limit (rejected for criterion 32). +**Next:** commits 4e993058..007d9d41 (contract `2026-11-20-u2-trial-adjustments-1259.md`); Refaire hold e2e diagnosis; Placer au centre; chips mockup; owner final check on db:trial. diff --git a/.claude/memory/learnings.md b/.claude/memory/learnings.md index 12493cc1..78ae9072 100644 --- a/.claude/memory/learnings.md +++ b/.claude/memory/learnings.md @@ -989,3 +989,13 @@ Apply: any per-item retry in lists/grids; test focus on body vs elsewhere, repea ## LRN-145 — Single-request failure e2e via route.fallback + remount; 0fr grid row keeps child padding (2026-11-17) Pattern: (1) Playwright: fail one request (one version) with route.abort for its URL and route.fallback() for the rest; remount the component (search filter out/in) instead of page reload so failure state is reached without reload side effects; DevTools offline + search is the manual equivalent. (2) CSS collapse grid-rows 0fr→1fr: padding/border on the 0fr row's direct child stays visible (R3 phone panel kept 12 px); put padding on an inner wrapper inside the min-h-0 overflow-hidden child, assert closed height 0. Apply: single-request failure e2e; any CSS-only collapsible panel. + +## LRN-146 — Equine draft main view_box null: frame from horse.svg viewBox (2026-11-20) +**Pattern:** equine draft main view has `view_box: null` in `document.json`; frame = viewBox of `supabase/seed/anatomical-sheets/equine/draft/assets/horse.svg` (`0 0 2073.4 1629.4`). +**Context:** geometry sweeps over draft polygons (removeBubble tests, prototypes) crashed on `view_box` None. +**Application:** read frame from asset svg by regex in tests, never hard-code; fall back to it whenever view_box null. + +## LRN-147 — Drawing reacts to pointer events only: AT bare click ignored (2026-11-20) +**Pattern:** editor drawing reacts only to pointerdown/pointerup (`usePressGesture.ts` onClick from press effect); no DOM `click` listener on canvas. Assistive tech activation sending bare click (no pointer events) does nothing on drawing. +**Context:** U2 trial screen-reader path: tool armed by AT click, then drawing activation ignored; only Enter keydown on focused drawing works (focus mode). +**Application:** any create/act path for AT users needs explicit button (e.g. « Placer au centre »), never drawing activation. Do not trust read-before claims on click paths: read the press machine.