feat(pdf): archive check tool pnpm report:compare (attachment vs its v3 reading, unresolved items flagged, --diff/--summary/--identity); readAttachedDocument split out of extractReportJson; stale scaffold:species script removed; docs
This commit is contained in:
1 parent
1e0491f3bc
commit
dc78a00835
13 files changed
+753
-37
No files matched your search
@@ -0,0 +1,330 @@
|
||||
import {
|
||||
ReportV2Schema,
|
||||
findingPathKey,
|
||||
type Finding,
|
||||
type FindingV2,
|
||||
type MigrationOutcome,
|
||||
type ObservationZoneV2,
|
||||
type Report,
|
||||
type ReportZone,
|
||||
} from '@faunosteo/domain'
|
||||
import type { Locale } from '../../src/i18n/types'
|
||||
import { pickLabel, type SheetIndex } from '../../src/services/sheetIndex'
|
||||
|
||||
/**
|
||||
* Pure comparison of a report document found in a PDF with its v3 reading:
|
||||
* a v2 archive is shown legacy id → canonical id line by line, a v3 report
|
||||
* is checked against the bundled sheet. Every item the sheet cannot place is
|
||||
* marked `!! UNRESOLVED` with the reason, nothing is summarised away.
|
||||
*/
|
||||
|
||||
export const UNRESOLVED = '!! UNRESOLVED'
|
||||
|
||||
export interface CompareOptions {
|
||||
locale: Locale
|
||||
/** Print practitioner, animal and owner names (off by default). */
|
||||
identity: boolean
|
||||
}
|
||||
|
||||
export interface Comparison {
|
||||
/** `v2` when the attachment was migrated, `v3` when read as is. */
|
||||
source: 'v2' | 'v3'
|
||||
header: string[]
|
||||
observations: string[][]
|
||||
footer: string[]
|
||||
/** Lines in the v3 vocabulary only, for `--diff` between two PDFs. */
|
||||
normalized: string[]
|
||||
counts: Counts
|
||||
}
|
||||
|
||||
export interface Counts {
|
||||
observations: number
|
||||
zones: number
|
||||
unresolvedZones: number
|
||||
findings: number
|
||||
unresolvedFindings: number
|
||||
}
|
||||
|
||||
const q = (text: string) => `"${text}"`
|
||||
|
||||
function zoneRef(z: { annotationId: string; viewId: string; side?: string }) {
|
||||
return `${z.annotationId}@${z.viewId}${z.side ? ' ' + z.side : ''}`
|
||||
}
|
||||
|
||||
function findingRef(f: { findingZoneId: string; path: readonly string[] }) {
|
||||
return findingPathKey(f.findingZoneId, f.path)
|
||||
}
|
||||
|
||||
function vertebraeOf(z: { vertebrae?: { region: string; index: number }[] }) {
|
||||
return z.vertebrae?.length
|
||||
? ` [${z.vertebrae.map((v) => `${v.region}${v.index}`).join(', ')}]`
|
||||
: ''
|
||||
}
|
||||
|
||||
/** A v3 zone against the sheet: current label, or why it cannot be shown. */
|
||||
function describeZone(
|
||||
z: ReportZone,
|
||||
sheet: SheetIndex,
|
||||
locale: Locale,
|
||||
): string {
|
||||
const ref = `${zoneRef(z)}${vertebraeOf(z)}`
|
||||
const anno = sheet.annotation(z.annotationId)
|
||||
if (z.unresolved) {
|
||||
return `${ref} ${q(z.labelFrSnapshot ?? '')} ${UNRESOLVED} legacy zone kept from the archive`
|
||||
}
|
||||
if (!anno || anno.view_id !== z.viewId) {
|
||||
return `${ref} ${q(z.labelFrSnapshot ?? '')} !! not in the sheet (unflagged)`
|
||||
}
|
||||
return `${ref} ${q(pickLabel(sheet.name(anno), locale))}`
|
||||
}
|
||||
|
||||
/** A v3 finding against the sheet: current label, or why it cannot be shown. */
|
||||
function describeFinding(
|
||||
f: Finding,
|
||||
sheet: SheetIndex,
|
||||
locale: Locale,
|
||||
): string {
|
||||
const snapshot = q(locale === 'en' ? f.labelEnSnapshot : f.labelFrSnapshot)
|
||||
const vet = f.requiresVetReferral ? ' (!)' : ''
|
||||
const side = f.side ? ` ${f.side}` : ''
|
||||
const ref = `${findingRef(f)}${side}${vet}`
|
||||
if (f.unresolved) {
|
||||
return `${ref} ${snapshot} ${UNRESOLVED} kept with its snapshot`
|
||||
}
|
||||
const node = sheet.nodeAt(f.findingZoneId, f.path)
|
||||
if (!node) return `${ref} ${snapshot} !! not in the sheet (unflagged)`
|
||||
if (node.children.length > 0) {
|
||||
return `${ref} ${snapshot} !! points at a category, not a leaf`
|
||||
}
|
||||
return `${ref} ${q(pickLabel(node.name, locale))}`
|
||||
}
|
||||
|
||||
/** Legacy zone → migrated zone. */
|
||||
function describeZoneMigration(
|
||||
legacy: ObservationZoneV2,
|
||||
out: ReportZone,
|
||||
sheet: SheetIndex,
|
||||
locale: Locale,
|
||||
): string {
|
||||
const side = legacy.side ? ` ${legacy.side}` : ''
|
||||
const from = `${legacy.boneId}${legacy.detailSourceId ? '@' + legacy.detailSourceId : ''}${side}${vertebraeOf(legacy)}`
|
||||
if (out.unresolved) {
|
||||
return `${from} ${UNRESOLVED} unknown legacy id, kept as ${zoneRef(out)}`
|
||||
}
|
||||
const anno = sheet.annotation(out.annotationId)
|
||||
const label = anno ? q(pickLabel(sheet.name(anno), locale)) : '!! missing'
|
||||
return `${from} ${q(out.labelFrSnapshot ?? '')} → ${zoneRef(out)} ${label}`
|
||||
}
|
||||
|
||||
/** Legacy finding → migrated finding, with the fate the map decided. */
|
||||
function describeFindingMigration(
|
||||
legacy: FindingV2,
|
||||
out: Finding,
|
||||
sheet: SheetIndex,
|
||||
locale: Locale,
|
||||
): string {
|
||||
const map = sheet.sheet.migrationMap.finding_paths
|
||||
const vet = legacy.requiresVetReferral ? ' (!)' : ''
|
||||
const key = `${findingPathKey(legacy.zoneId, legacy.path)}${vet}`
|
||||
const snapshot = q(
|
||||
locale === 'en' ? legacy.labelEnSnapshot : legacy.labelFrSnapshot,
|
||||
)
|
||||
if (out.unresolved) {
|
||||
const why = Object.hasOwn(map, findingPathKey(legacy.zoneId, legacy.path))
|
||||
? 'removed from the sheet, kept with its label'
|
||||
: 'never in the legacy catalog, kept with its label'
|
||||
return `${key} ${snapshot} ${UNRESOLVED} ${why}`
|
||||
}
|
||||
const node = sheet.nodeAt(out.findingZoneId, out.path)
|
||||
const label = node ? q(pickLabel(node.name, locale)) : '!! missing'
|
||||
const target =
|
||||
findingRef(out) === findingPathKey(legacy.zoneId, legacy.path)
|
||||
? 'same'
|
||||
: findingRef(out)
|
||||
return `${key} ${snapshot} → ${target} ${label}`
|
||||
}
|
||||
|
||||
function observationLines(
|
||||
obs: Report['observations'][number],
|
||||
sheet: SheetIndex,
|
||||
opts: CompareOptions,
|
||||
): string[] {
|
||||
const lines = [
|
||||
`[${obs.id}] severity ${obs.severity ?? 'none'}`,
|
||||
...obs.zones.map((z) => `zone ${describeZone(z, sheet, opts.locale)}`),
|
||||
...obs.findings.map(
|
||||
(f) => `finding ${describeFinding(f, sheet, opts.locale)}`,
|
||||
),
|
||||
...obs.freeTextFindings.map((t) => `text ${q(t)}`),
|
||||
]
|
||||
if (obs.comment) lines.push(`comment ${q(obs.comment)}`)
|
||||
return lines
|
||||
}
|
||||
|
||||
function migratedObservationLines(
|
||||
raw: unknown,
|
||||
report: Report,
|
||||
sheet: SheetIndex,
|
||||
opts: CompareOptions,
|
||||
): string[][] {
|
||||
const v2 = ReportV2Schema.parse(raw)
|
||||
return v2.observations.map((legacy, i) => {
|
||||
const out = report.observations[i]!
|
||||
const severity = legacy.severity
|
||||
? `${legacy.severity} → ${out.severity}`
|
||||
: 'none'
|
||||
const lines = [`[${legacy.id}] severity ${severity}`]
|
||||
legacy.zones.forEach((z, j) => {
|
||||
const line = describeZoneMigration(z, out.zones[j]!, sheet, opts.locale)
|
||||
lines.push(`zone ${line}`)
|
||||
})
|
||||
legacy.findings.forEach((f, j) => {
|
||||
const line = describeFindingMigration(
|
||||
f,
|
||||
out.findings[j]!,
|
||||
sheet,
|
||||
opts.locale,
|
||||
)
|
||||
lines.push(`finding ${line}`)
|
||||
})
|
||||
lines.push(...legacy.freeTextFindings.map((t) => `text ${q(t)}`))
|
||||
if (legacy.comment) lines.push(`comment ${q(legacy.comment)}`)
|
||||
return lines
|
||||
})
|
||||
}
|
||||
|
||||
function countsOf(report: Report): Counts {
|
||||
const zones = report.observations.flatMap((o) => o.zones)
|
||||
const findings = report.observations.flatMap((o) => o.findings)
|
||||
return {
|
||||
observations: report.observations.length,
|
||||
zones: zones.length,
|
||||
unresolvedZones: zones.filter((z) => z.unresolved).length,
|
||||
findings: findings.length,
|
||||
unresolvedFindings: findings.filter((f) => f.unresolved).length,
|
||||
}
|
||||
}
|
||||
|
||||
function headerLines(
|
||||
source: 'v2' | 'v3',
|
||||
report: Report,
|
||||
sheet: SheetIndex,
|
||||
opts: CompareOptions,
|
||||
): string[] {
|
||||
const ref = sheet.sheet.ref
|
||||
const sameSheet =
|
||||
report.sheet.sheetId === ref.sheetId &&
|
||||
report.sheet.documentSha256 === ref.documentSha256
|
||||
const sheetLine = sameSheet
|
||||
? `sheet ${ref.sheetId} (${sheet.sheet.status}, matches the bundled sheet)`
|
||||
: `sheet ${report.sheet.sheetId} !! written on another sheet document (sha ${report.sheet.documentSha256.slice(0, 12)}…)`
|
||||
const c = countsOf(report)
|
||||
const lines = [
|
||||
source === 'v2' ? 'v2 → v3 (migrated)' : 'v3 (read as is)',
|
||||
sheetLine,
|
||||
`id ${report.id} · date ${report.date} · ${c.observations} observations · ${c.zones} zones (${c.unresolvedZones} unresolved) · ${c.findings} findings (${c.unresolvedFindings} unresolved)`,
|
||||
]
|
||||
if (opts.identity) {
|
||||
lines.push(
|
||||
`practitioner ${q(report.practitioner.name)} · animal ${q(report.animal.name)} · owner ${q(report.owner.name)}`,
|
||||
)
|
||||
}
|
||||
return lines
|
||||
}
|
||||
|
||||
function footerLines(report: Report): string[] {
|
||||
const lines: string[] = []
|
||||
if (report.conclusion) lines.push(`conclusion ${q(report.conclusion)}`)
|
||||
if (report.recommendations) {
|
||||
lines.push(`recommendations ${q(report.recommendations)}`)
|
||||
}
|
||||
if (report.nextAppointment) {
|
||||
lines.push(`next appointment ${JSON.stringify(report.nextAppointment)}`)
|
||||
}
|
||||
return lines
|
||||
}
|
||||
|
||||
/**
|
||||
* `raw` is the attachment as found in the PDF, `outcome` its v3 reading
|
||||
* (`readReportDocument`); `migrated` tells which vocabulary the lines use.
|
||||
*/
|
||||
export function compareReport(
|
||||
raw: unknown,
|
||||
outcome: MigrationOutcome,
|
||||
migrated: boolean,
|
||||
sheet: SheetIndex,
|
||||
opts: CompareOptions,
|
||||
): Comparison {
|
||||
const { report } = outcome
|
||||
const source = migrated ? 'v2' : 'v3'
|
||||
const v3Lines = report.observations.map((o) =>
|
||||
observationLines(o, sheet, opts),
|
||||
)
|
||||
return {
|
||||
source,
|
||||
header: headerLines(source, report, sheet, opts),
|
||||
observations: migrated
|
||||
? migratedObservationLines(raw, report, sheet, opts)
|
||||
: v3Lines,
|
||||
footer: footerLines(report),
|
||||
normalized: [...v3Lines.flat(), ...footerLines(report)],
|
||||
counts: countsOf(report),
|
||||
}
|
||||
}
|
||||
|
||||
export function renderComparison(name: string, c: Comparison): string[] {
|
||||
return [
|
||||
`== ${name}`,
|
||||
...c.header.map((l) => ` ${l}`),
|
||||
...c.observations.flatMap((lines) =>
|
||||
lines.map((l, i) => (i === 0 ? ` ${l}` : ` ${l}`)),
|
||||
),
|
||||
...c.footer.map((l) => ` ${l}`),
|
||||
]
|
||||
}
|
||||
|
||||
export function renderSummary(name: string, c: Comparison): string {
|
||||
const n = c.counts
|
||||
return `${name} · ${c.source === 'v2' ? 'v2→v3' : 'v3'} · ${n.observations} obs · zones ${n.zones}/${n.unresolvedZones} unresolved · findings ${n.findings}/${n.unresolvedFindings} unresolved`
|
||||
}
|
||||
|
||||
/** Lines of A absent from B and lines of B absent from A, in order. */
|
||||
export function diffLines(a: string[], b: string[]): string[] {
|
||||
const inB = new Set(b)
|
||||
const inA = new Set(a)
|
||||
return [
|
||||
...a.filter((l) => !inB.has(l)).map((l) => `- ${l}`),
|
||||
...b.filter((l) => !inA.has(l)).map((l) => `+ ${l}`),
|
||||
]
|
||||
}
|
||||
|
||||
export interface CliArgs extends CompareOptions {
|
||||
files: string[]
|
||||
summary: boolean
|
||||
diff: boolean
|
||||
}
|
||||
|
||||
export function parseArgs(argv: string[]): CliArgs {
|
||||
const args: CliArgs = {
|
||||
files: [],
|
||||
locale: 'fr',
|
||||
identity: false,
|
||||
summary: false,
|
||||
diff: false,
|
||||
}
|
||||
for (let i = 0; i < argv.length; i += 1) {
|
||||
const arg = argv[i]!
|
||||
if (arg === '--identity') args.identity = true
|
||||
else if (arg === '--summary') args.summary = true
|
||||
else if (arg === '--diff') args.diff = true
|
||||
else if (arg === '--locale') {
|
||||
const value = argv[++i]
|
||||
if (value !== 'fr' && value !== 'en') {
|
||||
throw new Error('--locale takes fr or en')
|
||||
}
|
||||
args.locale = value
|
||||
} else if (arg.startsWith('--')) throw new Error(`unknown option ${arg}`)
|
||||
else args.files.push(arg)
|
||||
}
|
||||
return args
|
||||
}
|
||||
Reference in new issue
Block a user