diff --git a/.claude/memory/decisions.md b/.claude/memory/decisions.md index f996c442..f115c5d8 100644 --- a/.claude/memory/decisions.md +++ b/.claude/memory/decisions.md @@ -928,3 +928,15 @@ Owner brief « R0 — Autorisation des trois dernières corrections graphiques **Alternatives rejected**: decide from click target (pointer capture retargets click of selected marker press; blur-commit rebuild drops click); deselect at pointerup for all pointers (touch click lands on shifted layout); Escape registry in workspace (hidden kept body cannot hold focus → per-body listener simpler). **Refs**: contract .claude/tasks/contracts/2026-11-12-r1-history-deselect-1141.md; plan rev 3 .claude/tasks/plans/2026-11-12-r1-history-deselect-1141.md; commits 7dda61d, bbb1668, bbdfd27, a1ee194, 132756e, 6ed90ef; docs V1-2-6_U1_CORRECTIONS.md R1 « Behaviour and limits », ANNOTATION-RENDERING.md D6b. Supersedes D6 line « empty-canvas click left to U2 » (BDR-107). **Validation**: technical (verifier 15/15, security PASS x2, code review fixes landed, e2e:shell 197/4/99 = baseline fails only); owner manual check on db:trial PENDING. +- **Status (2026-11-12)**: accepted; R1 validated functionally by owner 2026-11-12 (10/10 manual db:trial + 927537b visual check) + +## BDR-114 — R2 Références tab: display sort/search in TS, provisional EN labels, anomaly B fixed apart, GO after R1 visual confirmation (2026-11-12) +- **Status**: accepted (owner 2026-11-12) +**Decision** (owner 2026-11-12 « Validation du plan R2 » + « Validation finale R1, correctif E2E et GO R2 »): R2 = Références tab (D1-D4, A1-A4, boards 23-27), sub-lots R2.0-R2.6, one commit + push per validated sub-lot. +**A. Sort + search of references for display in TypeScript**: pure over reference ids; never mutate document, stored order, ids or undo/redo history. Exception to BDR-043 (Rust by default) written in `RUST_ARCHITECTURE_REVIEW.md` Part II. Why: display ordering only; locale collation via `Intl.Collator` (Rust equivalent needs ICU); `filter.ts`, `citations.ts` already TS. +**B. EN labels of `docs/design/v1-2-6-r0/REVUE.md`** = provisional working basis, NOT ratified one by one; exhaustive FR/EN table of new/changed R2 labels with ambiguities flagged, app terminology kept, shown at R2 checkpoint before final validation. +**C. Anomaly B** (admin.spec working-copy dialog on historical sheet, slot taken by sandbox suite copy 8c315a12) fixed apart, before R2, own commit: isolated fixture (`seedOfficialSheet`, real core fingerprint), suite archives only copies it created, no existing data changed or deleted, assertions not weakened. Fails or needs existing data → stop, R2 not started. +**Gate lifted**: R1 visual confirmation of 927537b obtained 2026-11-12 (R1 validated functionally). +**Constraints**: sandbox-only automated tests; no SQL migration, Rust/worker, roles, MFA, secrets, trial data, historical sheet or manual working copy change; no merge/deploy; R3/R4/U2/U2b not started. +**Alternatives rejected**: sort/search in Rust core (no gain, ICU weight, no document impact); EN labels ratified en bloc (owner wants per-label check); set-aside/restore of existing copies like editor-equine (modifies existing data). +**Refs**: `.claude/tasks/TODO.md` R2 block (a1d4084), `docs/development/V1-2-6_U1_CORRECTIONS.md` §R2, `docs/design/v1-2-6-r0/{ARBITRAGES,REVUE}.md`, BDR-110. diff --git a/.claude/memory/journal.md b/.claude/memory/journal.md index 8ab44418..f2aecb90 100644 --- a/.claude/memory/journal.md +++ b/.claude/memory/journal.md @@ -555,3 +555,4 @@ R5.4: `draft/{labels,changelog,review_report,drawing,overlay,app_review,svg_comp ## 2026-11-12 - 2026-11-12 R1 + D6b delivered on feature/v1-2-anatomical-sheets (owner GO): Défaire/Refaire, Désélectionner, Escape priority, empty press on drawing deselects (useEmptyTap, press-based; mouse at pointerup, touch+pen at own click). Plan challenged x2 (capture retarget, blur-rebuild click drop, touch click-through). Gates: unit 1381/180/66, e2e:ui 227, e2e:shell 197/4/99 (4 = admin.spec.ts:717 baseline). Verifier 15/15, security PASS x2, code review fixes landed. Stopped at R1 checkpoint; R2 not started. - 2026-11-12 R1 last owner feedback: « Sélection » tag above drawing made sr-only (927537b), drawing stable on select/deselect (desktop + 375 twin e2e); docs 00936c8 (board 04/26 deviation). BLK-013, LRN-131. Owner: R1 accepted technically, visual fix to confirm on db:trial; ToolNotes shift + SR selection announce + iOS open; RR-14 secrets rule added. R2 not started. +- 2026-11-12 R1 VALIDATED functionally by owner (10/10 manual checks + 927537b visual confirmation). BDR-114 R2 decisions recorded. Next: anomaly B e2e fix (isolated fixture), then R2 GO. diff --git a/.claude/tasks/TODO.md b/.claude/tasks/TODO.md index b59760f4..fa7750b5 100644 --- a/.claude/tasks/TODO.md +++ b/.claude/tasks/TODO.md @@ -689,11 +689,11 @@ Order (BDR-071): P0 docs + decisions → V1-1 clients and animals → V1-2 sheet - [x] R1 history « Défaire » / « Refaire » + « Désélectionner » + Escape priority + D6b: DELIVERED 2026-11-12 (`7dda61d`, `bbb1668`, `bbdfd27` + `a1ee194`, `ab823f4` + `2327d61` + `0849e54`, `0d1edac`; review fixes `132756e`, `6ed90ef`, `9807ed2`; docs `90a5e7a`, `a180b9e`, `58d432d`, `b8dda1b`, comment `6ef5223`); final gates on `a180b9e` (src = HEAD but one comment): typecheck, lint, build ok; unit app 1381, supabase 180, core-wasm 66; e2e:ui 227; e2e:shell 197 passed / 4 failed (`admin.spec.ts:717`, anomaly B, baseline) / 99 skipped; verifier 15/15, security PASS x2, code review fixes landed; limits in `V1-2-6_U1_CORRECTIONS.md` R1; memory BDR-113, LRN-128..130. Owner 2026-11-12 « Validation mémoire R1 »: R1 accepted TECHNICALLY on the report; owner manual validation on db:trial still to do (line below); R2, R3, R4, U2, U2b not started - [x] D6b (owner 2026-11-12, U1 manual test on db:trial): a click or tap on the drawing outside any annotation deselects; built and tested in Chromium - [ ] R1 follow-ups: undo/redo glyph paths differ from board i-undo / i-redo (U1 code, deferred) · « Toutes les annotations » and « Supprimer » are 36 px below xl (touch target) · « Toutes les annotations »: focus falls to the page when its row is filtered out - - [ ] owner manual checks on db:trial: R1 (« Défaire » / « Refaire », « Désélectionner », Escape) and D6b with mouse and touch, iOS Safari included (not proven by the tests) + - [x] owner manual checks on db:trial: R1 (« Défaire » / « Refaire », « Désélectionner », Escape) and D6b with mouse and touch: 10/10 passed (owner 2026-11-12); iOS Safari not covered (kept in the known limits below) - [x] last owner feedback (brief « V1-2.6 — R1 — Dernier retour utilisateur », 2026-11-12): « Sélection : … » tag above the drawing made screen-reader-only, drawing stable on select / deselect (`927537b`, docs `00936c8`, BLK-013, LRN-131); unit app 1382; e2e:shell db:sandbox 6 editor specs 37 passed / 37 skipped / 0 failed; verifier CONFORME, security PASS x2. Owner 2026-11-12: R1 accepted technically - - [ ] owner browser confirmation on db:trial of the `927537b` visual fix (drawing stays in place, no tag above it; `V1-2-6_OWNER_TRIAL.md` §4.9 step 3) + - [x] owner browser confirmation on db:trial of the `927537b` visual fix (drawing stays in place, no tag above it): CONFIRMED by the owner 2026-11-12 (brief « Validation finale R1, correctif E2E et GO R2 »). R1 VALIDATED FUNCTIONALLY by the owner; `927537b` + `00936c8` accepted - [ ] R1 known limits kept (owner 2026-11-12): ToolNotes `role="alert"` hint above the canvas (EditableAnnotations.tsx ~373), cleared on select, still moves the drawing one line when a hint is showing (must stay visible: fixed slot or overlay, LRN-131) · the selection itself is not announced to screen readers (only the deselection is) · iOS Safari validation still needed · the other R1 deviations already documented (follow-ups line above, `V1-2-6_U1_CORRECTIONS.md` R1 « Behaviour and limits ») - - [ ] R2 fifth tab « Références », tiles, search + clear, view-only sort, panel from a finding only (34 rem, 150-200 ms slide, reduced motion). Plan APPROVED (owner 2026-11-12 « Validation du plan R2 »); GO GATED on the owner's visual confirmation of `927537b` on db:trial (no « Sélection : … » text, drawing still on select / deselect); the R1 doc closure is NOT that confirmation. Flow `/ship-feature` (plan file, challenge, contract), one commit + push per validated sub-lot, sandbox-only automated tests, no SQL / Rust / worker / MFA / roles / trial data change, no merge, no deploy, R3 R4 U2 U2b not started, untracked review file kept. Stop at the final R2 checkpoint (commits, test results, independent reviews, known gaps, db:trial manual protocol) + - [ ] R2 fifth tab « Références », tiles, search + clear, view-only sort, panel from a finding only (34 rem, 150-200 ms slide, reduced motion). Plan APPROVED (owner 2026-11-12 « Validation du plan R2 »); GO was gated on the owner's visual confirmation of `927537b` on db:trial: confirmed 2026-11-12, GO R2 given (brief « Validation finale R1, correctif E2E et GO R2 ») AFTER anomaly B is fixed and validated (fails or needs existing data changed → stop, R2 not started). Flow `/ship-feature` (plan file, challenge, contract), one commit + push per validated sub-lot, sandbox-only automated tests, no SQL / Rust / worker / MFA / roles / trial data change, no merge, no deploy, R3 R4 U2 U2b not started, untracked review file kept. Stop at the final R2 checkpoint (commits, test results, independent reviews, known gaps, db:trial manual protocol) - Owner decisions: (A) presentation sort + search in TypeScript, never mutating document, stored order, ids or history; exception written in `RUST_ARCHITECTURE_REVIEW.md` Part II · (B) EN labels of `REVUE.md` = working basis, not ratified: exhaustive FR/EN table of new or changed R2 labels with ambiguities, app terminology kept, shown at the checkpoint before final validation · (C) anomaly B fixed apart (below) - Extra requirements: cited reference never deletable · « Retirer de ce constat » removes that one association only, undone by « Défaire » · no edit action in read-only · several findings citing one reference · panel only from a finding · focus back to its origin if it still exists · Vérification « Aller à » opens the right tile with focus · reader catalogue unchanged · panel ≤ 34 rem, never wider than available · no drawing shift on panel open / close · widths 375, 1 024, 1 180, 1 279, 1 280 · `prefers-reduced-motion` · closed panel (exit animation included) neither interactive nor keyboard-reachable · visual ops never mutate stored order · four sorts tested · A1 to A4 kept · references still reachable when a search returns nothing - [ ] R2.0 internal rename of the panel place (`references` → panel name), no visible effect