diff --git a/.claude/tasks/plans/2026-11-17-v1-2-6-u2.md b/.claude/tasks/plans/2026-11-17-v1-2-6-u2.md index 1deb9456..bbf1baf3 100644 --- a/.claude/tasks/plans/2026-11-17-v1-2-6-u2.md +++ b/.claude/tasks/plans/2026-11-17-v1-2-6-u2.md @@ -1627,3 +1627,73 @@ message API), `i18n/{fr,en}.ts`, unit and e2e tests. measures again; a fresh verifier on the contract with its addendum; a fresh security auditor on the U2 diff. - [ ] STOP for the owner's trial on `db:trial`, the real equine sheet and the tablet. U2 closes only on the owner's validation. + +## Rev 5 (owner decisions at the checkpoint, 2026-11-19; contract addendum 2, criteria 32-35) + +Order: Task 17 (the drawing, riskiest, moves the layout) → Task 18 (bubble, sits over that layout) → Task 19 +(catalogue-integrity diagnosis, sandbox alone) → Task 20 (docs and gates). No `up fresh`, no reset (D4). + +### Task 17: The drawing is never under the strip + +**Files:** `styles/index.css`, `components/editor/annotations/EditableAnnotations.tsx` (`CanvasColumn` and the grid), +`AnnotationCanvas.tsx` if the box sizing changes, e2e `editor-geometry.spec.ts`, `editor-deselect.spec.ts`, +`editor-journey.spec.ts`, `docs/ANNOTATION-RENDERING.md`. + +- Pin the canvas column (view chips, canvas, add row, message line) under the strip on the editable layout + (≥ 1 024 px) while the aside scrolls past: `sticky` at `top: bar + strip + gap`, so no part of it goes under the + strip or the bar. The aside may still pass under the strip: say so in the docs. +- The column must fit: if the viewport height cannot hold it, the add row and the message line must stay + reachable. If the canvas is capped by the viewport height, its size depends on the window, never on the scroll, + and is unchanged at 1 024 × 768, 1 180 × 820 and 1 280 × 800 (measure first; probe at least one shorter height, + e.g. 1 024 × 600 and 1 180 × 700). +- Pinned controls get no scroll margin (the Task 14 page jump: a focus on a stuck element scrolled 300 → 0): + exclude the pinned column from the drawing-place margin as the strip is excluded; extend « a focus never scrolls + onto the bar or the strip » to a chip, a handle, the add button and the line's « Défaire » while scrolled; probe + the keyboard insert/delete path that scrolls a vertex into view. +- Remove the rev 4 test workarounds (`scrollToTop` / `expectOnDrawing` from de418b29): the presses in + editor-deselect :287, :597 and editor-journey :313 pass where first written. The axe scan of the journey may stay + at the page top only if the aside still meets the strip there; say which. +- « Sans décalage intempestif »: find whether the 291 px scroll on a row click came from the product or from + Playwright's click; assert the canvas's on-screen position (getBoundingClientRect) around a row selection. +- No horizontal scroll at the three sizes and the shorter probe; touch: one-finger drag, pinch, page scroll over + the canvas without a selection, the loupe: editor-touch green. +- [ ] Steps: probes first (figures before), failing tests, implement, gates, commit `fix(editor): the drawing stays + clear of the strip while the page scrolls`. + +### Task 18: The held reason in a bubble (D1) + +**Files:** `components/editor/HistoryButtons.tsx`, a bubble component under `components/editor/`, remove the +`historyPress` route (`workStore`, `EditableAnnotations` effect, other-tab guard), i18n unchanged (same texts), +unit and e2e tests. + +- A press (click, tap, Enter, Space) on a held « Défaire » or « Refaire » shows its reason in a small bubble right + under that button: absolutely placed (no layout shift), inside the viewport and below the top bar, clamped + horizontally (no horizontal scroll), on every tab. Reuse `anchoredPlace.ts` if it fits. +- Announced once per press (a status role or the existing describedby read; no double announcement), keeps + `aria-describedby`; axe passes while open. +- Closes when the hold ends, on a tab change, when the focus leaves the button (keyboard), on a press elsewhere + (touch, mouse) and on Escape. Escape order: with the bubble open, Escape closes the bubble first; the next Escape + does what it does today (creation asks, pending work drops). Test it. +- It does not cover the control its text names when that control is on screen (for « annulez-la avec Défaire » the + bubble is under « Refaire », not over « Défaire »). +- Unit: per press kind, the other-tab case flipped (the bubble shows on every tab), the closing rules, Escape order. + e2e at 1 024 × 768, 1 180 × 820, 1 280 × 800: bubble box in viewport and below the bar with the French text, + `expectNoShift`, `scrollWidth` unchanged, axe open. +- [ ] Steps: failing tests, implement, gates, commit `feat(editor): the held reason shows in a bubble by its button`. + +### Task 19: Catalogue-integrity 4 → 6, non-destructive diagnosis (D5) + +- Read-only SELECT counts of published sheets and versions now against the 426 versions recorded on 2026-11-18. +- One head run of `catalogue-integrity.spec.ts` alone, `--workers=1`. +- Only if that run fails all six: one baseline run at 56c75b1 the same way, straight after, in a git worktree + under `.superpowers/`, removed with `git worktree remove` (never by hand). No env file copied. +- Report « attributed » or « not attributed » with the figures; nothing deleted, nothing reset. + +### Task 20: Documents and gates (rev 5) + +- `V1-2-6_OWNER_TRIAL.md` §4.17: D1 to D5 recorded as decided; the bubble and the pinned drawing steps; the + « Choix visibles » list updated (bubble closing rules, Escape order, pinned column, aside under the strip). +- `V1-2-6_UX_TESTS.md`: the environment failures per D5 (named with their evidence, not resolved, not all formally + independent of U2), the Task 19 result; gate figures. +- Gates on the final code: check:all, the shell suite without editor-equine, both measures, a fresh verifier, a + fresh security auditor on the rev 5 delta. Then STOP for the owner's db:trial run.