From d9e3e34aff38b834b5a863d4655e0cf51c7a656e Mon Sep 17 00:00:00 2001 From: bchanot Date: Fri, 6 Nov 2026 11:06:10 +0100 Subject: [PATCH] docs(docs): V1-2.6 UX U0, contract amendments, O22 checks, level-1 notes --- .claude/rules/schemas.md | 5 +- .claude/rules/sheet-model.md | 17 +- .../2026-11-03-v1-2-6-editor-1509.md | 87 ++++++- .../contracts/2026-11-05-v1-2-6-ux-u0.md | 63 +++++ docs/design/README.md | 15 +- docs/development/V1-2-6_UX_COMPATIBILITY.md | 23 +- docs/development/V1-2-6_UX_DECISIONS.md | 149 +++++++---- docs/development/V1-2-6_UX_PLAN.md | 110 +++++---- docs/development/V1-2-6_UX_RISKS.md | 19 +- docs/development/V1-2-6_UX_TESTS.md | 25 +- docs/development/V1-2_ANATOMICAL_SHEETS.md | 232 +++++++++++++++++- 11 files changed, 604 insertions(+), 141 deletions(-) create mode 100644 .claude/tasks/contracts/2026-11-05-v1-2-6-ux-u0.md diff --git a/.claude/rules/schemas.md b/.claude/rules/schemas.md index c411d8a2..ea0effab 100644 --- a/.claude/rules/schemas.md +++ b/.claude/rules/schemas.md @@ -8,7 +8,10 @@ paths: ["crates/core/src/domain/**", "packages/core-wasm/tests/n-1/**"] `packages/domain` was deleted at R5.7; its byte-identical Zod copy under `packages/core-wasm/tests/n-1` is the permanent N-1 reader. Never change a contract without bumping the version on a breaking change (additive optional fields keep it); a change touches the - Rust struct, the regenerated ts-rs types and the N-1 test + Rust struct, the regenerated ts-rs types and the N-1 test. A new optional field of the sheet document is omitted when + absent and refuses `null` (`skip_serializing_if`, `js::present`, `ts(optional)`), so existing fingerprints stay + equal and the ts-rs type stays assignable to N-1; the V1-2.6 category keys also need the proofs of + `docs/development/V1-2-6_UX_COMPATIBILITY.md` §8 (T2) - Every report entering the store comes from the core (new report, draft restore, import, reducer outputs); form values are plain assignments (D-R7) - Report version 3: zones by `(annotationId, viewId)`, findings by `(findingZoneId, path)`, severities diff --git a/.claude/rules/sheet-model.md b/.claude/rules/sheet-model.md index e187da71..f11dd2bc 100644 --- a/.claude/rules/sheet-model.md +++ b/.claude/rules/sheet-model.md @@ -12,10 +12,18 @@ paths: ["crates/core/src/domain/sheet/**", "docs/development/ANATOMICAL_SHEET_MO draft (`create_sheet_draft`) then publication; from V1-2, publication only from an approved round on a server verdict of the core. - The Rust core is the only authority on document rules (O22): add a rule to `validate_sheet_document` and to the spec - table only. V1-2 (M5) dropped the SQL mirror (`private.sheet_document_issues`); SQL keeps the structural and - relational guards and the one declared status check (contract §12.2). Never add a business rule in SQL. + table only. A rule that must not strip existing fingerprints or reject old snapshots lives in `edit.rs` (editor + refusals) and in the verdict-only tier of `sheet_report`, never as a `validate.rs` error (V1-2.6 fixed categories, + T4). V1-2 (M5) dropped the SQL mirror (`private.sheet_document_issues`); SQL keeps the structural and relational + guards, the declared status check and, from V1-2.6 U6, the two declared fixed-category checks (save + non-regression; approval and publication), which hold the fixed-category invariants only (contract §12.2, + §17.12). Never add any other business rule in SQL. - Document schema change → bump `SHEET_DOCUMENT_SCHEMA_VERSION`, extend the SQL CHECK on `document_schema_version`. - No bump during V1-2 (BLK-008). + No bump during V1-2 (BLK-008). Ratified exception (V1-2.6 T2, BDR-100, BDR-101): an optional key omitted when + absent (`skip_serializing_if`, `js::present`, `ts(optional)`, an explicit `null` refused, never defaulted in the + fingerprinted document) is not a version change; it ships only with the proofs of + `docs/development/V1-2-6_UX_COMPATIBILITY.md` §8, and its first write is a point of no return (one-way + compatibility, never called full backward compatibility). - Historical equine sheet `503dc301…` = generated seed `draft/` (`pnpm import:equine --out` into an empty folder, then reviewed and copied; never edit `legacy-import/` or `draft/` by hand; `curation_draft` / `curation_review` fail on drift, `pnpm import:equine --check` lists it). Its content changes only through `curation/changes.json` (traced in @@ -31,4 +39,5 @@ paths: ["crates/core/src/domain/sheet/**", "docs/development/ANATOMICAL_SHEET_MO review screen), the document measure (`size.rs`: PostgreSQL's `jsonb` text, never `JSON.stringify`), `PreviewSheet` and the editor's commands (`edit.rs`, the §6.6 marking rules). A change to the SVG reader, the rules, the caps, the fingerprint or the digests is a core change - (contract §6.4: the release withdraws open rounds). RUST.md §12. + (contract §6.4: the release withdraws the rounds of drafts in flight; a published version's round stays approved). + RUST.md §12. diff --git a/.claude/tasks/contracts/2026-11-03-v1-2-6-editor-1509.md b/.claude/tasks/contracts/2026-11-03-v1-2-6-editor-1509.md index 8233c36a..55504227 100644 --- a/.claude/tasks/contracts/2026-11-03-v1-2-6-editor-1509.md +++ b/.claude/tasks/contracts/2026-11-03-v1-2-6-editor-1509.md @@ -8,6 +8,16 @@ - contract of the step: docs/development/V1-2_ANATOMICAL_SHEETS.md §16.7 and §8.1-§8.4, with §6.2, §6.6, §6.7, §9.2-§9.4, §10, §11.1-§11.2, §17.9, §17.11; design docs/design/v1-2-4 boards 04, 05, 06 A (approved, BDR-096), REVUE.md ratified wordings +- [amended 2026-11-05, V1-2.6 UX U0] level 1 as built here is NOT declared validated as a whole (owner T11); the + redesign (sub-steps U1 to U8 of `docs/development/V1-2-6_UX_PLAN.md`) follows the 16 boards of + `docs/design/v1-2-6` (validated 2026-11-05), which replace v1-2-4 boards 04 and 05 for editing (board 05's + narrow-screen read-only mode stays the reference under O14 A, C16); the criteria it changes carry an amendment + note below. Precedence for the redesign: where a criterion of this contract, with or without a note, differs + from the validated v1-2-6 boards or from the V1-2 contract as amended (§8.2-§8.4, §17.12), the amended contract + prevails first, then the boards. Two exceptions: a difference listed in `docs/development/V1-2-6_UX_DECISIONS.md` + (« Points from the boards for U1 and later ») is an open owner question, and until the owner answers it the + criterion stays as written; a point owned by another step (V1-2.7: preview, withdrawal) stays with that step. The + other criteria stay in force ## REQUEST (verbatim — IMMUTABLE) @@ -159,7 +169,9 @@ Q: Which drawing for A2 (« un SVG réel », non-equine, exported then cleaned) committed Inkscape 1.4.3 export (`crates/core/tests/fixtures/svg/exports/inkscape-1.4.3-*.svg`, a real export, cleaning offered) plus a hostile file; the owner may import a drawing of their own at the trial. Q: Undo / redo control (not on board 04) / A: [gated 2026-11-03] two icon buttons « Annuler » and « Rétablir » -in the tool column under the zoom, plus Ctrl+Z and Ctrl+Shift+Z. +in the tool column under the zoom, plus Ctrl+Z and Ctrl+Shift+Z. [amended 2026-11-05, U0, §17.12: the two buttons +move to the editor header on every tab (ARBITRAGES choice 2, built at U1); the history command is named « Annuler la dernière +modification » (T15); the shortcuts are unchanged.] Q: Plan approval (8 visible choices, rescue copy) / A: [gated 2026-11-03] owner brief « GO propriétaire V1-2.6 »: plan, lots A-M, C1-C24 and the 8 choices approved; M8 on the throwaway sandbox only; no JSON export button for the recovery copy; local recovery kept with exact messages on its state and limits; a local restore never silently @@ -198,11 +210,22 @@ checked across develop, main, feature/v1-1, feature/v1-2: next free were BDR-099 3. Tabs Général, Vues et illustrations, Annotations, Constats, Références, Vertèbres, Vérification (§11.1), ARIA tabs; every change is one core `sheet.edit` command run on commit (blur, confirm, pointer-up), never per keystroke; TypeScript keeps no document schema and no Zod copy (ts-rs types only). + [amended 2026-11-05, V1-2.6 UX U0, V1-2 contract §17.12; built at U1] Four tabs: Général, Annotations, + Constats, Vérification. Views, drawings, annotation categories and vertebral regions move into Annotations; + Références becomes a side panel opened from the header or from a finding; Annuler and Rétablir sit in the + header on every tab. The commit rule and the ts-rs-only rule above are unchanged. 4. Général: FR/EN name, description, scope disclaimer, attribution (authors, licence, notes); annotation categories (name FR/EN, colour) add, edit, delete. + [amended 2026-11-05, U0, §17.12] Categories leave Général for the category panel of Annotations (U3: swatch + and name, palette and hex, staged « Appliquer », delete when unused, « Réaffecter à… »). From U6 the three fixed + categories Os, Articulations, Vertèbres keep their names and roles (no delete, name read-only), their colour and + fill opacity stay adjustable; other categories stay free. 5. Références: add, edit, delete; type, citation, URL (http or https only), DOI. Vertèbres: add (code typed at creation, read-only after), edit, reorder ↑/↓, delete. A refused removal (`has_dependents`) lists the dependents from `sheet.dependents`; no cascade deletion. + [amended 2026-11-05, U0, §17.12] References move to a side panel (C3). Vertebral regions open from the + vertebra-role category at U6 (board 09): reorder by grip handle or Alt+arrows, staged « Appliquer »; the + ↑/↓ buttons stay until then; whether a region code stays read-only after creation is settled at U6. 6. Vues et illustrations: main view and detail views (parent; own drawing or crop entered as numeric `view_box` values over the parent's preview), rename, delete (dependents listed). Drawing upload: the file is read by the core (`clean_svg`); hard rejection and active content refused with the reason in FR/EN, no @@ -211,6 +234,11 @@ checked across develop, main, feature/v1-1, feature/v1-2: next free were BDR-099 registered, hashed and uploaded are `SvgCleaning.stored` with the core's sha256; register, upload at `.svg` (an existing object, Storage HTTP 400 with body `statusCode` "409", counts as present), confirm; the drawing state (ok, missing, rejected) is shown; the §9.3 closed codes have FR/EN messages. + [amended 2026-11-05, U0, §17.12] Views and drawings sit in Annotations. A crop is drawn as a rectangle over + the parent's drawing, its handles resizable by keyboard (U4); the numeric `view_box` editor leaves the normal + journey; the view's name is proposed from the annotations inside and stays editable (U5); replacing a crop + view's drawing opens the three-action dialog of decision T9 before any upload (U5). Upload, cleaning, register, + upload and confirm are unchanged. 7. Annotations: on the core-composed view (`view.canvas`), tools select, point, zone, detail-view link, zoom; a point by one click with its radius in a field; a zone and a link as polygons by successive clicks, closed, Escape cancels a tracing; a link chooses the view it opens; selection on the drawing or in the @@ -219,8 +247,21 @@ checked across develop, main, feature/v1-1, feature/v1-2: next free were BDR-099 moved or edited as path data; zoom and pan; every coordinate (cx, cy, r, each vertex x and y) in numeric fields, vertices added and removed in the list; a keyboard-only path creates and edits points, zones and links (numeric fields). + [amended 2026-11-05, U0, §17.12; built at U2 and U4] Direct manipulation replaces the numeric fields in the + normal journey: point move and a size slider snapped to the sizes of the view, with the core's minimum mark; + vertex drag, « + » on a segment, « − » on the chosen vertex (disabled at 3 vertices with its reason, board 12 B); zone move, directly + with the mouse once selected, in an explicit « Déplacer la zone » mode by touch; redraw keeping the old shape + until the new one is accepted. The keyboard alternative goes through the handles (Tab, arrows, Shift ×10, + Insert or Backspace or Delete, Enter, Escape); no coordinate field. The detail-view link tool leaves the + toolbar: an access is placed from the view's menu (« Ajouter un accès »), and created with the view from U6 + when no annotation overlaps it. Paths are unchanged (C45, T16): displayed, selectable, deletable, never moved + or edited; « Remplacer par un polygone » stays their one explicit exit, validated by the core, the old path kept + until the polygon is accepted, one undo entry. 8. Annotation properties: FR and EN name, category, laterality, finding zone, vertebral region, colour, review marking; « Marquer comme relu » on one element; delete with the dependents shown when refused. + [amended 2026-11-05, U0, §17.12; built at U3] The annotation's own colour is shown only when set, with + « Revenir à la couleur de la catégorie » (one `update` with `color: null`); a new annotation carries no own + colour and inherits its category's. The other properties are unchanged. 9. Constats: tree of finding zones, categories (kind) and nodes up to depth 8: add, rename FR/EN, describe FR/EN, vet referral flag, cite references, review marking of one element, « Marquer comme relu » on one category or one zone (never sheet-wide), reorder among siblings with ↑/↓, delete with a confirmation @@ -236,6 +277,14 @@ checked across develop, main, feature/v1-1, feature/v1-2: next free were BDR-099 deviation of REVUE.md); header « Révision N · modifications non enregistrées »; every server failure kind mapped to an FR/EN message; « Annuler les modifications » returns to the last saved document after a confirmation; the leave guard (`useLeaveGuard`) is armed while unsaved. + [amended 2026-11-05, U0, §17.12; built at U1] The header states follow the validated boards (07, 08, 09, + 12 A, 13): « n modifications non enregistrées » while unsaved, « Enregistré à hh:mm · révision n » after a + save; the exact labels go to the U1 label review. + [amended 2026-11-05, U0, owner decision T15, §17.12; built at U1] The command that returns to the last saved + document is labelled « Abandonner les modifications » (today `editor.draft.discard` « Annuler les + modifications », `apps/app/src/i18n/fr.ts:1238`), so no discard of unsaved changes is called « Annuler »; + dialogs that close without effect keep « Annuler » (outside T15, DECISIONS T15); its confirmation and behaviour + are unchanged. 12. Conflict (§6.2): `draft_conflict` opens a dialog with the server revision (and its author and time if the owner's answer provides them) and « Recharger » or « Garder ma version »; the second saves the local document on the new revision only after an explicit confirmation naming what it replaces; nothing is @@ -245,12 +294,18 @@ checked across develop, main, feature/v1-1, feature/v1-2: next free were BDR-099 status bound to the real write (LRN-057), removed after a successful save or an explicit discard; offered back on opening when it differs from the server document, restored through the core, never sent automatically; proven by a restore round trip (LRN-058). + [amended 2026-11-05, U0, wording matched to the code] The copy is keyed by account and version + (`apps/app/src/editor/state/recovery.ts:47-49`); the revision is a field of the copy (`recovery.ts:25`), used + as the expected revision at restore (C27). Behaviour unchanged. 14. Undo and redo: a stack bounded by 8 MiB of document strings (UTF-8 bytes). 15. Ids generated by the page `-<10 characters a-z2-7>` (crypto random), inside the stable-id grammar, never derived from labels, never editable, never reused within the document. 16. Below 1 024 px (board 05): read-only, badges « Brouillon » and « Lecture seule », the notice title alone (L15, BDR-099 §17.11), tabs, the whole drawing at opening, zoom and pan, a properties summary, no editing action; unsaved work in memory survives a width change. No horizontal scroll at 320, 375 and 768 px. + [amended 2026-11-05, U0] Board 05 is v1-2-4's and stays the reference of this read-only mode under O14 A. + Board 15 C of v1-2-6 shows the same rule only as an illustration: its two-sentence notice and the absence of + tabs and summary there are not adopted; the notice title alone, the tabs and the summary stay. 17. Security: stored drawing bytes are never inserted into the page; only core-composed trees are rendered (DOMParser + importNode); the cleaning preview is composed by the core under a scope unique in the page; the original file is never rendered; no `innerHTML` / `dangerouslySetInnerHTML` carries drawing or @@ -259,6 +314,11 @@ checked across develop, main, feature/v1-1, feature/v1-2: next free were BDR-099 core's rules and readers, the readers of user data, the equine legacy sources, seed and oracles, the goldens; the wasm module within its 600 000 B gzip budget; `pnpm r5:import-equine --check` without difference. + [amended 2026-11-05, U0, §17.12] This list describes level 1. The redesign changes, each on its own + authorisation: one read-only core value (U2), two core queries (U5), and at U6 the category model (core rules + and edit refusals, a bounded widening of the snapshot reader, one SQL migration with the declared checks of + contract §12.2), under `docs/development/V1-2-6_UX_COMPATIBILITY.md`. The seed, the legacy sources, the + oracles, the goldens, the wasm budget rule and `r5:import-equine --check` stay unchanged. 19. i18n: FR and EN parity; the ratified wordings (REVUE.md, §17.9, §17.11) used verbatim; the new labels listed for a separate owner review, not declared approved. 20. Tests: unit (editor state, ids, undo bound, recovery, conflict, upload steps, issue mapping); `e2e:shell` @@ -267,6 +327,9 @@ checked across develop, main, feature/v1-1, feature/v1-2: next free were BDR-099 account without capability refused); read-only at 320, 375 and a width under 1 024 px; axe on the editor and the read-only mode; core-wasm proofs; equine non-regression (catalogue P1, the equine working copy opening in the editor read path, `r5:import-equine --check`). + [amended 2026-11-05, U0, §17.12] With the redesign the keyboard path goes through the handles and the + rectangle (C7 and C6 as amended), not through numeric fields; the redesign's tests are in + `docs/development/V1-2-6_UX_TESTS.md` (U1 to U8). The other tests are unchanged. 21. Demonstration on a fresh sandbox of the request's §3 journey (steps 1 to 12) for a non-equine species, built from scratch in the UI, saved, reloaded, conflicted, submitted; the validation panel shows no error while elements are still `to_confirm`; the round reaches `verifying` (no verification worker started). @@ -280,6 +343,14 @@ checked across develop, main, feature/v1-1, feature/v1-2: next free were BDR-099 25. [gated 2026-11-03] The plan's eight visible choices are built as approved; no JSON export or import of the recovery copy; every message about the copy says it is temporary, limited to this tab and not saved on the server, and reads the real write flag. + [amended 2026-11-05, U0, §17.12] Of the plan's eight choices, the redesign replaces three: categories edited in + Général (now in Annotations, C4), keyboard creation through numeric fields (now through handles, C7), the + properties card under the canvas from 1 024 to 1 279 px (now beside it, board 13). + Plan choice 2 (creation panels ask names and laterality before the element exists, no preselection, no default + labels): for detail views it gives way to the validated name proposal (ARBITRAGES choice 6, contract §8.2 as + amended, C6); for points and zones it differs from boards 02 and 04 (laterality and other properties set after + creation), an open owner question listed in DECISIONS, plan choice 2 in force until it is answered. The other + four stay. 26. [gated 2026-11-03] Default point: radius `r0 = min(12 + 0.03 × max(w, h), min(w, h) / 2)` in the view's frame as composed by the core (composed root `viewBox`, origin kept); the clicked position is kept with r0 when the circle fits, else with a smaller radius when the core accepts it; otherwise a corrected position is shown @@ -296,7 +367,8 @@ checked across develop, main, feature/v1-1, feature/v1-2: next free were BDR-099 the server version; a copy the core refuses is reported, kept, never applied, and editing stays blocked until it is ignored. 28. [gated 2026-11-03] A copy is removed only by a successful save leaving nothing unsaved, or a confirmed - « Annuler les modifications », « Ignorer la copie », « Recharger » or « Abandonner cette copie »; never on + « Annuler les modifications » ([amended 2026-11-05, U0] « Abandonner les modifications » from U1, C11 as amended), « Ignorer la copie », + « Recharger » or « Abandonner cette copie »; never on undo, never by automatic eviction; at most two copies of other versions of the account; when the cap or the storage quota prevents keeping the current copy, the page says so and lists the other copies for an explicit, confirmed abandonment; unit tests for the cap, the quota and pending copies. @@ -317,6 +389,9 @@ checked across develop, main, feature/v1-1, feature/v1-2: next free were BDR-099 illustrations »; existing annotations shown and selectable with read-only geometry, no drag; `accept` refuses every creation and geometry commit there (checked on the post-commit state); the fallback frame `0 0 100 100` is never used as a frame; the core stays the authority, no TypeScript frame or size rule. + [amended 2026-11-05, U0, §17.12] With direct manipulation the same views disable the handles, the size slider, + the keyboard handle moves, the creation tools and the detail-view rectangle, with the same hint naming where the + drawing is attached (Annotations after U1); there is no numeric geometry field left to disable. 33. [gated 2026-11-04] Geometry commits: accepted only when the changed annotation carries no Error at `annotations[i].geometry` after the commit (new, valid or already invalid before), refused otherwise with the handle rolled back and nothing kept; a typed radius the core reports `too_small` is refused; the geometry @@ -326,6 +401,11 @@ checked across develop, main, feature/v1-1, feature/v1-2: next free were BDR-099 annotation without a geometry error gets one, or a measured view holding annotations becomes unmeasured; the save path and the server verdict unchanged; Node-core unit tests for repair, `too_small`, drag rollback and frame changes. + [amended 2026-11-05, U0, §17.12] The acceptance rule applies to every handle gesture, slider release and + keyboard move: a geometry commit is kept only when the changed annotation carries no Error at + `annotations[i].geometry` afterwards; a refused gesture restores the previous shape exactly, with the core's + message. The numeric form group leaves the normal journey: an annotation already invalid is repaired through its + handles, its error shown until the fix is accepted. The frame-change rule is unchanged. 34. [gated 2026-11-04] A drag starts after 4 CSS px (click, keyboard and touch kept); an unreadable copy is kept until « Ignorer la copie » confirmed, its notice names the loss, editing blocked meanwhile; the leave guard is armed only while unsaved or a recovery decision is pending, and its mobile-browser limits are documented; the @@ -344,6 +424,9 @@ checked across develop, main, feature/v1-1, feature/v1-2: next free were BDR-099 naming its effect) and non-destructive (undoable; the stored drawing is not deleted). 40. [gated 2026-11-04 checkpoint] Default tab at opening: Général for a new, empty sheet; Annotations for an existing sheet with at least one measurable view; read-only modes kept. + [amended 2026-11-05, U0, §17.12] Same rule on the four tabs of C3: Annotations now also holds the views and + drawings, so a sheet without a measurable view still opens on Général and reaches the drawing upload from + Annotations. 41. [gated 2026-11-04 checkpoint] Attaching a drawing to an unmeasured view whose annotations would fall out of the new frame no longer forces their deletion: the attachment and the repairs are prepared in a temporary state and validated atomically by the Rust core (one commit, nothing kept on refusal). A new Rust operation, if one diff --git a/.claude/tasks/contracts/2026-11-05-v1-2-6-ux-u0.md b/.claude/tasks/contracts/2026-11-05-v1-2-6-ux-u0.md new file mode 100644 index 00000000..6b66dca4 --- /dev/null +++ b/.claude/tasks/contracts/2026-11-05-v1-2-6-ux-u0.md @@ -0,0 +1,63 @@ +# CONTRACT: V1-2.6 UX, sub-step U0 (contract, decisions and amendments, docs only) (2026-11-05) + +- REQUEST (owner brief « FAUNOSTEO — V1-2.6 UX — Autorisation U0 uniquement », 2026-11-05): start U0 and U0 only, + after the pending doc corrections are verified and committed. The UX choices and the 16 V2 boards are approved + for good; no graphic arbitration is reopened. Record the complementary ratification (A), run U0 as defined in + `docs/development/V1-2-6_UX_PLAN.md` §3 U0 (docs, contract, preconditions, non-destructive checks), stop at the U0 + checkpoint. No merge, no deploy, no DEV access or write, no U1, no V1-2.7. Owner brief « FAUNOSTEO — V1-2.6 UX — + Finalisation de U0 uniquement » (2026-11-05, after the ratification was verified CONFORME at `a505b24`): finish the + uncommitted U0 work without overwriting it (main contract sections, level-1 criteria, five UX docs, BDR-101, TODO), + check every cross-reference, independent review, commit and push only the planned docs, stop at the U0 checkpoint. +- OWNER ANSWERS (brief A): + - T4: both declared SQL checks approved: at save, protect the uniqueness of the fixed categories, their roles and + their presence without blocking old drafts that carry none of these keys; at approval and publication, + guarantee the model's invariants whatever the worker does. O22 amended strictly for these invariants; the core's + validation is not duplicated in SQL. + - T5: new-sheet ids `cat-bone`, `cat-joint`, `cat-vertebra`; the validated French names kept; the English names + and the exact reference colours documented from the existing data; historical sheets and their fingerprints + fully preserved. + - T10: option B: internal category `cat-access`, role `navigation`, not visible as an anatomical category; + automatic access conditional on U6. + - T15: « Annuler la dernière modification » for the history; « Abandonner » or « Abandonner les modifications » + for a form. + - T16: deferral of curve editing kept; a check of the existing geometries planned before any activation of the + new model, with no DEV access during U0. + - T12: U7 stays blocked until the source and the legal content are validated. + - T17: its exact wording read and presented, no decision invented; stop only if it really blocks U0. + - T1/T6: conditions and deadlines already documented kept. + - « Remplacer par un polygone »: kept only as an explicit replacement, validated, the old path kept until + success, undo and redo supported; no automatic destructive conversion. +- ACCEPTANCE CRITERIA: + - U1c Each answer above is recorded once (`V1-2-6_UX_DECISIONS.md` and the contract's new §17.12) and cited where + it applies; BDR-101 written through `memory.sh`; BDR-100's open items marked answered through `memory.sh status`. + - U2c O22 (`V1-2_ANATOMICAL_SHEETS.md` §12.2 and the §17.1 row) amended strictly: the two declared checks hold only + the fixed-category invariants (each role `bone`, `joint`, `vertebra` carried by exactly one category with its + fixed FR and EN names; at save: no regression of the stored draft's roles, role-less drafts still save); no other + rule mirrored; `.claude/rules/sheet-model.md` says the same. + - U3c §7.4 records the one-time copy of a versioned common text and the T12 block, with no normative wording. + - U4c §8.2, §8.3, §8.4 match the validated UX and the decisions: four tabs, direct manipulation, no coordinate + field in the normal journey, crop rectangle drawn, fixed categories and opacity at U6, own colour shown when + set, access placed from the view's menu (automatic at U6 with `cat-access`), curves per T16 with the + « Remplacer par un polygone » guarantee, O14 A kept, the tablet rule. + - U5c §16.7 states the level-1 status (T11, not validated as a whole) and the redesign sub-steps; the withdrawal + rule of §6.4 is precise about draft rounds, matching T4 and the code. + - U6c Level-1 contract criteria C3, C4, C6, C7, C8, C13, C32, C33, C40 amended in place (original text kept, an + amendment note appended), the immutable REQUEST untouched; no contradiction with the boards or the contract. + - U7c `docs/design/README.md`: v1-2-6 validated, its boards replace v1-2-4 boards 04 and 05 for the editor + (BDR-096 kept for the rest). + - U8c `.claude/rules/schemas.md` and `sheet-model.md`: optional category keys under T2 (omitted when absent, never + null, no version bump, proof list), rules also in `edit.rs` and `sheet_report`. + - U9c The implementer decisions (T7, T8, T13, T18, T19) recorded in the contract. + - U10c The five UX docs, RISKS blocking criteria, TODO.md and the journal agree with U1c-U9c; nothing answered is + still called open or « to confirm »; T17, T1, T6, T12, T14 stay open with their conditions. + - U11c Facts cited for T5 (names, colours) and the « Remplacer par un polygone » guarantee hold in the data and + the code (file:line). + - U12c Scope: no change under `crates/`, `apps/`, `packages/`, `supabase/`, `scripts/`; no SQL, worker, sandbox or + DEV command; no merge. +- FILE SCOPE: `docs/development/V1-2_ANATOMICAL_SHEETS.md`, `docs/development/V1-2-6_UX_{DECISIONS,PLAN,COMPATIBILITY, + TESTS,RISKS}.md`, `docs/design/README.md`, `.claude/tasks/contracts/2026-11-03-v1-2-6-editor-1509.md`, + `.claude/rules/{sheet-model,schemas}.md`, `.claude/tasks/TODO.md`, `.claude/memory/{decisions,journal}.md` + (through `memory.sh`), this contract. +- OUT OF SCOPE: code, SQL, worker, Supabase DEV, sandbox, `docs/design/v1-2-6/*` (archived boards and their notes), + `ANNOTATION-RENDERING.md` and `ANATOMICAL_SHEET_MODEL.md` (U6), U1 and later, V1-2.7. +- ABANDON: if a criterion needs a change outside the file scope, stop and report. diff --git a/docs/design/README.md b/docs/design/README.md index 037d31b9..1afd0812 100644 --- a/docs/design/README.md +++ b/docs/design/README.md @@ -106,11 +106,20 @@ Accepted deviations (owner 2026-11-02, V1-2.5): the boards stay as approved, not 2. On a phone, « Références » is a plain, non-collapsible card (`03`). Condition: it does not hide the anatomical area (it starts at or below the drawing's bottom, checked at 320 and 375 px). -## v1-2-6/ — V1-2.6 graphic editor maquettes (proposal, not validated) +## v1-2-6/ — V1-2.6 graphic editor maquettes (validated 2026-11-05) + +Validated by the owner on 2026-11-05 (brief « V1-2.6 — Validation UX définitive et préparation technique »: the +sixteen boards of archive V2 and the eleven choices of `ARBITRAGES.md`; confirmed for good by the brief « V1-2.6 +UX — Autorisation U0 uniquement », no graphic arbitration reopened; V1-2 contract §17.12). They replace boards +`04` and `05` of v1-2-4 as the editing reference; board `05`'s narrow-screen read-only mode stays the reference +under O14 A (level-1 C16); BDR-096 stays in force for every other v1-2-4 board. The +« Ouvert » statuses of `ARBITRAGES.md` and the « à arbitrer » notes of `REVUE.md` are superseded by that +validation; both files are kept as archived. Boards `14` to `16` (phone editing) are the reference of a future +lot: in V1-2 the editor stays read-only below 1 024 px (O14 A, choice 9). Implementation follows +`docs/development/V1-2-6_UX_PLAN.md` (sub-steps U1 to U8), each on its own owner authorisation. Produced 2026-11-05 on the owner's brief « V1-2.6 : nouvelles maquettes UX approuvées sur le principe » -(contract `.claude/tasks/contracts/2026-11-05-v1-2-6-ux-maquettes.md`). A proposal until the owner validates it: -boards `04` and `05` of v1-2-4 stay the editor reference meanwhile. Sixteen boards, desktop, tablet and phone: +(contract `.claude/tasks/contracts/2026-11-05-v1-2-6-ux-maquettes.md`). Sixteen boards, desktop, tablet and phone: four tabs (Général, Annotations, Constats, Vérification), references in a side panel, point and zone tools with direct manipulation (vertex handles, « + » on segments, « − » bubble, move and redraw modes, undo/redo), fixed categories Os / Articulations / Vertèbres with colour and opacity, detail view drawn as a rectangle, vertebral diff --git a/docs/development/V1-2-6_UX_COMPATIBILITY.md b/docs/development/V1-2-6_UX_COMPATIBILITY.md index 4a88c064..cd6b2f9f 100644 --- a/docs/development/V1-2-6_UX_COMPATIBILITY.md +++ b/docs/development/V1-2-6_UX_COMPATIBILITY.md @@ -2,7 +2,8 @@ Status: PROPOSAL, 2026-11-05, audited at `f58cf23`, revised after the independent review and after the owner's answers of 2026-11-05 (T2/T3 ratified with conditions, T4 without residual gap, T5 historical preservation, T10 -navigation type). Companion of `V1-2-6_UX_PLAN.md`. Each cell states the outcome the code gives today (VERIFIED, +navigation type) and the brief « Autorisation U0 uniquement » (T4 SQL checks approved, T5 defaults, T10 option B; +BDR-101). Companion of `V1-2-6_UX_PLAN.md`. Each cell states the outcome the code gives today (VERIFIED, file:line) or the outcome the plan requires and must prove by a test (REQUIRED, test in `V1-2-6_UX_TESTS.md`). Nothing here is proven by assertion alone. @@ -24,7 +25,7 @@ The change is compatible in one direction only, and these documents never call i Two optional keys on `AnnotationCategory` (`crates/core/src/domain/sheet/schema.rs:219-228`): ```text -role?: "bone" | "joint" | "vertebra" (+ "navigation" if T10 option B is confirmed) +role?: "bone" | "joint" | "vertebra" | "navigation" (navigation: T10 option B, ratified) fill_opacity?: integer percent, 10 to 100 (T3) ``` @@ -36,7 +37,7 @@ validated document the fingerprint hashes (the layer applies its constants at re annotation `color` precedent, `schema.rs:215-216`, `429-430`), every fingerprint, review digest and R4 app-path digest would change: that serialisation is forbidden and pinned by tests. -If T10 option B is confirmed, the automatic access adds, on demand, one internal category +Under T10 option B (ratified, BDR-101), the automatic access adds, on demand, one internal category `cat-access` with role `navigation`: an ordinary `{id, name, color}` category for every reader before U6 once the role is stripped (§4). @@ -101,11 +102,11 @@ the fixed categories. Published versions are never re-judged by this rule (§5, |---|---|---|---|---| | `check_document_structure` | pass | pass | pass (category members never read) | VERIFIED `20261028110000_sheet_review_workflow.sql:411-441` | | CHECKs `schema_known`, `schema_matches` | pass | pass | pass | VERIFIED `20261010100000:10-12`, `20261008110000:120-121` | -| `save_sheet_draft` | saves | saves a draft without roles; with the recommended non-regression check, refuses a save that removes or duplicates a role of the stored draft or renames its category | same | VERIFIED no category check today `20261028110000:593-623`; REQUIRED U6 pgTAP if the owner confirms (T4) | +| `save_sheet_draft` | saves | saves a draft without roles; with the approved declared check, refuses a save where a role is carried twice, a role-bearing category lacks its fixed names or a role of the stored draft is lost | same | VERIFIED no category check today `20261028110000:593-623`; REQUIRED U6 pgTAP (T4, contract §12.2) | | Status walk, disclaimer, group keys | unchanged | unchanged | unchanged | VERIFIED `20261028110000:150-215`, `20261101100000:107-181` | | `sheet_verdict_codes` | unchanged | unchanged | unchanged: report issues map to the existing `verification.validation.rules`; SQL checks only top-level failure codes | VERIFIED `20261101100000:57-69`, `360-368`; `verdict.rs:277-296` | | Core gate at completion (T4) | n/a | a passed verdict from a core older than U6 refused | same | REQUIRED U6 migration and pgTAP; `verified_with` today `faunosteo-core 0.1.0` for every core (`verdict.rs:164-166`, `Cargo.toml:10`), so a U6 marker is added | -| Rounds in flight when the rules change | rounds of draft versions withdrawn by the U6 migration; the approved round of each published version stays approved (`20261028110000:102-104`, `704-705`) | same | same | REQUIRED U6 pgTAP; contract `V1-2_ANATOMICAL_SHEETS.md:945-949` | +| Rounds in flight when the rules change | rounds of draft versions withdrawn by the U6 migration; the approved round of each published version stays approved (`20261028110000:102-104`, `704-705`) | same | same | REQUIRED U6 pgTAP; contract §6.4 (worded at U0) | | Worker at `f58cf23` (old image) | verdict as today, without the fixed-category rule (refused by the core gate) | same | definitive `verification.integrity.document` (draft) or `.base` (base) | VERIFIED `verify.rs:93-97`, `verdict.rs:169-185`, `264-274`; `20261101100000:355-378` | | Worker of U6 | verdict with the fixed-category rule: fails until the draft carries the fixed categories | same | reads; passes when the fixed model holds | REQUIRED `verify-e2e` with an image checked against `HEAD` | | Approval and publication | need a verdict on the current revision and an approved round on it; U6 adds the declared check `private.sheet_fixed_categories_ok(content)` at both | refused without the fixed categories | pass when the fixed model holds | VERIFIED `20261028110000:984-990`, `1028-1072`; REQUIRED U6 pgTAP (T4, O22 amended at U0) | @@ -118,7 +119,7 @@ the fixed categories. Published versions are never re-judged by this rule (§5, | Case | Outcome | Evidence | |---|---|---| | Draft saved before U6, opened after | read as New-absent; verification fails until the fixed categories are added (repair action, T4) | REQUIRED U6 | -| Draft stripped of its roles by a direct save or an older tab | refused at save if the owner confirms the non-regression check; otherwise saved, shown with the issue and the repair; in both cases no round opens and no publication | REQUIRED U6 (T4) | +| Draft stripped of its roles by a direct save or an older tab | refused at save by the approved declared check (T4, contract §12.2), the stored draft unchanged; a draft that never carried roles still saves and is shown with the issue and the repair; in both cases no round opens and no publication | REQUIRED U6 (T4) | | Recovery copy (sessionStorage) taken before U6, restored after | document text read by the same strict reader | VERIFIED storage `recovery.ts:10-57`; REQUIRED U6 | | Recovery copy taken after U6, restored by a rolled-back app | refused like any `invalid_document`; the copy is kept, not deleted | REQUIRED: test that a refused copy is not purged | | Undo history across the U6 release | history is per page session, never persisted | VERIFIED `undo.ts`, `editorLoad.ts:136-152` | @@ -131,9 +132,9 @@ Order for any environment, for U6 and the curves lot (and any later change of th the fingerprint): 1. SQL: the U6 migration, which withdraws the rounds of draft versions in `verifying`, `open`, `approved` (contract - `V1-2_ANATOMICAL_SHEETS.md:945-949` says « every round »; the approved round linked to each published version - stays approved, T4) and adds the core gate, the rules epoch, the publication check and, if confirmed, the save - check (T4). No verdict code is added, so no + §6.4, worded at U0: rounds of draft versions; the approved round linked to each published version stays + approved, T4) and adds the core gate, the rules epoch, the publication check and the save check (T4, contract + §12.2). No verdict code is added, so no change to `sheet_verdict_codes`. 2. Worker image, built from the same commit as the app (`.gitea/workflows/release-images.yml:103-120`). 3. Application. @@ -143,7 +144,7 @@ and creates no new-model sheet until it reads that epoch, so an application depl v2. SQL first is mandatory: only the orders that start with SQL fail closed (an old worker's passed verdicts refused by the gate, the publication check refusing a draft outside the fixed model). Worker before SQL leaves rounds already `approved` on old verdicts publishable until the U6 migration lands; that is why SQL goes first. U6 runs on the sandbox only until the owner decides -otherwise. Before U6 reaches any environment beyond the throwaway sandbox: the read-only count of path geometries (T16) and, for production, +otherwise. Before the new model is activated on an environment, and before U6 or U8 reaches any environment beyond the throwaway sandbox: the read-only count of path geometries (T16) and, for production, the 0.1.0 reader check below. Rollback: @@ -170,7 +171,7 @@ Tests in `V1-2-6_UX_TESTS.md` U6. |---|---| | Fingerprints | equine `12d78872…` and alias `27c7383c…` recomputed equal; every seed review digest equal to its pre-U6 pin; `sheet_fingerprint.rs`, `r5_6_switch.rs`, `characterisation_serde_tolerance.rs` green unchanged; a New-present document hashed twice gives one value | | Rust | both keys round-trip; absent keys not written; explicit `null`, unknown role and out-of-range opacity refused; positional-array and one-key-map shapes handled as decided at U6; `validate.rs` issue lists equal before and after on every fixture; rules and refusals of T4 | -| SQL | U6 migration: draft rounds withdrawn with the reason, published versions' rounds still approved, core gate refusing an older `verified_with`, rules epoch exposed, publication and approval refused outside the fixed model, save non-regression if confirmed; `up upgrade` from the current migration set; `types --check`; publication refused without a current passed U6 verdict | +| SQL | U6 migration: draft rounds withdrawn with the reason, published versions' rounds still approved, core gate refusing an older `verified_with`, rules epoch exposed, publication and approval refused outside the fixed model, save refused when it duplicates, renames away or loses a role; `up upgrade` from the current migration set; `types --check`; publication refused without a current passed U6 verdict | | PDF | `lean_document` and the export gate strip both keys; PDF goldens and R4 digests unchanged; a New-present sheet's PDF exported and reopened (archive kept) | | Worker | image rebuilt from `HEAD`; `verify-e2e` with a New-absent draft (fails on the fixed-category rule), the same draft once converted, which then carries roles (passes), and a sheet created by the U6 `sheet.empty` (passes) | | N-1 reader | New-present fixture and harness: PDFs pass `n-1.reader.test.ts:178-196`; `contracts.types.test.ts` green; frozen copies unchanged in the diff | diff --git a/docs/development/V1-2-6_UX_DECISIONS.md b/docs/development/V1-2-6_UX_DECISIONS.md index d79b07fa..78f894c7 100644 --- a/docs/development/V1-2-6_UX_DECISIONS.md +++ b/docs/development/V1-2-6_UX_DECISIONS.md @@ -1,30 +1,32 @@ # V1-2.6 UX redesign: technical decisions -Status: OWNER ANSWERS RECORDED, 2026-11-05 (brief « FAUNOSTEO — V1-2.6 UX — Ratification des décisions -techniques »). Companion of `V1-2-6_UX_PLAN.md`; this is the single table of what blocks what. The 11 UX choices and -the direct SVG interactions validated by the owner on 2026-11-05 are not reopened. Nothing here authorises code: U0 -(docs) and every later sub-step start only on a new explicit authorisation. +Status: OWNER ANSWERS RECORDED, 2026-11-05: brief « FAUNOSTEO — V1-2.6 UX — Ratification des décisions +techniques » (BDR-100), then brief « V1-2.6 UX — Autorisation U0 uniquement » (BDR-101; T4 checks, T5 defaults, T10 +option B, T15, T16 count, « Remplacer par un polygone »). Companion of `V1-2-6_UX_PLAN.md`; this is the single +table of what blocks what; the contract records the same decisions in `V1-2_ANATOMICAL_SHEETS.md` §17.12. The 11 UX +choices and the 16 boards are approved for good and not reopened. Nothing here authorises code: U0 (documents only) +was authorised on 2026-11-05; every later sub-step starts only on a new explicit authorisation. ## Owner decisions | Id | Question | Owner answer (2026-11-05) | State | Blocks | |---|---|---|---|---| -| T1 | Fallback if the wasm budget is exceeded | not asked this round; measuring rule recorded (LRN-118) | open, used only if a measure exceeds 600 000 B | U5, U6 if a measure exceeds | +| T1 | Fallback if the wasm budget is exceeded | not asked; conditions kept (brief U0); measuring rule recorded (LRN-118) | open, used only if a measure exceeds 600 000 B | U5, U6 if a measure exceeds | | T2 | Optional category keys; widening of the snapshot reader | agreement in principle, conditional on the proofs | ratified with conditions (§ T2 and T3) | writing the keys (U6 write lock) | | T3 | Opacity semantics | integer percent from 10 to 100 | ratified with T2's conditions | U6 | -| T4 | Fixed-category checks | no residual gap; checks in the core and at the server boundaries of save and publication; nothing written before they are live | ratified; design below; the two declared SQL checks (save non-regression, publication) to confirm | U6 | -| T5 | Equine history; categories of a new sheet | historical preservation mandatory; roles on a working copy only; conversion tested without mutating the originals | ratified for the history; new-sheet ids, EN names and colours still to ratify | U6 (defaults), V1-2.8 | -| T6 | Equine working copy conversion | not asked | open, decided at V1-2.8 under T4 and T5 | V1-2.8 | +| T4 | Fixed-category checks | no residual gap; checks in the core and at the server boundaries of save and publication; nothing written before they are live; brief U0: both declared SQL checks approved (save, approval and publication), O22 amended strictly for these invariants | ratified; design below; O22 amended at U0 (contract §12.2) | none left to decide; U6 builds them | +| T5 | Equine history; categories of a new sheet | historical preservation mandatory; roles on a working copy only; conversion tested without mutating the originals; brief U0: ids `cat-bone`, `cat-joint`, `cat-vertebra`, French names kept, EN names and colours from the existing data | ratified | none left to decide; V1-2.8 (T6) | +| T6 | Equine working copy conversion | not asked; conditions and deadline kept (brief U0) | open, decided at V1-2.8 under T4 and T5 | V1-2.8 | | T9 | Replacing a crop view's drawing | explicit choice: keep positions, reposition, cancel; no approximate automatic transformation | ratified; design below | U5 | -| T10 | Automatic access to a detail view | system navigation type distinct from the visible taxonomy; schema checked first; never Os, Articulations or Vertèbres | principle ratified; internal category to confirm | automatic access (moved to U6) | +| T10 | Automatic access to a detail view | system navigation type distinct from the visible taxonomy; schema checked first; never Os, Articulations or Vertèbres; brief U0: option B (`cat-access`, role `navigation`, not visible as an anatomical category, automatic access at U6) | ratified | automatic access waits for U6 | | T11 | Fate of the level-1 owner trial | approved: old-UX trials stopped; anomalies and untested items tracked; level 1 not declared validated | ratified | none | -| T12 | Common text | principle of one versioned copy kept; legal text, source and validation to be supplied | principle ratified; text missing | U7 | +| T12 | Common text | principle of one versioned copy kept; legal text, source and validation to be supplied; brief U0: U7 stays blocked until they are validated | principle ratified; text missing | U7 | | T14 | Multi-tab notice | not asked | open, follow-up | none | -| T15 | Header « Annuler » wording | not asked | open | U1 (accessible name and tooltip) | -| T16 | Curve handle editing | deferral only if the audit confirms it; exact geometry; no destructive conversion; identified future lot | ratified: deferred to the curves lot | none in V1-2.6; the database count before U6 or U8 reaches any environment beyond the throwaway sandbox | -| T17 | Vertebral regions entry without a vertebra role | not asked | open | U6 | +| T15 | « Annuler » wording | brief U0: « Annuler la dernière modification » for the history; « Abandonner » or « Abandonner les modifications » for a form | ratified | none left to decide; U1 applies it | +| T16 | Curve handle editing | deferral only if the audit confirms it; exact geometry; no destructive conversion; identified future lot; brief U0: deferral kept, existing geometries checked before any activation of the new model, no DEV access during U0; « Remplacer par un polygone » explicit, validated, old path kept until success, undoable | ratified: deferred to the curves lot | none in V1-2.6; the path count before the new model is activated on an environment and before U6 or U8 reaches any environment beyond the throwaway sandbox | +| T17 | Vertebral regions entry without a vertebra role | not asked; wording presented at the U0 checkpoint, no answer invented | open | U6 (not U0) | -## Implementer decisions (recorded at U0, no owner question) +## Implementer decisions (recorded at U0 in contract §17.12, no owner question) | Id | Decision | Reason | |---|---|---| @@ -90,8 +92,8 @@ the direct SVG interactions validated by the owner on 2026-11-05 are not reopene invisible while the 4 px rules assume it visible. Detail triggers keep 0.06; the selected state keeps its accent at 0.85 (`apps/app/src/styles/index.css:14`). Written first in `docs/ANNOTATION-RENDERING.md`. The layer writes it as `fill-opacity`, which the PDF highlight overwrites: no PDF effect. -- Doctrine: `.claude/rules/sheet-model.md` amended at U0 (an optional key omitted when absent is not a version - change, with this proof list). Route B (schema v3, excluded by contract §12.3, `V1-2_ANATOMICAL_SHEETS.md:1779-1781`) +- Doctrine: `.claude/rules/sheet-model.md` and `schemas.md` amended at U0 (an optional key omitted when absent is + not a version change, with this proof list). Route B (schema v3, excluded by contract §12.3, BLK-008 paragraph) and route C (reserved ids without opacity, contradicts choice 5) stay excluded. ## T4 · Fixed-category checks (ratified: no residual gap) @@ -100,27 +102,33 @@ the direct SVG interactions validated by the owner on 2026-11-05 are not reopene server boundaries for save and publication; the new model is not written before the necessary checks are live; a progressive rollout or a functional lock is used if needed. The earlier recommendation (issues relative to the base, residual first-version gap accepted) is withdrawn. +- Owner answer, brief U0 (BDR-101): both declared SQL checks approved. At save: protect the uniqueness of the fixed + categories, their roles and their presence without blocking the old drafts that carry none of these keys. At + approval and publication: guarantee the model's invariants whatever the worker does. O22 is amended strictly for + these invariants (contract §12.2, §17.12); the rest of the core's validation is not duplicated in SQL. Both checks + are planned at U6 and not built. - Property guaranteed: no review round opens and no version is published on a draft whose categories break the fixed model, whoever wrote the draft (the editor, a direct `save_sheet_draft`, « Garder ma version », a tab running an older bundle). Fixed model: each role `bone`, `joint`, `vertebra` carried by exactly one category, - and that category carries its fixed FR and EN names (T5). + and that category carries its fixed FR and EN names (T5); the role `navigation` (T10) carried by at most one + category, with its fixed names. | Tier | Check | Where | New code | |---|---|---|---| | Core, verdict | absolute rule on the draft, no base needed: missing role, duplicate role, wrong name on a role-bearing category; error issues of their own code family `category.fixed.*`, mapped to the existing `verification.validation.rules` | `sheet_report` on the draft (`verdict.rs:188`), mapping `verdict.rs:277-296` | Rust; no verdict code, no `validate.rs` error | -| Core, editor | giving a role writes the fixed FR and EN names in the same update; renaming a role-bearing category is allowed only to its fixed names; removing it, changing or clearing its role and a duplicate role are refused; `navigation` (T10 B) is never assignable by an edit; repair commands insert a missing fixed category, restore the fixed names and clear a duplicate role, so every state a direct save can write is repairable | `edit.rs` | Rust | -| Server, save | non-regression check (recommended): a save that removes or duplicates a role present in the stored draft, or renames its category away from the fixed names, is refused; drafts without roles (pre-U6, equine working copy) still save | U6 migration, `save_sheet_draft`, a second declared SQL check under O22 | SQL, pgTAP; owner confirmation | +| Core, editor | giving a role writes the fixed FR and EN names in the same update; renaming a role-bearing category is allowed only to its fixed names; removing it, changing or clearing its role and a duplicate role are refused; `navigation` (T10 B) is never given to, changed on or cleared from a category by an edit: the only way it enters a document is the insertion of the canonical `cat-access` (its id, fixed names, role, no colour) inside the core-built automatic-access batch, accepted only while no navigation category exists; repair commands insert a missing fixed category, restore the fixed names and clear a duplicate role, so every state a direct save can write is repairable | `edit.rs` | Rust | +| Server, save | declared check (approved, brief U0): refused when a role is carried by two categories, when a category carrying a role does not carry that role's fixed names, or when a role of the stored draft is lost; a document without roles saves when the stored draft has none (pre-U6 drafts, equine working copy); every state a save can reach stays repairable | U6 migration, `save_sheet_draft`, a second declared SQL check under O22 (contract §12.2) | SQL, pgTAP | | Server, verification | the worker computes the verdict with the core above; a round opens only on a passed verdict | `complete_sheet_verification` (`20261101100000_sheet_verification_jobs.sql:300-345`) | none | | Server, core gate | a passed verdict computed by a core older than the U6 core is refused at completion, so an old worker (rollback, stale image, second instance) never opens a round | U6 migration, keyed on `verified_with` | SQL, pgTAP | -| Server, publication | a declared SQL check `private.sheet_fixed_categories_ok(content)` (each role once, fixed names) at approval and at publication, beside the existing status checks, so a worker defect cannot publish a draft outside the fixed model (the reason O22 keeps declared SQL checks, contract `V1-2_ANATOMICAL_SHEETS.md:1705-1711`, `20261028110000:146-149`); the existing preconditions stay (`verdict.missing`, `verdict.stale`, `:984-990`; approved round on the current revision, `:1028-1072`) | U6 migration, `decide_sheet_review`, `publish_sheet_version` | SQL, pgTAP; O22 amended at U0 | -| Server, rounds in flight | rounds in `verifying`, `open`, `approved` of draft versions withdrawn with the reason; the approved round linked to each published version stays approved | U6 migration (contract `V1-2_ANATOMICAL_SHEETS.md:945-949`) | SQL, pgTAP | +| Server, publication | a declared SQL check `private.sheet_fixed_categories_ok(content)` (name provisional: each of `bone`, `joint`, `vertebra` once, `navigation` at most once, fixed names) at approval and at publication, beside the existing status checks, so a worker defect cannot publish a draft outside the fixed model (the reason O22 keeps declared SQL checks, contract §12.2, `20261028110000:146-149`); the existing preconditions stay (`verdict.missing`, `verdict.stale`, `:984-990`; approved round on the current revision, `:1028-1072`) | U6 migration, `decide_sheet_review`, `publish_sheet_version` | SQL, pgTAP; O22 amended at U0 | +| Server, rounds in flight | rounds in `verifying`, `open`, `approved` of draft versions withdrawn with the reason; the approved round linked to each published version stays approved | U6 migration (contract §6.4, worded at U0) | SQL, pgTAP | - Save boundary: the earlier text left save fully permissive and cited BDR-043; the governing rule is O22 (contract - `V1-2_ANATOMICAL_SHEETS.md:1683-1711`), which allows a declared SQL check. An absolute check at save would lock the - equine working copy and every pre-U6 draft; the non-regression check above locks none of them and stops stripping - by a direct save, « Garder ma version » or an older tab at the source. Recommended; owner confirmation requested - for both declared SQL checks: the contract says today « No other rule is mirrored » - (`V1-2_ANATOMICAL_SHEETS.md:1711`), so O22 is amended at U0 only on that confirmation. + §12.2), which allows a declared SQL check. A check requiring the three fixed categories at save would lock the + equine working copy and every pre-U6 draft; the approved check requires nothing of a document without roles and + stops stripping, duplicating or renaming by a direct save, « Garder ma version » or an older tab at the source. + The owner approved both declared SQL checks (brief U0); O22 is amended in contract §12.2 (two table rows and the + bullet that replaces « No other rule is mirrored »), and the contract §6.2 and §6.7 cite them. - Core gate detail: every core so far reports `faunosteo-core 0.1.0` (`verdict.rs:164-166`, workspace version `Cargo.toml:10`), so the gate needs a marker that tells the U6 core apart: a core version bump (owner's call) or a rules epoch added to `verified_with` (free text of at most 100 characters for SQL today). Chosen at U6, pinned by @@ -151,12 +159,20 @@ the direct SVG interactions validated by the owner on 2026-11-05 are not reopene - Test: a conversion of an in-memory copy of the seed draft document (roles on the T6 categories) asserts before and after that the seed bytes, the fingerprint, the alias and every review digest are unchanged, and that the copy differs only in the converted categories (`V1-2-6_UX_TESTS.md` U6). -- New-sheet defaults, still to ratify (blocks U6): ids `cat-bone`, `cat-joint`, `cat-vertebra`, chosen by the core +- New-sheet defaults, ratified (brief U0, BDR-101): ids `cat-bone`, `cat-joint`, `cat-vertebra`, chosen by the core (suffixes of 4 to 8 characters, so never a page id `cat-<10 chars a-z2-7>`, `apps/app/src/editor/ids.ts:1-21`); - names FR « Os », « Articulations », « Vertèbres » (validated on board 07, `docs/design/v1-2-6/ARBITRAGES.md:60`), - EN « Bones », « Joints », « Vertebrae » (proposal); default colours `#a41e65`, `#ff9500`, `#e100ff`, copied from the - equine categories (copying mutates nothing) and shown as « Couleur d'origine » (board 07 A). Names stay stored, so - old readers show them. + French names « Os », « Articulations », « Vertèbres » (validated on board 07, `docs/design/v1-2-6/ARBITRAGES.md:60`). + English names and reference colours, documented from the existing data: + + | Id | FR | EN | Colour | Source | + |---|---|---|---|---| + | `cat-bone` | Os | Bones | `#a41e65` | equine category `os`: « Os » / « Bones », `#a41e65` (`supabase/seed/anatomical-sheets/equine/draft/document.json:425-430`) | + | `cat-joint` | Articulations | Joints | `#ff9500` | equine category `articulations`: « Articulations » / « Joints », `#ff9500` (`document.json:417-422`) | + | `cat-vertebra` | Vertèbres | Vertebrae | `#e100ff` | colour of the equine category `zone-colonne` (« Segments vertébraux » / « Vertebral segments », `document.json:441-446`), the one T6 proposes for the vertebra role; no existing category is named « Vertèbres », and EN « Vertebrae » is the existing dictionary pair of the editor tab (`apps/app/src/i18n/fr.ts:1230` « Vertèbres », `en.ts:1199` « Vertebrae ») | + + The colours come from the curated draft, which is the historical sheet's document; the legacy import holds none + (`legacy-import/document.json`, every category colour `null`). Copying a value mutates nothing. The colours are shown as + « Couleur d'origine » (board 07 A). Names stay stored, so old readers show them. ## T6 · Equine working copy conversion (V1-2.8) @@ -200,7 +216,7 @@ the direct SVG interactions validated by the owner on 2026-11-05 are not reopene neither keep nor reposition, only « Annuler »: stricter than today's attach, which accepts it (stated in U5). - Labels: the owner's French words above; EN « Keep positions », « Reposition annotations », « Cancel » proposed. -## T10 · Automatic access to a detail view (principle ratified) +## T10 · Automatic access to a detail view (ratified: option B) - Owner answer: prefer a system navigation type distinct from the visible anatomical taxonomy; check the existing schema constraints before choosing an internal id or category; never categorise this access arbitrarily as Os, @@ -227,8 +243,14 @@ the direct SVG interactions validated by the owner on 2026-11-05 are not reopene category (the role is stripped from snapshots, T7). The editor lists it in no category panel and no picker; only detail triggers use it (an edit refusal and a verdict issue for an observable annotation in it, and for a second category with that role). -- Recommendation: (B). It needs the owner's confirmation: a fourth role value and an internal category go beyond - the T2 approval, and its names are visible to old readers. +- Owner answer, brief U0 (BDR-101): option B validated: internal category `cat-access`, role `navigation`, not + visible as an anatomical category, automatic access conditional on U6. Its names and colour are those written in + option B above. Creation path (implementer, to keep the editor rule of T4 whole): `navigation` is never given to, + changed on or cleared from a category by an edit; the canonical `cat-access` enters a document only inside the + core-built automatic-access batch, accepted while no navigation category exists. Limit kept in view: old readers + and N-1 show it as an ordinary category (its names are visible there). +- Open point for U6 (not decided at U0, owner question if it is visible): the category of an access placed by hand + from the view's menu after U6, when the overlap list is not empty. Until U6 the editor chooses it explicitly. - Effect on the plan: automatic access moves from U5 to U6 (it needs the role). U5 keeps the name proposal and the overlap list. Until U6, « Ajouter un accès » (U4) asks the editor for the category as level 1 does: an explicit choice by the editor, never an automatic one. Existing triggers keep their category (the equine « Tête » access @@ -271,7 +293,8 @@ the direct SVG interactions validated by the owner on 2026-11-05 are not reopene - U7 is blocked until the owner supplies the FR and EN text, its source, and who validated it and when. The commit that adds the text cites that record. Until then no such wording is written in the application, the dictionaries or the docs; U7's tests use a fixture text marked as a test value, kept under `tests/`, never shipped. -- Contract §7.4 amended at U0 to state this, without any normative wording. +- Contract §7.4 amended at U0 to state this, without any normative wording (brief U0: U7 stays blocked until the + source and the legal content are validated). ## T14 · Multi-tab notice (open) @@ -280,10 +303,23 @@ the direct SVG interactions validated by the owner on 2026-11-05 are not reopene - Recommendation: out of V1-2.6, tracked as a follow-up. If kept later: heartbeat-based (a crashed tab never says goodbye), wording consistent with « Garder ma version ». -## T15 · « Annuler » wording (open, needed by U1) +## T15 · « Annuler » wording (ratified) -- Recommendation: keep the validated label; give the header button the accessible name and tooltip « Annuler la - dernière modification » / « Undo the last change ». +- Owner answer, brief U0 (BDR-101): distinguish the commands. « Annuler la dernière modification » for the history; + « Abandonner » or « Abandonner les modifications » for a form. +- Applied at U1 and later: + - history command: the header button keeps the drawn icon and short label of the approved boards; its accessible + name and tooltip are « Annuler la dernière modification » (EN « Undo the last change », proposed); the toast + after a gesture undoes the same entry under the same name; + - leaving a staged form without applying it (board 02 pending point, board 07 states, board 08 rectangle, board 09 + regions): « Abandonner »; + - returning the draft to its last saved revision (level-1 C11, today `editor.draft.discard` « Annuler les + modifications », `apps/app/src/i18n/fr.ts:1238`): « Abandonner les modifications »; its confirmation already + uses those words (`fr.ts:1240`); + - the trace strip of board 04 already reads « Abandonner ». +- Not covered by the answer and unchanged: « Annuler » on dialogs that close without any effect (confirmations, + the cleaning dialog, the T9 dialog's third action, which the owner named « Annuler »). Any change there is an owner + question, not an implementer choice. ## T16 · Curve handle editing (ratified: deferred to the curves lot) @@ -296,14 +332,18 @@ the direct SVG interactions validated by the owner on 2026-11-05 are not reopene sheet and its working copy derive from them. - Journeys that write geometry: creation makes points and polygons only (`apps/app/src/editor/annotations/creation.ts:90-97`); the editable geometries are circle and polygon (`geometryEdit.ts:9`, `34`); package import, zones from the - drawing's shapes and curve drawing are level 2 (contract §8.3, `V1-2_ANATOMICAL_SHEETS.md:1328-1338`). + drawing's shapes and curve drawing are level 2 (contract §8.3). - Journeys that meet a path: display by the core layer; the attach repair returns a path unchanged and keeps the attach refused, document unchanged byte for byte (`repair.ts:55-69`, blocked ids `95-100`, C45, `editor-geometry.spec.ts:317`); « Remplacer par un polygone » (`PropertiesPanel.tsx:138`, contract §8.3). - Not inspected: the database contents of DEV and of the sandbox (docs-only brief, no query run). A path there can - only come from a direct RPC save or a test fixture. Before U6 or U8 reaches any environment beyond the throwaway sandbox, a - read-only count of path geometries in its drafts and published versions is run, by the owner or under an explicit authorisation; a - non-zero count reopens T16. + only come from a direct RPC save or a test fixture. Before the new model is activated on an environment (its U6 + write lock lifted there), and before U6 or U8 reaches any environment beyond the throwaway sandbox, a read-only + count of path geometries in its drafts and published versions is recorded; on the throwaway sandbox U6 runs it + itself, on DEV and any shared environment the owner runs it or authorises it explicitly, never during U0 (brief + U0); a non-zero count reopens T16. + - Re-checked at U0 (2026-11-05, `a505b24`): same counts (seed draft 22 circles, 6 polygons, 0 paths; legacy import + 21, 6, 0); `pnpm r5:import-equine --check` clean (0 differences). - Conclusion: the condition holds for every tracked document and every product journey; the deferral is adopted. - Guarantee until the curves lot: - a stored path keeps its `d` text byte for byte; no TypeScript parses it (C45); no operation moves, scales, @@ -312,13 +352,34 @@ the direct SVG interactions validated by the owner on 2026-11-05 are not reopene remap (`remap.path`), the U2 handle layer and zone move (a path gets no handle and no move); - « Remplacer par un polygone » is the one way a path leaves a document: the editor draws a new polygon by hand, one undo entry, published versions untouched. It replaces the curve by the editor's choice; nothing converts - it. It stays as ratified in contract §8.3 unless the owner removes it. + it. Owner, brief U0 (BDR-101): kept only as an explicit replacement, validated, the old path kept until success, + undo and redo supported, no automatic destructive conversion (contract §8.3 as amended). Level 1 already holds + it: the trace closes into one `update` committed under the geometry accept, a refusal drops the trace and leaves + the annotation unchanged (`apps/app/src/editor/annotations/usePlacement.ts:39-63`, `annotationCommit.ts:55-72`, + `93-104`); tests cover the replacement and the refusal (`apps/app/tests/unit/editor-annotations-tab.test.tsx:692-714`, + `845-866`). Not yet tested: undo and redo restoring the exact `d`, and Escape during the trace; added at U2 + (`V1-2-6_UX_TESTS.md` U2, « Paths » row). - Future lot « Courbes » (ex-U9): specification in `V1-2-6_UX_PLAN.md` §2 D, tests in `V1-2-6_UX_TESTS.md` (« Curves lot »), with the path point-correction proposal. Recorded in TODO.md with its dependency rule: no feature that lets a path enter a document (package import, zones from the drawing's shapes, a curve drawing tool) ships before or without it. It needs a size lever (T1) and a round-withdrawal migration. -## T17 · Vertebral regions entry without a vertebra role (open, needed by U6) +## Points from the boards for U1 and later (found at U0, not decided) + +The validated boards show these; level 1 or its contract says otherwise. Each involves a visible choice or another +step's scope, so it is an open owner question, asked when the sub-step that builds it is planned; until then the +level-1 text stays as written (precedence rule of the level-1 contract header). None blocks U0. + +| Point | Boards | Level 1 or contract | Sub-step | +|---|---|---|---| +| « Prévisualiser » in the editor header | 01 to 05, 07 to 11, 13 | deferred to V1-2.7 (level-1 CLARIFICATIONS; contract §16.8) | U1 planning: owner question (V1-2.7 is not open) | +| Withdrawing a submission from the Vérification tab | 12 C notice | withdrawal deferred to V1-2.7 (same) | U1 planning: owner question | +| Recovery buttons « Restaurer » / « Ignorer » | 12 D | C27: « Restaurer la copie » / « Ignorer la copie » | U1 label review | +| Properties at creation of points and zones: names and laterality asked before the element exists, no preselected laterality | 02, 04 (laterality and other properties set after creation) | level-1 plan choice 2 (C25), `apps/app/src/editor/annotations/creation.ts:48-56`, `109`; the core requires a laterality (`crates/core/src/domain/sheet/schema.rs:424`, `450`), so the boards' flow implies a default | U2 planning: owner question (detail-view names are not open: choice 6, proposed name, U5) | +| Region code read-only after creation | 09 (not legible) | C5: read-only after creation | U6 planning | +| Category of an access placed by hand after U6 when annotations overlap | 08 | T10 section above | U6 planning | + +## T17 · Vertebral regions entry without a vertebra role (open, blocks U6, not U0) - Facts: board 09 opens the regions from the Vertèbres category; the equine working copy has no role before V1-2.8. - Recommendation: when no category carries the vertebra role, the Annotations panel keeps a « Régions diff --git a/docs/development/V1-2-6_UX_PLAN.md b/docs/development/V1-2-6_UX_PLAN.md index 77859735..480eaae4 100644 --- a/docs/development/V1-2-6_UX_PLAN.md +++ b/docs/development/V1-2-6_UX_PLAN.md @@ -1,9 +1,11 @@ # V1-2.6 UX redesign: technical implementation plan Status: PROPOSAL for the owner, 2026-11-05, revised the same day with the owner's answers to T2/T3, T4, T5, T9/T10, -T11, T12 and T16 (brief « V1-2.6 UX — Ratification des décisions techniques », recorded in -`V1-2-6_UX_DECISIONS.md`). Nothing in this file authorises code. No application, Rust, SQL or worker change is made -before the owner authorises U0 and then each sub-step explicitly. Branch `feature/v1-2-anatomical-sheets`, worktree +T11, T12 and T16 (brief « V1-2.6 UX — Ratification des décisions techniques », BDR-100), then with the brief +« V1-2.6 UX — Autorisation U0 uniquement » (BDR-101: T4 SQL checks, T5 defaults, T10 option B, T15, T16 count, +« Remplacer par un polygone »), recorded in `V1-2-6_UX_DECISIONS.md` and contract §17.12. Nothing in this file +authorises code. U0 (documents only) was authorised on 2026-11-05; no application, Rust, SQL or worker change is +made before the owner authorises each later sub-step explicitly. Branch `feature/v1-2-anatomical-sheets`, worktree `/home/bchanot/Documents/faunosteo-v1-2`, audited at `f58cf23`. Companion files: @@ -118,7 +120,7 @@ study). Facts that govern it: - Doctrine conflict, settled by the owner under T2 (route A, ratified with conditions): `.claude/rules/schemas.md:9-11` says additive optional fields keep the contract; `.claude/rules/sheet-model.md` says a document schema change bumps `SHEET_DOCUMENT_SCHEMA_VERSION`, with no bump during V1-2 (BLK-008); BDR-068 says `v1` freezes the construction and the validation. Route B (schema v3) - is excluded by the contract during V1-2 (`docs/development/V1-2_ANATOMICAL_SHEETS.md:1779-1781`) and would need a + is excluded by the contract during V1-2 (`docs/development/V1-2_ANATOMICAL_SHEETS.md` §12.3, BLK-008 paragraph) and would need a data migration (BLK-008) plus a change to `save_sheet_draft`, which never updates `document_schema_version` (`supabase/migrations/20261028110000_sheet_review_workflow.sql:621-623` against the CHECK of `20261008110000_anatomical_sheets.sql:120-121`). @@ -170,8 +172,8 @@ Node `gzipSync(bytes, { level: 9 })` on the `pkg` build, re-measured on 2026-11- never run). The sandbox reuses `faunosteo_worker:dev` without checking it matches the checkout (`scripts/db-sandbox.sh:335-347`): every model step rebuilds it explicitly. - The only SQL the redesign needs is the U6 migration (decision T4): the round withdrawal the contract requires - when the integrity rules change (`V1-2_ANATOMICAL_SHEETS.md:945-949`), the core gate, the rules epoch, the - declared publication check and, if confirmed, the save non-regression check. The curves lot will need its own + when the integrity rules change (contract §6.4, worded at U0: rounds of draft versions), the core gate, the + rules epoch, the declared publication check and the declared save check (both approved, contract §12.2). The curves lot will need its own withdrawal (path reader). References are in the document; own drawings use the existing upload path, capped at 4 drawings per sheet, 2 MiB each, 6 MiB in all (`core/domain/archive/snapshot.rs:21-28`). @@ -203,7 +205,7 @@ Node `gzipSync(bytes, { level: 9 })` on the `pkg` build, re-measured on 2026-11- ### A. Non-destructive migration for fixed categories and opacity -- Route A, ratified in principle with conditions (T2, T3): `role` (`bone` | `joint` | `vertebra`) and +- Route A, ratified in principle with conditions (T2, T3): `role` (`bone` | `joint` | `vertebra` | `navigation`, the last under T10 option B) and `fill_opacity` (integer percent 10 to 100) on `AnnotationCategory`, both `Option` + `#[serde(default)]` + `js::present` (an explicit `null` refused, one canonical form) + `skip_serializing_if = "Option::is_none"` + `ts(optional)`, the `LocalizedOptionalText` pattern; never serialised as `null`; an absent key never defaulted in @@ -214,21 +216,23 @@ Node `gzipSync(bytes, { level: 9 })` on the `pkg` build, re-measured on 2026-11- review digest, R4 app-path digests, `V1-2-6_UX_TESTS.md` U6); a document carrying a key cannot be read by any earlier application, worker or core, so the first such write is a point of no return (COMPATIBILITY §0, §7). - New sheets: `sheet.empty` creates the three fixed categories with roles, core-chosen ids (precedent `view-main`, - `core/domain/sheet/create.rs:9`, `28`), fixed names and default colours (T5; ids, EN names and colours still to - ratify). + `core/domain/sheet/create.rs:9`, `28`), fixed names and default colours (T5, ratified: `cat-bone`, `cat-joint`, + `cat-vertebra`, values and sources in DECISIONS T5). - Fixed-category checks, no residual gap (T4), never as a `validate.rs` error (that would strip fingerprints and reject old snapshots): - core, verdict tier: `sheet_report` on the draft gives error issues for a missing role, a duplicate role or a wrong name on a role-bearing category, with no base needed, so a first version is judged like any other; they map to the existing `verification.validation.rules` (`verdict.rs:277-296`), no new verdict code; - core, editor tier: `edit.rs` refuses removing a role-bearing category, changing or clearing its role, a duplicate - role, a rename away from the fixed names and any `navigation` assignment; giving a role writes the fixed names + role, a rename away from the fixed names and any edit giving, changing or clearing `navigation` (`cat-access` + enters only in the core-built access batch, T10); giving a role writes the fixed names in the same update; repair commands insert a missing fixed category, restore the fixed names and clear a duplicate role (DECISIONS T4); - server: the U6 migration withdraws the rounds of draft versions in flight, adds a core gate at `complete_sheet_verification` that refuses a passed verdict from a pre-U6 core, and adds a declared SQL check - of the fixed model at approval and publication (O22 amended at U0); recommended, to confirm: a non-regression - check at `save_sheet_draft` (no role removed, duplicated or renamed away; role-less drafts still save). + of the fixed model at approval and publication and a declared check at `save_sheet_draft` (a role carried + twice, renamed away or lost refused; role-less drafts still save); both approved, O22 amended at U0 (contract + §12.2), not built. - Functional write lock instead of an expand-then-write split: the U6 migration exposes a rules epoch and the application writes no key and creates no new-model sheet before it reads it; SQL first is mandatory, the only order that fails closed (COMPATIBILITY §7). U6 runs on the sandbox only until the owner decides otherwise. @@ -270,12 +274,13 @@ Validated guarantee already held: a curve is never converted or simplified. Path editor never reshapes them (level-1 C45) and offers « Remplacer par un polygone ». No document of the project holds a path (the seed has 22 circles, 6 polygons, 0 paths), and no product path can create one: creation makes points and polygons only (`creation.ts:93-97`), package import and zones from the drawing's shapes stay deferred -(`V1-2_ANATOMICAL_SHEETS.md:1330-1338`). Board 05 labels its curve card « exemple d'une autre fiche ». +(`V1-2_ANATOMICAL_SHEETS.md` §8.3). Board 05 labels its curve card « exemple d'une autre fiche ». Handle editing of curves (anchors, controls, translation) is deferred out of V1-2.6 to the curves lot (ex-U9, decision T16). The owner made the deferral conditional on an audit: it confirms that no tracked document holds a path and no product journey needs one changed; the database contents of DEV and the sandbox were not queried, so a -read-only count runs before U6 or U8 reaches any environment beyond the throwaway sandbox (DECISIONS T16). Until the curves lot, a stored path keeps its +read-only count runs before the new model is activated on an environment and before U6 or U8 reaches any +environment beyond the throwaway sandbox (DECISIONS T16). Until the curves lot, a stored path keeps its `d` text byte for byte, no operation converts it, and every operation that would change it is refused with the document unchanged; « Remplacer par un polygone » (contract §8.3) stays the one, explicit, undoable way a path leaves a document. The curves lot precedes any feature that lets a path enter a document. Its specification is kept @@ -339,11 +344,11 @@ so it can start without a new study: - Name proposal (page, display formatting from the core's list): FR and EN names of the `inside` annotations, in document order, joined by the locale's list format, the first three then « … »; none inside → « Vue détaillée n » / « Detail view n », n = number of detail views + 1. Both fields stay editable. -- Access category (T10, principle ratified): a navigation access is never put in Os, Articulations or Vertèbres by +- Access category (T10, option B ratified): a navigation access is never put in Os, Articulations or Vertèbres by the system. The navigation type exists (`detail_trigger`, `schema.rs:439-462`) but requires an existing category (`schema.rs:449`, `validate.rs:287-292`), and snapshots carry triggers to N-1 (`snapshot_rules.rs:141-165`). - Recommended, pending the owner's confirmation: one internal category `cat-access`, role `navigation`, created by - the core, absent from every visible panel and picker (DECISIONS T10 option B). + Ratified (option B, brief U0, BDR-101): one internal category `cat-access`, role `navigation`, created by the + core inside the automatic-access batch, absent from every visible panel and picker (DECISIONS T10). - Access: automatic creation needs that role, so it lands in U6, not U5. Then the view, its access (the drawn rectangle as its polygon in the parent view) and, if missing, the navigation category are inserted in one batch, only when the overlap list is empty. Otherwise the box is unchecked with the reason stated, and the access is @@ -357,8 +362,8 @@ so it can start without a new study: - Page operations, each one `sheet.edit update` of the whole annotation: vertex drag (preview on move, commit on pointer-up), « + » inserts the segment midpoint after the segment's start vertex, « − » removes the chosen vertex, zone drag translates every point, redraw replaces the points after the new trace is accepted. -- Protections before the core: « − » not offered at 3 vertices; no non-finite value committed; a vertex released on - its neighbour is a no-op; above a handle cap (implementation constant, recorded at U0) the shape shows its outline +- Protections before the core: « − » disabled at 3 vertices with « Une zone garde au moins 3 sommets » (board 12 B); no non-finite value committed; a vertex released on + its neighbour is a no-op; above a handle cap (T18: rule recorded at U0, contract §17.12; value fixed at U2 from the equine maximum, 17 vertices, with a margin) the shape shows its outline and a message instead of one handle per vertex. The core judges the end state on commit (`invalid_shape` below 3 points; `out_of_frame`, `too_small`, `interior_too_small` through `issues.ts:123-175`). A refusal restores the previous shape. @@ -390,10 +395,9 @@ seed untouched, axe, keyboard and touch journeys, sandbox and worker runs. ### I. Decisions that block before any code Each sub-step lists the decisions it consumes; the single table is in `V1-2-6_UX_DECISIONS.md` and the blocking -criteria in `V1-2-6_UX_RISKS.md`. Answered 2026-11-05: T2/T3 (with conditions), T4, T5 (history), T9, T10 -(principle), T11, T12 (principle), T16. Still open: before U1, T15; before U5, T1 only if a measure exceeds the -budget; before U6, the two T4 SQL checks, the T5 new-sheet defaults, T10 option B, T17; before U7, the T12 text; -at V1-2.8, T6. +criteria in `V1-2-6_UX_RISKS.md`. Answered 2026-11-05: T2/T3 (with conditions), T4 (with both SQL checks), T5 +(history and new-sheet defaults), T9, T10 (option B), T11, T12 (principle), T15, T16. Still open: before U5 or U6, +T1 only if a measure exceeds the budget; before U6, T17; before U7, the T12 text; at V1-2.8, T6; T14 a follow-up. --- @@ -425,17 +429,23 @@ Common rules for every sub-step that touches code: ### U0 · Contract, decisions and amendments (docs only) +- State: authorised 2026-11-05 (brief « Autorisation U0 uniquement »), contract + `.claude/tasks/contracts/2026-11-05-v1-2-6-ux-u0.md`. - Objective: record the owner's answers to `V1-2-6_UX_DECISIONS.md` and amend the ratified texts the validated UX replaces. -- Files: `docs/development/V1-2_ANATOMICAL_SHEETS.md` §7.4 (common text), §8.2 (no coordinate fields, fixed +- Files: `docs/development/V1-2_ANATOMICAL_SHEETS.md` §6.2 (save check, local copy key), §6.4 (withdrawal of draft + rounds), §6.7 (fixed-category row), §7.4 (new-sheet categories, common text), §8.2 (no coordinate fields, fixed categories, colour shown when set, access created with the view), §8.3 (vertex drag and the crop rectangle leave - level 2; curves per T16), §8.4 (O14 A kept, tablet rule), §16.7 (new state); the level-1 contract - `.claude/tasks/contracts/2026-11-03-v1-2-6-editor-1509.md` (C3, C4, C6, C7, C8, C13 wording to match the code key, - C32, C33, C40); `docs/design/README.md` (v1-2-6 boards replace V1-2.4 boards 04 and 05 for the editor, BDR-096); + level 2; curves per T16), §8.4 (O14 A kept, tablet rule), §12.2 and the §17.1 row (O22 amended for the two SQL + checks), §16.7 (new state), §16.12 (deferred lots), §17.12 (the decisions); the level-1 contract + `.claude/tasks/contracts/2026-11-03-v1-2-6-editor-1509.md` (C3, C4, C5, C6, C7, C8, C11 per T15, C13 wording to match + the code key, C16, C18, C20, C25, C28, C32, C33, C40, and a precedence rule in its header); `docs/design/README.md` (v1-2-6 + boards replace V1-2.4 boards 04 and 05 for editing, board 05's read-only mode kept, BDR-096); `.claude/rules/sheet-model.md` (optional keys under T2; rules may also live in `edit.rs` and `sheet_report`) and `schemas.md`; the implementer decisions (T7, T8, handle cap, branch policy); `.claude/memory/decisions.md` via `memory.sh`. §7.4 records T12 without any normative wording; §8.3 records the curves lot (T16). -- Dependencies: owner answers (recorded 2026-11-05, BDR-100) and the owner's authorisation to start U0. +- Dependencies: owner answers (recorded 2026-11-05, BDR-100, BDR-101) and the owner's authorisation to start U0 + (given 2026-11-05). - Rust ops: none. Tests: a fresh verifier checks the amendments against the answers. - Acceptance: each decision recorded once and cited where it applies; no contradiction left between the contract, the level-1 criteria and the boards. @@ -454,7 +464,8 @@ Common rules for every sub-step that touches code: `ToolColumn.tsx`, i18n; `scripts/db-sandbox.sh` (image check, demo sheet), `crates/worker/Dockerfile` (commit label). - Dependencies: U0, T11 (ratified: level-1 trial stopped, level 1 not declared validated, residuals tracked), T15 - (header undo accessible name). + (ratified: header undo named « Annuler la dernière modification », C11 relabelled « Abandonner les + modifications »). - Rust ops: none. - Tests: `V1-2-6_UX_TESTS.md` U1. - Acceptance: four tabs at 1 024 px and wider; every existing editor journey green on the new shell; narrow-width @@ -538,7 +549,7 @@ Common rules for every sub-step that touches code: - Acceptance: board 08 with explicit placement; the replacement dialog on every replacement, « Conserver les positions », « Repositionner les annotations » and « Annuler » each proven on fixtures, a different aspect ratio refused, « Annuler » sending no request; one undo entry per remap; size within budget or T1 applied. -- Owner demo: board 08 on the demo sheet; attach the seed head drawing to a crop (keep offered); attach a re-based +- Owner demo: board 08 on the demo sheet; attach the seed head drawing to a crop whose rectangle equals its `viewBox` `60 100 500 380` (keep offered); attach a re-based fixture drawing (reposition offered); cancel a replacement. - Risk: size; bounds over-report. Rollback: revert (documents written are plain v2). - Checkpoint: owner. @@ -547,11 +558,12 @@ Common rules for every sub-step that touches code: - Objective: route A (§2 A) under the owner's conditions (T2, T3); `sheet.empty` creates the three categories; the T4 checks (absolute verdict rule, edit refusals with the repair path, the U6 migration with round withdrawal, - core gate, publication check, rules epoch and the save check if confirmed) live before any key is written (write + core gate, publication check, rules epoch and the save check) live before any key is written (write lock); the layer applies `fill_opacity`; snapshot and export gate strip both keys; the snapshot reader widened only as bounded in §2 C; the panel locks the fixed categories (no delete, name read-only, role badge, « Couleur d'origine » from T5) and gains the opacity slider and field; - automatic access with the navigation category if T10 option B is confirmed; board 09: regions open from the + automatic access with the navigation category `cat-access` (T10 option B, ratified), built on the U5 overlap + list and created only when it is empty; board 09: regions open from the vertebra-role category, the region picker of a zone filtered to the vertebra-role category's annotations (page filter, no rule), staged « Appliquer » with the error count; fallback per T17 when no category has the role (the equine copy before V1-2.8). `docs/ANNOTATION-RENDERING.md` amended first. @@ -560,10 +572,11 @@ Common rules for every sub-step that touches code: `domain/archive/snapshot_rules.rs:141-165`, `pdf/write/input.rs:174-181`, `export.rs:27-37`, types; app `refusal.ts`, the category panel, the repair action, the regions dialog (`components/editor/vertebrae/*`), `DetailViewForm.tsx` (automatic access), i18n; SQL `supabase/migrations/_sheet_rounds_withdraw_v1_2_6.sql` - (name provisional: round withdrawal, core gate, rules epoch, publication check, save check if confirmed); docs `ANNOTATION-RENDERING.md`, `ANATOMICAL_SHEET_MODEL.md` + (name provisional: round withdrawal, core gate, rules epoch, publication check, save check); docs `ANNOTATION-RENDERING.md`, `ANATOMICAL_SHEET_MODEL.md` (spec table), `RUST.md`, `DEPLOY.md` (order, write lock). -- Dependencies: U3, U5; T2 and T3 (ratified with conditions), T4 (ratified; the save and publication SQL checks to confirm), T5 (history - ratified; new-sheet defaults to ratify), T10 option B (to confirm, automatic access only), T17. +- Dependencies: U3, U5 (U5 brings `annotations_in_rect`, the overlap list the automatic access needs, after U4's + rectangle); T2 and T3 (ratified with conditions), T4 (ratified with both SQL checks), T5 (ratified), T10 option B + (ratified), T17 (open: blocks U6). - Rust ops: schema fields, edit refusal kinds, verdict-tier issues, layer reading, snapshot stripping, verdict marker. - Tests: `V1-2-6_UX_TESTS.md` U6; each row of `V1-2-6_UX_COMPATIBILITY.md` is an acceptance line, and §8 lists the @@ -573,7 +586,7 @@ Common rules for every sub-step that touches code: passes); the contract §16.7 journey on a non-equine sheet with the new UX reaches `open` after the worker verdict; a role-stripped draft never reaches a round. - Owner demo: new species sheet with its three categories, custom opacity, regions from Vertèbres, automatic access, - PDF exported and reopened; a role-stripped direct save refused at save (if confirmed) or at verification. + PDF exported and reopened; a role-stripped direct save refused at save. - Deploy order, write lock and rollback: `V1-2-6_UX_COMPATIBILITY.md` §7. Returning to the old application is impossible once a document with the keys exists (point of no return; sandbox only until the owner decides otherwise). @@ -590,7 +603,7 @@ Common rules for every sub-step that touches code: change note records the template id and version. - Rust ops: none (one `update` of the sheet texts). - Tests: `V1-2-6_UX_TESTS.md` U7. -- Acceptance: board 10; contract §7.4 as amended at U0. +- Acceptance: board 10; contract §7.4 as amended at U0 (no normative wording until the owner's text exists). - Owner demo: insert, edit, compare. Rollback: revert. - Checkpoint: owner and the person responsible for the wording. @@ -598,7 +611,8 @@ Common rules for every sub-step that touches code: - Objective: recovery and conflict journeys re-run on the new UX; the contract §16.7 acceptance on the sandbox; the level-1 residuals tracked under T11 re-checked one by one (level 1 still not declared validated as a whole); - the T16 path count recorded for any environment beyond the sandbox; documents and TODO closed; + the T16 path count recorded before the new model is activated on an environment and before U6 or U8 reaches + any environment beyond the sandbox; documents and TODO closed; `V1-2-6_OWNER_TRIAL.md` updated. - Dependencies: U1 to U6 (U7 when its text exists; curves in their own lot, T16). - Tests: `V1-2-6_UX_TESTS.md` U8. @@ -633,7 +647,7 @@ Common rules for every sub-step that touches code: | U2 | yes | one read-only value | no | no | no | | U3, U4 | yes | no | no | no | no | | U5 | yes | two queries | no | no | no (the worker calls neither) | -| U6 | yes | yes | optional keys | round withdrawal, core gate, rules epoch, publication check, save check if confirmed (T4) | rebuilt, deployed before the app | +| U6 | yes | yes | optional keys | round withdrawal, core gate, rules epoch, publication check, save check (T4) | rebuilt, deployed before the app | | U7 | yes | no | no | no | no | | U8 | no | no | no | no | rebuilt for the final run | | Curves lot (out of V1-2.6) | yes | path ops | no | round withdrawal | rebuilt, deployed before the app | @@ -657,7 +671,7 @@ robustness CONCERNS(9), simplicity CONCERNS(6); no BLOCKER. Integrated: - The U7a/U7b expand-then-write split did not hold (`sheet.empty` writes the keys from the first new sheet) and protected no environment: one model sub-step (U6) with the rollback limit stated. - M9 dropped: report issues map to the existing `verification.validation.rules` (`verdict.rs:277-296`); the - round-withdrawal migration of contract `945-949` added to U6 and U9, with a frozen pre-U9 reader oracle. + round-withdrawal migration of contract §6.4 added to U6 and U9, with a frozen pre-U9 reader oracle. - Sub-branches dropped (the gitflow lib branches only from develop): commit in place, rollback by revert. - Curves: no document holds a path; U9 proposed for deferral (T16); the size lever becomes a fallback measured op by op (T1), the PDF split a separate track. @@ -683,6 +697,9 @@ the owner decides under T4. No second review was run on the corrected version. ## 7. Owner answers recorded (2026-11-05) +Dated record; the items still open here (T4 SQL checks, T5 defaults, T10 option B) and the T16 count wording were +answered or refined by the U0 brief and are superseded by §9 and DECISIONS. + Brief « FAUNOSTEO — V1-2.6 UX — Ratification des décisions techniques ». The UX choices are not reopened. Changes to this plan and its companions: @@ -715,4 +732,15 @@ rows; the save non-regression variant offered under O22. A fresh verifier on the older T4 scope, BDR-100 superseded on T4 and T9), fixed, then a targeted re-check (ECARTS(2): one U6 test and the deploy-order line still assumed a permissive save and an all-rounds withdrawal), fixed. A third, independent check before the commit (2026-11-05): ECARTS(2) on K10 and K11 (the R-3 mitigation and the U6 objective still on the older T4 scope, the write-lock test assuming a stripping save succeeds, two forms of the T16 count scope), fixed, -then a fresh targeted re-check (result in TODO.md). +then a fresh targeted re-check: CONFORME 12/12, committed at `bd444d6` and `a505b24`. + +## 9. Owner answers of the U0 brief (2026-11-05) + +Brief « FAUNOSTEO — V1-2.6 UX — Autorisation U0 uniquement » (BDR-101), then « Finalisation de U0 uniquement »: +U0 authorised alone; the 16 boards and 11 choices approved for good. Recorded in `V1-2-6_UX_DECISIONS.md` and +contract §17.12: both T4 SQL checks approved (save; approval and publication), O22 amended strictly for these +invariants (contract §12.2); T5 new-sheet ids, names and colours from the existing data; T10 option B; T15 wording; +T16 deferral kept with the path count before any activation of the new model and before U6 or U8 reaches any +environment beyond the throwaway sandbox; « Remplacer par un polygone » as an +explicit, validated, undoable replacement; T12 and T17 open (U7 and U6), T1 and T6 unchanged. U0 amended the V1-2 +contract, the level-1 contract, `docs/design/README.md` and the rules `sheet-model.md` and `schemas.md`. diff --git a/docs/development/V1-2-6_UX_RISKS.md b/docs/development/V1-2-6_UX_RISKS.md index a35091ee..6fdcc055 100644 --- a/docs/development/V1-2-6_UX_RISKS.md +++ b/docs/development/V1-2-6_UX_RISKS.md @@ -1,6 +1,7 @@ # V1-2.6 UX redesign: risk register -Status: PROPOSAL, 2026-11-05, revised after the independent review and after the owner's answers of 2026-11-05. +Status: PROPOSAL, 2026-11-05, revised after the independent review and after the owner's answers of 2026-11-05 +(BDR-100, then BDR-101 with the brief « Autorisation U0 uniquement »). Companion of `V1-2-6_UX_PLAN.md`. Decisions live in `V1-2-6_UX_DECISIONS.md` (single table); sub-step dependencies in the plan (§3, each sub-step's « Dependencies »); deploy order, write lock and rollback in `V1-2-6_UX_COMPATIBILITY.md` §7. Probability and impact: H high, M medium, L low. @@ -9,7 +10,7 @@ in the plan (§3, each sub-step's « Dependencies »); deploy order, write lock |---|---|---|---|---|---| | R-1 | New category keys written as `null` when absent: every fingerprint, review digest, equine sheet-ref, alias and R4 app-path digest changes | H without a pin | H | `skip_serializing_if` + `js::present`; tests pin fingerprint `12d78872…`, alias `27c7383c…`, seed digests (T2) | U6 | | R-2 | An unconditional `validate.rs` rule on roles strips fingerprints of existing documents and rejects old PDF snapshots | H if done | H | rules only in `edit.rs` and `sheet_report` (T4) | U6 review | -| R-3 | Direct save, « Garder ma version » or an older bundle strips the roles of a sheet before its first publication | M | H | closed (T4): absolute verdict rule on the draft, no base needed; core gate at verification completion; declared publication check `private.sheet_fixed_categories_ok` at approval and publication; save non-regression check if confirmed | U6 | +| R-3 | Direct save, « Garder ma version » or an older bundle strips the roles of a sheet before its first publication | M | H | closed (T4): absolute verdict rule on the draft, no base needed; core gate at verification completion; declared publication check `private.sheet_fixed_categories_ok` at approval and publication; declared save check (both approved, contract §12.2, built at U6) | U6 | | R-4 | Worker older than the app reads a New-present draft: definitive `integrity.document` | H on skew | M | one commit for both images; worker before app; `verify-e2e` refuses a stale image | U1 guard, U6 | | R-5 | Rounds in flight across a rule or reader change keep a verdict of the old core | M | M | round-withdrawal migration in U6 (T4) and the curves lot, tested with `up upgrade` and live rounds | U6 | | R-6 | A caller-built snapshot or `export_from_envelope` carries the keys: N-1 and older apps drop the snapshot | M | M | strip at both points (T7); N-1 test on a New-present fixture | U6 | @@ -41,10 +42,10 @@ in the plan (§3, each sub-step's « Dependencies »); deploy order, write lock | R-32 | An old worker (rollback, stale image, second instance) passes a draft without the fixed categories | M | H | core gate at completion refuses a passed verdict from a pre-U6 core (T4); `verified_with` needs a U6 marker since every core reports `0.1.0` | U6 | | R-33 | The release replay judges published versions with the fixed-category rule and flags the historical equine version | M | M | the rule is a submission rule on drafts; the replay checks reading, fingerprint, validation, drawings (COMPATIBILITY §5) | release track | | R-34 | The equine working copy and every pre-U6 draft fail verification under the absolute rule | certain | L | intended (T4); repair action in the editor; working copy converted at V1-2.8 (T6) | U6, V1-2.8 | -| R-35 | The navigation category (T10 B) shows up in the anatomical taxonomy or is used by a point or zone | M | M | absent from panels and pickers; edit refusal and verdict issue for an observable annotation in it; old readers see an ordinary category | U6 | +| R-35 | The navigation category (T10 B) shows up in the anatomical taxonomy or is used by a point or zone | M | M | absent from panels and pickers; `navigation` never given, changed or cleared by an edit, `cat-access` inserted only in the core-built access batch; edit refusal and verdict issue for an observable annotation in it; old readers see an ordinary category | U6 | | R-36 | Invented or unapproved normative text ships with U7 | L | H | U7 blocked until the owner's text, source and validation record; test fixtures only under `tests/`; review gate (T12) | U7 | | R-37 | A future feature lets a path into a document before the curves lot exists | M | H | dependency recorded in TODO.md (T16); path guarantee tests stay in the suites | future lots | -| R-38 | A path already sits in a database (direct RPC save or test fixture) that U6 or U8 reaches | L | M | read-only count before U6 or U8 reaches any environment beyond the throwaway sandbox; non-zero reopens T16 | U8, deploy | +| R-38 | A path already sits in a database (direct RPC save or test fixture) that U6 or U8 reaches | L | M | read-only count before the new model is activated on an environment and before U6 or U8 reaches any environment beyond the throwaway sandbox; non-zero reopens T16 | U8, deploy | | R-39 | The halted level-1 trial leaves defects unseen; level 1 read as validated | M | M | level 1 not declared validated (T11); residuals tracked in TODO.md; untouched criteria re-tested at U1 and U8 | U1, U8 | ## Blocking criteria @@ -53,17 +54,13 @@ Each line holds until its condition is met; nothing in this list authorises a su | Criterion | Holds | Condition to lift | |---|---|---| -| U0 and every sub-step | all code and contract amendments | a new explicit owner authorisation (brief 2026-11-05) | -| T15 answered | U1 (header undo accessible name and tooltip) | owner answer | +| U1 and every later sub-step | all code | a new explicit owner authorisation each (U0, documents only, authorised 2026-11-05) | | T2/T3 proofs (COMPATIBILITY §8) | writing a key outside a test | every proof green and reviewed | -| T4 checks live on the environment | the U6 write lock | U6 migration (withdrawal, core gate, publication check, rules epoch) first, then the U6 worker | -| T4 SQL checks confirmed | U6 | owner confirms the declared publication check and the recommended save non-regression check (O22 amended at U0) | -| T5 new-sheet defaults | U6 (`sheet.empty`) | owner ratifies ids, EN names, default colours | -| T10 option B | automatic access (U6) | owner confirms the internal category (id, names, role `navigation`) | +| T4 checks live on the environment | the U6 write lock | U6 migration (withdrawal, core gate, publication check, save check, rules epoch) first, then the U6 worker | | T17 answered | U6 (regions entry) | owner answer | | T1 | U5 or U6 only if a measure exceeds 600 000 B | owner decision on the measured figure | | T12 text | U7 | owner supplies the FR and EN text, its source and its validation record | -| T16 database count | U6 or U8 on any environment beyond the throwaway sandbox | read-only count of paths is zero | +| T16 database count | activating the new model on an environment; U6 or U8 on any environment beyond the throwaway sandbox | read-only count of paths recorded and zero (non-zero reopens T16) | | 0.1.0 reader check and release replay | any production release carrying U6 | R-30 read and recorded; replay green | ## Dependencies outside the plan diff --git a/docs/development/V1-2-6_UX_TESTS.md b/docs/development/V1-2-6_UX_TESTS.md index 87e3f8d9..a765fa0b 100644 --- a/docs/development/V1-2-6_UX_TESTS.md +++ b/docs/development/V1-2-6_UX_TESTS.md @@ -34,13 +34,14 @@ every path's `d` text byte for byte through the sub-step's journeys, save and re | Kind | Test | |---|---| -| Review | fresh verifier: each owner answer of 2026-11-05 recorded once and cited where it applies; no contradiction between contract §7.4, §8.2-8.4, §16.7, the level-1 criteria (C3, C4, C6, C7, C8, C13, C32, C33, C40) and the boards; no normative common text written (T12) | +| Review | fresh verifier on the U0 contract (`.claude/tasks/contracts/2026-11-05-v1-2-6-ux-u0.md`): each owner answer of 2026-11-05 recorded once (DECISIONS, contract §17.12, BDR-100, BDR-101) and cited where it applies; no contradiction between contract §6.2, §6.4, §6.7, §7.4, §8.2-8.4, §12.2 (O22 amended), §16.7, §16.12, the level-1 criteria (C3, C4, C5, C6, C7, C8, C11, C13, C16, C18, C20, C25, C28, C32, C33, C40, with the precedence rule of its header), the rules files and the boards; the two SQL checks described at save and at approval and publication and stated as not built; no normative common text written (T12); every cross-reference resolves | +| Preconditions | `pnpm r5:import-equine --check` clean; seed geometry counts (T16) re-run; wasm figure by the gate's call (LRN-118); `git diff --stat` empty under `crates/`, `apps/`, `packages/`, `supabase/`, `scripts/` | ## U1 · Shell | Kind | Tests | |---|---| -| Unit | four-tab model, initial tab, width tiers (replaces `editor-route.test.tsx:66`, `128-170`, `editor-mode.test.ts:99-110`); header undo and redo states; undo from each tab reverts the last commit made on another tab; a typed field is flushed before the header undo (behaviour pinned); header undo accessible name and tooltip as decided under T15; references panel open, close, return focus; « Aller à » target for every issue kind (`verification.ts:64-131`) | +| Unit | four-tab model, initial tab, width tiers (replaces `editor-route.test.tsx:66`, `128-170`, `editor-mode.test.ts:99-110`); header undo and redo states; undo from each tab reverts the last commit made on another tab; a typed field is flushed before the header undo (behaviour pinned); header undo accessible name and tooltip « Annuler la dernière modification » (T15); « Abandonner les modifications » for the return to the saved revision (C11 as amended); references panel open, close, return focus; « Aller à » target for every issue kind (`verification.ts:64-131`) | | E2E shell | helpers rewritten (`e2e/support/editor.ts:326-330`, `warm-up.ts:43-45`, `editor-access.spec.ts:34-42`); every existing editor journey green on the new shell; sidebar hidden in the editor at 1 024, 1 180, 1 279 px, shown at 1 280 px, menu reachable in one tap; narrow-width read-only unchanged | | Tooling | `verify-e2e` refuses an image whose commit label differs from `HEAD`; the trial command provisions the demo sheet through the application upload path | | Accessibility | axe on the four tabs and on the open references panel; Tab order header → tabs → panel → canvas | @@ -50,13 +51,13 @@ every path's `d` text byte for byte through the sub-step's journeys, save and re | Kind | Tests | |---|---| -| Unit (tables) | slider stops = distinct radii of the view; snapping; red mark from the core value; midpoint insert after the segment start; « − » hidden at 3 vertices; zone translation; nearest-handle priority; keyboard map (arrows, Shift ×10, Insert or Backspace or Delete, Enter, Escape, roving focus); arrows pan only when the box is focused; handle cap fallback | +| Unit (tables) | slider stops = distinct radii of the view; snapping; red mark from the core value; midpoint insert after the segment start; « − » disabled at 3 vertices with its reason (board 12 B); zone translation; nearest-handle priority; keyboard map (arrows, Shift ×10, Insert or Backspace or Delete, Enter, Escape, roving focus); arrows pan only when the box is focused; handle cap fallback | | Unit (state) | pending preview cancelled and restored on undo, redo, document replacement, tab change, second pointer; toast dismissed on any commit, undo or redo; slider commits once on release (history depth after a keyboard walk) | | Core | the per-view minimum visible radius equals the `marker_too_small` threshold on the equine views and on edge frames | -| E2E mouse | drag a vertex, « + », « − », zone drag on a selected zone, redraw accepted, redraw refused by `interior_too_small` restores the old shape, undo and redo of each, toast « Annuler » undoes the same entry as the header | +| E2E mouse | drag a vertex, « + », « − », zone drag on a selected zone, redraw accepted, redraw refused by `interior_too_small` restores the old shape, undo and redo of each, toast « Annuler » undoes the same entry as the header; header button and toast action carry the accessible name « Annuler la dernière modification » (T15) | | E2E touch (`hasTouch`, 1 024, 1 180, 1 280 px) | one-finger handle drag; explicit « Déplacer la zone » mode; finger 1 on a vertex handle then finger 2 elsewhere: the pinch zooms, the drag is cancelled, no commit (CDP `Input.dispatchTouchEvent` with two points); page scroll over the canvas with a selection and outside it | | Keyboard | create a zone, add and remove a vertex, move the zone, validate, without a pointer; Ctrl+Z on a focused handle after arrow moves restores the pre-move shape | -| Paths (T16) | a path annotation gets no handle, no « + » or « − », no zone move in either mode, no keyboard move; its `d` is byte-identical after every gesture on its neighbours, a save and a reload; « Remplacer par un polygone » stays the only change, one undo entry restoring the exact `d` | +| Paths (T16) | a path annotation gets no handle, no « + » or « − », no zone move in either mode, no keyboard move; its `d` is byte-identical after every gesture on its neighbours, a save and a reload; « Remplacer par un polygone » stays the only change: explicit, validated by the core, the path kept while tracing, on Escape and on a refusal; one undo entry restoring the exact `d`, redo restoring the polygon (owner, BDR-101) | | Accessibility | axe on selection, tracing and move states; handle names (« sommet 3 de Thoraciques »); live-region message after a move | | Performance | commit latency under the 500 ms budget (`editor-equine.spec.ts:25-34`) for drag, insert, remove | @@ -103,15 +104,15 @@ every path's `d` text byte for byte through the sub-step's journeys, save and re | Rust snapshot (T2, T7) | `lean_document` and the export gate strip both keys; controlled widening: the snapshot reader accepts exactly the two keys with their types and range, and gives `Schema` (report kept) for any other unknown key, `null`, unknown role, out-of-range opacity | | Equine history (T5) | conversion of an in-memory copy of the seed draft (roles on the T6 categories): seed bytes, fingerprint, alias and every review digest equal before and after; the copy differs only in the converted categories; `pnpm r5:import-equine --check` clean | | App and N-1 | New-present sheet fixture and harness: exported PDFs pass the assertions of `n-1.reader.test.ts:178-196`; `contracts.types.test.ts` green with `ts(optional)`; `measure.test.ts` green; PDF goldens unchanged | -| SQL | the U6 migration: pgTAP with rounds of draft versions in `verifying`, `open`, `approved` before it and withdrawn after with the reason; core gate: a passed verdict with an older `verified_with` refused, the U6 marker accepted; `save_sheet_draft` accepts a draft without roles; if the owner confirms the non-regression check, it refuses a save that removes or duplicates a role of the stored draft or renames its category away from the fixed names; `private.sheet_fixed_categories_ok` refuses approval and publication outside the fixed model; the rules epoch RPC answers; draft rounds withdrawn while the approved round of each published version stays approved; approval and publication refused without a current passed verdict; `pnpm db:sandbox up upgrade` from the current migration set; `types --check` | +| SQL | the U6 migration: pgTAP with rounds of draft versions in `verifying`, `open`, `approved` before it and withdrawn after with the reason; core gate: a passed verdict with an older `verified_with` refused, the U6 marker accepted; `save_sheet_draft` accepts a draft without roles over a stored draft without roles; the approved declared check refuses a save where a role is carried by two categories, a role-bearing category lacks its fixed FR or EN name, or a role of the stored draft is lost, and accepts each repair save; `private.sheet_fixed_categories_ok` refuses approval and publication outside the fixed model; the rules epoch RPC answers; draft rounds withdrawn while the approved round of each published version stays approved; approval and publication refused without a current passed verdict; `pnpm db:sandbox up upgrade` from the current migration set; `types --check` | | Worker | image rebuilt from `HEAD`; `verify-e2e` with a New-absent draft (fails on `verification.validation.rules`), the same draft repaired, which then carries roles (passes), and a sheet created by the U6 `sheet.empty` (passes) | -| Write lock (T4) | on a sandbox with the old worker image and the U6 SQL: a role-less draft's round (or, without the confirmed save check, a role-stripped one) never opens (gate); the U6 app on a stack without the rules epoch writes no key and creates no new-model sheet; publication and approval refused outside the fixed model even with a forged passed verdict (pgTAP) | +| Write lock (T4) | on a sandbox with the old worker image and the U6 SQL: a role-less draft's round never opens (gate); a save stripping the roles of a role-bearing draft refused (save check); the U6 app on a stack without the rules epoch writes no key and creates no new-model sheet; publication and approval refused outside the fixed model even with a forged passed verdict (pgTAP) | | Flipped suites | `sheet_verdict.rs:39-52`, `80-90`, `sheet-verification.sandbox.ts:27`, `209-211`, `373`, worker fixtures and `tests/verify_loop.rs` moved to converted in-memory copies, each change mapped in the commit message; seed unchanged | -| Navigation access (T10, if B is confirmed) | `cat-access` with role `navigation` created on demand in the same batch as the view and its access, only when the overlap list is empty; absent from the category panel and the pickers; an observable annotation in it and a second navigation category refused (edit) and reported (verdict); its role stripped from snapshots, N-1 reads the category | +| Navigation access (T10 option B, ratified) | `cat-access` with role `navigation` created on demand in the same core-built batch as the view and its access, only when the overlap list is empty; an edit that gives, changes or clears `navigation` refused; a second `cat-access` insertion refused; absent from the category panel and the pickers; an observable annotation in it and a second navigation category refused (edit) and reported (verdict); its role stripped from snapshots, N-1 reads the category | | Unit and E2E app | board 07 locks (no delete, name read-only, role badge, « Couleur d'origine »); opacity slider and field synchronised, commit on release; board 09: regions from the vertebra-role category, picker filtered, staged « Appliquer (n erreurs) »; fallback entry when no category has the role (T17); board 08 automatic access | -| Acceptance journey | a new non-equine sheet with the new UX (drawing, rectangle view, automatic access, points, zones, findings, custom opacity), saved, submitted, worker verdict passes, round `open`; its PDF exported, reopened by the app and read by N-1 (archive kept); the same journey with the roles stripped by a direct save: refused at save if the owner confirms the non-regression check, otherwise saved with verdict failing and no round; in both branches no publication | -| Recovery | a copy taken before an opacity edit restored after reload; conflict journey on a role-bearing category; « Garder ma version » with a role-less document: on a sheet whose stored draft carries roles, the save is refused under the confirmed non-regression check (otherwise saved, report issue and repair shown); on a role-less sheet it saves and shows the issue and the repair | -| Security | fresh review: no path writes the keys into an envelope; the SQL checks are exactly those declared under T4 and O22 as amended at U0 (publication check, save non-regression if confirmed); the core gate checks a version marker only | +| Acceptance journey | a new non-equine sheet with the new UX (drawing, rectangle view, automatic access, points, zones, findings, custom opacity), saved, submitted, worker verdict passes, round `open`; its PDF exported, reopened by the app and read by N-1 (archive kept); the same journey with the roles stripped by a direct save: refused at save, the stored draft unchanged; a draft that never carried roles saves, its verdict fails and no round opens; no publication in either case | +| Recovery | a copy taken before an opacity edit restored after reload; conflict journey on a role-bearing category; « Garder ma version » with a role-less document: on a sheet whose stored draft carries roles, the save is refused by the declared check; on a role-less sheet it saves and shows the issue and the repair | +| Security | fresh review: no path writes the keys into an envelope; the SQL checks are exactly those declared under T4 and O22 as amended at U0 (contract §12.2: the save check and the approval and publication check, fixed-category invariants only); the core gate checks a version marker only | | Accessibility | axe on board 07 and 09 states; the opacity value is exposed to assistive technology | ## U7 · Common text @@ -132,7 +133,7 @@ Starts only with the owner's text, its source and its validation record (T12). | Full run | common gates, `check:all`, sandbox order, `verify-e2e`, N-1 suite, frozen references unchanged, axe on every tab and state, keyboard-only journey, tablet touch journey | | Acceptance | contract §16.7 journey re-run on the redesigned editor | | Level-1 residuals (T11) | each tracked item re-checked and its state recorded (closed, still open, superseded by the redesign); level 1 still not declared validated as a whole | -| Paths (T16) | before U6 or U8 reaches any environment beyond the throwaway sandbox: read-only count of path geometries in its drafts and published versions recorded (owner or explicit authorisation) | +| Paths (T16) | before the new model is activated on an environment and before U6 or U8 reaches any environment beyond the throwaway sandbox: read-only count of path geometries in its drafts and published versions recorded (sandbox by U6 itself; DEV and shared environments by the owner or under an explicit authorisation) | | Owner trial | `V1-2-6_OWNER_TRIAL.md` updated; WebKit iPad and a real tablet by the owner | ## Curves lot (ex-U9, deferred out of V1-2.6, T16) diff --git a/docs/development/V1-2_ANATOMICAL_SHEETS.md b/docs/development/V1-2_ANATOMICAL_SHEETS.md index 20617a92..6201a0ce 100644 --- a/docs/development/V1-2_ANATOMICAL_SHEETS.md +++ b/docs/development/V1-2_ANATOMICAL_SHEETS.md @@ -769,9 +769,10 @@ round (on a draft): before M5, working copy, empty document) gives no base, and every group is to cover (§6.3). - Unsaved changes stay in the page. The leave guard of V1-1 protects them; - a local recovery copy, keyed by version and revision, is kept in the - browser with the report editor's persistence pattern and offered back after - a crash or an expired session, never sent automatically. + a local recovery copy, keyed by account and version with the revision + recorded in the copy (wording matched to the code at V1-2.6 U0, §17.12), is + kept in the browser with the report editor's persistence pattern and offered + back after a crash or an expired session, never sent automatically. - Validation while editing: the page runs the core's checks and shows the validation panel (§8.1). It is advisory; the server verdict decides (§6.4). - Saving is explicit (« Enregistrer »): `save_sheet_draft(version_id, @@ -785,6 +786,11 @@ round (on a draft): the author set, and the audit records `anatomical_sheet_version.saved` with the revision. A draft may hold integrity errors while it is being written; the verdict refuses them at submission. +- From V1-2.6 U6 (owner 2026-11-05, §17.12; not built yet), the save also + applies the declared fixed-category check of §12.2: no role carried by two + categories, a category carrying a role keeps that role's fixed names, no + role of the stored draft lost. A draft that carries no role (every draft + saved before U6, the equine working copy) still saves. - A trigger bumps `revision` on any content write, so no write slips under a round unseen. - The direct UPDATE grants on `content`, `change_note`, `name`, `slug` and @@ -943,9 +949,11 @@ caps; completeness counts (statuses, vet referrals, uncited elements); the groups and their digests; the change list; `verified_with` (core version). Core changes. A release that changes the SVG reader, the integrity rules, the -caps or the fingerprint ships a migration that withdraws every round in -`verifying`, `open` or `approved`, with the reason recorded; editors submit -again and the new worker verifies. The release replay (§15) runs before such a +caps or the fingerprint ships a migration that withdraws every round of a +draft version in `verifying`, `open` or `approved`, with the reason recorded +(the round of a published version stays `approved`, §6.1, and +`withdraw_sheet_review` refuses it with `draft.not_a_draft`; worded at V1-2.6 +U0); editors submit again and the new worker verifies. The release replay (§15) runs before such a release. Availability. Reviews and publications need a running, health-checked @@ -1100,6 +1108,7 @@ Four stages, each a superset of the previous: | Every annotation in frame shows at least 4 CSS px on the smallest preview, the editor at 320 × 568 (main view box 286 × 310, detail view box 254 × 191, `xMidYMid meet`): a point's visible disc (`2 × max(2, r − 12)`), a trigger circle's diameter, a polygon's or a path's smaller side (curves and arcs on their shape). Same views, same frame; the document is never rewritten (owner brief 2026-11-01, RUST.md §12.13) | yes | | | `verification.validation.marker_too_small` (issue `annotation.geometry.too_small`) | | Every polygon or path annotation in frame fills a disc of 4 CSS px on the same preview: under the `nonzero` rule the layer fills with, its stroke left out, a centre inside the fill at least the radius from every edge (closing edges included), curves and arcs cut into chords whose deviation is taken off; arcs modelled as browsers store them (`f32` endpoints, a radius other than zero at least `2⁻²⁰`, the spread of one `f32` ulp added); measured within `interior::MAX_OUTLINE_VERTICES` 4 096 vertices and one budget of `2²⁵` edge distances per sheet, refused past them; refused in doubt (owner brief « fermeture du dernier MEDIUM » 2026-11-01, RUST.md §12.14) | yes | | | `verification.validation.marker_interior_too_small` (issue `annotation.geometry.interior_too_small`) | | Fingerprint computed | yes | | | `verification.integrity.fingerprint` | +| Fixed categories (from V1-2.6 U6, §17.12; not built yet): each of `bone`, `joint`, `vertebra` carried by exactly one category with its fixed FR and EN names, `navigation` by at most one with its fixed names; judged on drafts, never on a published version (the §15 replay filters it) | yes | yes | yes | submission: issues `category.fixed.*` under `verification.validation.rules`; approval and publication: the declared check of §12.2 (closed code fixed at U6) | | Verdict passed, on the current revision | | yes | yes | `verdict.missing`, `verdict.failed`, `verdict.stale` | | No `to_confirm` element (D2) | | yes | yes | `publish.to_confirm.open` | | No `inherited` element, an omitted status counting as `inherited` (O3 B) | | yes | yes | `publish.inherited.present` | @@ -1114,7 +1123,8 @@ Four stages, each a superset of the previous: - The rules of the first six lines come from the stored verdict. SQL checks relations, states, rights, separation, the verdict's structure (§6.4), and - the declared defensive check of statuses on the stored document (§12.2). + the declared defensive checks on the stored document (§12.2): statuses and, + from V1-2.6 U6, the fixed categories. - Shown, never blocking: uncited elements, the two warning codes, the number of vet referral nodes. - Approval never changes the document. @@ -1232,6 +1242,19 @@ uses, and whether a species gets a default sheet, is decided with V1-3. - No template of scientific content is shipped. Vertebral formulas, zones and findings of a new species are entered by the editor from sources cited in the references registry. +- From V1-2.6 U6 (owner 2026-11-05, §17.12) the empty document carries the + three fixed categories `cat-bone` (« Os » / « Bones »), `cat-joint` + (« Articulations » / « Joints ») and `cat-vertebra` (« Vertèbres » / + « Vertebrae »), with their roles and default colours; nothing else is + pre-filled. +- Scope and limits (choice 7, decision T12): the editor may insert a + versioned common text once into the FR and EN scope fields while both are + empty; the fields stay free text afterwards, and no later version of the + common text changes a draft or a published version. No common text exists + yet: its FR and EN wording, its source and its validation record are + supplied by the owner before U7, and nothing is written in their place + meanwhile. It is never presented as veterinary or legal advice approved by + the platform. ### 7.5 Species-specific checks @@ -1325,6 +1348,35 @@ An editor can, from the application only: report, submit, follow the round and its verification, read comments, withdraw. +Amended for the V1-2.6 redesign (owner 2026-11-05, §17.12; built in sub-steps +U1 to U6, each on its own authorisation). The functions above stay; the way +they are reached changes: + +- four tabs, Général, Annotations, Constats and Vérification; views, + drawings, annotation categories and vertebral regions in Annotations; the + references registry in a side panel opened from the header or from a + finding; undo and redo in the header on every tab; +- geometry by direct manipulation on the drawing: a point moved, and sized + with a slider snapped to the sizes of its view, the core's minimum shown; a + polygon's vertices dragged, added with « + » on a segment, removed with + « − »; a zone moved (with the mouse once selected, in an explicit mode by + touch) or redrawn, the old shape kept until the new one is accepted; the + keyboard alternative goes through the handles. No coordinate field remains + in the normal journey; +- a detail view drawn as a rectangle over its parent's drawing, its name + proposed from the annotations inside and editable (U5); its access placed + from the view's menu (U4), or created with the view from U6 when no + annotation overlaps the rectangle, in the internal navigation category + `cat-access`; +- annotation categories: the three fixed categories keep their names and + roles, their colour and fill opacity adjustable (from U6); other categories + stay free; an annotation's own colour is shown only when set, with + « Revenir à la couleur de la catégorie »; a new annotation inherits its + category's colour; +- replacing the drawing of a crop view asks first: keep the positions, + reposition the annotations or cancel, each offered only under the + conditions of decision T9, never an approximate transformation. + ### 8.3 Level 2, deferred Curves (`path` drawn or edited by handles; existing paths are displayed and @@ -1337,6 +1389,17 @@ drawing or on elements, drag and drop in the finding tree, bulk import of findings, species templates, collaborative live editing, package export and import. +Amended 2026-11-05 (§17.12): dragging vertices and drawing a crop rectangle +on the canvas move into V1-2.6 (§8.2 as amended); the size slider snaps to +the sizes already used in the view, other snapping stays deferred. Curves +form the curves lot (decision T16), which precedes package import, zones from +the drawing's own shapes and any curve drawing tool. Until then a stored path +keeps its data byte for byte and is never converted; an operation that would +change it is refused with the document unchanged. « Remplacer par un +polygone » stays its one exit, as an explicit replacement only: the editor +traces the polygon, the core validates it, the old path stays until the +polygon is accepted, and the change is undone and redone as one entry. + ### 8.4 What level 1 does not do, and narrow screens (O14 A) Level 1 never edits the drawing itself, accepts no raster image, draws no @@ -1350,6 +1413,12 @@ per sheet, revision conflicts). | Draft editor, every tab, graphic and structured | full | read-only with a notice naming the 1 024 px minimum | | Admin lists, overview, rights, species, review screen (read, comment, acknowledge, decide), publication confirmation, deprecation, archive | full | usable, tested at 375 px | +Amended 2026-11-05 (§17.12): O14 A is kept. Editing on a phone (boards 14 to +16 of `docs/design/v1-2-6`) is a future lot after V1-2. From 1 024 px the +editor works with the mouse, the keyboard and touch (a tablet in landscape, +handles of at least 44 px); below 1 280 px the application's sidebar is +hidden in the editor, its menu one tap away. + --- ## 9. Drawings (SVG assets) @@ -1701,14 +1770,32 @@ Inventory of the current SQL checks and their fate: | `reference.url.scheme` | `sheet_document_reference_issues` | duplicate of the core's strict parse | removed in M5 | | verdict structure: group keys and drawings match the document (§6.4) | completion RPC (new) | relational | added in M5 and M6 | | statuses: no `to_confirm`, no `inherited`, an absent `review_status` counting as `inherited` (new) | publication and approval | declared defensive check | added in M5 | +| fixed categories at save: no role carried by two categories, a category carrying a role keeps that role's fixed FR and EN names, no role of the stored draft lost; a document without roles saves when the stored draft has none (owner 2026-11-05, §17.12) | `save_sheet_draft` | declared defensive check | planned at V1-2.6 U6, not built | +| fixed model at approval and publication: each of `bone`, `joint`, `vertebra` carried by exactly one category with its fixed FR and EN names, `navigation` by at most one with its fixed names (owner 2026-11-05, §17.12) | `private.sheet_fixed_categories_ok(content)` (name provisional), called by `decide_sheet_review` and `publish_sheet_version` | declared defensive check | planned at V1-2.6 U6, not built | -- The status check is the one remaining mirror, declared as such: a +- The status check is the first declared mirror (the fixed-category checks + below are the others, from V1-2.6 U6): a structural walk over `annotations[*]`, `finding_zones[*].categories[*]` and every `children[*]` below them, refusing an element whose `review_status` is absent, `to_confirm` or `inherited`. It is kept in SQL so that a worker defect can never make unread content official, and it follows the schema's default (`inherited`), which is why the absent case is explicit. A pgTAP - case uses an omitted status. No other rule is mirrored. + case uses an omitted status. Besides it, only the two fixed-category checks + below are mirrored (O22 amended 2026-11-05). +- The fixed-category checks (owner 2026-11-05, §17.12; planned at U6, not + built) are declared mirrors of the category model's invariants only: the + fixed roles, their uniqueness, their presence and their fixed names, read + from `categories[*].role` and `categories[*].name`. At save they stop a + direct save, an older tab or « Garder ma version » from stripping, + duplicating or renaming the fixed categories of a draft; at approval and + publication they keep a worker defect from making a draft outside the model + official. The core keeps the authority and the same rule with its messages + (the verdict issues `category.fixed.*`, the editor's refusals and repairs); + no other part of the core's validation is mirrored (no annotation, view, + finding or reference rule). A draft that carries no role still saves when + the stored draft carries none, so no draft saved before U6 is locked, and every state a save can reach stays + repairable in the editor. Closed codes and pgTAP allowed and denied cases + come with U6. - Transition without an unprotected window: M5 replaces the publication gate by the verdict-based one and drops the mirror functions in the same migration. From M5 until M6 provides the worker RPCs, no verdict can be @@ -2323,7 +2410,9 @@ V1-2.7 on. - Application changes: the draft editor. SQL changes: M8 `sheet_draft_last_save`, a read migration for the conflict dialog (§12.3, owner decision 2026-11-03; was « none »). - Tests: `e2e:shell` A2, A3, A4 with a conflict and a local recovery; - keyboard path through numeric fields; axe; read-only below 1 024 px. + keyboard path through numeric fields (amended 2026-11-05, U0: from V1-2.6 + U2 through the handles, from U4 through the crop rectangle, §8.2 as + amended); axe; read-only below 1 024 px. - Acceptance: a sheet for a species other than the horse, with a drawing exported from a vector tool and cleaned, a detail view, points, zones, links and a finding catalogue, is built from scratch in the UI on the @@ -2350,6 +2439,17 @@ V1-2.7 on. under 61 ms (budget 500 ms). Only measured views are editable (owner 2026-11-04); the AAL2 residual of §13 stays open. DEV untouched; the owner has not tried the editor yet. +- State 2026-11-05: the owner stopped the level-1 trials (decision T11): + level 1 is not declared validated as a whole, its residuals stay tracked in + `.claude/tasks/TODO.md`. The editor is redesigned on the validated boards of + `docs/design/v1-2-6` (§8.2 to §8.4 as amended, §17.12) in sub-steps U0 to + U8 of `docs/development/V1-2-6_UX_PLAN.md`, each started on its own owner + authorisation; U0 (contract and decisions, documents only) was authorised + on 2026-11-05. SQL changes planned for the redesign: one U6 migration (the + round withdrawal of §6.4, a core gate, a rules epoch, the fixed-category + checks of §12.2). The acceptance above is re-run on the redesigned editor at + U6 and U8, with the verification worker on the sandbox, up to a round + `open`. ### 16.8 V1-2.7 Preview, review and publication UI @@ -2454,7 +2554,9 @@ sharing, follows, forks, students; rights scoped by species or sheet; review quorum (O5); e-mail notifications; species deactivation and deletion; Storage object deletion beyond the `object_conflict` runbook; offline cache; professional verification (Step 9); entitlements (Step 11, switch of §5.3); a -synchronous verification service. RR-2 (fingerprint rollback limit, `RUST.md` +synchronous verification service; the curves lot (§8.3 as amended, decision +T16); editing on a phone (§8.4 as amended); a multi-tab notice (decision T14, +a follow-up candidate). RR-2 (fingerprint rollback limit, `RUST.md` §11.22) stays open on the release track: before any release to users, a gate requires it settled, by shipping the switch with the release or the alias registry in any build that can be rolled back to; V1-2 does not resolve it. @@ -2491,7 +2593,7 @@ which would have accepted a browser verdict or deferred MFA, are rejected. | O19 | A: cleaning before upload with preview and confirmation, refusal of active and external content, server check kept, no silent change of a stored drawing | §9.2 | | O20 | Deferred to the release track; RR-2 open; gate before any release to users | §16.12 | | O21 | Catalogue access as an explicit, provisional, fail-closed right until the entitlements of Step 11; layers distinguished; reader row predicate; tests per actor | §5.1, §5.3 | -| O22 | Rust core the only authority on document rules; SQL keeps access, relations, states, revisions, locks, atomicity and the verdict's identity; the business mirror is removed in M5 without an unprotected window; one declared status check kept | §12.2 | +| O22 | Rust core the only authority on document rules; SQL keeps access, relations, states, revisions, locks, atomicity and the verdict's identity; the business mirror is removed in M5 without an unprotected window; one declared status check kept; amended 2026-11-05: two declared fixed-category checks, at save and at approval and publication (§17.12) | §12.2 | | O23 | Fail-closed verification: explicit states and outcomes, closed codes per category, idempotent retries under a limit, withdrawal always possible, audit, no partial publication | §6.5 | ### 17.2 Arbitration AR-1: MFA on platform role changes (ratified, option B) @@ -2674,6 +2776,112 @@ wordings ratified in V1-2.4 are kept. reviewed in `IDENTITY.md` §4.2; no safe, rehearsed recovery exists yet, which is a production prerequisite (§13). No MFA bypass, no `aal2` weakening, no new path that resets a factor. +### 17.12 V1-2.6 UX redesign decisions (owner, 2026-11-05) + +Three owner briefs of 2026-11-05: « V1-2.6 — Validation UX définitive et +préparation technique » (the sixteen boards of `docs/design/v1-2-6` and the +eleven choices of its `ARBITRAGES.md`), « V1-2.6 UX — Ratification des +décisions techniques » (BDR-100) and « V1-2.6 UX — Autorisation U0 +uniquement » (BDR-101). The technical detail, the single decision table and +the sub-steps U0 to U8 (plus the curves lot, ex-U9) live in +`docs/development/V1-2-6_UX_{DECISIONS,PLAN,COMPATIBILITY,TESTS,RISKS}.md`. +Nothing below is built yet; each sub-step starts on its own authorisation. + +**Level 1 (T11).** Built (lots A to O, level-1 criteria C1 to C48), never +tried by the owner, not declared validated as a whole; its trials stop and its +residuals stay tracked in `.claude/tasks/TODO.md`, re-checked at U8. + +**Validated UX (choices 1 to 11).** Four tabs, references in a side panel, +undo and redo in the header on every tab; direct manipulation of points and +polygons, a zone moved with the mouse once selected and in an explicit mode +by touch, a size slider snapped to the sizes of the view; no coordinate field +in the normal journey; a detail view drawn as a rectangle, its name proposed, +its access never laid over an existing annotation; fixed categories Os, +Articulations, Vertèbres (names and roles fixed, colour and fill opacity +adjustable); a one-time copy of a versioned common text; explicit save with +the local copy; O14 A kept, touch drawing on a tablet in landscape, the +sidebar hidden in the editor below 1 280 px, phone editing a future lot; an +annotation's own colour shown only when set. Amended accordingly: §6.2, §7.4, +§8.2 to §8.4, §16.7, §16.12, and the level-1 contract +(`.claude/tasks/contracts/2026-11-03-v1-2-6-editor-1509.md`: C3, C4, C5, C6, +C7, C8, C11, C13, C16, C18, C20, C25, C28, C32, C33, C40, the undo question of +its CLARIFICATIONS, and a precedence rule in its header; the board differences +left to the owner are listed in `V1-2-6_UX_DECISIONS.md`). + +**Category model (T2, T3, T4, T5, T10).** +- Two optional keys on a category, `role` (`bone`, `joint`, `vertebra`, + `navigation`) and `fill_opacity` (an integer percent from 10 to 100), + omitted when absent, never `null`, no schema version bump. Written only once + the proofs of `V1-2-6_UX_COMPATIBILITY.md` §8 are green and reviewed and the + checks below are live (write lock). Compatibility runs one way: once a + document carries a key, no earlier application, worker or core reads it, + and returning to the old application is impossible. +- Fixed model: each of `bone`, `joint`, `vertebra` carried by exactly one + category, with its fixed names; `navigation` by at most one. +- New-sheet defaults (T5): `cat-bone` « Os » / « Bones » `#a41e65`, + `cat-joint` « Articulations » / « Joints » `#ff9500`, `cat-vertebra` + « Vertèbres » / « Vertebrae » `#e100ff`, colours shown as « Couleur + d'origine ». The names Bones and Joints and the three colours come from the + equine categories `os`, `articulations` and `zone-colonne`; no existing + category is named Vertebrae, which follows the editor's tab pair + « Vertèbres » / « Vertebrae ». +- Navigation category (T10 option B): `cat-access`, role `navigation`, + « Accès aux vues détaillées » / « Detail view access », no colour; never + shown as an anatomical category (no panel, no picker); holds detail + triggers only; created by the core with the first automatic access (U6). +- Checks (T4, no residual gap): the core's verdict issues `category.fixed.*` + (§6.7) and editor refusals with repairs; a core gate at verification + completion that refuses a passed verdict of a core older than U6; the + round withdrawal of §6.4; the two declared SQL checks of §12.2 (O22 + amended), at save and at approval and publication, holding the + fixed-category invariants only. +- History (T5): the historical equine versions keep their ids, names, + colours, own colours, annotations and fingerprints; roles go on the working + copy only (V1-2.8, decision T6); the seed and the published historical + version never change. + +**Detail views (T9, T10).** Replacing a crop view's drawing opens a dialog +before any upload with three actions: keep the positions (only when the +candidate's `viewBox` equals the crop), reposition the annotations (only for +the same aspect ratio, with no path and no descendant crop), cancel; never an +approximate automatic transformation. The automatic access needs the +navigation role, so it comes at U6, not U5, and only when no annotation +overlaps the rectangle; until then the access is placed explicitly from the +view's menu (U4). + +**Curves (T16).** Curve handle editing is deferred to the curves lot, which +precedes any feature letting a path into a document. Stored paths keep their +data byte for byte and are never converted; an operation that would change +one is refused with the document unchanged. « Remplacer par un polygone » is +kept as an explicit replacement only (§8.3 as amended). Before the new model +is activated on an environment, and before U6 or U8 reaches any environment +beyond the throwaway sandbox, a read-only count of path geometries in its +drafts and published versions is recorded (DEV and shared environments by the +owner or under an explicit authorisation, never during U0); a non-zero count +reopens T16. + +**Common text (T12).** One versioned copy inserted once into empty fields +(§7.4); U7 blocked until the owner supplies the FR and EN text, its source and +its validation record; no normative wording before that. + +**Wording (T15).** « Annuler la dernière modification » names the history +command (header button, tooltip and accessible name, the toast after a +gesture); « Abandonner » or « Abandonner les modifications » names leaving a +form or discarding unsaved changes (level-1 C11). + +**Open.** T1 (only if a measure exceeds the 600 000 B wasm budget), T6 +(V1-2.8), T14 (multi-tab notice, follow-up), T17 (the vertebral regions entry +when no category carries the vertebra role; blocks U6), the T12 text (blocks +U7), and the category of an access placed by hand after U6 when annotations +overlap the rectangle (a U6 design point, DECISIONS T10). + +**Implementer decisions** (no owner question): T7 both keys stripped from +every envelope snapshot; T8 path operations on the written digits (curves +lot); T13 commits in place on `feature/v1-2-anatomical-sheets`, rollback by +revert; T18 a handle cap per shape, fixed at U2 from the equine maxima (17 +vertices today) with a margin; T19 sliders and arrow moves commit on release, +Enter or blur. + --- ## 18. Documents touched by V1-2.0