From d401cc824f62bc3d2e23a781e067bc34f6c3334e Mon Sep 17 00:00:00 2001 From: bchanot Date: Sun, 25 Oct 2026 23:46:51 +0100 Subject: [PATCH] test(app): mask fixture values in refused request URLs too --- apps/app/e2e/support/browser.ts | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/apps/app/e2e/support/browser.ts b/apps/app/e2e/support/browser.ts index b4e5b545..ce1c2210 100644 --- a/apps/app/e2e/support/browser.ts +++ b/apps/app/e2e/support/browser.ts @@ -63,23 +63,22 @@ export const test = base.extend({ const forbidden = forbiddenInUrls.filter((value) => value !== '') const refused: string[] = [] const leaking: string[] = [] + const mask = (url: string) => + forbidden.reduce( + (masked, value) => masked.replaceAll(value, ''), + url, + ) await context.route( (url) => !allowedOrigins.includes(url.origin), (route) => { - refused.push(route.request().url()) + refused.push(mask(decodeURIComponent(route.request().url()))) return route.abort('blockedbyclient') }, ) context.on('request', (request) => { const url = decodeURIComponent(request.url()) - const found = forbidden.filter((value) => url.includes(value)) - if (found.length > 0) - leaking.push( - found.reduce( - (masked, value) => masked.replaceAll(value, ''), - url, - ), - ) + if (forbidden.some((value) => url.includes(value))) + leaking.push(mask(url)) }) await use({ forbid: (...values) =>