docs(docs): editor overlay states the bubble's real guarantees; Rust exception row

This commit is contained in:
bchanot committed 2026-11-20 16:34:57 +01:00
1 parent c16840d736
commit cab976e5c9
2 files changed
+31 -22

No files matched your search

+27 -20
View File
@@ -188,14 +188,20 @@ A selected polygon (zone, or a link traced as a polygon) gets its handles in the
same layer, in this order: one « + » at the midpoint of each segment (wrapping same layer, in this order: one « + » at the midpoint of each segment (wrapping
from the last vertex to the first), then one vertex handle per vertex, then the from the last vertex to the first), then one vertex handle per vertex, then the
« − » bubble of the chosen vertex, a rounded rectangle placed away from the « − » bubble of the chosen vertex, a rounded rectangle placed away from the
vertex's two segments, on the side of the larger angle they make, so the « + » vertex's two segments, on the side of the larger angle they make (the open side
of those segments are never in its way. Its hit rectangle never meets the of the vertex), so the « + » of those segments are never in its way. Its hit
vertex's own hit circle nor the hit circle of a shown « + »; when room allows rectangle never meets the vertex's own hit circle; when room allows it also
it also keeps clear of the other vertices' hit circles. It always lies inside keeps clear of the other vertices' hit circles. It always lies inside the
the drawing and, while its vertex is on screen, inside the part shown; when drawing (the whole frame when none of it is on screen). It is clear of the hit
that part leaves no place clear of the « + », it stays on screen with no circles of the shown « + » and inside the part shown whenever such a place
« + » centre under it and its own centre under no « + ». Its place is computed exists: always at fit, and whenever the part shown leaves room. At the edge of
at each render (zoom, pan, drag preview), never stored. Each handle is a the part shown (zoomed or panned) it may turn over the polygon's interior or
come near a « + »; it then stays unambiguous, with no « + » centre under it and
its own centre under no « + », except in rare corner cases: three of 9 261
measured placements, with the vertex at a window corner (caudal v1 ×5.0625 at
screen (0, 0); sacral v7 ×2.25 at (679, 0) and (679, 20)), accepted by the
owner on 2026-11-20. Its place is computed at each render (zoom, pan, drag
preview), never stored. Each handle is a
`role="button"` with `tabindex="0"`, so Tab and Shift+Tab walk them in `role="button"` with `tabindex="0"`, so Tab and Shift+Tab walk them in
document order. They sit in one `<g role="group">` named « Sommets de document order. They sit in one `<g role="group">` named « Sommets de
{nom} »; each name carries the shape's display name in the current locale: {nom} »; each name carries the shape's display name in the current locale:
@@ -205,12 +211,13 @@ shorter than two hit radii on screen at the current zoom (R-9); Insert or the
« + » key on a vertex still reaches it. The « − » bubble is `aria-disabled` and « + » key on a vertex still reaches it. The « − » bubble is `aria-disabled` and
greyed while the polygon has three vertices. Above 40 vertices (`HANDLE_CAP`, greyed while the polygon has three vertices. Above 40 vertices (`HANDLE_CAP`,
T18) the layer draws no handle at all: the overlay keeps the selection outline. T18) the layer draws no handle at all: the overlay keeps the selection outline.
No handle covers the polygon's interior, except the « − » bubble of a vertex At fit, no handle covers the polygon's interior, except the « − » bubble of a
whose larger angle is inside (a re-entrant corner): a press inside it still vertex whose larger angle is inside (a re-entrant corner): a press inside it
reads the core's markers, so an annotation drawn on top is the one a click still reads the core's markers, so an annotation drawn on top is the one a click
reaches. A reaches. Zoomed or panned, the bubble may also lie over the interior at the edge
path, or an annotation without geometry, gets no handle. The pending shape of a of the part shown (above). A path, or an annotation without geometry, gets no
resumed creation gets the same handles (see the creation marks below). handle. The pending shape of a resumed creation gets the same handles (see the
creation marks below).
Marks of a gesture in progress, drawn by the overlay: Marks of a gesture in progress, drawn by the overlay:
@@ -258,8 +265,8 @@ the strip is not sticky.
The drawing column (U2 Task 17: the view chips, the tools and the canvas box, The drawing column (U2 Task 17: the view chips, the tools and the canvas box,
the add row, the message line; `data-drawing-column`) is pinned under the strip the add row, the message line; `data-drawing-column`) is pinned under the strip
from 1 024 px wide and 40.75 rem (652 px) high below 1 280 px wide, 40.25 rem (644 px) from 1 024 px wide and 40.75 rem (652 px) high below 1 280 px wide, 40.25 rem
high from there: `sticky` at `--edit-pinned-top` (644 px) high from there: `sticky` at `--edit-pinned-top`
(bar + strip + 0.75 rem, the strip's gap), aligned to the start of its grid row, (bar + strip + 0.75 rem, the strip's gap), aligned to the start of its grid row,
so no part of it ever passes under the strip or the bar while the side panel so no part of it ever passes under the strip or the bar while the side panel
scrolls past; the side panel still passes under the strip. A bottom margin of scrolls past; the side panel still passes under the strip. A bottom margin of
@@ -279,11 +286,11 @@ widths; a tablet's browser toolbars take their height off the screen's); a
capped box sits left, with spare width on its right. The column's focusables capped box sits left, with spare width on its right. The column's focusables
carry only the bar's margin there (the strip's margin, larger than the pinned carry only the bar's margin there (the strip's margin, larger than the pinned
top, would scroll the page on a focus of a pinned control). The column parts top, would scroll the page on a focus of a pinned control). The column parts
assume one row of view chips: a sheet whose chips wrap to a second row makes the column assume one row of view chips: a sheet whose chips wrap to a second row makes
about 38 px taller than the cap allows, so where the cap binds the column's top the column about 38 px taller than the cap allows, so where the cap binds the column's top
goes under the strip at the end of the page. Below 652 px of window height goes under the strip at the end of the page. Below 652 px of window height
(644 px from 1 280 px wide) the tool column (365 px) no longer fits beside a capped box: nothing is pinned or (644 px from 1 280 px wide) the tool column (365 px) no longer fits beside a
capped, and the drawing scrolls under the strip as before, with the strip's capped box: nothing is pinned or capped, and the drawing scrolls under the strip as before, with the strip's
margin on its focusables. margin on its focusables.
The editor page's other focusables (criterion 25: the header's « Enregistrer », the The editor page's other focusables (criterion 25: the header's « Enregistrer », the
+4 -2
View File
@@ -312,6 +312,7 @@ concrete constraint.
| `apps/app/src/editor/annotations/{press,escape}.ts` | the press machine of the editor drawing (click or drag, which handle, which annotation, what a second pointer cancels, double click) and the Escape priority across the workspace (V1-2.6 U2) | TS | portable (pure functions), but pointer and keyboard event handling is DOM and UI; each result is a proposal that goes through `sheet.edit` and the core's verdict | no | none; called in event handlers | none | `annotations.press.test.ts`, `editor-escape.test.tsx` | **C**: pointer and keyboard event handling, DOM and UI (CLAUDE.md « kept as is »); owner validation of the U2 plan, 2026-11-17 (R-17) | n/a | | `apps/app/src/editor/annotations/{press,escape}.ts` | the press machine of the editor drawing (click or drag, which handle, which annotation, what a second pointer cancels, double click) and the Escape priority across the workspace (V1-2.6 U2) | TS | portable (pure functions), but pointer and keyboard event handling is DOM and UI; each result is a proposal that goes through `sheet.edit` and the core's verdict | no | none; called in event handlers | none | `annotations.press.test.ts`, `editor-escape.test.tsx` | **C**: pointer and keyboard event handling, DOM and UI (CLAUDE.md « kept as is »); owner validation of the U2 plan, 2026-11-17 (R-17) | n/a |
| `apps/app/src/editor/annotations/missingFields.ts` | which required fields of the annotation form are missing, as i18n keys, in form order (V1-2.6 U2, board 33) | TS | portable, but it is a UI form rule over i18n keys; the document's own rules stay the core's | no | none | none | `annotations.missingFields.test.ts` | **C**: UI form rule over i18n keys (CLAUDE.md « kept as is »); owner validation of the U2 plan, 2026-11-17 (R-17) | n/a | | `apps/app/src/editor/annotations/missingFields.ts` | which required fields of the annotation form are missing, as i18n keys, in form order (V1-2.6 U2, board 33) | TS | portable, but it is a UI form rule over i18n keys; the document's own rules stay the core's | no | none | none | `annotations.missingFields.test.ts` | **C**: UI form rule over i18n keys (CLAUDE.md « kept as is »); owner validation of the U2 plan, 2026-11-17 (R-17) | n/a |
| `apps/app/src/editor/annotations/{polygonEdit,pointSize}.ts` | preview arithmetic while a handle moves: midpoint, vertex removal, vertex move, handle cap, « + » visibility; point-size stops, most used radius, snap, slider range (V1-2.6 U2) | TS | portable, but it runs at interaction rate on every pointer move, and UX plan §1.3 and §2 G, ratified at U0, place it in the page; each result is committed through `sheet.edit`, and no core rule is copied: the minimum point radius comes from the core (`PreviewState.min_point_radius`) | no | none; called in event handlers | none | `annotations.polygonEdit.test.ts`, `annotations.pointSize.test.ts` | **C**: interaction-rate preview arithmetic, the core judges the end state; owner validation of the U2 plan, 2026-11-17 (R-17) | n/a | | `apps/app/src/editor/annotations/{polygonEdit,pointSize}.ts` | preview arithmetic while a handle moves: midpoint, vertex removal, vertex move, handle cap, « + » visibility; point-size stops, most used radius, snap, slider range (V1-2.6 U2) | TS | portable, but it runs at interaction rate on every pointer move, and UX plan §1.3 and §2 G, ratified at U0, place it in the page; each result is committed through `sheet.edit`, and no core rule is copied: the minimum point radius comes from the core (`PreviewState.min_point_radius`) | no | none; called in event handlers | none | `annotations.polygonEdit.test.ts`, `annotations.pointSize.test.ts` | **C**: interaction-rate preview arithmetic, the core judges the end state; owner validation of the U2 plan, 2026-11-17 (R-17) | n/a |
| `apps/app/src/editor/annotations/removeBubble.ts` | where the « − » bubble of the chosen polygon vertex sits: open side of the vertex, clear of the shown « + » hit circles, inside the part shown (V1-2.6 U2) | TS | portable, but it computes the placement of handle chrome in the render path, where the core is never called (CLAUDE.md « no call in a render path »); no core rule is copied | no | none; called at each render of the overlay | none | `annotations.removeBubble.test.ts` | **C**: interaction-rate placement of handle chrome, the core judges the end state; owner validation of the U2 plan, 2026-11-17 (R-17) | n/a |
| `i18n/*` (281 keys ×2, `useT`, `pickLocaleLabel`) | UI strings | TS | UI data and hook; the engine's 25 archived labels move with the engine | no | | | parity test | **C** | n/a | | `i18n/*` (281 keys ×2, `useT`, `pickLocaleLabel`) | UI strings | TS | UI data and hook; the engine's 25 archived labels move with the engine | no | | | parity test | **C** | n/a |
| `config/env.ts`, `lib/supabase.ts`, providers, guards, routes, components, styles | runtime config, React | TS | glue | no | | | | **C** | n/a | | `config/env.ts`, `lib/supabase.ts`, providers, guards, routes, components, styles | runtime config, React | TS | glue | no | | | | **C** | n/a |
| `vite/sheet-bundle.ts`, ESLint, Vite, vitest configs | build tooling | Node | Vite plugin API is JavaScript | no | | | | **C** | n/a | | `vite/sheet-bundle.ts`, ESLint, Vite, vitest configs | build tooling | Node | Vite plugin API is JavaScript | no | | | | **C** | n/a |
@@ -352,9 +353,10 @@ concrete constraint.
decides or bypasses the check. decides or bypasses the check.
Same exception for the annotation editor's page-side modules (V1-2.6 U2, owner Same exception for the annotation editor's page-side modules (V1-2.6 U2, owner
validation of the plan, 2026-11-17, R-17): `press.ts`, `escape.ts`, validation of the plan, 2026-11-17, R-17): `press.ts`, `escape.ts`,
`missingFields.ts`, `polygonEdit.ts` and `pointSize.ts` under `missingFields.ts`, `polygonEdit.ts`, `pointSize.ts` and `removeBubble.ts` under
`apps/app/src/editor/annotations/` handle pointer and keyboard events, a UI `apps/app/src/editor/annotations/` handle pointer and keyboard events, a UI
form rule and interaction-rate preview arithmetic. Every end state goes form rule, interaction-rate preview arithmetic and handle placement in the render
path. Every end state goes
through `sheet.edit` and the core's verdict; no core rule is copied. through `sheet.edit` and the core's verdict; no core rule is copied.
--- ---