fix(domain): V1-2.2 second review round, linear walks, bounds, CSS loaders

Verifier ECARTS(3) and security PASS on 8294d54: one indexed walk per
view chain in sheet.edit, a set for referenced drawings, released
preview parses, xml:base and CSS loaders refused, fail-closed PI scan,
PI drawings rejected by the preview, the builder naming its cap.
This commit is contained in:
bchanot committed 2026-10-29 13:58:32 +01:00
1 parent 8294d5471c
commit ca31b787b6
13 files changed
+201 -36

No files matched your search

+29 -4
View File
@@ -3878,7 +3878,9 @@ budget); `sheet.dependents` `{document, key}` → `{dependents: [{element, relat
`drawing_hash_mismatch`, `caps`, `read_only`); a preview holds at most 16 drawings of at most 2 MiB each
(`MAX_HELD_DRAWINGS`; the builder's `add_drawing` answers `false` past them and its build throws `caps: drawings`); the function `clean_svg(bytes)` (`SvgCleaning`). `view.canvas` is one composition for `LoadedSheet` and
`PreviewSheet` (`ops::canvas_of`). The runtime (`CoreRuntime`) does not manage preview handles yet: their poison and
recovery come with their first page (V1-2.5). ts-rs: 31 new type files, `types/index.ts` 126 entries.
recovery come with their first page (V1-2.5). ts-rs: 31 new type files, `types/index.ts` 126 entries. The app's
trapping test stub (`apps/app/tests/helpers/core.ts`) lists the two new glue members, as it lists every member of
`GlueModule`.
### 12.3 Behaviour (declared)
@@ -3923,9 +3925,11 @@ recovery come with their first page (V1-2.5). ts-rs: 31 new type files, `types/i
for drafts; an invalid draft draws with its issues; five replacements, one drawing read; read-only published; no
report operation on a preview; at most 16 drawings of at most 2 MiB.
- `sheet_edit` (11): each marking rule of §6.6, the refusals, `dependents`, the facade, and 400 random commands on the
small sheet and on the equine draft, view crops and drawings, references, zones included (strict re-read, every
key kept by every command but `remove`, which takes only the key and its descendants, the marking rule of each
command, `mark_reviewed` on its zone only, nothing turned `inherited`).
small sheet and on the equine draft, view crops and drawings, references, zones included (strict re-read;
on the marked elements, annotations, categories and nodes: every key kept by every command but `remove`, which
takes only its key and descendants, the rule of insert, update, move, set_status and `mark_reviewed`; nothing
turned `inherited`). The keys of views, references, regions and annotation categories and the redraw rule are held
by the case tests, not by the property test.
- `svg_clean` (10): the 42 hostile files, each on the §9.2 line it belongs to; the security audit's 13 probes
(stylesheet PIs, active content under a long title, HTML fetchers, XHTML elements) refused; a stored PI refused by the
verdict; active names; a plain `<style>` cleaned and
@@ -3954,6 +3958,13 @@ commit): ECARTS(6), all closed in the same step (the long-title MEDIUM, the prop
kept in uploaded bytes; active content classed cleanable under a long title or as HTML fetchers; review groups built
in quadratic time, now one indexed pass; the runtime fixpoint check now compares the serialisation too).
Second round (fresh, on 8294d54): verifier ECARTS(3) (A6 waits on the owner's exports; A12 outside its permitted
commands, covered by `check:all`; the app test stub, now recorded in §12.2) and security PASS with findings fixed in
the same step: one indexed walk per view chain in `sheet.edit` (2 000 chained views were cubic, 5 s per edit; now a
test bound of 1 s debug), a set for the referenced drawings, a replaced asset releases its parse, `xml:base` and the
CSS loaders `src(`, `image(`, `cross-fade(` refused as active, the PI scan fail-closed (`?unreadable`), a drawing
with a PI shown `rejected` by the preview as the verdict refuses it.
### 12.6 Residual risks and points for V1-2.3
- The module's margin under its budget is about 6 KB by the test's measure: the V1-2.5 and V1-2.6 pages must not grow the
@@ -3967,3 +3978,17 @@ in quadratic time, now one indexed pass; the runtime fixpoint check now compares
(`complete_sheet_verification`) must accept a failed verdict without them, or the round would wait for its attempt limit.
- `PreviewSheet` handles are not yet under `CoreRuntime`'s poison and recovery (§8.3): the first page that holds one adds
it.
- Dangling `#id` references are clean and pass the verdict: once a view is inlined into the page, such an id resolves
against the page, so a detail drawing with 256 `<use href="#big"/>` can instantiate the main drawing's group
(security audit, MEDIUM, probe on the shipped module) or show page icons. §9.7's « ids scoped per view » becomes
necessary before V1-2.6 draws two uploaded drawings in one page; refusing references to ids a drawing does not
define is the alternative. Owner decision.
- A clean file is uploaded as its original bytes (contract §9.2 « used as is »): an HTML-only comment form
(`<!-->…-->`) or an XML declaration naming another encoding stays in the stored object, inert for every current
reader (the bucket serves `image/svg+xml`, the app parses core serialisations). Uploading the core's serialisation
in the clean case too would remove it; that changes §9.2 and is the owner's call.
- `validate_sheet_document`'s `view.parent.cycle` rule (R2 code) walks each view's parent chain: quadratic on a long
chain (8 000 chained views, 2.4 s per `preview.state` in the module; the server cap of 2 MiB allows that order).
Left as it was in this step; memoising the chain is the fix, with the conformance fixtures as its oracle.
- The glue copies a drawing's bytes into linear memory before the 2 MiB check (transient, bounded by the bucket).
+5 -3
View File
@@ -1205,8 +1205,8 @@ supplied; they are not invented.
wire ops are `insert`, `update`, `remove`, `move` (the reorder), `set_status`
and `mark_reviewed`; besides what breaks strict parsing they refuse what would
leave an element unaddressable or outside the editor's offer
(`duplicate_key`, `unknown_key`, `id_changed`, `invalid_position`, `too_deep`
beyond 8 finding levels); removing a view or a category leaves the
(`duplicate_key`, `unknown_key`, `invalid_target`, `id_changed`,
`invalid_position`, `too_deep` beyond 8 finding levels); removing a view or a category leaves the
annotations that name it in place, dangling for the validation panel, which
`dependents` lists before the confirmation (§6.6 « with descendants » read
as the finding tree's children).
@@ -1423,7 +1423,9 @@ A drawing never blocks authoring: only the round waits for its verdict.
given are reported in the state, never a load failure; `caps` and
`drawing_missing` refuse a published or deprecated version only (owner
decision 2026-10-29). A hash mismatch and an unreadable document refuse every
mode.
mode, and so do the handle's own resource bounds (V1-2.2): a drawing over
2 MiB (`caps: drawing_bytes`) and more than 16 drawings held
(`caps: drawings`).
- `LoadedSheet` (the report editor's sheet) keeps its mandatory migration map;
`archive::SheetStatus` is not extended; a deprecated version previews like a
published one with a « retirée » mark. The readers of user data