From c8ebcde913ae7d36270b156103187d99fe59bd55 Mon Sep 17 00:00:00 2001 From: bchanot Date: Sat, 10 Oct 2026 01:53:11 +0200 Subject: [PATCH] docs: step 4c curation layout, review drawings, plan and changelog entries --- CHANGELOG.md | 1 + CLAUDE.md | 4 ++-- docs/development/ANATOMICAL_SHEET_MODEL.md | 27 +++++++++++++++++++++- docs/development/IMPLEMENTATION_PLAN.md | 6 +++++ docs/development/MIGRATION_STRATEGY.md | 14 +++++++---- docs/development/SUPABASE.md | 2 +- 6 files changed, 45 insertions(+), 9 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3f53f873..d166f844 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,6 +11,7 @@ Versions follow [Semantic Versioning](https://semver.org/). - **Supabase foundation** — local stack (`supabase/config.toml`), migrations (schemas `private` / `audit`, `profiles`, platform roles with audited RPCs), pgTAP suite run on PGlite (`pnpm test:run`) and on the real stack (`pnpm db:test`), `@faunosteo/supabase` typed client + generated types. No UI change. - **Anatomical sheet model** — `@faunosteo/domain`: canonical sheet document (views tree, annotations with stable ids and explicit laterality, ordered vertebral regions, typed finding categories, explicit annotation → finding zone links, FR/EN labels) with integrity validation; tables `species`, `anatomical_sheets`, `anatomical_sheet_versions` (published rows immutable, one draft per sheet, deletion preconditions), `anatomical_sheet_assets`; lifecycle RPCs (create, draft, publish, deprecate, delete, fork with provenance, archive, assets) audited and under RLS. Spec: `docs/development/ANATOMICAL_SHEET_MODEL.md`. +- **Equine sheet curation (Step 4c)** — document schema v2 (references registry, `review_status` on findings and annotations, configurable vertebral `count_range`; migration `20261010100000`, pgTAP 008); `@faunosteo/anatomy` curation pipeline: authored changeset (`curation/changes.json`, levels A/B/C, before/after records) applied to the legacy baseline → working draft with `CHANGELOG.md`, `REVIEW-REPORT.md` (10 sections for the osteopath) and before/after review drawings; one cleaned SVG asset, head view as a crop. Content: research-backed audit of the horse sheet (44 changes, 48 verifiable references): sphenoid zone restructured, NAV terminology, FR/EN translations, vertebral ranges, nine SVG points relocated, carpus zone added, veterinary red flags, legal disclaimer anchored on R. 243-6 / R. 243-8, osteopathic-model status on unvalidated concepts, 9 questions for the professional. Still a private DRAFT, not published. Docker resources prefixed `faunosteo_` (Compose project and container). - **Equine import (Step 4b)** — `@faunosteo/anatomy` deterministic importer: `Horse.svg` + `Horse_head.svg` + `pathologies.json` → canonical document, legacy id map, French import report, idempotent seed creating the official sheet `faunosteo-cheval` as a private DRAFT (never published by code). Storage bucket `anatomical-sheet-assets` (content-addressed SVGs, read through the sheet, operator upload script). ### Changed (SaaS migration, plan Step 2) diff --git a/CLAUDE.md b/CLAUDE.md index dda04398..6213b173 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -206,7 +206,7 @@ faunosteo/ │ └─ tests/{fixtures/horse-slice.ts,*.test.ts} ├─ packages/anatomy/ ← @faunosteo/anatomy: legacy importer (SVG + catalog → canonical document) + curation │ ├─ src/legacy/{svg,catalog,regions,ids,report,importer}.ts, src/cli/import-equine.ts -│ ├─ src/curation/{schema,targets,ops,apply,assets,stats,changelog,review-report,seed,pipeline}.ts ← changeset → draft +│ ├─ src/curation/{schema,targets,ops,apply,assets,stats,changelog,review-report,overlay,seed,pipeline}.ts ← changeset → draft │ └─ tests/ ← counts preserved, special cases, determinism, curation ops, golden artifacts ├─ packages/supabase/ ← @faunosteo/supabase │ ├─ src/{index,client,database.types,anatomical-sheets}.ts ← typed client, generated types, publish gate @@ -217,7 +217,7 @@ faunosteo/ │ ├─ seed/anatomical-sheets/equine/ │ │ ├─ legacy-import/ ← GENERATED baseline: document, id map, IMPORT-REPORT, SVG copies (no SQL) │ │ ├─ curation/{changes,references}.json ← AUTHORED changeset + references registry (never generated) -│ │ └─ draft/ ← GENERATED working revision: document, cleaned horse.svg, CHANGELOG, REVIEW-REPORT, equine_draft.sql +│ │ └─ draft/ ← GENERATED working revision: document, cleaned horse.svg, CHANGELOG, REVIEW-REPORT, review/*.svg, equine_draft.sql │ └─ tests/*.sql ← pgTAP: allowed + denied paths per policy ├─ packages/README.md ← shared packages index ├─ .gitea/workflows/ci.yml ← CI: install, typecheck, test, lint, build, docker diff --git a/docs/development/ANATOMICAL_SHEET_MODEL.md b/docs/development/ANATOMICAL_SHEET_MODEL.md index 7843aed7..ccf1bdff 100644 --- a/docs/development/ANATOMICAL_SHEET_MODEL.md +++ b/docs/development/ANATOMICAL_SHEET_MODEL.md @@ -310,7 +310,7 @@ authored curation files, and writes under | ---------------- | -------------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | `legacy-import/` | generated baseline | canonical `document.json`, `legacy-id-map.json` (every legacy `data-anno-id`, category slug and view key → new id), `assets.json` + byte-identical SVG copies, `IMPORT-REPORT.md` (French, for the osteopath: volumes, mappings, anomalies). No SQL. | | `curation/` | authored, committed | `references.json` (the references registry) and `changes.json` (the changeset) | -| `draft/` | generated working revision | curated `document.json`, `assets.json` + `assets/horse.svg`, `CHANGELOG.md`, `REVIEW-REPORT.md`, `equine_draft.sql` | +| `draft/` | generated working revision | curated `document.json`, `assets.json` + `assets/horse.svg`, `CHANGELOG.md`, `REVIEW-REPORT.md`, `review/annotations-.svg` (before/after drawing per view), `equine_draft.sql` | Changeset (`packages/anatomy/src/curation/schema.ts`): each change has an id `CHG-nnn`, a level (A demonstrated error, B supported improvement, C @@ -332,6 +332,31 @@ markers are document data now); the head view has no asset and a `view_box` (`60 100 500 380`) cropping it. This step is the reserved change `CHG-000`, listed like the others. +Review drawings: `review/annotations-main.svg` and `review/annotations-head.svg` +draw the cleaned anatomy with every curated annotation (blue unchanged, +green moved or added, red dashed = previous position or removed), ids as +labels, framed on the view's box. Pure data generated by the same command, +readable in a browser; the PNG renders of the review are made by the +operator (ImageMagick) and are not committed. + +Step 4c content (2026-10-10, `curation/changes.json`, 44 changes + CHG-000, +48 references): research-backed audit of the legacy data (NAV 2017, Sisson, +Spoormakers 2021, Degueurce 2004, Dyson & Pollard 2023, Code rural R. 243-6 / +R. 243-8, ECOP glossary…). Level A fixes: sphenoid zone restructured (it +duplicated the SSB tree), sutures absent in the horse removed, FR grammar, +NAV terms (caudal vertebrae, thoraco-lombaire, atlanto-occipitale, +supra-/infra-épineux, fibularis tertius), vertebral ranges (T 17–19, L 5–6, +Cd 15–21, no fixed 18), 62 descriptions translated, view and document +labels. Level B (integrated, `to_confirm`): nine annotation points moved +onto the drawn structures (hip ↔ sacroiliac swap, C7-T1 / T18-L1 / L6-S1 +onto the column, skull points), carpus zone + point added, veterinary red +flags on the distal joints, legal disclaimer anchored on the articles, +osteopathic-model status written on the sacral, Fryette and intra-osseous +nodes, pain-behaviour descriptions. Level C (questions, data kept): SSB +patterns, sacral lateralization, NSR, accessory motions, sesamoid zone, +"charnière", "fixation", two-tier referral, duplicate reasons. Nothing is +published; the professional review starts from `REVIEW-REPORT.md` §10. + Seed: `equine_draft.sql` is idempotent and converging. On a fresh database it inserts the sheet, the cleaned asset row and the draft through `private.insert_sheet_draft`; when the sheet's only version is a draft diff --git a/docs/development/IMPLEMENTATION_PLAN.md b/docs/development/IMPLEMENTATION_PLAN.md index 9b89c72e..c9087c62 100644 --- a/docs/development/IMPLEMENTATION_PLAN.md +++ b/docs/development/IMPLEMENTATION_PLAN.md @@ -149,6 +149,12 @@ Risks: subtle divergences between parser and importer on the detail trigger (no (migration 20261009100000), pgTAP 006/007. Business decisions of 2026-10-09 recorded in ANATOMICAL_SHEET_MODEL.md §5 (follow-gated use → community step; verified publication → identity step; erasure path → retention step). + Step 4c done 2026-10-10 (branch feature/step-04c-equine-curation, awaiting user validation): + document schema v2 (references registry, review_status, vertebral count_range; migration + 20261010100000, pgTAP 008), curation pipeline in packages/anatomy (changeset → draft with + CHANGELOG, REVIEW-REPORT, before/after review drawings), seed layout legacy-import/ + curation/ + + draft/ (the `v1/` folder is gone), research-backed audit of the equine sheet (44 changes, 48 + references, levels A/B/C, nothing published), Docker naming convention (BDR-035). ``` ```text diff --git a/docs/development/MIGRATION_STRATEGY.md b/docs/development/MIGRATION_STRATEGY.md index 730059d1..6ed503ec 100644 --- a/docs/development/MIGRATION_STRATEGY.md +++ b/docs/development/MIGRATION_STRATEGY.md @@ -179,15 +179,19 @@ dictionaries. Locale persists in `profiles.locale` and still in public/species/equine/Horse.svg + Horse_head.svg + src/domain/species/equine/pathologies.json │ legacy importer (packages/anatomy/legacy), deterministic ▼ -supabase/seed/anatomical-sheets/equine/v1/ +supabase/seed/anatomical-sheets/equine/legacy-import/ (generated baseline, no SQL) document.json canonical sheet document (stable ids, explicit mapping, region codes) legacy-id-map.json old data-anno-id → annotation id, old detail key 'head' → view id assets/ the two SVG files, byte-identical to public/ (checksums recorded) - │ seed script (idempotent) + │ curation changeset (supabase/seed/anatomical-sheets/equine/curation/, authored, Step 4c) ▼ -anatomical_sheets "Faunosteo / Cheval / Fiche anatomique officielle" -anatomical_sheet_versions v1, published, immutable -storage: anatomical-sheets////Horse.svg ... +supabase/seed/anatomical-sheets/equine/draft/ (generated working revision) + document.json, assets/horse.svg (one cleaned drawing), CHANGELOG.md, REVIEW-REPORT.md, review/*.svg + │ equine_draft.sql (idempotent, converging; never publishes) + ▼ +anatomical_sheets "Faunosteo / Cheval / Fiche anatomique officielle" (platform-owned, private) +anatomical_sheet_versions DRAFT until a platform admin publishes after the professional review +storage: anatomical-sheet-assets/.svg (content-addressed, operator upload) ``` Normalisations performed once, logged in the seed report (§23.5): duplicate diff --git a/docs/development/SUPABASE.md b/docs/development/SUPABASE.md index 4833bf88..6f4c9a45 100644 --- a/docs/development/SUPABASE.md +++ b/docs/development/SUPABASE.md @@ -20,7 +20,7 @@ supabase/ ├─ seed/anatomical-sheets/equine/ official equine sheet as a DRAFT, generated by `pnpm import:equine` │ ├─ legacy-import/ baseline import (document, id map, SVG copies, IMPORT-REPORT.md), no SQL │ ├─ curation/ authored changes.json + references.json -│ └─ draft/equine_draft.sql idempotent, converging seed (sheet, 1 asset row, working draft), applied by db reset and by PGlite +│ └─ draft/ curated working revision (document, horse.svg, CHANGELOG, REVIEW-REPORT, review/*.svg) + equine_draft.sql: idempotent, converging seed (sheet, 1 asset row, working draft), applied by db reset and by PGlite └─ tests/ pgTAP, one file per concern, allowed AND denied paths packages/supabase/ ├─ src/client.ts createBrowserClient() (anon key, PKCE)