feat(editor): « Aller à » opens the finding dialog, spec races fixed
« Aller à » a finding shows its row and opens its dialog in view mode. E2e helpers wait for the history to settle after a layer or section pop; the layout walk waits out the write budget. Label rows for the nine new keys.
This commit is contained in:
1 parent
4731a3376a
commit
c893dec60b
10 files changed
+89
-3
No files matched your search
@@ -15,6 +15,7 @@ import {
|
||||
closeFinding,
|
||||
draftPath,
|
||||
expectNoDialog,
|
||||
layersSettled,
|
||||
draftTitle,
|
||||
editorActor,
|
||||
historyButton,
|
||||
@@ -146,6 +147,9 @@ test.describe('editor shell layout (H)', () => {
|
||||
await expectNoHorizontalOverflow(page, `the sheet at ${width} px`)
|
||||
await closeCitations(page, dict)
|
||||
await closeFinding(page, dict)
|
||||
// The walk is a script: about 20 history entries per width would pass the adapter's
|
||||
// write budget (40 pushes in 10 s) over four widths. A person never does.
|
||||
await page.waitForTimeout(4_000)
|
||||
}
|
||||
})
|
||||
|
||||
@@ -223,8 +227,10 @@ test.describe('editor shell layout (H)', () => {
|
||||
})
|
||||
await openCitations(page, dict, 'Constat A')
|
||||
await page.keyboard.press('Escape')
|
||||
await expect(place(page, 'citations')).toHaveCount(0)
|
||||
await page.keyboard.press('Escape')
|
||||
await expectNoDialog(page)
|
||||
await layersSettled(page)
|
||||
await selectTab(page, dict, 'annotations')
|
||||
await expect(place(page, 'citations')).toHaveCount(0)
|
||||
await expect(page.getByTestId('annotation-canvas')).toBeVisible()
|
||||
@@ -382,8 +388,10 @@ test.describe('editor shell keyboard order (H)', () => {
|
||||
}
|
||||
expect(met.has('panel')).toBe(true)
|
||||
await page.keyboard.press('Escape')
|
||||
await expect(place(page, 'citations')).toHaveCount(0)
|
||||
await page.keyboard.press('Escape')
|
||||
await expectNoDialog(page)
|
||||
await layersSettled(page)
|
||||
await selectTab(page, dict, 'annotations')
|
||||
const after = await walk(page, 'side')
|
||||
expect(after.slice(0, 3)).toEqual(['tab', 'undo', 'redo'])
|
||||
|
||||
Reference in new issue
Block a user