docs(docs): R4.10 owner decisions: J2.3 option 1 (expected result corrected), J1.7 rectified as PASS with a picker-delay reserve, R4.8 deletion trace (23 files), RUST.md §10.12 ZenQuality logo diagnosis, CHANGELOG, contract, TODO

This commit is contained in:
bchanot committed 2026-10-21 15:47:19 +02:00
1 parent dcc79400de
commit c619f3eba2
9 files changed
+156 -21

No files matched your search

+7 -2
View File
@@ -276,8 +276,13 @@ feat/findings-tree-v2 merged (FindingsTreePicker tracked in HEAD); all work belo
- [x] R4.10c fix A: serve.mjs mirrors nginx.conf cache headers (/assets/ immutable); regression harness `scripts/browser/r4-offline-import.mjs` (J1.7 offline on the 3 engines + header check)
- [x] R4.10d anomaly B diagnosis: editor export always embeds the bundled branding (Step 6 rule, unchanged since 66909b6); archived branding reused only by `export_from_envelope` (cargo); J2.3 expectation wrong (R4.6 wording) → owner decision, no code change
- [x] R4.10e gates: verifier CONFORME 7/7; security PASS, 2 LOW applied (immutable by resolved folder, harness child cleanup) + targeted re-gate; mini-recette `R4_MINI_RECETTE.md`; LRN-066; commits 63034e1..baebb98
- [ ] R4.10f owner: mini-recette M1-M6 on the devices; decision on J2.3 (keep the rule and correct the expected result, or reuse the archived branding on re-export); Safari iOS J1/J2 still NON TESTÉ; gitleaks `[gated]` marker still pending → STOP, no merge, no R5
- [ ] owner actions: add `[gated 2026-10-18]` to `.gitleaks.toml` allowlist description (security BLOCK); `[gated]` clarification for the 21 R4.8-deleted test files if wanted (verifier floor); open UFW 4173 for the recette session; J1 + J2 on the OD-6 devices
- [x] R4.10f owner decisions (2026-10-21): J2.3 option 1 (editor export keeps the application's current branding; the archive keeps its data for a faithful reproduction); J1.7 stays open (cache fix accepted, picker freeze unexplained, Ctrl+O = a clue not a proof, network-share hypothesis not confirmed); Safari iOS pending (real device, no simulator for memory); gitleaks marker authorised again; R4.8 deletion trace to verify; ZenQuality footer logo to diagnose
- [ ] R4.10g J2.3 docs per option 1: R4_J2.md expected result (logos of the application's current branding, the archive's `null` slots not reused), R4_J2_RESULTS.md (declared cell = acceptable under the rule, subject to the logos matching the expected branding), RUST.md §10.12 decision line, mini-recette J2.3 line; no engine, golden or oracle change
- [ ] R4.10h `.gitleaks.toml`: the exact `[gated 2026-10-18]` marker in the one allowlist description, scope unchanged
- [ ] R4.10i R4.8 deletion trace: 23 test files deleted by 0dc1ba2 (one commit, nothing else on the branch); 22 traced case by case in LEDGER.tsv (ported / replaced / deleted with a target), the glue's `pdf-export.ts-engine.test.ts` traced in RUST.md §10.10 and R4.8b; approval = contract 2026-10-20 header (« Je valide officiellement R4.8 … les remplacements de tests sont approuvés ») + BDR-064; RUST.md §10.11 says 21 → corrected to 23; no new deletion
- [ ] R4.10j ZenQuality footer logo: diagnosis (hotlink since caac149 2026-05-21; the DEPLOY.md CSP is the VPS reverse proxy's, docker/nginx.conf carries none; faunosteo.com today sends no CSP header; the PDF uses the bundled `zenquality-logo-fr.png`, unaffected; seen by the R2 and R4 CSP proofs as the known violation, never a J1/J2 item) → fix: the exact remote file bundled under `src/assets/brand/`, Footer `?url` import like the partner logo (same pixels, no branding change); `components.Footer` test (no external image source); `r4-app-csp.mjs` drops the known-host exception (any violation is a problem); build:preview + r4-app-csp + r4-offline-import re-run; CSP unchanged
- [ ] R4.10k gates: verifier on the contract, security gate on the diff; docs (RUST.md §10.12, CHANGELOG), memory; report → STOP: owner's M1-M5 + Safari before any R4 close; no merge, no R5, no release, no deploy
- [ ] owner actions: open UFW 4173 for the recette session, then delete the rule; J1 + J2 on the OD-6 devices
- [ ] owner action (non-blocking): `packages/pdf/node_modules` leftover (13 pnpm symlinks, 6 bin shims, 1 vitest cache file, 0 tracked or useful files) → `rm -rf packages/pdf/node_modules && rmdir packages/pdf` (the recursive delete was refused to Claude by the permission layer)
- [ ] outside R4 (owner 2026-10-17, non-blocking): worker container ignores SIGTERM (Docker kill after 10 s; chore, e.g. `init: true`); README test counter stale (367 vs 1,015)
- [ ] R5 curation pipeline + importer + upload tool: seed golden regenerated once (new `documentSha256`, D-R5), `packages/anatomy` + `packages/domain` deleted, docs map; all before Step 13
@@ -0,0 +1,43 @@
# Contract: R4.10 owner decisions (J2.3 option 1, gitleaks marker, R4.8 trace, ZenQuality logo) and the J1.7 rectification
Base: 1814a8d on `feature/rust-r4-pdf-core`. Date: 2026-10-21.
## REQUEST (verbatim, owner, two messages)
Message 1, « Décisions R4.10 et préparation de la mini-recette »:
- J2.3: « Je choisis définitivement l'option 1. Conserver le comportement historique : les nouveaux exports effectués depuis l'éditeur utilisent le branding actuel de Faunosteo, même lorsque le document importé provient d'une archive sans logos. […] Corrige uniquement l'attendu incorrect de J2.3 et les documents de recette associés. Ne modifie ni le comportement du moteur, ni les goldens, ni les oracles pour ce point. »
- J1.7: « J'accepte le correctif des en-têtes de cache du serveur de recette et les contrôles de sécurité associés. […] Ne considère pas J1.7 comme définitivement validé. […] Ne suppose pas que la piste du partage réseau est confirmée. Le test Ctrl+O est un indice de diagnostic, pas une preuve suffisante à lui seul. Préserve les résultats actuels des tests automatisés. »
- Safari iOS: « La validation Safari iOS réelle reste en attente. […] Un simulateur iPhone ne remplacera pas les mesures de mémoire sur matériel réel. »
- Marqueurs: « Je réitère mon autorisation d'ajouter le marqueur exact `[gated 2026-10-18]` à l'exception strictement ciblée de `.gitleaks.toml`. […] Applique-la sans élargir la portée de l'exception. Vérifie également que l'autorisation des 21 suppressions de tests de R4.8 est correctement tracée, sans créer de nouvelle suppression. »
- ZenQuality: « Vérifie son impact réel sur l'application et sur les exports PDF. Précise si cette ressource est effectivement absente du rendu en build de production et pourquoi les recettes précédentes n'ont pas détecté ce problème. Si un défaut est confirmé, présente un correctif ciblé. Privilégie une ressource locale embarquée, si possible et autorisée, plutôt qu'un assouplissement injustifié de la CSP. Ne modifie pas le branding produit sans décision préalable. »
- Livraison: « Mets à jour les documents correspondant à mes décisions. Exécute les vérifications ciblées nécessaires et conserve les audits précédents. Ne transforme pas les tests headless en résultats humains. Attends mon retour sur M1 à M5 et Safari avant de conclure R4. Reste sur feature/rust-r4-pdf-core. Aucune fusion dans develop. Ne commence pas R5. Ne publie pas la release 0.2.0. Ne déploie rien sur faunosteo.com. »
Message 2, « Rectification définitive J1.7 / M1 / M2 »:
« Lorsque la connexion réseau du système est coupée, le sélecteur de fichiers met environ une minute à s'ouvrir, aussi bien depuis Ctrl+O dans un onglet vide que depuis le bouton « Importer » de Faunosteo. Une fois le sélecteur ouvert, les imports hors ligne fonctionnent normalement. Résultats corrigés : M1 : PASS avec délai d'environ 60 secondes. M2 : PASS avec délai d'environ 60 secondes. J1.7 : PASS fonctionnel, avec réserve de performance concernant l'ouverture du sélecteur. M3 : NON TESTÉ. M4/M5 : NON TESTÉ dans la mini-recette ; les validations J1 antérieures restent déclarées. Le comportement est constaté hors de Faunosteo également. […] Conserve la correction des en-têtes Cache-Control […]. Mets à jour les résultats et le suivi R4.10, sans présenter l'origine exacte des 60 secondes comme prouvée. Ne lance pas de nouvelle modification applicative pour ce symptôme sans preuve d'un défaut de Faunosteo. Ma décision J2.3 reste l'option 1 […]. Les tests sur Safari iOS restent à effectuer. Aucune fusion R4 dans develop, aucun démarrage R5, aucune modification de production sans mon autorisation. »
## FILE SCOPE
- `docs/development/R4_J2.md` (J2.3 expected result), `R4_J2_RESULTS.md`, `R4_J1_RESULTS.md`, `R4_MINI_RECETTE.md`, `RUST.md` §10.11 (count), §10.12 (decisions, C paragraph), `CHANGELOG.md`, `CLAUDE.md` (map line)
- `.gitleaks.toml` (the one description string)
- `apps/app/src/components/brand/Footer.tsx`, `apps/app/src/assets/brand/zenquality-logo-horizontal.png` (new), `apps/app/tests/unit/components.Footer.test.tsx` (new)
- `scripts/browser/r4-app-csp.mjs`, `scripts/browser/results/2026-10-21-r4-{csp,offline-import}.json` (new)
- `.claude/tasks/TODO.md`, memory
Out of scope: `crates/**`, `packages/**`, `apps/app/src/pdf/**`, the goldens, the oracles, the R4 digests, DEPLOY.md's CSP, `docker/nginx.conf`, any deletion.
## ACCEPTANCE CRITERIA
1. J2.3: `R4_J2.md` expects the application's current branding (the four logos of J2.1) on the export of `r3-demo.fr.nologos.pdf`; `R4_J2_RESULTS.md` records the owner's observation as acceptable under that rule, subject to the logos being the current branding, with the original FAIL declaration kept in the note; no file under `crates/`, `packages/`, `apps/app/src/pdf/`, `apps/app/tests/fixtures/goldens/`, `crates/core/tests/oracles/` changed (`git diff --stat 1814a8d`).
2. `.gitleaks.toml`: the allowlist description starts with `[gated 2026-10-18]`; `paths` unchanged, no other key added (`git diff 1814a8d -- .gitleaks.toml` is one line changed).
3. R4.8 trace: `git log --diff-filter=D --name-only --format= 66909b6..HEAD -- '*.test.ts' '*.test.tsx'` lists 23 files, all from 0dc1ba2; RUST.md §10.11 states 23 (and that the verifier counted 21), the ledger traces 22 of them case by case (`awk -F'\t' 'NR>1{print $1}' crates/core/tests/pdf/LEDGER.tsv | sort -u` contains every deleted path but `packages/core-wasm/tests/pdf-export.ts-engine.test.ts`, which §10.10 names); no file deleted by the diff from 1814a8d.
4. J1.7 recorded as the owner rectified it: `R4_J1_RESULTS.md` J1.7 cells for Firefox and Brave read PASS with the picker-delay note, the declared column a PASS with a performance reserve, the note keeps the first FAIL and says the cause of the delay is not established; `R4_MINI_RECETTE.md` §3 holds M1 PASS ~60 s, M2 PASS ~60 s, M3 NON TESTÉ, M4/M5 NON TESTÉ, M6 NON TESTÉ; no application change for the symptom (criterion 1's path list plus `apps/app/src/app/routes/HomeRoute.tsx` and `apps/app/src/core/**` unchanged).
5. ZenQuality: `Footer.tsx` has no `http` image source (`grep -n "src=" apps/app/src/components/brand/Footer.tsx`), imports `@/assets/brand/zenquality-logo-horizontal.png?url`; the file is a valid PNG 1024 × 237 whose sha256 is `8625f6b16022494ab376d94d86fa85cd54aa3d5280e3ceb27531ff33538c0f85`; `components.Footer.test.tsx` passes (`cd apps/app && ./node_modules/.bin/vitest run tests/unit/components.Footer.test.tsx`) and fails when `src={zenQualityUrl}` is replaced by the old URL (prove by a temporary edit, reverted); `DEPLOY.md` unchanged; `apps/app/src/pdf/branding.ts` unchanged.
6. CSP proof: `scripts/browser/r4-app-csp.mjs` holds no `KNOWN_IMAGE_HOST` and treats every document violation, CSP console message and report as a problem; `scripts/browser/results/2026-10-21-r4-csp.json` has 12 runs, every `problems` empty, every `documentViolations` and `consoleCsp` empty; `2026-10-21-r4-offline-import.json` has 6 runs with empty `problems`.
7. The app suite, typecheck and lint green: `pnpm typecheck`, `pnpm lint`, `cd apps/app && ./node_modules/.bin/vitest run` (59 files, 429 cases); the headless results are never written into a device cell of the results grids (every device cell of `R4_J1_RESULTS.md` and `R4_J2_RESULTS.md` other than J1.7 Firefox and Brave stays `NON TESTÉ` or `not applicable`).
8. Docs: RUST.md §10.12 carries the J2.3 decision, the J1.7 rectification (cause not claimed) and the C paragraph (impact, where the policy lives, the live site's header, why the recettes did not report it, the fix and its proofs); CHANGELOG Unreleased has the footer entry; CLAUDE.md map line names the footer logo.
## CLARIFICATIONS
Q: apply the fix or only present it? / A: the owner asked for a targeted fix with a bundled resource and no branding change; the bundled file is the exact remote file, so the picture does not change; applied on the branch, reversible by the owner. [gated 2026-10-21, owner's message 1]