feat(editor): keep edit-only forms across a width change
Edit-only parts (creation forms, submission note, crop group, annotation edit body) mount at the first editable render and stay mounted, hidden and detached from canvases, while read-only. Guards: the viewport hook commits the focused field before the tier crosses 1 024 px, the route releases focus left in a hidden part and treats a store out of step as read-only, delete and discard confirmations close when the editor turns read-only, a drag is dropped while the edit body is hidden. Read-only twins take an id prefix. R-24: no existing assertion rewritten; editor-no-loss.test.tsx and two editor-shell Chromium cases added.
This commit is contained in:
1 parent
9d89daed19
commit
c57af6441f
23 files changed
+883
-108
No files matched your search
@@ -4,6 +4,8 @@ import { expect, test } from '../support/browser'
|
||||
import { dropLateReplays, routeToSandbox } from '../support/sandbox'
|
||||
import {
|
||||
backToDrawing,
|
||||
copyKeyOf,
|
||||
storedCopy,
|
||||
closeReferences,
|
||||
editorActor,
|
||||
openEditor,
|
||||
@@ -34,7 +36,7 @@ async function open(page: Page) {
|
||||
}
|
||||
const seed = await seedDraft(actor, { shape: shapeWith(free) })
|
||||
await openEditor(page, dict, actor, seed.sheetId)
|
||||
return seed
|
||||
return { ...seed, actor }
|
||||
}
|
||||
|
||||
const active = (page: Page) => page.locator(':focus')
|
||||
@@ -141,3 +143,47 @@ test.describe('editor shell, kept places (B2a)', () => {
|
||||
await expect(active(page)).toHaveAttribute('id', 'editor-tab-annotations')
|
||||
})
|
||||
})
|
||||
|
||||
// V1-2.6 U1 B2b: a 1 024 px crossing never loses typed input.
|
||||
test.describe('editor shell, width crossing (B2b)', () => {
|
||||
test.use({ locale: 'fr-FR', actionTimeout: 15_000 })
|
||||
test.beforeEach(async ({ context }, info) => {
|
||||
test.skip(isPhone(info), 'editing needs 1 024 px') // floor-guard: allow C16 editing needs >= 1024 px; phone read-only covered in editor-access
|
||||
await routeToSandbox(context)
|
||||
})
|
||||
test.afterEach(async ({ context }) => {
|
||||
await dropLateReplays(context)
|
||||
})
|
||||
|
||||
test('a field typed without a blur is committed before the crossing and the copy is written', async ({
|
||||
page,
|
||||
}) => {
|
||||
const { actor, draftId } = await open(page)
|
||||
await selectTab(page, dict, 'general')
|
||||
const field = page.locator('#general-name-fr')
|
||||
await field.click()
|
||||
await field.fill('Nom saisi sans quitter le champ')
|
||||
const key = copyKeyOf(actor.account.id, draftId)
|
||||
expect(await storedCopy(page, key)).toBeNull()
|
||||
await page.setViewportSize({ width: 800, height: 900 })
|
||||
await expect(page.locator('#general-name-fr')).toHaveText(
|
||||
'Nom saisi sans quitter le champ',
|
||||
)
|
||||
await expect.poll(() => storedCopy(page, key)).not.toBeNull()
|
||||
})
|
||||
|
||||
test('the category form text is hidden below 1 024 px and comes back on widening', async ({
|
||||
page,
|
||||
}) => {
|
||||
await open(page)
|
||||
await openSection(page, dict, 'categories')
|
||||
const field = page.locator('#category-new-fr')
|
||||
await field.fill('Brouillon')
|
||||
await page.setViewportSize({ width: 800, height: 900 })
|
||||
await expect(field).toBeHidden()
|
||||
await expect(page.locator(':focus')).toHaveCount(0)
|
||||
await page.setViewportSize({ width: 1280, height: 900 })
|
||||
await expect(field).toBeVisible()
|
||||
await expect(field).toHaveValue('Brouillon')
|
||||
})
|
||||
})
|
||||
Reference in new issue
Block a user