chore(memory): BLK-013, LRN-131, R1 last feedback, RR-14

This commit is contained in:
bchanot committed 2026-11-12 15:38:39 +01:00
1 parent dca33b0047
commit c54ba5d62f
5 files changed
+116

No files matched your search

+9
View File
@@ -911,3 +911,12 @@ Limit: wording of this client version only.
**happy-dom** (20.x, vitest): `PointerEvent` init defaults `isPrimary: false`, `pointerType: ''`, `buttons: 0`; `fireEvent.click` moves no focus; no layout (box size 0), no pointer-capture retarget. → pass `isPrimary: true, button: 0, buttons: 1, pointerType` explicitly; focus explicitly; pan translation assertions impossible (assert zoom / preventDefault instead).
**Compressed command output (rtk proxy)**: `pnpm lint | tail` printed `[warn] Linter process terminated abnormally (possibly out of memory)` with rc 254, while `pnpm lint > file 2>&1` gave rc 0 and every package "Done" (2026-11-12, worktree faunosteo-v1-2). Observed once in this context only; the message comes from the proxy wrapping a piped command, NOT proof that eslint never runs out of memory elsewhere. → For gate evidence, redirect to a file and read rc + per-package lines; a real OOM still has to be ruled out from the unproxied log.
**Refs**: scratchpad gate logs r1-gates/final*, .superpowers ledger for plan 2026-11-12-r1-history-deselect-1141.
## LRN-131 — Conditional in-flow element above a canvas = layout shift; fix per message, sr-only only for redundant text (2026-11-12)
**Context**: R1 owner feedback 2026-11-12: drawing jumped at each selection change in sheet editor (BLK of same date, 927537b).
**General problem (layout)**: any element mounted/unmounted or resized on a state change and placed in flow ABOVE a canvas or hit-tested area moves that area: visual jump, and next clicks/taps land on stale coordinates. Sources: selection labels, transient hints, notices, banners.
**Detection**: e2e reads target `boundingBox().y` before and after each state change (select, deselect, hint on/off), desktop + phone; happy-dom has no layout, so unit tests can only assert classes/structure.
**Fix options (choose per message, not one rule)**: (a) redundant info already carried elsewhere (highlight, side panel) → drop visually, keep `sr-only` text if useful for SR browse (SelectionTag case); (b) message user must see (warning, refusal, error, save state) → stays VISIBLE: reserve fixed space (min-height slot), overlay inside canvas box (`relative` parent, absolute + pointer-events-none), or place below / beside canvas. Never sr-only a warning to fix layout.
**A11y check**: sr-only text not live = no announce, available to browse only; announce needs live region, avoid duplicating an existing one.
**Open instance**: ToolNotes hint above canvas (EditableAnnotations.tsx ~373) cleared on select = remaining shift, needs option (b).
**Refs**: SelectionTag.tsx, editor-deselect.spec.ts layout tests, docs/design/README.md deviation 2026-11-12, LRN on layout shift vs hit-test (recompute box per press).