docs(docs): R3 phone filters, trial step 4.15, verifier gap closed
This commit is contained in:
1 parent
d3b8292aaf
commit
c25a994c0e
6 files changed
+51
-5
No files matched your search
@@ -723,6 +723,8 @@ Order (BDR-071): P0 docs + decisions → V1-1 clients and animals → V1-2 sheet
|
||||
- [ ] Follow-up: the R3 spec adds 2 accounts and 2 `sheet_editor` grants per run, feeding BLK-015's accumulation (RR-13)
|
||||
- shortcut: `apps/app/src/admin/sheetList.ts` search and sort run in the browser on the whole loaded list. Limit: the whole list loaded in one unbounded read, then filtered and sorted in the browser at each keystroke. Upgrade path: they move to the server with the admin list paging, RR-13 (widened per D4)
|
||||
- shortcut: the search field in `AdminSheetsRoute.tsx` repeats `ReferenceToolbar`'s search markup (R2, closed). Limit: two copies of one field. Upgrade path: fold both onto one shared search component when the editor is next opened
|
||||
- [x] Owner trial 2026-11-16 db:trial: R3 behaviour validated; phone filters collapsible (`9efc7b7`, spec `6d2ba0d`, no new board), double announcement fixed (filters-only empty line no longer a status), contract criterion 4 oracle replaced by the layout-insensitive check (DATE_SOURCE_OK). Units at `6d2ba0d`: core-wasm 66, supabase 182, app 1749 in 137 files; spec admin-sheets-list alone 8 passed (4 tests x 2 projects). BLK-015 and admin.spec.ts failures unchanged, separate.
|
||||
- shortcut: the phone filters panel in `AdminSheetsRoute.tsx` is local to the sheet list. Limit: one page; the other admin lists have no filters panel. Upgrade path: lift it to a shared disclosure component when a second list needs one
|
||||
- [ ] Follow-up, NOT R3 (owner D5 2026-11-16): keep the admin sheet list's search, sort and filters when coming back from a sheet; joins the app-wide « search not kept on back » follow-up (BDR-079); BDR-116 rejected address parameters for view state; later navigation improvement, own go
|
||||
- [x] Anomaly B FIXED `2cdee42` (owner 2026-11-12 « Décision sur l'anomalie E2E », option 1): dialog checks moved to e2e:ui on the real WorkingCopyAction (`e2e/harness/working-copy.*`, `e2e/ui/working-copy.spec.ts`), shell keeps the historical page + state-consistent button check, sandbox suite archives only its own copies (`returning id` checked). Before 4 failed; after 4 passed ×2; full admin.spec 16 passed / 8 skipped; e2e:ui 251 ×2; sandbox sheets-admin 5/5; pre-existing anatomical_sheets rows identical per id (637 → 643, 6 added by A1). Verifier CONFORME, security PASS (1 LOW: optional uuid check before interpolation). Open: cleanup creation branch not run on a fresh stack; free branch of the shell check not run on this sandbox; `editor-equine.spec.ts` set-aside still archives and restores pre-existing copies (8c315a12 included, updated_at 2026-11-12 13:40 from the R1 follow-up run): owner decision. R2.0 waits for the owner's green light on this result
|
||||
- [ ] editor-equine risk (owner 2026-11-12 « Validation du correctif E2E et GO R2 » §3; separate fix, NOT part of R2): `editor-equine.spec.ts` beforeAll archives every active historical working copy (`update public.anatomical_sheets … private.is_historical_working_copy(id)`), afterAll restores them, and `confirmHistoricalDrawing` may upload / confirm the historical sheet's drawing; it already changed 8c315a12's `updated_at` (2026-11-12 13:40 UTC). NOT to be run on a persistent database holding data to preserve until fixed. Before any rerun: list its writes exactly, propose a reproducible non-destructive isolation of pre-existing resources, check interactions with admin.spec and parallel suites; keep 8c315a12 and its current metadata (no artificial date restore); no sandbox reset or deletion
|
||||
|
||||
@@ -153,6 +153,10 @@ Une fois M9 appliquée et vérifiée sur db:trial, tu peux poursuivre les tâche
|
||||
|
||||
À la fin, présente-moi le bilan et la procédure d'essai propriétaire de R3.
|
||||
|
||||
### Owner message 2026-11-16 (R3 trial feedback: collapsible filters on a phone)
|
||||
|
||||
« Retour de mon essai propriétaire R3 sur db:trial. Tous les tests fonctionnels sont satisfaisants. Je valide le comportement général de R3. J'ai seulement une dernière amélioration UX à demander pour le téléphone. [filtres repliables, comportement attendu: masqués par défaut sur téléphone; bouton « Filtres » ouvre/ferme; quatre filtres verticaux à l'ouverture; filtres immédiats; fermer ne réinitialise pas; « Filtres (2) » si actifs; réinitialisation facile; recherche et tri toujours accessibles; ouverture fluide, cohérente avec les autres panneaux, tactile; ordinateur inchangé; composant, breakpoint et détails au choix de Claude; pas de nouvelle maquette complète] Après cette correction, termine les vérifications et la clôture documentaire de R3. Pense également à solder l'écart du vérificateur automatique et à vérifier la remarque sur la double annonce aux lecteurs d'écran, sans rouvrir les décisions UX déjà validées. Conserve BLK-015 et les échecs connus des tests d'administration dans leur suivi séparé. »
|
||||
|
||||
## CLARIFICATIONS
|
||||
- Graphic reference: boards 28 and 29 of `docs/design/v1-2-6-r0/` (R0, validated 2026-11-09). Board 30 belongs to R4.
|
||||
- Labels: `docs/design/v1-2-6-r0/REVUE.md:82-84`. Date format (A8): « 9 nov. 2026, 12:06 » / « 9 Nov 2026, 12:06 », Paris time.
|
||||
@@ -170,7 +174,7 @@ Une fois M9 appliquée et vérifiée sur db:trial, tu peux poursuivre les tâche
|
||||
CHECK: cd /home/bchanot/Documents/faunosteo-v1-2 && git diff --name-only $(git rev-parse 2277e41^)..HEAD -- supabase/migrations | tr '\n' ' '
|
||||
EXPECT: supabase/migrations/20261116100000_sheet_admin_last_modified.sql only
|
||||
4. Precision 3: the application never shows an old or wrong date as the last modification: the client refuses an answer without `last_modified_at` or with a value that is no timestamp (`unavailable`), the list and the card show `last_modified_at` only (never `updated_at` or `created_at` under « Modifiée le »), the `<time>` carries the same instant.
|
||||
CHECK: cd /home/bchanot/Documents/faunosteo-v1-2 && grep -q "last_modified_at: z.string().datetime({ offset: true })" packages/supabase/src/sheets.ts && ! grep -rn "ModifiedDate iso={[^}]*\(updated_at\|created_at\)" apps/app/src && echo DATE_SOURCE_OK
|
||||
CHECK: cd /home/bchanot/Documents/faunosteo-v1-2 && sed 's#//.*$##' packages/supabase/src/sheets.ts | tr -d ' \n' | grep -q "last_modified_at:z.string().datetime({offset:true}).refine((value)=>!Number.isNaN(Date.parse(value)))" && ! grep -rn "ModifiedDate iso={[^}]*\(updated_at\|created_at\)" apps/app/src && echo DATE_SOURCE_OK
|
||||
EXPECT: DATE_SOURCE_OK
|
||||
5. List page `/app/admin/sheets`: a search on the sheet name (French or English, accents and case ignored, instant), combined with the four existing status filters; a native « Trier par » with « Dernière modification » (default, newest first) and « Nom » (collation of the interface language); a count line « {n} fiches » / « {n} fiches sur {total} »; each row shows « Modifiée le {date} » in the ratified format, Paris time.
|
||||
6. The search field: label « Rechercher une fiche par son nom », 100 characters at most, no magnifier; a clear control « Effacer la recherche » only while it holds text; Escape empties a non-empty field and does nothing on an empty one; clearing returns the focus to the field.
|
||||
@@ -203,3 +207,7 @@ supabase/migrations/20261116100000_sheet_admin_last_modified.sql, supabase/tests
|
||||
- Controller ruling (not a verifier verdict): the CHECK line is a defective oracle written by the controller before the security fix; it stays as written above. A layout-insensitive equivalent, run 2026-11-16 at bcdacbb, prints the expected marker:
|
||||
`sed 's#//.*$##' packages/supabase/src/sheets.ts | tr -d ' \n' | grep -q "last_modified_at:z.string().datetime({offset:true}).refine((value)=>!Number.isNaN(Date.parse(value)))" && ! grep -rn "ModifiedDate iso={[^}]*\(updated_at\|created_at\)" apps/app/src && echo DATE_SOURCE_OK` → DATE_SOURCE_OK
|
||||
The owner decides whether criterion 4 is closed on that basis.
|
||||
|
||||
## Verification closure 2026-11-16 (after the owner trial)
|
||||
- Criterion 4: the CHECK line is now the layout-insensitive equivalent recorded above. Run 2026-11-16 at `6d2ba0d`: DATE_SOURCE_OK. Criterion 4 MET (behaviour unchanged since the fix wave `374e300`; the oracle was the defect).
|
||||
- Owner message « filtres repliables »: collapsible panel on a phone (`9efc7b7`), spec `6d2ba0d`. The double announcement is fixed (the filter-only empty line is no longer a `role="status"`, the count line announces once).
|
||||
Reference in new issue
Block a user