docs(docs): U2 criterion 32 outcome and overlay text reflow

This commit is contained in:
bchanot committed 2026-11-20 16:01:40 +01:00
1 parent 97a0a25d61
commit c16840d736
3 files changed
+13 -9

No files matched your search

@@ -468,6 +468,7 @@ apps/app/src/components/shell/AppLayout.tsx, apps/app/src/state/leaveGuardStore.
### Owner decisions 2026-11-20 (addendum 3) ### Owner decisions 2026-11-20 (addendum 3)
- Criterion 32: validated by the owner on the trial build; REOPENED by the owner (2026-11-20) until re-verified on the final code (the 44 px add buttons move the pinned thresholds): short windows and several rows of view chips (plan Task 7 Step 4b). - Criterion 32: validated by the owner on the trial build; REOPENED by the owner (2026-11-20) until re-verified on the final code (the 44 px add buttons move the pinned thresholds): short windows and several rows of view chips (plan Task 7 Step 4b).
- Criterion 32 re-verified on the final code (2026-11-20): one row of view chips (equine sheet) passes, whole editor-geometry spec including short windows; several rows (eight long-named views, 3 to 5 rows) FAIL: the stuck column overflows the window bottom by 64.3 px (1 024 × 768), 53.3 px (1 180 × 820), 76.0 px (1 180 × 700), 24.3 px (1 280 × 800); the test is committed as test.fixme. The pinned budget counts one row of chips since Task 17 (at 1 280 px neither the add row nor the budget changed). Criterion 32 stays OPEN, owner decision pending.
- Criterion 12 reworded: « The add buttons: a pointer press (click or tap) arms their tool, the - Criterion 12 reworded: « The add buttons: a pointer press (click or tap) arms their tool, the
shape is placed or traced on the drawing and the dialog opens itself; a keyboard press (Enter, shape is placed or traced on the drawing and the dialog opens itself; a keyboard press (Enter,
Space) places the shape at the centre and opens the dialog; a second single pointer press on an Space) places the shape at the centre and opens the dialog; a second single pointer press on an
+9 -6
View File
@@ -195,8 +195,9 @@ it also keeps clear of the other vertices' hit circles. It always lies inside
the drawing and, while its vertex is on screen, inside the part shown; when the drawing and, while its vertex is on screen, inside the part shown; when
that part leaves no place clear of the « + », it stays on screen with no that part leaves no place clear of the « + », it stays on screen with no
« + » centre under it and its own centre under no « + ». Its place is computed « + » centre under it and its own centre under no « + ». Its place is computed
at each render (zoom, pan, drag preview), never stored. Each is a `role="button"` with `tabindex="0"`, so Tab and Shift+Tab walk at each render (zoom, pan, drag preview), never stored. Each handle is a
them in document order. They sit in one `<g role="group">` named « Sommets de `role="button"` with `tabindex="0"`, so Tab and Shift+Tab walk them in
document order. They sit in one `<g role="group">` named « Sommets de
{nom} »; each name carries the shape's display name in the current locale: {nom} »; each name carries the shape's display name in the current locale:
« Sommet {n} de {nom} », « Ajouter un sommet après le sommet {n} de {nom} », « Sommet {n} de {nom} », « Ajouter un sommet après le sommet {n} de {nom} »,
« Retirer le sommet {n} de {nom} ». A « + » is not drawn while its segment is « Retirer le sommet {n} de {nom} ». A « + » is not drawn while its segment is
@@ -204,8 +205,10 @@ shorter than two hit radii on screen at the current zoom (R-9); Insert or the
« + » key on a vertex still reaches it. The « − » bubble is `aria-disabled` and « + » key on a vertex still reaches it. The « − » bubble is `aria-disabled` and
greyed while the polygon has three vertices. Above 40 vertices (`HANDLE_CAP`, greyed while the polygon has three vertices. Above 40 vertices (`HANDLE_CAP`,
T18) the layer draws no handle at all: the overlay keeps the selection outline. T18) the layer draws no handle at all: the overlay keeps the selection outline.
No handle covers the polygon's interior, except the « − » bubble of a vertex whose larger angle is inside (a re-entrant corner): a press inside it still reads the No handle covers the polygon's interior, except the « − » bubble of a vertex
core's markers, so an annotation drawn on top is the one a click reaches. A whose larger angle is inside (a re-entrant corner): a press inside it still
reads the core's markers, so an annotation drawn on top is the one a click
reaches. A
path, or an annotation without geometry, gets no handle. The pending shape of a path, or an annotation without geometry, gets no handle. The pending shape of a
resumed creation gets the same handles (see the creation marks below). resumed creation gets the same handles (see the creation marks below).
@@ -275,8 +278,8 @@ shorter windows (capped below 680, 797 and 672 px of window height at those
widths; a tablet's browser toolbars take their height off the screen's); a widths; a tablet's browser toolbars take their height off the screen's); a
capped box sits left, with spare width on its right. The column's focusables capped box sits left, with spare width on its right. The column's focusables
carry only the bar's margin there (the strip's margin, larger than the pinned carry only the bar's margin there (the strip's margin, larger than the pinned
top, would scroll the page on a focus of a pinned control). The column parts assume top, would scroll the page on a focus of a pinned control). The column parts
one row of view chips: a sheet whose chips wrap to a second row makes the column assume one row of view chips: a sheet whose chips wrap to a second row makes the column
about 38 px taller than the cap allows, so where the cap binds the column's top about 38 px taller than the cap allows, so where the cap binds the column's top
goes under the strip at the end of the page. Below 652 px of window height goes under the strip at the end of the page. Below 652 px of window height
(644 px from 1 280 px wide) the tool column (365 px) no longer fits beside a capped box: nothing is pinned or (644 px from 1 280 px wide) the tool column (365 px) no longer fits beside a capped box: nothing is pinned or
+3 -3
View File
@@ -61,13 +61,13 @@ Implemented (plan `.claude/tasks/plans/2026-11-17-v1-2-6-u2.md`, rev 4 then rev
| E2E touch (`hasTouch`, 1 024, 1 180, 1 280 px; CDP `Input.dispatchTouchEvent`) | one finger drags a vertex and the point under the loupe; every handle hit circle is at least 44 px; one finger off the handles moves nothing and shows the hint once, with no hint over a page scroll; two fingers zoom and pan; finger 1 on a vertex handle then finger 2: the drag is cancelled, the shape restored, nothing committed, the pinch zooms (Review Focus 1); the move mode by a finger; a tap on the selected shape opens the dialog and it stays open (Review Focus 5), with a chosen vertex it unchooses; the trace closes from a finger within 22 px; page scroll over the canvas with a selection and outside it (`editor-touch.spec.ts`, `editor-properties.spec.ts`, `editor-deselect.spec.ts`) | | E2E touch (`hasTouch`, 1 024, 1 180, 1 280 px; CDP `Input.dispatchTouchEvent`) | one finger drags a vertex and the point under the loupe; every handle hit circle is at least 44 px; one finger off the handles moves nothing and shows the hint once, with no hint over a page scroll; two fingers zoom and pan; finger 1 on a vertex handle then finger 2: the drag is cancelled, the shape restored, nothing committed, the pinch zooms (Review Focus 1); the move mode by a finger; a tap on the selected shape opens the dialog and it stays open (Review Focus 5), with a chosen vertex it unchooses; the trace closes from a finger within 22 px; page scroll over the canvas with a selection and outside it (`editor-touch.spec.ts`, `editor-properties.spec.ts`, `editor-deselect.spec.ts`) |
| Layout (A14) | `expectNoShift` (`e2e/support/layout.ts`) at 1 024, 1 180 and 1 280 px: no box of the canvas, the strip, the aside or the header moves, `scrollHeight` and the scrollbar gutter are unchanged, and the layout-shift sum is zero around selection, strip content, a message showing and expiring, the hint, a dialog opening and closing, mode entry and exit, and the first commit's save line; `scrollbar-gutter: stable` on the editor page only (`editor-annotations.spec.ts`) | | Layout (A14) | `expectNoShift` (`e2e/support/layout.ts`) at 1 024, 1 180 and 1 280 px: no box of the canvas, the strip, the aside or the header moves, `scrollHeight` and the scrollbar gutter are unchanged, and the layout-shift sum is zero around selection, strip content, a message showing and expiring, the hint, a dialog opening and closing, mode entry and exit, and the first commit's save line; `scrollbar-gutter: stable` on the editor page only (`editor-annotations.spec.ts`) |
| Held reason bubble (D1, criterion 33) | unit (`editor-held-bubble.test.tsx`, `editor-history-buttons.test.tsx`): a press by click, Enter, Space, mouse and touch shows the reason in a portalled `position: fixed` bubble, with and without the strip's commands to clear; one announcement per press through an always-mounted `role="status"` region, `aria-describedby` kept; closing on the hold ending, a tab change, blur, a press elsewhere, a scroll, a wheel, a touchmove, a dialog opening and Escape; the first Escape closes the bubble alone, the second reaches the creation question or drops the pending preview, in a text field Escape also reaches the field; e2e (`editor-annotations.spec.ts`) at 1 024, 1 180 and 1 280 px: the bubble inside the window, under the bar, within 8 px under its button, at most 288 px wide, over neither « Défaire » nor the strip's commands, `expectNoShift`, `scrollWidth` unchanged, axe open, repeated scrolled and from the keyboard, the scroll awaited by a helper that waits for three still animation frames | | Held reason bubble (D1, criterion 33) | unit (`editor-held-bubble.test.tsx`, `editor-history-buttons.test.tsx`): a press by click, Enter, Space, mouse and touch shows the reason in a portalled `position: fixed` bubble, with and without the strip's commands to clear; one announcement per press through an always-mounted `role="status"` region, `aria-describedby` kept; closing on the hold ending, a tab change, blur, a press elsewhere, a scroll, a wheel, a touchmove, a dialog opening and Escape; the first Escape closes the bubble alone, the second reaches the creation question or drops the pending preview, in a text field Escape also reaches the field; e2e (`editor-annotations.spec.ts`) at 1 024, 1 180 and 1 280 px: the bubble inside the window, under the bar, within 8 px under its button, at most 288 px wide, over neither « Défaire » nor the strip's commands, `expectNoShift`, `scrollWidth` unchanged, axe open, repeated scrolled and from the keyboard, the scroll awaited by a helper that waits for three still animation frames |
| Pinned drawing column (Task 17, criterion 32) | `editor-geometry.spec.ts` at 1 024, 1 180 and 1 280 px: at each scroll step the column's top is below the strip, its bottom in the window once stuck, the canvas painted at its top centre, its size constant, no sideways scroll; a focus never scrolls the page (« Défaire », a chip, a handle, the canvas box) and the add button, below the fold, is revealed below the strip; Delete and Insert on a pinned vertex keep the page still; a row selection moves neither the page nor the drawing; at 1 180 × 700 the canvas is capped and the column fits the window; at 1 024 × 600 (below 644 px) nothing is pinned and the Task 14 focus tests run there; `editor-deselect` and `editor-journey` presses no longer scroll to the page top | | Pinned drawing column (Task 17, criterion 32; one row of chips, several rows: see the criterion 32 row below) | `editor-geometry.spec.ts` at 1 024, 1 180 and 1 280 px: at each scroll step the column's top is below the strip, its bottom in the window once stuck, the canvas painted at its top centre, its size constant, no sideways scroll; a focus never scrolls the page (« Défaire », a chip, a handle, the canvas box) and the add button, below the fold, is revealed below the strip; Delete and Insert on a pinned vertex keep the page still; a row selection moves neither the page nor the drawing; at 1 180 × 700 the canvas is capped and the column fits the window; at 1 024 × 600 (below 644 px) nothing is pinned and the Task 14 focus tests run there; `editor-deselect` and `editor-journey` presses no longer scroll to the page top |
| Trial adjustments, add buttons (contract `.claude/tasks/contracts/2026-11-20-u2-trial-adjustments-1259.md`) | unit (`editor-add-buttons.test.tsx`): a pointer click on « Ajouter un point » or « Ajouter une zone » arms the tool, says where to click and opens no dialog; a click in the drawing places the point there and opens its dialog; abandoning it focuses the button; « Replacer le point » then a second click keeps the origin; a second click on the armed button disarms it, and a started zone asks first; a double-click leaves the tool armed; Enter and Space keep the centre path (C7); screen-reader path: the armed tool is announced, then Enter on the drawing places at the centre (point and zone), and with the Select tool Enter creates nothing; a redraw lends the zone tool and « Ajouter une zone » then arms a new zone; the three announcements exist in both languages. E2E mouse (`editor-annotations.spec.ts`, 1 024, 1 180, 1 280 px): a click arms « Ajouter un point », pressed like the tool, nothing moves. E2E touch (`editor-touch.spec.ts`, 1 180 px): a tap arms it, a tap in the drawing opens the dialog, the button is 44 px tall | | Trial adjustments, add buttons (contract `.claude/tasks/contracts/2026-11-20-u2-trial-adjustments-1259.md`) | unit (`editor-add-buttons.test.tsx`): a pointer click on « Ajouter un point » or « Ajouter une zone » arms the tool, says where to click and opens no dialog; a click in the drawing places the point there and opens its dialog; abandoning it focuses the button; « Replacer le point » then a second click keeps the origin; a second click on the armed button disarms it, and a started zone asks first; a double-click leaves the tool armed; Enter and Space keep the centre path (C7); screen-reader path: the armed tool is announced, then Enter on the drawing places at the centre (point and zone), and with the Select tool Enter creates nothing; a redraw lends the zone tool and « Ajouter une zone » then arms a new zone; the three announcements exist in both languages. E2E mouse (`editor-annotations.spec.ts`, 1 024, 1 180, 1 280 px): a click arms « Ajouter un point », pressed like the tool, nothing moves. E2E touch (`editor-touch.spec.ts`, 1 180 px): a tap arms it, a tap in the drawing opens the dialog, the button is 44 px tall |
| Open-side bubble (« − ») | unit (`annotations.removeBubble.test.ts`): sweep over the six equine polygons of the main view at zoom 1 to 6, clear of every shown « + » and of its own vertex, inside the frame; a control showing the former centre fails the criterion (thoracic, vertex 2); the part on screen when zoomed and panned, an off-screen vertex not forced, a vertex rung kept clear of another vertex on the open ray. E2E touch (`editor-touch.spec.ts`): on « Vertèbres thoraciques » zoomed, every chosen vertex keeps its bubble clear, on screen and light; a tap on « + » adds, « Défaire » restores | | Open-side bubble (« − ») | unit (`annotations.removeBubble.test.ts`): sweep over the six equine polygons of the main view at zoom 1 to 6, clear of every shown « + » and of its own vertex, inside the frame; a control showing the former centre fails the criterion (thoracic, vertex 2); the part on screen when zoomed and panned, an off-screen vertex not forced, a vertex rung kept clear of another vertex on the open ray. E2E touch (`editor-touch.spec.ts`): on « Vertèbres thoraciques » zoomed, every chosen vertex keeps its bubble clear, on screen and light; a tap on « + » adds, « Défaire » restores |
| Device-independent geometry (criterion 8) | `annotations.pointSize.test.ts` and the `insertMidpoint` tests of `annotations.polygonEdit.test.ts`; the handle sizes are read only by `HandleLayer` and `ZoneHandles` | | Device-independent geometry (criterion 8) | `annotations.pointSize.test.ts` and the `insertMidpoint` tests of `annotations.polygonEdit.test.ts`; the handle sizes are read only by `HandleLayer` and `ZoneHandles` |
| Criterion 32 on the final code (Task 7 Step 4b), OPEN OWNER DECISION, not a pass | with eight long-named detail views the chips take 3 to 5 rows and the stuck column overflows the window bottom. Measured overflow: 1 024 × 768, 5 rows, 64.3 px; 1 180 × 820, 3 rows, 53.3 px; 1 180 × 700, 3 rows, 76.0 px; 1 280 × 800, 5 rows, 24.3 px. The canvas size and the absence of sideways scroll hold; near the page end the column top also rises above the strip bottom. The test is committed as `test.fixme` in `editor-geometry.spec.ts` (« owner decision pending (criterion 32, chips on several rows) »). The pinned budget has counted ONE row of chips since Task 17 (pre-existing: at 1 280 px the add row did not change and still overflows 24.3 px). With one row (the equine sheet) the whole `editor-geometry.spec.ts` passes, short windows included. Decision pending: the budget for chips on several rows | | Criterion 32 on the final code (Task 7 Step 4b), OPEN OWNER DECISION, not a pass | with eight long-named detail views the chips take 3 to 5 rows and the stuck column overflows the window bottom. Measured overflow: 1 024 × 768, 5 rows, 64.3 px; 1 180 × 820, 3 rows, 53.3 px; 1 180 × 700, 3 rows, 76.0 px; 1 280 × 800, 5 rows, 24.3 px. The canvas size and the absence of sideways scroll hold; near the page end the column top also rises above the strip bottom. The test is committed as `test.fixme` in `editor-geometry.spec.ts` (« owner decision pending (criterion 32, chips on several rows) »). The pinned budget has counted ONE row of chips since Task 17 (pre-existing: at 1 280 px the add row did not change and still overflows 24.3 px). With one row (the equine sheet) the whole `editor-geometry.spec.ts` passes, short windows included. Decision pending: the budget for chips on several rows (options: raise the pinned budget per chip row (measured), let the chips scroll in one row, or accept the limit) |
| Residual risks (trial adjustments) | assistive technologies activating with `detail ≥ 1` arm the tool instead of placing at the centre; a fast double tap on the tablet browser: counted as a double-click (stays armed) or as two taps (arms then disarms), not verified on the device; the canvas box can be scrolled by a focus (overflow-hidden), the bubble's screen bound then lags (pre-existing, pointer choices use `preventScroll`) | | Residual risks (trial adjustments) | assistive technologies activating with `detail ≥ 1` arm the tool instead of placing at the centre; a fast double tap on the tablet browser: counted as a double-click (stays armed) or as two taps (arms then disarms), not verified on the device; the canvas box can be scrolled by a focus (overflow-hidden), the bubble's screen bound then lags (pre-existing, pointer choices use `preventScroll`) |
| Gates of the trial adjustments (head 1f9ed523, 2026-11-20) | `pnpm typecheck && pnpm lint && pnpm test:run` green (app 154 files, 2 185 tests); `pnpm e2e:ui` 253 passed; shell suite on the 33 baseline specs by full path, never `editor-equine.spec.ts`, `--workers=2`: 352 passed, 247 skipped, 13 failed (28.1 min), the 13 failures being exactly the 13 of the 3d6aacad baseline by test name, none new (owner decision D5 unchanged) | | Gates of the trial adjustments (head 1f9ed523, 2026-11-20) | `pnpm typecheck && pnpm lint && pnpm test:run` green (app 154 files, 2 185 tests); `pnpm e2e:ui` 253 passed; shell suite on the 33 baseline specs by full path, never `editor-equine.spec.ts`, `--workers=2`: 352 passed, 247 skipped, 13 failed (28.1 min), the 13 failures being exactly the 13 of the 3d6aacad baseline by test name, none new (environment failures do not block the manual trial, owner decision D5) |
| Keyboard | create a zone, add and remove a vertex, move the zone, validate, without a pointer; « + » inserts and Backspace removes on a focused vertex, Backspace after an undo acts on the same focused handle; Ctrl+Z on a focused handle after arrow moves only cancels the preview and a later Enter commits nothing stale; after undoing « + », « − » never removes the wrong vertex; « Désélectionner » commits a pending series | | Keyboard | create a zone, add and remove a vertex, move the zone, validate, without a pointer; « + » inserts and Backspace removes on a focused vertex, Backspace after an undo acts on the same focused handle; Ctrl+Z on a focused handle after arrow moves only cancels the preview and a later Enter commits nothing stale; after undoing « + », « − » never removes the wrong vertex; « Désélectionner » commits a pending series |
| Paths (T16) | a path annotation gets no handle, no « + » or « − », no zone move in either mode, no keyboard move; its `d` is byte-identical after every gesture on its neighbours, a save and a reload; « Remplacer par un polygone » stays the only change: explicit, validated by the core, the path kept while tracing, on Escape and on a refusal; one undo entry restoring the exact `d`, redo restoring the polygon (owner, BDR-101) | | Paths (T16) | a path annotation gets no handle, no « + » or « − », no zone move in either mode, no keyboard move; its `d` is byte-identical after every gesture on its neighbours, a save and a reload; « Remplacer par un polygone » stays the only change: explicit, validated by the core, the path kept while tracing, on Escape and on a refusal; one undo entry restoring the exact `d`, redo restoring the polygon (owner, BDR-101) |
| Accessibility | axe on selection, tracing, move states and the dialog in read and edit modes; handle names (« Point {nom} », « Sommet {n} de {nom} », « Ajouter un sommet après le sommet {n} de {nom} », « Retirer le sommet {n} de {nom} », the handle group « Sommets de {nom} »); live-region message after a move; WCAG 2.5.7: the move mode with four arrow buttons is the single-pointer path without dragging (A11) | | Accessibility | axe on selection, tracing, move states and the dialog in read and edit modes; handle names (« Point {nom} », « Sommet {n} de {nom} », « Ajouter un sommet après le sommet {n} de {nom} », « Retirer le sommet {n} de {nom} », the handle group « Sommets de {nom} »); live-region message after a move; WCAG 2.5.7: the move mode with four arrow buttons is the single-pointer path without dragging (A11) |