feat(editor): the canvas tells an engine failure (retry) from a view it cannot draw (no retry)

This commit is contained in:
bchanot committed 2026-10-15 01:03:16 +02:00
1 parent 6882c6da4a
commit c0a5c8c7ce
8 files changed
+182 -36

No files matched your search

+21 -1
View File
@@ -102,6 +102,26 @@ function liveTree(selector) {
return treeOf(document.querySelector(selector))
}
/**
* Owner decision 2026-10-15: an unnamed trigger carries the opened view's name per language;
* the freeze has the French name twice. Applied to the frozen tree before comparing
* (apps/app/tests/helpers/svgTree.ts withTriggerNamesPerLanguage).
*/
function declared(frozen) {
const doc = JSON.parse(readFileSync(resolve(import.meta.dirname,
'../supabase/seed/anatomical-sheets/equine/draft/document.json'), 'utf8'))
const views = doc.views.map((v) => ({ id: v.id, fr: v.name.fr, en: v.name.en }))
const visit = (n) => {
if (typeof n !== 'object' || n === null) return
const view = views.find((v) => v.id === n.attrs?.['data-anno-opens-view'])
if (view && n.attrs?.['data-anno-name-en'] === view.fr) n.attrs['data-anno-name-en'] = view.en
for (const v of views) if (n.text === `${v.fr} / ${v.fr}`) n.text = `${v.fr} / ${v.en}`
n.children?.forEach(visit)
}
visit(frozen)
return frozen
}
async function dom(base) {
const { chromium } = require('playwright-core')
const goldens = resolve(import.meta.dirname, '../apps/app/tests/fixtures/goldens/r3')
@@ -117,7 +137,7 @@ async function dom(base) {
let failed = 0
for (const view of ['main', 'head']) {
const frozen = readFileSync(join(goldens, `canvas.${view}.json`), 'utf8')
const same = JSON.stringify(trees[view]) === JSON.stringify(JSON.parse(frozen))
const same = JSON.stringify(trees[view]) === JSON.stringify(declared(JSON.parse(frozen)))
if (!same) failed++
console.log(`${same ? 'equal ' : 'DIFFERENT'} ${view} canvas vs the R3 O1 freeze (${browser.version()})`)
}