feat(editor): the canvas tells an engine failure (retry) from a view it cannot draw (no retry)

This commit is contained in:
bchanot committed 2026-10-15 01:03:16 +02:00
1 parent 6882c6da4a
commit c0a5c8c7ce
8 files changed
+182 -36

No files matched your search

+16 -5
View File
@@ -18,7 +18,12 @@ import {
GOLDEN_REPORTS,
type GoldenReports,
} from '../helpers/goldenReports'
import { checkR3Golden, treeOf, type TreeNode } from '../helpers/svgTree'
import {
checkR3Golden,
treeOf,
withTriggerNamesPerLanguage,
type TreeNode,
} from '../helpers/svgTree'
let sheet: SheetIndex
let golden: GoldenReports
@@ -56,6 +61,12 @@ function layerOf(tree: TreeNode): TreeNode {
return last
}
/** The declared change of the owner's decision 2026-10-15, on the draft's views. */
function declared(frozen: unknown): unknown {
const views = sheet.sheet.document.views.map((v) => ({ id: v.id, ...v.name }))
return withTriggerNamesPerLanguage(frozen, views)
}
async function mountedLayer(viewId: string, states: ViewStates): Promise<TreeNode> {
const { container, unmount } = render(
<AnatomyCanvas index={sheet} viewId={viewId} states={states} onZoneClick={() => undefined} />,
@@ -68,9 +79,9 @@ async function mountedLayer(viewId: string, states: ViewStates): Promise<TreeNod
describe.each(VIEWS)('the %s canvas', (viewId) => {
it('builds the frozen tree with no state', () => {
const svg = buildViewSvg(sheet, viewId)
expect(svg).not.toBeNull()
checkR3Golden(`canvas.${viewId}.json`, treeOf(svg!))
const build = buildViewSvg(sheet, viewId)
if (!build.ok) throw new Error(`canvas ${viewId}: ${build.failure}`)
checkR3Golden(`canvas.${viewId}.json`, treeOf(build.svg), declared)
})
it('shows the frozen layer for every state set of the reference reports', async () => {
@@ -79,6 +90,6 @@ describe.each(VIEWS)('the %s canvas', (viewId) => {
layers[name] = await mountedLayer(viewId, states)
}
expect(Object.keys(layers).length).toBeGreaterThan(8)
checkR3Golden(`canvas.${viewId}.layers.json`, layers)
checkR3Golden(`canvas.${viewId}.layers.json`, layers, declared)
})
})