From be1a5c017311a79ff8becefc017a6963c2a73c44 Mon Sep 17 00:00:00 2001 From: bchanot Date: Wed, 4 Nov 2026 23:19:57 +0100 Subject: [PATCH] chore(memory): V1-2.6 checkpoint report, host filter, scope line --- .claude/tasks/contracts/2026-11-03-v1-2-6-editor-1509.md | 3 ++- .claude/tasks/plans/2026-11-04-v1-2-6-checkpoint.md | 9 +++++++-- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/.claude/tasks/contracts/2026-11-03-v1-2-6-editor-1509.md b/.claude/tasks/contracts/2026-11-03-v1-2-6-editor-1509.md index b6e53dc9..a05aed48 100644 --- a/.claude/tasks/contracts/2026-11-03-v1-2-6-editor-1509.md +++ b/.claude/tasks/contracts/2026-11-03-v1-2-6-editor-1509.md @@ -395,6 +395,7 @@ checked across develop, main, feature/v1-1, feature/v1-2: next free were BDR-099 apps/app/src/components/ui/Icon.tsx, apps/app/src/state/persistence.ts, apps/app/src/admin/labels.ts (C1, C7, C11, C13, C16, C17 reuse); apps/app/vite/trial.config.ts, scripts/db-sandbox.sh, docs/development/SUPABASE.md (plan choice 7, C25); supabase/tests/023_sheet_draft_last_save.sql (M8 pgTAP); packages/supabase/tests/sandbox/** - and apps/app/e2e/playwright.shell.config.ts (C20, C22) + and apps/app/e2e/playwright.shell.config.ts (C20, C22); [amended 2026-11-04 after the owner's approval of a09e24d] apps/app/e2e/playwright.lan.config.ts and + apps/app/e2e/lan/** (C47: the LAN trial check) - NOT in scope: crates/**, supabase/migrations/** (except a read migration if the owner chooses it), supabase/seed/**, legacy sources, goldens, oracles diff --git a/.claude/tasks/plans/2026-11-04-v1-2-6-checkpoint.md b/.claude/tasks/plans/2026-11-04-v1-2-6-checkpoint.md index c85b9105..de452405 100644 --- a/.claude/tasks/plans/2026-11-04-v1-2-6-checkpoint.md +++ b/.claude/tasks/plans/2026-11-04-v1-2-6-checkpoint.md @@ -7,7 +7,7 @@ The owner has not tried the editor: V1-2.6 is NOT declared functionally validate ## HEAD and commits - Branch `feature/v1-2-anatomical-sheets`, pushed, no merge, working tree clean. HEAD: the commit that adds this file (`git log -1 -- .claude/tasks/plans/2026-11-04-v1-2-6-checkpoint.md`); last application code `2057b0e`, last trial - tooling `fb95255`. + tooling: the host-filter commit right before this report (`git log -1 -- apps/app/vite/trial.config.ts`). - Step range `2571978..HEAD`: lots A-M (`2f824a9..7a4ce9e`), lot N owner checkpoint decisions (`be4f468..5e0aa62`), lot O last owner decisions (`a69eba5`, `d74c54e`, `2057b0e`, `fb95255`); docs and `.claude` commits in between. - No file changed under `crates/`, `supabase/seed/`, `apps/app/tests/fixtures/`, `packages/core-wasm/{tests,types}/` @@ -23,12 +23,17 @@ The owner has not tried the editor: V1-2.6 is NOT declared functionally validate - `pnpm check:all`: « all checks passed » (unit core-wasm 66, supabase 159, app 1085; e2e:ui passed). - `pnpm r5:import-equine --check`: legacy-import 6 files and draft 12 files, 0 differences (historical documents intact). - LAN trial on `fb95255` (orchestrator): `pnpm db:sandbox trial` → `== trial: http://192.168.1.100:5193`; sockets - 192.168.1.100:5193 and 127.0.0.1:57801 only; 127.0.0.1:5193 refused; `Host: evil.example` → 403; `/@fs` of `.claude`, + 192.168.1.100:5193 and 127.0.0.1:57801 only; 127.0.0.1:5193 refused; `/@fs` of `.claude`, `.superpowers`, `supabase/seed.sql`, `crates`, the sandbox secrets → 403, `packages` → 200; no `PGPASSWORD` in the Vite environment; the LAN Playwright journey (`apps/app/e2e/playwright.lan.config.ts`: sign-in, TOTP, catalogue, new non-equine sheet, SVG import through cleaning, save, reload, no request leaving the LAN origin) passed; then stopped, `down`, 0 containers, 0 listeners, throwaway password deleted. Not tested: a real second device. - `fb95255` changes only the trial Vite config, the trial command and docs (not used by the automated suites). +- Host filter (after the third fresh verifier found that Vite 7's `allowedHosts` lets every IP literal and + localhost through): the trial config adds a middleware answering 403 to any Host other than the trial host. + Probed on the running trial: `Host: 192.168.1.100:5193` → 200; `10.0.0.1:5193`, `127.0.0.1:5193`, + `localhost:5193`, `a.localhost`, `evil.example` → 403, also on the proxied `/auth/v1/health`; the LAN Playwright + journey passed again; then stopped, `down`, 0 containers, 0 listeners, password deleted. ## Audits and reviews - Security (fresh auditor): full range `2571978..25bdac4` PASS (0 blocking); scoped `25bdac4..fb95255` PASS: worktree