fix(bugs): obs card click + next-RDV radio + PDF toBlob fallback + head svg interactivity

Five fixes from manual QA:

1. ObservationCard — clicking anywhere on the card now selects it.
   The wrapping button only covered the text rows; empty space was dead.
   The whole card is now role="button" with keyboard (Enter/Space) support;
   inner action buttons (↑ ↓ 🗑) stop propagation so they don't double-fire.
   This was also the root cause of "details look stuck" — the active
   observation simply wasn't being switched.

2. NextAppointmentPicker — when value === undefined the "Date" radio was
   still showing as checked because `kind` defaulted to 'date'. The three
   radios now read from the raw `value?.kind` (which can be undefined),
   so "Aucun" is the only checked option when no next RDV is set.

3. svgToPng.rasterizeSvg — `canvas.toBlob` can return null in some
   browsers when the canvas state is unusual; the call now falls back to
   `canvas.toDataURL('image/png')` and decodes the base64 payload. Also
   paints a white background before canvg renders (so the PDF embed is
   opaque) and clamps width/height to >= 1px to avoid zero-area canvases.
   canvg errors are caught + logged instead of propagating, so the export
   still produces a (possibly blank) page rather than throwing.

4. svgConvention.parseSvgBones — clickable bones are now distinguished
   from decorative ones. Interactive = has a hitbox element OR category
   is spine-zone OR head. Decorative bones (teeth, malar, mandible,
   nasal-bone, facial-crest, individual vertebrae paths…) get
   `pointer-events: none` applied to their elements and are excluded from
   the returned map. Result: in Horse_head.svg, frontal/temporal/parietal/
   sphenoid/occipital/atm/ssb/c0-c1/hyoid become clickable as intended,
   while teeth / malar / mandible no longer intercept the clicks.

5. (covered by #1) — the per-observation details panel always read the
   active observation; the bug was the click handler scope. Confirmed by
   switching observations: the editor section now updates immediately.

88 tests still pass, lint clean, build clean.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Bastien ChanotandClaude Opus 4.7 committed 2026-05-18 22:48:13 +02:00
1 parent 9a99fc916b
commit bdf5e6475b
5 files changed
+189 -37

No files matched your search

+45 -9
View File
@@ -2,12 +2,21 @@ import { Canvg } from 'canvg'
const TARGET_WIDTH = 1200
export async function rasterizeSvg(svgString: string, scale: number): Promise<Uint8Array> {
export async function rasterizeSvg(
svgString: string,
scale: number,
): Promise<Uint8Array> {
const tmp = new DOMParser().parseFromString(svgString, 'image/svg+xml')
const root = tmp.documentElement
const vb = (root.getAttribute('viewBox') ?? '0 0 1000 600').split(/\s+/).map(Number)
const widthPx = Math.round(TARGET_WIDTH * Math.max(1, scale) * 0.5)
const heightPx = Math.round((vb[3] / vb[2]) * widthPx)
const vb = (root.getAttribute('viewBox') ?? '0 0 1000 600')
.split(/\s+/)
.map(Number)
const widthPx = Math.max(
1,
Math.round(TARGET_WIDTH * Math.max(1, scale) * 0.5),
)
const ratio = vb[3] > 0 && vb[2] > 0 ? vb[3] / vb[2] : 0.6
const heightPx = Math.max(1, Math.round(ratio * widthPx))
const canvas = document.createElement('canvas')
canvas.width = widthPx
@@ -15,11 +24,38 @@ export async function rasterizeSvg(svgString: string, scale: number): Promise<Ui
const ctx = canvas.getContext('2d')
if (!ctx) throw new Error('Canvas 2D context unavailable')
const canv = await Canvg.from(ctx, svgString)
await canv.render()
// White background so the resulting PNG is opaque (some PDF viewers
// ignore transparent canvases when embedded).
ctx.fillStyle = '#ffffff'
ctx.fillRect(0, 0, widthPx, heightPx)
const blob: Blob = await new Promise((resolve, reject) => {
canvas.toBlob((b) => (b ? resolve(b) : reject(new Error('toBlob returned null'))), 'image/png')
try {
const canv = await Canvg.from(ctx, svgString, {
anonymousCrossOrigin: true,
})
await canv.render()
} catch (err) {
console.error('canvg render failed; falling back to blank canvas', err)
}
const blob = await new Promise<Blob | null>((resolve) => {
canvas.toBlob((b) => resolve(b), 'image/png')
})
return new Uint8Array(await blob.arrayBuffer())
if (blob) return new Uint8Array(await blob.arrayBuffer())
// toBlob can return null in some browsers when the canvas state is
// unusual; fall back to toDataURL which is synchronous and broadly
// available.
const dataUrl = canvas.toDataURL('image/png')
const comma = dataUrl.indexOf(',')
if (comma < 0) {
throw new Error('canvas.toDataURL returned an unexpected payload')
}
const base64 = dataUrl.slice(comma + 1)
const binary = atob(base64)
const bytes = new Uint8Array(binary.length)
for (let i = 0; i < binary.length; i += 1) {
bytes[i] = binary.charCodeAt(i)
}
return bytes
}