fix(bugs): obs card click + next-RDV radio + PDF toBlob fallback + head svg interactivity
Five fixes from manual QA:
1. ObservationCard — clicking anywhere on the card now selects it.
The wrapping button only covered the text rows; empty space was dead.
The whole card is now role="button" with keyboard (Enter/Space) support;
inner action buttons (↑ ↓ 🗑) stop propagation so they don't double-fire.
This was also the root cause of "details look stuck" — the active
observation simply wasn't being switched.
2. NextAppointmentPicker — when value === undefined the "Date" radio was
still showing as checked because `kind` defaulted to 'date'. The three
radios now read from the raw `value?.kind` (which can be undefined),
so "Aucun" is the only checked option when no next RDV is set.
3. svgToPng.rasterizeSvg — `canvas.toBlob` can return null in some
browsers when the canvas state is unusual; the call now falls back to
`canvas.toDataURL('image/png')` and decodes the base64 payload. Also
paints a white background before canvg renders (so the PDF embed is
opaque) and clamps width/height to >= 1px to avoid zero-area canvases.
canvg errors are caught + logged instead of propagating, so the export
still produces a (possibly blank) page rather than throwing.
4. svgConvention.parseSvgBones — clickable bones are now distinguished
from decorative ones. Interactive = has a hitbox element OR category
is spine-zone OR head. Decorative bones (teeth, malar, mandible,
nasal-bone, facial-crest, individual vertebrae paths…) get
`pointer-events: none` applied to their elements and are excluded from
the returned map. Result: in Horse_head.svg, frontal/temporal/parietal/
sphenoid/occipital/atm/ssb/c0-c1/hyoid become clickable as intended,
while teeth / malar / mandible no longer intercept the clicks.
5. (covered by #1) — the per-observation details panel always read the
active observation; the bug was the click handler scope. Confirmed by
switching observations: the editor section now updates immediately.
88 tests still pass, lint clean, build clean.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
1 parent
9a99fc916b
commit
bdf5e6475b
5 files changed
+189
-37
No files matched your search
@@ -40,8 +40,26 @@ export function validateBoneElement(el: Element): void {
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* A bone is interactive (clickable) if any of these is true:
|
||||
* - at least one element carries the `hitbox` class (hitbox+visible pattern);
|
||||
* - its category is `spine-zone` (single overlay polygon, pointer-events:all);
|
||||
* - its category is `head` (single entry-point polygon for a detail SVG).
|
||||
*
|
||||
* Decorative elements (e.g. individual vertebrae paths, teeth, malar bone)
|
||||
* carry `data-bone-id` so their colorization can be controlled by JS, but
|
||||
* must NOT intercept clicks. We mark them with `pointer-events: none` and
|
||||
* exclude them from the returned Bone map so the click handler ignores
|
||||
* them naturally.
|
||||
*/
|
||||
function isInteractiveBone(bone: Bone): boolean {
|
||||
if (bone.hitboxEls.length > 0) return true
|
||||
if (bone.category === 'spine-zone' || bone.category === 'head') return true
|
||||
return false
|
||||
}
|
||||
|
||||
export function parseSvgBones(svgRoot: SVGSVGElement): Map<string, Bone> {
|
||||
const map = new Map<string, Bone>()
|
||||
const raw = new Map<string, Bone>()
|
||||
const all = svgRoot.querySelectorAll<Element>('[data-bone-id]')
|
||||
all.forEach((el) => {
|
||||
validateBoneElement(el)
|
||||
@@ -53,13 +71,13 @@ export function parseSvgBones(svgRoot: SVGSVGElement): Map<string, Bone> {
|
||||
const classes = classList(el)
|
||||
const isHitbox = classes.includes('hitbox')
|
||||
|
||||
const existing = map.get(id)
|
||||
const existing = raw.get(id)
|
||||
if (existing) {
|
||||
if (isHitbox) existing.hitboxEls.push(el)
|
||||
else existing.visibleEls.push(el)
|
||||
if (opensDetail && !existing.opensDetail) existing.opensDetail = opensDetail
|
||||
} else {
|
||||
map.set(id, {
|
||||
raw.set(id, {
|
||||
id,
|
||||
fr,
|
||||
en,
|
||||
@@ -70,7 +88,23 @@ export function parseSvgBones(svgRoot: SVGSVGElement): Map<string, Bone> {
|
||||
})
|
||||
}
|
||||
})
|
||||
return map
|
||||
|
||||
const interactive = new Map<string, Bone>()
|
||||
raw.forEach((bone, id) => {
|
||||
if (isInteractiveBone(bone)) {
|
||||
interactive.set(id, bone)
|
||||
} else {
|
||||
// Decorative — make sure clicks fall through to whatever is underneath.
|
||||
bone.visibleEls.forEach((el) => {
|
||||
if (el instanceof SVGElement || el instanceof HTMLElement) {
|
||||
el.style.pointerEvents = 'none'
|
||||
} else {
|
||||
el.setAttribute('pointer-events', 'none')
|
||||
}
|
||||
})
|
||||
}
|
||||
})
|
||||
return interactive
|
||||
}
|
||||
|
||||
export function getBoneIdFromEvent(event: Event): string | null {
|
||||
|
||||
Reference in new issue
Block a user