fix(anatomy): R5.4 authored backticks refused, underscores paired across code spans refused; sweep cites probe_ref and probe_ref_

This commit is contained in:
bchanot committed 2026-10-23 13:21:28 +02:00
1 parent aff3a96d55
commit bc5d0ad038
7 files changed
+91 -29

No files matched your search

+23 -15
View File
@@ -28,7 +28,10 @@ fn oracle() -> Value {
}
/// The raw CHANGELOG and REVIEW-REPORT of a probe, as the port writes them.
fn raw_reports(frozen: &Value, case: &Value) -> (String, Result<String, PipelineError>) {
fn raw_reports(
frozen: &Value,
case: &Value,
) -> (Result<String, PipelineError>, Result<String, PipelineError>) {
let baseline = &frozen["baseline"];
let references =
parse_references(&to_js_compact(&json!({ "references": frozen["references"] })).unwrap())
@@ -52,7 +55,7 @@ fn raw_reports(frozen: &Value, case: &Value) -> (String, Result<String, Pipeline
})
.unwrap();
let changes: Vec<_> = changeset.changes.iter().map(|c| c.summary()).collect();
let changelog = render_changelog(&result.records, &before, &after, &stats).unwrap();
let changelog = render_changelog(&result.records, &before, &after, &stats);
let review = render_review_report(&ReviewReportInput {
changes: &changes,
records: &result.records,
@@ -70,12 +73,11 @@ const EQUINE_SAFE: &str = "[]&#{}=<>\"':;()/%?-.,«»…≠°—+";
fn equine_safe(probe: &str) -> bool {
// A leading or trailing space becomes two spaces once the probe sits in its sentence; the
// inline constructs (links, wiki links, autolinks, character references) are probed apart.
let tag = probe
.split('<')
.skip(1)
.any(|after| after.starts_with(|c: char| c.is_ascii_alphabetic() || "/!?".contains(c)));
let tag = probe.match_indices('<').any(|(at, _)| {
probe[at + 1..].starts_with(|c: char| c.is_ascii_alphabetic() || "/!?".contains(c))
});
let construct = tag
|| ["](", "][", "![", "[[ ", " ]]", "&"]
|| ["](", "][", "![", "[[ ", " ]]", "&", "`"]
.iter()
.any(|m| probe.contains(m));
!construct
@@ -95,16 +97,21 @@ fn every_probe_is_formatted_as_the_typescript_or_refused() {
let probe = case["probe"].as_str().unwrap();
let (changelog, review) = raw_reports(&frozen, case);
let digest = |text: &str| sha256_hex(text.as_bytes());
assert_eq!(
digest(&changelog),
case["changelog_raw_sha256"],
"{probe:?} raw"
);
if let Ok(changelog) = &changelog {
assert_eq!(
digest(changelog),
case["changelog_raw_sha256"],
"{probe:?} raw"
);
}
if let Ok(review) = &review {
assert_eq!(digest(review), case["review_raw_sha256"], "{probe:?} raw");
}
let outcomes = [
(format_report(&changelog), &case["changelog_sha256"]),
(
changelog.and_then(|text| format_report(&text)),
&case["changelog_sha256"],
),
(
review.and_then(|text| format_report(&text)),
&case["review_sha256"],
@@ -121,8 +128,9 @@ fn every_probe_is_formatted_as_the_typescript_or_refused() {
Err(other) => panic!("{probe:?}: {other}"),
}
}
let closer = case["reference_id"] == "probe_ref_";
assert!(
!(case_refused && equine_safe(probe)),
!(case_refused && equine_safe(probe) && !closer),
"{probe:?}: refused, yet made of what the equine reports use"
);
if case_refused {
@@ -137,6 +145,6 @@ fn every_probe_is_formatted_as_the_typescript_or_refused() {
"silent differences for {} probes: {silent:?}",
silent.len()
);
assert_eq!(same + refused, 782);
assert_eq!(same + refused, 790);
println!("{same} identical, {refused} refused");
}