feat(editor): four tabs, Annotations sections, references from the header
U1 Lot B1. Four tabs (Général, Annotations, Constats, Vérification); views,
categories and regions become full-width Annotations sections opened from the
overview panel; references move to a header-toggled panel (minimal, Lot D
completes it); « Aller à » goes through EditorTarget and the navigation hook.
EditorWorkspace owns the navigation; DraftHeader split in HeaderActions and
SaveLine; EditorTabs split in TabList and MoreTabs.
R-24, assertions removed or rewritten (file: old -> new):
unit
- editor-route.test: seven tab names -> four; « Plus » at 800 px with
Références clicked -> no « Plus »; below 640 px five others -> Général,
Constats, and Constats opens the findings tab; + references panel cases
- editor-route-recovery.test: tab Références + editor-tab-references label ->
header button + editor-references-panel labelled by its heading
- editor-mode.test: small tier `more` of five -> [general, findings]
- editor-focus-request.test: {key,serial} -> {target,serial}; ReferencesTab and
VertebraeTab -> ReferencesPanel and RegionsSection; issueTarget tab/key ->
target place/section/key (vertebrae tab -> annotations/regions); consumed
context (serial) -> (serial, outcome); annotation case adds heading focus
- editor-verification.test: onGoTo('annotations', key) -> navigate(targetOfKey
(key), opener); props onSelectTab/onGoTo -> navigate
- editor-annotations-tab.test: props onSelectTab -> navigate + section props;
no_category text « (onglet Général) » -> « (Annotations, section
Catégories) »
- editor-tabs-general.test: categories cases render GeneralTab ->
CategoriesSection(doc); + Général holds no categories editor
- editor-tabs-lists.test: tab imports -> panel and section; read-only
references « no button » -> only « Fermer les références »
- editor-tabs-views, editor-drawing-upload, editor-repair.test: ViewsTab ->
ViewsSection import, assertions kept; editor-findings.test: navigate prop
e2e
- support/editor selectTab: exact name -> pattern (error badge in the name);
+ place, openSection, showDrawing, backToDrawing, openReferences, TABS
- support/warm-up: seven tabs -> four + sections + references panel
- editor-access: seven-tab axe loops -> four tabs + three sections + panel
(edit and read-only); narrow widths add panel overflow and axe
- editor-drawings: tab Vues -> openSection views; tab Annotations ->
showDrawing
- editor-structures: tab Général (categories) -> openSection categories, axe
label « general tab » -> « categories section »; tab Références ->
openReferences/closeReferences; tab Vertèbres -> openSection regions; tab
Annotations -> showDrawing
- editor-geometry: three tab Vues -> openSection views
- editor-equine: tab Général (categories add) -> openSection categories; five
tabs loop -> two tabs + sections + panel; tab Annotations -> showDrawing
- editor-journey: tab Vues, tab Général (category), tab Annotations ->
openSection views/categories, showDrawing; frozen axe scrolls to the header
- lan/trial-lan (not run): tab Vues -> Annotations tab + views entry
Verified: typecheck, lint, vitest 107 files / 1125 tests, whole shell suite on
the sandbox 151 passed, 49 skipped, 0 failed.
This commit is contained in:
1 parent
95b1b7e461
commit
bc2dba7c14
56 files changed
+2419
-699
No files matched your search
@@ -4,6 +4,7 @@ import { cleanup, render, screen, within } from '@testing-library/react'
|
||||
import userEvent from '@testing-library/user-event'
|
||||
import type { AnatomicalSheetDocument } from '@faunosteo/core-wasm/types'
|
||||
import DeleteDialog from '@/components/editor/DeleteDialog'
|
||||
import CategoriesSection from '@/components/editor/general/CategoriesSection'
|
||||
import GeneralTab from '@/components/editor/tabs/GeneralTab'
|
||||
import { useLocaleStore } from '@/state/localeStore'
|
||||
import { edit, insert } from '../helpers/editorFixtures'
|
||||
@@ -24,7 +25,7 @@ vi.mock('@faunosteo/supabase', async (orig) => ({
|
||||
submitSheetReview: vi.fn(),
|
||||
}))
|
||||
|
||||
const props = { readOnly: false, onSelectTab: vi.fn(), reloadSheet: vi.fn() }
|
||||
const props = { readOnly: false, navigate: vi.fn(), reloadSheet: vi.fn() }
|
||||
const doc = (): AnatomicalSheetDocument =>
|
||||
JSON.parse(store.getState().documentText)
|
||||
|
||||
@@ -102,11 +103,17 @@ describe('Général: texts and attribution', () => {
|
||||
})
|
||||
})
|
||||
|
||||
describe('Général: annotation categories', () => {
|
||||
describe('Annotations, section Catégories', () => {
|
||||
it('Général no longer holds the categories editor', async () => {
|
||||
await openReady()
|
||||
render(<GeneralTab {...props} />)
|
||||
expect(screen.queryByText("Catégories d'annotation")).toBeNull()
|
||||
})
|
||||
|
||||
it('renames, recolours and adds a category', async () => {
|
||||
await openReady()
|
||||
const user = userEvent.setup()
|
||||
render(<GeneralTab {...props} />)
|
||||
render(<CategoriesSection doc={doc()} readOnly={false} />)
|
||||
const row = screen.getByLabelText('Nom de la catégorie (FR)', {
|
||||
selector: '#category-cat-a-name-fr',
|
||||
})
|
||||
@@ -140,7 +147,7 @@ describe('Général: annotation categories', () => {
|
||||
it('a new category needs both names', async () => {
|
||||
await openReady()
|
||||
const user = userEvent.setup()
|
||||
render(<GeneralTab {...props} />)
|
||||
render(<CategoriesSection doc={doc()} readOnly={false} />)
|
||||
await user.click(
|
||||
screen.getByRole('button', { name: 'Ajouter la catégorie' }),
|
||||
)
|
||||
@@ -151,7 +158,7 @@ describe('Général: annotation categories', () => {
|
||||
it('a used category cannot be deleted: the dialog lists the dependents', async () => {
|
||||
await openReady()
|
||||
const user = userEvent.setup()
|
||||
render(<GeneralTab {...props} />)
|
||||
render(<CategoriesSection doc={doc()} readOnly={false} />)
|
||||
await user.click(screen.getByRole('button', { name: 'Supprimer' }))
|
||||
const dialog = await screen.findByRole('dialog')
|
||||
expect(within(dialog).getByText(/utilise cette catégorie/)).toBeTruthy()
|
||||
@@ -171,7 +178,7 @@ describe('Général: annotation categories', () => {
|
||||
})
|
||||
await openReady({ text })
|
||||
const user = userEvent.setup()
|
||||
render(<GeneralTab {...props} />)
|
||||
render(<CategoriesSection doc={doc()} readOnly={false} />)
|
||||
const buttons = screen.getAllByRole('button', { name: 'Supprimer' })
|
||||
await user.click(buttons[1])
|
||||
const dialog = await screen.findByRole('dialog')
|
||||
|
||||
Reference in new issue
Block a user