docs(docs): record the R2 corrections and the admin.spec diagnosis

This commit is contained in:
bchanot committed 2026-11-13 14:19:55 +01:00
1 parent f7f0aa675d
commit b919cf8522
5 files changed
+91 -20

No files matched your search

+47 -1
View File
@@ -171,7 +171,7 @@ The criteria below are the contract as written.
### R2 — The Références tab (D1 to D4)
Status (2026-11-12): built on `feature/v1-2-anatomical-sheets`, awaiting the owner's validation (nothing merged,
Status (2026-11-13): corrected, still awaiting the owner's validation. Status (2026-11-12): built on `feature/v1-2-anatomical-sheets`, awaiting the owner's validation (nothing merged,
nothing deployed). Commits: `65a8fd3` (plan, rev 4 after the owner's GO), `fc3fec7` R2.0 (the panel's place renamed
`citations`), `4499bc7` R2.1 (fifth tab, panel from a finding), `c21995b` R2.2 (collapsible tiles), `3baac4d` R2.3
(search, sort, count, add), `8db6f42` R2.4 (contextual panel, board 25), `4b7d254` R2.5 (non-regression sweep), `2182307` (documentation),
@@ -207,6 +207,52 @@ Labels: `V1-2-6_R2_LABELS.md`. Decision record: BDR-114. What the build settled
without `editor-equine`: 219 passed, 116 skipped, 3 failed (all `admin.spec.ts`), full-row guard clean.
`editor-equine.spec.ts` was updated for typecheck and never run.
Corrections 2026-11-13 (owner brief), still awaiting the owner's validation (nothing merged, nothing deployed), on
top of `52aac41`:
- C1 `3303530`, `1e19479`: a refused draft is never dropped silently on a read-only flip. The tile in edit stays
shown through the flip, a drop is said once in the live region and shown in its tile, a forced close of the panel
names every refused field once, and the flip makes no history entry.
- C2 `d177992`, `c8109af`: « Annuler l'ajout » on the draft tile, and Escape from non-text targets and from a
pristine text field (never during IME composition). The document and undo/redo are untouched; the focus goes back
to « Ajouter une référence ». `c8109af` also hardened a flip unit test: happy-dom 20.10.6 holds MutationObserver
callbacks in a WeakRef, so a garbage collection under load stops the observation; the test now counts writes to
the live region.
- C3 `b1fd896`: a pinned tile that no longer matches the search shows « Ne correspond pas à la recherche » under
its header (`aria-describedby`). « Aucun résultat » shows only when no tile is shown (the add draft does not
count).
- C4 `969a5f3`, `817f74b`, `7766929`, `f7f0aa6` (test only): proof, no app code. At 667 × 375 with touch only, the
citations trigger sits at 811 to 855 px at scroll 0. Touch swipes (CDP `Input.dispatchTouchEvent`;
`Input.synthesizeScrollGesture` with `touch` scrolls nothing in this Chromium) bring its bottom 0 to 3 px above
the viewport bottom across runs (scrollY 480 to 483). A tap opens the panel, its heading and ✕ are in the
viewport and hit-testable, scrollY is unchanged (panel visible height about 319 px).
- New keys (provisional EN): `editor.references.add_cancel` fr « Annuler l'ajout », en « Cancel adding »;
`editor.references.outside_search` fr « Ne correspond pas à la recherche », en « Does not match the search ».
Rows in `V1-2-6_R2_LABELS.md`.
Limits kept after the corrections: undo, or a reload, that removes a reference whose tile holds a refused draft
drops that draft; undo/redo replacing a pending draft in a mounted view; two drops in one flip speak only the last;
the rotation to 667 × 375 with the panel open at scroll 0 keeps its cramped exception (not built, an option for the
owner). The add draft's cancel control, an open question above, is answered by C2.
`admin.spec.ts` diagnosis (C0, 2026-11-13, sandbox only, guard OK on every run, no grant pagination, no reset, no
deletion):
- `public.anatomical_catalog_grants` held 2 269 rows at the start (by day: 2026-11-08 234, 11-09 11, 11-12 1 896,
11-13 128), `auth.users` 2 871. Each run adds 25 grants and 25 accounts.
- Interleaved A/B, `admin.spec.ts` alone (24 listed, 8 workers): the pre-R2 worktree at `65a8fd3` (same lockfile)
against HEAD `52aac41`, four runs (abH1, abB1, abH2, abB2). Each gave 13 passed, 8 skipped, 3 failed, with the same
« Target crashed » inside `expectAccessible` (axe): A0 « the rights screen with grants » (`/app/admin/access`) in
one locale, « admin screens » desktop and 375 in one locale. Host memory stayed at 11.3 to 11.6 GiB available.
- Dose-response in a quiet window (no other Playwright run): a temporary copy of the spec routed
`list_catalog_grants` to its 753 newest rows. Capped (2 526 grants in base): 16 passed, 8 skipped, 0 failed. Full
(2 551): 11 passed, 8 skipped, 5 failed, 4 of them « Target crashed ». Capped again (2 570): 16 passed, 0 failed.
The temporary copy was deleted, never committed.
- Conclusion: the accumulation of e2e grants in the persistent sandbox causes the failures (the rights screen
renders every grant under axe). They are identical before R2 and on R2: not an R2 regression. Still failing on
the accumulated sandbox: A0 « the rights screen with grants » and « admin screens » (fr or en, desktop and 375,
the locale varies from run to run). The cure, a paginated grant list, belongs to RR-13; blocker BLK-015 stays open.
Original plan text:
- Tab model: `EDITOR_TABS` gains `references` between `findings` and `verification` (`apps/app/src/editor/tabs.ts:6-11`),