chore(editor): rev 5 review nits

Deterministic scroll-settle wait for the bubble e2e, useDismissal split,
precondition for the add-button focus test, CSS comment wrap.
This commit is contained in:
bchanot committed 2026-11-19 21:14:49 +01:00
1 parent a9252375e1
commit b5dcb766b1
4 files changed
+65 -26

No files matched your search

@@ -902,6 +902,11 @@ for (const viewport of VIEWPORTS) {
// scroll, never onto the bar or the strip, and the column stays below the strip.
await page.evaluate(() => window.scrollTo(0, 0))
const add = page.locator('[data-add-kind="point"]')
const unrevealed = (await add.boundingBox())!
expect(
unrevealed.y,
'precondition: the add button is below the fold',
).toBeGreaterThan(await page.evaluate(() => window.innerHeight))
await add.focus()
const revealed = await stripGeometry(page)
const addBox = (await add.boundingBox())!