chore(memory): R2 closure BDR-117, LRN-139..141, plan Rev 4, contract 19-25

This commit is contained in:
bchanot committed 2026-11-14 23:19:37 +01:00
1 parent be0f6d8beb
commit b41c24b29d
5 files changed
+94 -1

No files matched your search

@@ -199,7 +199,7 @@ Q: Plan rev 3 and choices 1-5 / A: approved by the owner 2026-11-13 (« je valid
13. [gated 2026-11-13] A changed « Enregistrer » in the finding or reference dialog is exactly ONE undoable operation (undo length +1, one Défaire restores the prior state); a pristine « Enregistrer » and every « Annuler » / « Abandonner » add none (unit + e2e).
14. [gated 2026-11-13] The citations sheet stacked over the finding dialog is fully usable by keyboard (Tab reaches every control, Escape closes the sheet only, focus returns to « X références ») and by touch (taps on its controls at 375 with hasTouch, the dialog underneath not activated) (e2e).
15. [gated 2026-11-13] Browser history entries hold navigation state only (tab, section, open layers by element key, references filter by finding key): no typed text, no search term, no draft; an entry restores only for the same sheet and the same signed-in account, otherwise the editor opens on its default view (unit: entry state shape and mismatch rules).
CHECK: cd /home/bchanot/Documents/faunosteo-v1-2/apps/app && f=src/editor/history/entry.ts && [ -f "$f" ] && grep -q "sheetId" "$f" && grep -q "userId" "$f" && ! grep -Eq "^\s*(query|draft|text|search)\??\s*:" src/editor/history/*.ts && echo HISTORY_SHAPE_OK
CHECK: cd /home/bchanot/Documents/faunosteo-v1-2/apps/app && f=src/editor/history/entry.ts && [ -f "$f" ] && grep -q "sheetId" "$f" && grep -q "tag" "$f" && ! grep -Eq "^\s*(query|draft|text|search)\??\s*:" src/editor/history/*.ts && echo HISTORY_SHAPE_OK
EXPECT: HISTORY_SHAPE_OK
EVIDENCE: MET exit=0 marker-found :: HISTORY_SHAPE_OK
16. [gated 2026-11-13] With the « Plus » menu open, the platform back request (CloseWatcher where the browser offers it) closes the menu before any navigation; without CloseWatcher the limit is stated (unit with a CloseWatcher stub).
@@ -210,3 +210,21 @@ Q: Plan rev 3 and choices 1-5 / A: approved by the owner 2026-11-13 (« je valid
apps/app/src/editor/** (navigation, history adapter, references view and filter), apps/app/src/components/editor/** (findings, references, citations, tabs, workspace, layers), apps/app/src/components/ui/{ModalDialog,Dialog}.tsx (only if a shared fix is needed), apps/app/src/components/shell/{ShellChrome,AppLayout}.tsx, apps/app/src/clients/useClientList.ts, apps/app/src/animals/useAnimalList.ts and their list routes (if the app-wide review keeps them), apps/app/src/i18n/{fr,en}.ts, apps/app/src/styles/** (only if needed), apps/app/tests/**, apps/app/e2e/{support,shell,ui}/**, docs/development/{V1-2-6_U1_CORRECTIONS,V1-2-6_OWNER_TRIAL,V1-2-6_R2_LABELS,BROWSER_TESTS,V1-2_ANATOMICAL_SHEETS}.md, docs/design/README.md, this contract, the plan, .claude/tasks/TODO.md, memory.
ORACLE AMENDMENT 2026-11-13 (controller): criterion 4 key renamed to the shipped key editor.references.filter_chip (chip « Références du constat : {name} »); criterion 15 path is src/editor/history/entry.ts (folder split in Task 1) and the forbidden-field scan covers every file of src/editor/history. Same assertions, no weakening.
## Owner trial 2026-11-14 (brief « Retour de mon essai propriétaire R2 »): additional criteria
19. [gated 2026-11-14] Finding view mode shows « Références citées » and « X références » only (no cite or remove control); edit mode adds and removes citations in the form draft; one changed « Enregistrer » = one undoable operation covering names and citations; the side sheet has no « Retirer de ce constat » (unit + e2e).
20. [gated 2026-11-14] After deleting a finding, the first « Défaire » restores it at once, selected, visible and focused; the first Back after a deletion has a visible effect (unit + e2e).
21. [gated 2026-11-14] Choosing a « Plus » entry by keyboard moves the focus to the new tab's panel (e2e at 375).
22. [gated 2026-11-14] History entries hold a random session tag, never an account id; accounts stay separated (tag bound to the account by a digest, rotated on sign-out and on mismatch); left-draft flag keyed by the tag (unit).
CHECK: cd /home/bchanot/Documents/faunosteo-v1-2/apps/app && ! grep -q "userId" src/editor/history/entry.ts && ! grep -q "userId" src/editor/leftDraft.ts && grep -q "tag" src/editor/history/entry.ts && echo SESSION_TAG_OK
EXPECT: SESSION_TAG_OK
EVIDENCE: MET SESSION_TAG_OK (controller 2026-11-14, rc 0; verifier rerun)
23. [gated 2026-11-14] With a dirty dialog, a multi-entry traversal leaving the editor asks « Abandonner les modifications ? » before anything is lost where the Navigation API can cancel it (Chromium, e2e via CDP history jump); elsewhere the after-the-fact notice stays (unit).
24. [gated 2026-11-14] R2 closure docs: validated status, limits accepted and lifted, a short list of final manual checks (incl. Android Back on a real phone, the leave confirmation, the fallback browsers).
25. [gated 2026-11-14] U2 orientation recorded in the U2 plan, the UX decisions and the design README (annotation property modals with direct manipulation kept; boards to redraw and validate before U2 code); U2 not started.
ORACLE AMENDMENT 2026-11-14 (controller): criterion 15 now reads « same sheet and same session tag » (owner decision 2026-11-14 replaces the account id); its oracle checks `sheetId` and `tag` instead of `userId`.
SCOPE AMENDMENT 2026-11-14 (controller): apps/app/src/app/providers/AuthProvider.tsx joins FILE SCOPE (Task 8: the session tag rotates on sign-out for the app lifetime; an editor-local subscription would miss a sign-out while the editor is unmounted).
SCOPE AMENDMENT 2026-11-14 (controller): docs/development/V1-2-6_UX_PLAN.md and V1-2-6_UX_DECISIONS.md join FILE SCOPE (required by criterion 25); CLAUDE.md folder map lines, useLeaveGuard.ts and components/ui/afterModalsClosed.ts accepted (helpers named by the plan).