fix(app): editor store keeps an unanswered copy across mode changes, refuses unsaved submit

This commit is contained in:
bchanot committed 2026-11-04 12:17:41 +01:00
1 parent 7f1d44065b
commit b14509f221
7 files changed
+102 -4

No files matched your search

+32
View File
@@ -332,3 +332,35 @@ describe('discard and submit', () => {
expect(store.getState().conflict).toEqual({ status: 'unknown' })
})
})
describe('guards', () => {
it('refuses a submit while the document differs from the saved text', async () => {
await openReady()
commitMove(40)
expect(await store.getState().submit()).toMatchObject({ ok: false, kind: 'unsaved' })
expect(sb.submitSheetReview).not.toHaveBeenCalled()
})
it('refuses a discard while a save is in flight', async () => {
await openReady()
commitMove(40)
sb.saveSheetDraft.mockReturnValue(deferred<unknown>().promise as never)
void store.getState().save()
expect(await store.getState().discardChanges({ confirmed: true })).toMatchObject({ kind: 'busy' })
expect(store.getState().unsaved).toBe(true)
})
it('drops a conflict read that lands after dismissal', async () => {
await openReady()
commitMove(40)
const late = deferred<unknown>()
sb.saveSheetDraft.mockRejectedValue(new SheetFailure('draft_conflict'))
sb.getOfficialSheetAdmin.mockReturnValue(late.promise as never)
const saving = store.getState().save()
await vi.waitFor(() => expect(store.getState().conflict).toEqual({ status: 'reading' }))
store.getState().dismissConflict()
late.resolve({ draft_version: { version_id: VERSION, version_number: 1, revision: 5 }, draft_last_save: null })
await saving
expect(store.getState().conflict).toBeNull()
})
})