chore(memory): R2 finish BDR-116, LRN-136..138, BLK-015 note, plan and contract

This commit is contained in:
bchanot committed 2026-11-13 23:59:39 +01:00
1 parent 3a7ffa2f8b
commit afc1051313
6 files changed
+469

No files matched your search

+12
View File
@@ -950,3 +950,15 @@ Limit: wording of this client version only.
**Context**: R2 « Terminer » below a field whose blur-commit is refused.
**Pattern**: mouse down blurs field → refusal line inserted → layout shifts → mouseup lands elsewhere → click lost (« Terminer » looks dead). Fix: `mousedown` preventDefault on the button (focus stays, button then runs the leave guard). Editor-wide general cure not done.
**Also (tests)**: happy-dom 20.10.6 holds MutationObserver callback in WeakRef → GC under load silently stops observation; count live-region announcements by wrapping textContent/nodeValue setters, restore in afterEach (c8109af, b1fd896). Touch e2e: CDP synthesizeScrollGesture touch scrolls nothing in Chromium 1248; dispatchTouchEvent swipes do, but slop floor ~60 px + load-dependent gain → pixel-exact touch landing not reproducible; prove reachability by touch, place worst case by programmatic scroll (78fb2d0).
## LRN-136 — Implementer gate claims need exit codes, controller reruns (2026-11-13)
Pattern: subagent implementer claimed typecheck/lint green while red (Task 2, 18085ce: missing import, readonly fixtures). Caught only when controller reran gates rounds later.
Apply: briefs demand real exit codes per gate; controller reruns typecheck + lint itself on every report before review. Never accept "green" without rc.
## LRN-137 — Template-built i18n keys escape typecheck (2026-11-13)
Pattern: i18n key built by template literal (t(`editor.findings.new.${kind}`)) escapes typecheck: Dict typed as string map, missing key renders raw. Found in final round: editor.findings.new.category absent in fr+en, title showed raw key.
Apply: every dynamic key site gets unit test asserting heading text has no 'editor.' prefix, or enumerate union kinds against both dicts in a test. Audit dynamic key sites in touched files at review.
## LRN-138 — Unblockable leave + no draft storage: content-free loss flag (2026-11-13)
Pattern: browser Back not interceptable (BDR-078) + owner forbids storing drafts + owner forbids silent loss. Resolution: on unmount with dirty dialog write one content-free flag (kind + element key, scoped sheetId+userId) to sessionStorage, try/catch; next mount of same sheet+user shows notice once, clears flag. Relies on React 19 parent-first cleanup on deletion.
Apply: any "cannot block leave, cannot keep data" conflict -> record the fact of loss, not the data, and tell user on return.