chore(memory): R2 finish BDR-116, LRN-136..138, BLK-015 note, plan and contract

This commit is contained in:
bchanot committed 2026-11-13 23:59:39 +01:00
1 parent 3a7ffa2f8b
commit afc1051313
6 files changed
+469

No files matched your search

+1
View File
@@ -124,3 +124,4 @@ Real cause: accumulation of e2e grants in persistent sandbox. Rights screen (/ap
Evidence: interleaved A/B admin.spec alone, pre-R2 worktree 65a8fd3 vs HEAD 52aac41, 4 runs all 13p/8s/3f same crashes → not an R2 regression. Dose-response quiet window (temp spec copy routing list_catalog_grants to 753 newest rows, deleted after): capped 16p/0f (2 526 grants), full 11p/5f 4 crashes (2 551), capped 16p/0f (2 570). Final sweep c6sweep2 221p/119s/5f all admin.spec; isolated 12p/8s/4f. Guard OK every run.
Solution: none applied (owner: no reset, no deletion of pre-existing data, pagination stays in RR-13). Rerun admin.spec alone only as diagnosis, never as gate. Close when RR-13 paginates grant list (or run-scoped fixture cleanup approved) and admin.spec green on sandbox.
Refs: `docs/development/BROWSER_TESTS.md` §6, `V1-2-6_U1_CORRECTIONS.md` §R2, BDR-115, LRN-133.
- **Status (2026-11-13)**: open: R2 finish 2026-11-13 sweep, admin.spec A0 + admin screens still Target crashed, same signature; shell chrome changed, no A/B cap rerun on this branch; pagination stays RR-13
+8
View File
@@ -955,3 +955,11 @@ Owner brief « R0 — Autorisation des trois dernières corrections graphiques
**Stated limits** (owner to ratify): undo/redo replacing pending draft in still-mounted view overwrites typed text silently; two drops in one flip speak only last (visible notes remain); full page reload out of scope (recovery copy rules); rotation cramped exception; admin.spec red on accumulated sandbox (BLK-015).
**Alternatives rejected**: close panel on read-only flip (loses context); drop slot in a store (StrictMode, scope) → tile-local; rotation auto-scroll (scope, offered); per-field error map in useEditCommand (every panel uses it).
**Refs**: plan `.claude/tasks/plans/2026-11-12-r2-references-tab-1730.md` rev 5/5b, contract criteria 15, 21-29, `docs/development/V1-2-6_U1_CORRECTIONS.md` §R2, BDR-114, BLK-015.
## BDR-116 — R2 finish: editor dialogs, view state in browser history, filter by finding (2026-11-13)
- **Status**: accepted
Context: owner R2 trial 2026-11-13, UX finish of sheet editor (plan .claude/tasks/plans/2026-11-13-r2-ux-finish-1624.md R2F-1..9, gate approved).
Decision: finding + reference add/edit/detail in D13 modal dialogs, transactional forms (one undo entry per changed save, BDR-050 amended for dialogs). Citations panel = modal side sheet over finding dialog (D2 kept: from finding only). Editor view layers (tab, section, dialog by element key, sheet, references filter by finding key) live in history.state via react-router navigate state (src/editor/history/{entry,useEditorHistory}.ts); never typed text, search, draft. Entry owned by sheetId+userId, foreign entry -> default view; reload drops forms; read-back allowlisted + length capped. « Tout afficher » filters by finding with removable chip (A3 amended). « Plus » = overlay dropdown, CloseWatcher closes it first (board 27 A amended). Sidebar sticky top-0 h-dvh. No new mockups: owner brief + gate = validation (docs/design/README.md addendum 2026-11-13). Clients/animals list searches NOT in history (BDR-078 stands).
Alternatives: URL params (rejected: leaks into links, A2), data router + useBlocker (rejected BDR-078), inline forms (owner asked modals).
Limits: delete replaces dialog entry (one dead Back); POP during pending Back can swallow a same-instant move; CloseWatcher stub-proved only; outside tap only closes « Plus »; multi-entry Back out of editor drops dirty dialog draft -> content-free sessionStorage flag, notice once on next mount (src/editor/leftDraft.ts).
Status: built, awaiting owner trial on db:trial. Commits 553a0e5..021685f on feature/v1-2-anatomical-sheets.
+1
View File
@@ -560,3 +560,4 @@ R5.4: `draft/{labels,changelog,review_report,drawing,overlay,app_review,svg_comp
## 2026-11-13
- R2 corrections 2026-11-13: C0 admin.spec diagnosis (A/B + dose-response, accumulation, BLK-015 open), C1-C5 + final review I1 + verifier gap fixed (3303530..538ce27), sweep 221p/5f admin.spec only, guard OK, verifier CONFORME; stopped at R2 checkpoint for db:trial trial.
- 2026-11-13 R2 UX finish built (553a0e5..021685f): dialogs, history Back/Forward, filter chip, Plus overlay, sticky sidebar; final review fixes; gates green, shell sweep fails only admin.spec (BLK-015); awaiting owner db:trial trial
+12
View File
@@ -950,3 +950,15 @@ Limit: wording of this client version only.
**Context**: R2 « Terminer » below a field whose blur-commit is refused.
**Pattern**: mouse down blurs field → refusal line inserted → layout shifts → mouseup lands elsewhere → click lost (« Terminer » looks dead). Fix: `mousedown` preventDefault on the button (focus stays, button then runs the leave guard). Editor-wide general cure not done.
**Also (tests)**: happy-dom 20.10.6 holds MutationObserver callback in WeakRef → GC under load silently stops observation; count live-region announcements by wrapping textContent/nodeValue setters, restore in afterEach (c8109af, b1fd896). Touch e2e: CDP synthesizeScrollGesture touch scrolls nothing in Chromium 1248; dispatchTouchEvent swipes do, but slop floor ~60 px + load-dependent gain → pixel-exact touch landing not reproducible; prove reachability by touch, place worst case by programmatic scroll (78fb2d0).
## LRN-136 — Implementer gate claims need exit codes, controller reruns (2026-11-13)
Pattern: subagent implementer claimed typecheck/lint green while red (Task 2, 18085ce: missing import, readonly fixtures). Caught only when controller reran gates rounds later.
Apply: briefs demand real exit codes per gate; controller reruns typecheck + lint itself on every report before review. Never accept "green" without rc.
## LRN-137 — Template-built i18n keys escape typecheck (2026-11-13)
Pattern: i18n key built by template literal (t(`editor.findings.new.${kind}`)) escapes typecheck: Dict typed as string map, missing key renders raw. Found in final round: editor.findings.new.category absent in fr+en, title showed raw key.
Apply: every dynamic key site gets unit test asserting heading text has no 'editor.' prefix, or enumerate union kinds against both dicts in a test. Audit dynamic key sites in touched files at review.
## LRN-138 — Unblockable leave + no draft storage: content-free loss flag (2026-11-13)
Pattern: browser Back not interceptable (BDR-078) + owner forbids storing drafts + owner forbids silent loss. Resolution: on unmount with dirty dialog write one content-free flag (kind + element key, scoped sheetId+userId) to sessionStorage, try/catch; next mount of same sheet+user shows notice once, clears flag. Relies on React 19 parent-first cleanup on deletion.
Apply: any "cannot block leave, cannot keep data" conflict -> record the fact of loss, not the data, and tell user on return.