fix(anatomy): V1-2.2 read url() references in their strict spelling only

Security review BLOCK(1): url(#%61) passed the dangling check and the
per-view scoping and resolved in browsers. One strict reading now, other
spellings are active content; glued names are other functions; the
composer refuses an unscoped reference; owner export procedure.
This commit is contained in:
bchanot committed 2026-10-29 16:49:15 +01:00
1 parent 5281337412
commit a678faaa23
13 files changed
+553 -70

No files matched your search

+16 -3
View File
@@ -1220,6 +1220,9 @@ supplied; they are not invented.
deletion is offered in level 1. An `insert` or `update` that names an
element absent from the document stays allowed (left to the validation
panel), as does a document saved with gaps: the verdict refuses them.
Structural rules that name nothing (`view.unreachable` after the last link
to a view goes, `view.main.count` after the main view goes) are left to
the validation panel too.
- Ids are generated by the page (`<prefix>-<10 lowercase base32
characters>`, alphabet `a-z2-7`, inside the stable-id rule), passed to the
core, never derived from labels, never editable, never reused.
@@ -1363,7 +1366,12 @@ The page reads the file with the core SVG reader before anything is stored.
so a new form is a new sha256, a new row and a new object.
- Local references (owner decision 2026-10-29): every `href="#id"`,
`xlink:href="#id"` and `url(#id)` must name an id the drawing itself
defines; a reference to an absent id is a hard rejection
defines, and a `url(` is a local reference only in its strict spelling
(CSS whitespace, an optional quote, `#`, an id in the reference grammar,
the same quote, CSS whitespace, `)`): `url(#%61)`, a tab, a space or an
unbalanced quote inside, an empty or non-ASCII id are active content and
refuse the file, since a browser normalises them (security review of the
checkpoint); a reference to an absent id is a hard rejection
(`dangling_reference`) for the reader of stored drawings, the cleaning
(after active content is classified, so a hostile file is still named as
such), the verdict and the preview. Valid internal references keep working.
@@ -1371,7 +1379,8 @@ The page reads the file with the core SVG reader before anything is stored.
keep the strict colour functions cairo writes, lowercase `rgb(` with three
and `rgba(` with four components, all bare numbers up to 255 or all
percentages up to 100, an alpha up to 1 or 100 %, commas, CSS whitespace,
nothing glued before the name. Every other function (`url(` outside the
nothing glued before the name (a non-ASCII letter included) and nothing
after the `)` but the end, a space, `;`, `,` or `!`. Every other function (`url(` outside the
document, `expression(`, `var(`, `hsl(`, an escaped name, an uppercase
name…) is removed or refused as before; scripts and active CSS stay
refused.
@@ -1477,7 +1486,11 @@ A drawing never blocks authoring: only the round waits for its verdict.
transformation runs at composition only: stored bytes, their sha256, the
published versions, the archive snapshot and the PDF views (each rasterised
as a document of its own) keep the drawing's ids. Composition is
deterministic and applied once per call. A drawing outside the stored form
deterministic and applied once per call; the composer refuses a canvas
that would keep a reference outside its scope (`unscoped_reference`).
The scope is unique within one document only: a page that inlines
canvases of two documents at once (two versions or two sheets side by
side) adds a per-document prefix first. A drawing outside the stored form
(§9.2) shows `rejected` with `not_canonical` and draws nothing, as the
verdict refuses it.
- `LoadedSheet` (the report editor's sheet) keeps its mandatory migration map;