chore(memory): BDR-103, LRN-119, U2b decisions contract and TODO
This commit is contained in:
1 parent
604f502b44
commit
a43145a03f
5 files changed
+183
-1
No files matched your search
@@ -681,7 +681,7 @@ Order (BDR-071): P0 docs + decisions → V1-1 clients and animals → V1-2 sheet
|
||||
- [x] static audits (core model, rendering/PDF/N-1, geometry/wasm, SQL/worker, editor/tests) · [x] docs/development V1-2-6_UX_{PLAN,COMPATIBILITY,TESTS,RISKS,DECISIONS}.md (sub-steps U0-U9, decisions T1-T19) · [x] independent review (3 lenses: CONCERNS 5/9/6, no BLOCKER) + fixes integrated (plan §6) · [x] commit + push branch · [x] owner answers 2026-11-05 (brief « V1-2.6 UX — Ratification des décisions techniques », BDR-100): T11 approved, T16 conditional deferral (curves lot), T2/T3 conditional on proofs, T4 no residual gap, T5 history preserved, T9 three actions, T10 navigation type, T12 principle · [x] five docs updated (decisions, compatibility §0/§7/§8, tests, risks + blocking criteria, plan §7) · [x] LRN-118 (wasm measuring rule) · [x] independent reviews: correctness challenger CONCERNS(5 MAJOR, 7 MINOR) integrated; verifier ECARTS(2) fixed; targeted re-check ECARTS(2) (one U6 test assumed permissive save, deploy order said all rounds) fixed · [x] third independent check before commit (2026-11-05): ECARTS(2) on K10/K11 (R-3 mitigation, U6 objective on older T4 scope, write-lock test assumed stripping save, T16 count scope in two forms) fixed · [x] fresh targeted re-check: CONFORME 12/12 (G1-G4 closed; 7 observations kept for U0) · [x] commit + push · [x] owner answers 2026-11-05 (brief « Autorisation U0 uniquement », BDR-101): T4 both SQL checks approved (O22 amended), T5 defaults, T10 option B, T15, T16 count before activation, « Remplacer par un polygone » explicit · [x] T17 answered 2026-11-06 (BDR-102) · [ ] still open: T12 text (before U7), T6 (V1-2.8), T14 follow-up; T1 only if a measure exceeds · [x] owner authorisation to start U0 (2026-11-05)
|
||||
- [ ] V1-2.6 UX U0, contract and decisions, docs only (contract `.claude/tasks/contracts/2026-11-05-v1-2-6-ux-u0.md`; no code, no SQL, no DEV, no U1): [x] V1-2 contract §6.2, §6.4, §6.7, §7.4, §8.2-§8.4, §12.2 + §17.1 (O22), §16.7, §16.12, §17.12 · [x] level-1 contract C3, C4, C5, C6, C7, C8, C11, C13, C16, C18, C20, C25, C28, C32, C33, C40, with the precedence rule of its header · [x] docs/design/README.md · [x] rules sheet-model.md, schemas.md · [x] five UX docs · [x] BDR-101 · [x] preconditions (r5:import-equine --check clean, seed 22/6/0 paths, wasm 592 143 B) · [x] independent verification: ECARTS x6 fixed, then CONFORME 12/12 (2026-11-06); open points for U2/U6 not in docs: point edge-size handle (boards 02/03), default laterality of the automatic access (U6), §15 replay text vs the category.fixed.* filter · [x] commit + push · [x] owner U0 checkpoint (approved for good in the brief « Autorisation de U1 uniquement », 2026-11-06)
|
||||
- [ ] V1-2.6 UX U1, editor shell (brief « Autorisation de U1 uniquement » + « U1 — Validation de la conception interne », approach A; contract `.claude/tasks/contracts/2026-11-06-v1-2-6-ux-u1-1123.md`; plan `.claude/tasks/plans/2026-11-06-v1-2-6-ux-u1.md`, lots A, B1, B2, C-I; no Rust/SQL/worker/scripts, no DEV, no merge, no U2): [x] design approach A validated by the owner with 10 precisions · [x] owner choices 2026-11-06 (server save time, non-modal references panel, citation button in the finding's detail, board 01 annotation card) · [x] plan written + three-lens challenge (correctness CONCERNS 6, robustness CONCERNS 5, simplicity CONCERNS 2, no BLOCKER) integrated · [ ] owner plan checkpoint · [ ] lots A-I · [ ] gates, verifier, security · [ ] owner U1 checkpoint
|
||||
- [ ] V1-2.6 UX complement « annotations ↔ constats » (owner brief 2026-11-06 « Nouvelle exigence UX : navigation bidirectionnelle »; contract `.claude/tasks/contracts/2026-11-06-v1-2-6-findings-nav-design.md`; design only, U1 plan untouched, no code, no DEV): [x] relations audit (one link `finding_zone_id`, no new association, equine draft 1:1) · [x] boards 17-22 `docs/design/v1-2-6-constats/` · [x] study `docs/development/V1-2-6_UX_FINDINGS_NAV.md` (no U1 integration point needed, sub-step U2b proposed, risks, tests, decisions F1-F21) · [x] fresh design review APPROVE WITH FIXES (3 MUST-FIX, 16 SHOULD), fixes applied · [x] fresh verifier ECARTS(4) → ECARTS(2) → CONFORME 9/9 (round 3) · [ ] owner validation of the complement (then F1-F21)
|
||||
- [ ] V1-2.6 UX complement « annotations ↔ constats » (owner brief 2026-11-06 « Nouvelle exigence UX : navigation bidirectionnelle »; contract `.claude/tasks/contracts/2026-11-06-v1-2-6-findings-nav-design.md`; design only, U1 plan untouched, no code, no DEV): [x] relations audit (one link `finding_zone_id`, no new association, equine draft 1:1) · [x] boards 17-22 `docs/design/v1-2-6-constats/` · [x] study `docs/development/V1-2-6_UX_FINDINGS_NAV.md` (no U1 integration point needed, sub-step U2b proposed, risks, tests, decisions F1-F21) · [x] fresh design review APPROVE WITH FIXES (3 MUST-FIX, 16 SHOULD), fixes applied · [x] fresh verifier ECARTS(4) → ECARTS(2) → CONFORME 9/9 (round 3; 567da67 came after it, not covered) · [x] owner principle validation 2026-11-06 (brief « Validation de principe U2b et préparation des checkpoints », BDR-103): U2b retained after U2 and before U3, F1/F2/F6/F8/F22 approved, F7 for the term « Famille », F3/F4 in part · [x] decisions F1-F22 table (alternatives, consequences, state), F2 groups vs leaves, F3 field list, F4 view semantics, boards with their decisions in study §7.4, U2b entry in `V1-2-6_UX_PLAN.md` §3, LRN-119 (`<Activity>`), contract `.claude/tasks/contracts/2026-11-06-v1-2-6-findings-nav-decisions.md` · [x] fresh verifier on that contract: ECARTS(9) → fixed → CONFORME 11/11 (6 observations outside criteria kept for the owner) · [ ] owner: F2 groups, F3 fields, F4 view model, F5, F9-F21 · [ ] U2b authorisation (after U2)
|
||||
- [ ] follow-up candidates (owner T14): multi-tab notice; RR item for the rollback limit of the category model (new id, reconcile with develop)
|
||||
- [ ] curves lot (ex-U9, owner T16 2026-11-05): curve handle editing, curved zone move, path remap, path point correction; spec `V1-2-6_UX_PLAN.md` §2 D, tests `V1-2-6_UX_TESTS.md` « Curves lot ». Rule: no feature that lets a path enter a document (package import, zones from the drawing's shapes, a curve drawing tool) ships before or without it. Before the new model is activated on an environment, and before U6 or U8 reaches any environment beyond the throwaway sandbox: read-only count of path geometries in its drafts and published versions (sandbox by U6 itself; DEV and shared environments by the owner or under explicit authorisation; non-zero reopens T16)
|
||||
- [ ] MANDATORY before merging V1-2 into develop (owner 2026-11-03): registry id reconciliation. LRN-095 collides: develop 09655b2 « Port a safe runner verbatim… » (2026-11-02) vs V1-2 « pgTAP across PGlite and the real Supabase image… » (2026-10-28, cited by BDR-084 and the V1-2.1 TODO lines). BLK-013 exists on develop only (« e2e:avatar on develop reached DEV »): `memory.sh` on V1-2 would hand out BLK-013 again, so a V1-2 blocker needs its id checked against develop first. Same for the TODO release-readiness ids: RR-11 is develop's (« sandbox-only e2e follow-ups »), V1-2 uses RR-12. No renumbering during V1-2.6 unless needed; renumber one side and patch its citers at the merge
|
||||
|
||||
@@ -0,0 +1,154 @@
|
||||
# CONTRACT — v1-2-6-findings-nav-decisions
|
||||
- date: 2026-11-06 | flow: design checkpoint preparation (docs only) | branch: feature/v1-2-anatomical-sheets
|
||||
- status: active
|
||||
- worktree: /home/bchanot/Documents/faunosteo-v1-2 (every command from this absolute path; never DEV: the
|
||||
`supabase_*_faunosteo` containers are DEV; no sandbox needed)
|
||||
- base: 567da67 (complement after the verifier's CONFORME 9/9, trigger name per the core). Commit in place, push; no
|
||||
merge, no `gitflow.sh finish`.
|
||||
- context: follows `.claude/tasks/contracts/2026-11-06-v1-2-6-findings-nav-design.md` (complement design, verdict
|
||||
CONFORME 9/9 on round 3, before 567da67). The U1 plan and contract stay as committed at 2e46c14.
|
||||
|
||||
## REQUEST (verbatim — IMMUTABLE)
|
||||
|
||||
# FAUNOSTEO — Validation de principe U2b et préparation des checkpoints
|
||||
|
||||
Le propriétaire approuve le principe de la navigation bidirectionnelle entre annotations et constats.
|
||||
|
||||
## 1. Placement
|
||||
|
||||
Retenir une sous-étape U2b « Annotations et constats », après U2 et avant U3, avec son propre contrat, ses tests et son checkpoint.
|
||||
|
||||
Ne pas modifier le plan U1 si les points d'intégration déjà prévus suffisent réellement.
|
||||
|
||||
Ne pas commencer l'implémentation de U2b.
|
||||
|
||||
## 2. Décisions enregistrables
|
||||
|
||||
F1 : placement U2b approuvé.
|
||||
|
||||
F2 : les compteurs portent sur les constats réels à toute profondeur, sans compter les conteneurs de familles et sans doublonner les constats associés à une même zone par plusieurs annotations.
|
||||
|
||||
F3 : recherche instantanée, insensible aux accents et à la casse. La liste exacte des champs recherchés doit être présentée avant ratification complète.
|
||||
|
||||
F4 : filtres texte et anatomiques combinés par intersection ; plusieurs zones anatomiques sélectionnées produisent une union sans doublon. Présenter la sémantique complète du filtre par vues avant ratification.
|
||||
|
||||
F6 : sous 1 024 px, consultation et filtres par liste, aucune édition graphique.
|
||||
|
||||
F7 : « Famille » désigne les familles de constats, distinctes des catégories anatomiques.
|
||||
|
||||
F8 : l'association d'une annotation dépourvue de zone passe par une opération logique atomique, validée et annulable, sans doublon silencieux.
|
||||
|
||||
Lorsqu'une annotation est sélectionnée et que l'utilisateur ajoute un constat, préselectionner sa zone de rattachement. Ne pas imposer une seconde sélection inutile.
|
||||
|
||||
## 3. Décisions non encore ratifiées
|
||||
|
||||
Préparer une table complète F1 à F21, reproduisant pour chacune :
|
||||
- Le libellé exact.
|
||||
- Les alternatives.
|
||||
- La recommandation.
|
||||
- Les conséquences techniques.
|
||||
- L'état : approuvé, partiellement approuvé ou à décider.
|
||||
|
||||
Ne pas convertir automatiquement les recommandations F5 et F9 à F21 en décisions du propriétaire.
|
||||
|
||||
## 4. Apprentissage React
|
||||
|
||||
Ajouter au registre d'apprentissages la distinction entre la conservation de l'état et la remise en route des effets avec React 19.2 `<Activity>`.
|
||||
|
||||
Documenter l'impact possible sur useFraming et FindingTree.
|
||||
|
||||
Ne pas généraliser l'interdiction de `<Activity>`.
|
||||
|
||||
## 5. Complément graphique
|
||||
|
||||
Conserver les six planches 17 à 22 comme proposition de conception U2b.
|
||||
|
||||
Fournir un moyen simple de les revoir avec les décisions F1 à F21.
|
||||
|
||||
Ne pas déclarer une nouvelle conformité indépendante après les modifications effectuées postérieurement au verdict CONFORME 9/9 sans vérification supplémentaire.
|
||||
|
||||
## 6. Plan U1
|
||||
|
||||
Préserver le plan U1 existant au commit 2e46c14.
|
||||
|
||||
Présenter son bilan de conception et les résultats des trois relecteurs indépendants, avec les éventuels blocages restants.
|
||||
|
||||
Ne pas engager l'implémentation U1 avant le checkpoint d'autorisation correspondant.
|
||||
|
||||
## 7. Restrictions
|
||||
|
||||
Documentation et conception uniquement pour cette intervention.
|
||||
|
||||
Aucune modification applicative, Rust, SQL ou worker.
|
||||
|
||||
Aucune opération sur Supabase DEV.
|
||||
|
||||
Aucune fusion, aucun déploiement et aucun début de V1-2.7.
|
||||
|
||||
S'arrêter au prochain checkpoint documentaire.
|
||||
|
||||
## CLARIFICATIONS
|
||||
(none; owner questions stay in the study's section 7)
|
||||
|
||||
## ACCEPTANCE CRITERIA
|
||||
1. Placement (request 1): `docs/development/V1-2-6_UX_PLAN.md` §3 lists a sub-step « U2b · Annotations et constats »
|
||||
between U2 and U3, stating its own contract, tests and owner checkpoint, that it starts only on a new owner
|
||||
authorisation, and pointing to the study; the study's section 4 records F1 as approved; the study's section 3
|
||||
re-checks, with line references to the U1 plan, that the integration points already planned suffice, and proposes
|
||||
no U1 amendment.
|
||||
CHECK: cd /home/bchanot/Documents/faunosteo-v1-2 && grep -q "^### U2b · Annotations et constats" docs/development/V1-2-6_UX_PLAN.md && awk '/^### U2 ·/{a=NR} /^### U2b ·/{b=NR} /^### U3 ·/{c=NR} END{exit !(a<b && b<c)}' docs/development/V1-2-6_UX_PLAN.md && echo U2B_PLACED
|
||||
EXPECT: U2B_PLACED
|
||||
EVIDENCE: MET exit=0 marker-found :: U2B_PLACED
|
||||
2. U1 preserved (request 6): the U1 plan and contract are byte-identical to 2e46c14, in the commits and in the
|
||||
working tree.
|
||||
CHECK: cd /home/bchanot/Documents/faunosteo-v1-2 && git diff --quiet 2e46c14 -- .claude/tasks/plans/2026-11-06-v1-2-6-ux-u1.md .claude/tasks/contracts/2026-11-06-v1-2-6-ux-u1-1123.md && echo U1_UNCHANGED
|
||||
EXPECT: U1_UNCHANGED
|
||||
EVIDENCE: MET exit=0 marker-found :: U1_UNCHANGED
|
||||
3. Decision table (request 3): the study's section 7 holds one row per decision F1 to F21, each with the question as
|
||||
the study worded it, the alternatives, the recommendation, the technical consequences and a state among
|
||||
« approved », « partially approved », « to decide »; F1, F2, F6, F8 approved and F7 approved for the term
|
||||
« Famille », with the owner's sentence quoted verbatim; F3 and F4 partially approved, with the approved part quoted
|
||||
and the part left to ratify named; F5 and F9 to F21 « to decide »; the owner's sentence on the preselected zone is
|
||||
recorded verbatim as an approved decision; every recommendation changed since commit 567da67 is flagged as changed.
|
||||
4. F2 precision: the study flags that « constats réels » may exclude intermediate group nodes, gives both counts on
|
||||
the equine draft (all nodes and leaves only: total, grasset, the boards' searches), cites the practitioner picker
|
||||
rule (only leaves are ticked) and leaves the choice to the owner.
|
||||
5. F3 field list (request 2): the study lists every text field of zones, families and findings, plus descriptions,
|
||||
references, ids, annotation names, kind labels, review status and the vet flag, each with searched or not
|
||||
(recommendation), its alternative and its effect on the equine draft computed from `document.json`; it states the
|
||||
normalisation, the word rule and the language rule.
|
||||
6. F4 semantics (request 2): the study states the complete semantics of the view filter: what the state holds, what
|
||||
chosen views do with and without picked annotations, picks across views, deselecting a view, detail triggers,
|
||||
annotations without zone, a zone shown by several annotations, combination with the text, partial clears, the
|
||||
keyboard and narrow lists, document changes (undo), read-only modes; with at least one alternative model and
|
||||
examples computed from the equine draft.
|
||||
7. Learning (request 4): a learnings entry written through `memory.sh` distinguishes state kept from effects re-run
|
||||
under `<Activity>` (React 19.2), names `useFraming.ts:69` and `FindingTree.tsx:31-33` with their impact, and does
|
||||
not forbid `<Activity>` in general.
|
||||
8. Boards (request 5): the PNG boards 17 to 22 and the contact sheet are byte-identical to 567da67; the study's
|
||||
section 7.4 shows the six boards (Markdown images, any preview) each with the ids of the decisions whose « Boards »
|
||||
column names it, consistent with that column, and no second copy of the decisions' content (amended 2026-11-06
|
||||
before verification: a generated HTML page needed a script, refused outside a skill run); `REVUE.md` says the
|
||||
CONFORME 9/9 verdict predates 567da67 and does not cover it, and claims no conformity for this intervention
|
||||
beyond the verdict of criterion 11.
|
||||
CHECK: cd /home/bchanot/Documents/faunosteo-v1-2 && git diff --quiet 567da67 -- 'docs/design/v1-2-6-constats/*.png' && echo BOARDS_UNCHANGED
|
||||
EXPECT: BOARDS_UNCHANGED
|
||||
EVIDENCE: MET exit=0 marker-found :: BOARDS_UNCHANGED
|
||||
9. Registries: the owner's approved decisions recorded in one decisions entry (no recommendation recorded as
|
||||
decided), a journal line, the TODO line of the complement updated; all through `memory.sh` except TODO.md.
|
||||
10. Constraints (request 7): no change under `apps/`, `crates/`, `supabase/`, `packages/`, `scripts/`,
|
||||
`docs/design/v1-2-6/`; untracked review files never staged; no DEV, no merge, no V1-2.7.
|
||||
CHECK: cd /home/bchanot/Documents/faunosteo-v1-2 && git diff --quiet 567da67 -- apps crates supabase packages scripts docs/design/v1-2-6 && ! git ls-files --error-unmatch faunosteo-v1-2-6-revue-ux-chatgpt.md >/dev/null 2>&1 && echo FD_SCOPE_OK
|
||||
EXPECT: FD_SCOPE_OK
|
||||
EVIDENCE: MET exit=0 marker-found :: FD_SCOPE_OK
|
||||
11. A fresh independent verifier against this contract, covering the 567da67 delta (board 19 C trigger name, F7
|
||||
citation, REVUE text) and this intervention; justified gaps fixed; exact verdict reported. STOP at the
|
||||
documentary checkpoint.
|
||||
|
||||
## FILE SCOPE
|
||||
- docs/development/V1-2-6_UX_FINDINGS_NAV.md, docs/development/V1-2-6_UX_PLAN.md (U2b entry and order line),
|
||||
docs/development/V1-2-6_UX_DECISIONS.md (one pointer line)
|
||||
- docs/design/v1-2-6-constats/REVUE.md, docs/design/README.md (the complement's pointer line)
|
||||
- .claude/tasks/TODO.md, this contract, .claude/memory (through memory.sh)
|
||||
- NOT in scope: apps/**, crates/**, supabase/**, packages/**, scripts/**, docs/design/v1-2-6/**, the PNG boards, the
|
||||
U1 plan and contract, the V1-1 checkout
|
||||
Reference in new issue
Block a user