chore(memory): BDR-103, LRN-119, U2b decisions contract and TODO
This commit is contained in:
1 parent
604f502b44
commit
a43145a03f
5 files changed
+183
-1
No files matched your search
@@ -818,3 +818,20 @@ Effect: U1 relocates existing level-1 regions editor into Annotations as that fa
|
||||
**Rationale**: board 09 path needs role; working copy and pre-U6 drafts have none; one place to edit regions avoids divergence.
|
||||
**Alternatives**: regions only from category (blocks equine copy until V1-2.8, rejected); permanent separate tab (duplicate, rejected by four-tab shell).
|
||||
**Open**: none on T17. Recorded in DECISIONS T17, contract §17.12, PLAN U6, TESTS U6, TODO.
|
||||
|
||||
## BDR-103 — V1-2.6 U2b principle approved: F1, F2, F6, F8, F22 decided, F7 term Famille, F3/F4 partial, F5 + F9-F21 open (2026-11-06)
|
||||
- **Status**: accepted
|
||||
**Decision**: owner brief « Validation de principe U2b et préparation des checkpoints » (2026-11-06) approves principle of bidirectional annotations ↔ findings navigation. Owner decisions only (recommendations not recorded as decided):
|
||||
- F1: sub-step U2b « Annotations et constats » after U2, before U3; own contract, tests, checkpoint. Not started; needs own authorisation.
|
||||
- F2: counters = real findings at any depth, families not counted, a zone named by several annotations counted once. Open: intermediate groups counted or not (study 7.1; boards count them: grasset 29 nodes vs 25 leaves; draft 730 vs 627).
|
||||
- F3 partial: instant search, accent- and case-insensitive. Field list, word rule, language rule to ratify (study 7.2).
|
||||
- F4 partial: text ∩ drawing; several picked zones = union, no duplicate. View semantics to ratify (study 7.3: model A facets, recommended; model B picks only).
|
||||
- F6: below 1 024 px consultation + list filters, no graphical editing.
|
||||
- F7 (term only): « Famille » = finding families, distinct from annotation categories. Other labels of F7 stay C44 proposals.
|
||||
- F8: annotation without zone gets one through one atomic, core-validated, undoable operation, no silent duplicate (`commitBatch`, one undo entry; duplicate-name notice = proposed reading, confirm in U2b contract).
|
||||
- F22: finding added from a selected annotation takes that annotation's zone; no second zone choice (board 18 A).
|
||||
Not decided: F5, F9-F21. U1 plan at 2e46c14 untouched: integration points re-checked, enough.
|
||||
**Rationale**: U2 rewrites selection/pointer/keyboard model of same canvas + `PropertiesPanel` → U2b after it; U3-U6 never touch zone link or findings tree. No core op, no document change (request C: `finding_zone_id` already links annotation → zone).
|
||||
**Alternatives**: U2b after U6 (less `AnnotationFields` rework, later delivery); inside U2 (too large). « Catégorie de constats » kept (clashes with annotation « Catégorie »).
|
||||
**Open**: F2 groups, F3 fields, F4 view model, F5, F9-F21. Recorded in `V1-2-6_UX_FINDINGS_NAV.md` §7, `V1-2-6_UX_PLAN.md` §3 U2b, contract `2026-11-06-v1-2-6-findings-nav-decisions.md`.
|
||||
- **Status (2026-11-06)**: accepted, corrected 2026-11-06 after fresh verifier: F22 decision = owner sentence only (« préselectionner sa zone de rattachement. Ne pas imposer une seconde sélection inutile. »); form variant open: fixed zone (board 18 A) or preselected changeable field (literal reading). F8 decision = owner wording (« opération logique atomique, validée et annulable, sans doublon silencieux »); core validation via commitBatch, one undo entry, duplicate-name notice = study's proposed means, confirm in U2b contract.
|
||||
@@ -535,3 +535,4 @@ R5.4: `draft/{labels,changelog,review_report,drawing,overlay,app_review,svg_comp
|
||||
|
||||
## 2026-11-06
|
||||
- V1-2.6 U0 (docs only, BDR-101): V1-2 contract §6.2/§6.4 (draft rounds)/§6.7/§7.4/§8.2-8.4/§12.2 O22 (save + approval/publication fixed-category checks, not built)/§16.7/§16.12/§17.12; level-1 C3-C40 notes; design README v1-2-6 validated; rules sheet-model/schemas; 5 UX docs. T17, T12, T6, T14, T1 open. Verifier ECARTS(1) x2 fixed. No code, no DEV.
|
||||
- V1-2.6 U2b principle approved by owner (BDR-103): U2b after U2; F1/F2/F6/F8/F22 decided, F7 term, F3/F4 partial; study §7 table F1-F22 with alternatives + consequences, F2 groups open (730 vs 627 leaves), F3 fields, F4 facet model; LRN-119 Activity. U1 plan 2e46c14 untouched. Docs only, no DEV.
|
||||
@@ -807,3 +807,13 @@ Observation, not a routine: worktree held uncommitted format-only Prettier chang
|
||||
- **Reference**: 592 143 B of 600 000 B → margin 7 857 B (raw 1 569 864 B; pkg built 2026-11-04 after last core change `bbab0e6`; re-measured 2026-11-05 with same call, same figure).
|
||||
- **Rule**: margin = same call, same params (`level: 9`), same `pkg` file as gate. No system gzip substitute: results differ. Measure after every core change (each new op). Never raise ceiling silently: raise = explicit owner decision (D-R13) on measured figure.
|
||||
- **How**: after `pnpm wasm:build`, run size test (prints figure) or `node -e` with `zlib.gzipSync(buf, {level: 9})` on that file.
|
||||
|
||||
## LRN-119 — React 19.2 Activity keeps state but re-runs effects on reveal: audit one-shot mount effects, no general ban (2026-11-06)
|
||||
- **Context**: V1-2.6 U1 plan (2e46c14) chose kept-mounted `hidden` wrappers over React 19.2 `<Activity>` for tab places; owner asked distinction recorded, no general ban (2026-11-06).
|
||||
- **Fact (react.dev/reference/react/Activity, checked 2026-11-06)**: `mode="hidden"` keeps state, refs and DOM (`display: none`) but destroys Effects (cleanups run); reveal re-creates them (setups run again). Conceptually hidden = unmounted with saved state. Hidden children still re-render on prop changes, at lower priority.
|
||||
- **Trap**: state kept ≠ effects quiet. Effect that does one-shot action on mount re-fires at each reveal:
|
||||
- `apps/app/src/catalogue/useFraming.ts:69` `useEffect(() => setFraming(FIT), [resetKey])` → zoom and pan reset at each return, though framing state was kept.
|
||||
- `apps/app/src/components/editor/findings/FindingTree.tsx:31-33` `useEffect(() => focus(focusId), [focusId])` → stale `focusId` re-focuses tree item at each return (steals focus).
|
||||
- **Rule**: before wrapping subtree in `<Activity>`, audit its effects. Idempotent on re-run (subscriptions, listeners, measures with cleanup) → fine. One-shot on mount (reset, focus, scroll, fetch, write) → make reveal-safe (apply once per key via ref, consume one-shot request) or keep `hidden` wrapper. `hidden` wrapper: no effect runs on switch, but hidden places re-render at normal priority (U1 plan §2 cost control). `<Activity>` stays allowed where audit passes.
|
||||
- **Future application**: U1 makes `focusId` one-shot and bans focus in mount effects; U2b search, filter panel, drawing in filter panel (`useFraming` reuse) follow same rule, so a later move to `<Activity>` stays possible.
|
||||
- **Status (2026-11-06)**: correct, amended 2026-11-06 after fresh verifier: hidden Activity keeps state (useRef values included) and DOM; refs to DOM elements detached while hidden (safelyDetachRef, react-dom 19.2.6), re-attached on reveal in layout phase before effects re-run; impact lines unchanged.
|
||||
Reference in new issue
Block a user