From a095ea0e1b6ed5de9ab856b0e88487d3c3fe07a4 Mon Sep 17 00:00:00 2001 From: bchanot Date: Fri, 30 Oct 2026 18:56:48 +0100 Subject: [PATCH] docs(docs): V1-2.2 final A6 perimeter, root visibility, open findings --- docs/ANNOTATION-RENDERING.md | 10 ++++ docs/development/RUST.md | 62 +++++++++++++++++++++- docs/development/V1-2_ANATOMICAL_SHEETS.md | 28 +++++++--- 3 files changed, 92 insertions(+), 8 deletions(-) diff --git a/docs/ANNOTATION-RENDERING.md b/docs/ANNOTATION-RENDERING.md index 1393f479..d126f907 100644 --- a/docs/ANNOTATION-RENDERING.md +++ b/docs/ANNOTATION-RENDERING.md @@ -111,6 +111,16 @@ view keeps the drawing's ids, so `osteo-halo` is reserved (V1-2.2, owner brief (`reserved_id`) and both composers refuse such a tree, so the halo the markers name is always the engine's. +Both forms append the layer as the root's last child, so it inherits the +root's `visibility`. A root `visibility` other than `visible` is refused by +the reader (`root_visibility`) and by both composers: a drawing could +otherwise hide every marker while its own children set `visible` back. The +root's `class`, `style`, `transform`, `filter`, `mask` and `clip-path` are +removed by the reader; `opacity` and `display` on the root act on the drawing +and the markers alike. Still open (RUST.md §12.10): `stroke-opacity`, +`stroke-dasharray` and `stroke-width` on the root reach the markers, which do +not set them, and a view without `view_box` takes its frame from the drawing. + ## Checking the look `pnpm import:equine` writes `draft/review/app-main.svg` and `app-head.svg` diff --git a/docs/development/RUST.md b/docs/development/RUST.md index ff009c45..d1e27f2c 100644 --- a/docs/development/RUST.md +++ b/docs/development/RUST.md @@ -3972,8 +3972,9 @@ with a PI shown `rejected` by the preview as the verdict refuses it. - The module's margin under its budget is about 30.8 KB by the test's measure since §12.8 (31.3 KB at §12.7) (3.3 KB before): the V1-2.5 and V1-2.6 pages must not grow the core's browser surface without measuring. - cairo colours: closed at the checkpoint (§12.7), strict numeric `rgb()` / `rgba()` kept. -- Editor exports: Inkscape 1.4.3 covered at the checkpoint (§12.7), Figma at the finalisation (§12.8); the real Adobe - Illustrator pending from the owner, its output untested until then (A6 open); Affinity optional. Figma's text +- Editor exports: Inkscape 1.4.3 covered at the checkpoint (§12.7), Figma at the finalisation (§12.8); A6's final + perimeter (owner, 2026-10-30, §12.10) is Figma, Inkscape, cairo and ImageMagick; Adobe Illustrator and Affinity are + optional and untested, never claimed without a real export. Figma's text handling is untested: neither owner file carries the source's live text. - A verdict whose document does not read strictly carries no group and no drawing: M6's structure check (`complete_sheet_verification`) must accept a failed verdict without them, or the round would wait for its attempt limit. @@ -4104,3 +4105,60 @@ drawing and every committed SVG); `pdf_session` (`the_pdf_refuses_a_reserved_id_ snapshots refused at the gate, the demo export's halo is the engine's filter byte for byte and every marker names it); `packages/core-wasm/tests/preview.test.ts` (three spellings on the shipped module). Mutations (`.claude/audits/2026-10-30-v1-2-2-mutations-reserved-ids.py`): 11 killed of 11. + +### 12.10 Root visibility and the final A6 perimeter (owner, 2026-10-30) + +Brief « V1-2.2 : arbitrage définitif A6 et correction visibility » on `81f7639`, after the MEDIUM of the security review +of §12.9: both composers append the marker layer as the root's last child (the PDF view keeps the drawing's root, the +canvas copies its attributes), so the layer inherits the root's `visibility`, which no marker sets. A drawing +`` whose children set `visible` back read clean (no removal) and drew without a marker. + +| Point | Built | Where | +|---|---|---| +| Reader | `SvgRejection::RootVisibility` (`root_visibility`): `sanitize::check_root_visibility` accepts no `visibility` on the root or `visible` (CSS whitespace and letter case aside); `hidden`, `collapse`, CSS-wide keywords and any other value are refused. In `read_svg` after the reserved ids, so the verdict (`svg_rejected`), the preview (`rejected`), the loaded sheet, the upload tool and the PDF snapshot gate (`asset root_visibility`) answer it; `clean_svg` after active content, the targets and the reserved ids | `anatomy/svg/{sanitize,mod,clean,tree}.rs` | +| Composers | `compose_canvas` and `compose_highlight` refuse such a root (`ComposeError::RootVisibility`, `svg_rejected` / `root_visibility` in `view.canvas`) | `anatomy/compose.rs`, `ops.rs` | +| A6 | final perimeter Figma, Inkscape, cairo, ImageMagick; Illustrator and Affinity optional, never claimed without a real export; `owner/` and its procedure kept | contract core E1, V1-2 contract §17.6, export READMEs | + +Why the root attribute only: the root's `class`, `style`, `transform`, `filter`, `mask` and `clip-path` were already +removed by the reader (so `style="visibility:hidden"` on the root is a removal and the cleaned drawing shows its +markers), `