From 9f585e9185ad7fed5a9d179cf5aa1bfa9766c1be Mon Sep 17 00:00:00 2001 From: bchanot Date: Mon, 26 Oct 2026 18:03:03 +0100 Subject: [PATCH] =?UTF-8?q?chore(memory):=20EVAL-041,=20V1-1.6=20journal,?= =?UTF-8?q?=20TODO,=20gate=20outcomes=20in=20contract=20=C2=A711.8?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .claude/memory/evals.md | 7 +++++++ .claude/memory/journal.md | 5 +++++ .claude/tasks/TODO.md | 8 +++++--- docs/development/V1-1_OWNERS_ANIMALS.md | 8 +++++++- 4 files changed, 24 insertions(+), 4 deletions(-) diff --git a/.claude/memory/evals.md b/.claude/memory/evals.md index ededacbd..ecab2742 100644 --- a/.claude/memory/evals.md +++ b/.claude/memory/evals.md @@ -289,3 +289,10 @@ Method: unit (supabase 92, app 509), access layer vs real PostgREST (sandbox 54) Result: security PASS (LOW: test SQL interpolation of sandbox uuids); noted USER_UPDATED reset of workspace unmounting forms → fixed e1c1980. Verifier 1 ECARTS (not-found heading unfocused → fixed 567ad40), verifier 2 ECARTS (docs counts uncommitted; floor assert drop of moved signIn → CLARIFICATIONS), verifier 3 CONFORME 11/11. Anomalies: Prettier over whole src reformatted 39 files → restored, edits re-applied on originals; duplicate h1 (pre-existing top bar) broke selectors; StrictMode ran listener cleanup; drawer exit kept page inert; shell HTML report held typed passwords (BROWSER_TESTS claim false since V1-1.3) → reporter removed; permission layer refused rm -rf via variable (correct) and secrets sourcing. Action: format new files only; dispatch verifier after committing docs; scan reports by content. + +## EVAL-041 | 2026-10-26 | V1-1.6 animal screens and relations: gates, three verifier rounds + +Method: access layer by fork (unit 35, real PostgREST sandbox 7); screens unit tests by fork (57); Chromium e2e:shell 82 (animals 40), 3 full runs; 12 unit + 2 browser mutations all caught; visual pass desktop+375 (one batch fix: relation actions bordered); impeccable detect 0; check:all green 17:19:26; import:equine 0 diff; pgTAP 919; types match; DEV restore step rehearsed on sandbox (counts equal, 26 expected privilege errors). Fresh security auditor + verifier ×3. +Result: security PASS (MEDIUM pre-existing sandbox literal pw; LOW trace override by argv). Verifier 1 ECARTS: client journey failed after passing (late replay of the animal-section reload added by V1-1.6) → dropLateReplays for every shell spec. Verifier 2 ECARTS: pgTAP 014 #237 regex `20[0-9]{2}-` matched a workspace uuid on long-lived sandbox (latent V1-1.4 false positive; would stop DEV db:test) → metadata minus workspace_id. Verifier 3 CONFORME 12/12. +Anomalies: Card dropped aria-labelledby since Step 7 (TS ignores hyphenated props; LRN-087); useT unstable in deps (LRN-088); en substring matches (Male/Female, Save/saved) → exact; safety check refused rm inside sh -c (not bypassed; dump left for owner). +Action: run the whole shell suite (not just the new spec) before the verifier; scope pgTAP regexes away from uuids; never chain rm into sh -c. diff --git a/.claude/memory/journal.md b/.claude/memory/journal.md index f2e845de..f9734a10 100644 --- a/.claude/memory/journal.md +++ b/.claude/memory/journal.md @@ -424,3 +424,8 @@ R5.4: `draft/{labels,changelog,review_report,drawing,overlay,app_review,svg_comp - Owner validated V1-1.4, authorised V1-1.5. Owner choices: U1 « Afficher plus », U2 archived toggle, animals read-only, first-animal section → V1-1.6. Built access layer (a0e0699), workspace in authStore (ff028ec), screens (b38e627), Chromium journeys (d33a8f6), docs (ae0bd3f, d8e86a4). - Fixes from gates: shell HTML report kept passwords (db81928), re-read unmounted forms (e1c1980), not-found heading focus (567ad40). BDR-078, LRN-085/086, EVAL-040. - Security PASS, verifier CONFORME 11/11 (3rd round), check:all green. STOP at checkpoint: no V1-1.6, DEV untouched, no merge. + +## 2026-10-26 (V1-1.6 animal screens and relations, branch feature/v1-1-clients-animals) +- Owner validated V1-1.5, D11 = drawer only. Owner choices: first animal from client page, no role default, in-page link panel, U3 lock. Built access layer (e223576), screens (930499c), Chromium journeys (3e968ee), docs + closure inventory + DEV restore check (e215e9b). +- Gate fixes: shared late-replay drop for shell specs, pgTAP 014 uuid-as-date false positive. BDR-079, LRN-087/088/089, EVAL-041. +- Security PASS, verifier CONFORME 12/12 (3rd round), check:all green, e2e:shell 82. STOP at checkpoint: no merge, no V1-2, DEV untouched (M1-M3 pending). diff --git a/.claude/tasks/TODO.md b/.claude/tasks/TODO.md index 97ae549d..c4e8f29f 100644 --- a/.claude/tasks/TODO.md +++ b/.claude/tasks/TODO.md @@ -477,7 +477,7 @@ Order (BDR-071): P0 docs + decisions → V1-1 clients and animals → V1-2 sheet - Acceptance: gates + Playwright green; owner check on phone and computer over the LAN - Security: only `packages/supabase` reaches the API; explicit column lists; no text filter in GET URLs; failures phrased by closed kinds - Stop if: the mockup lacks a pattern the screens need (propose, ask, never invent a direction); a visible choice not covered by §11 - - [ ] V1-1.6 Animals and relations UI, navigation and closure (owner brief 2026-10-26 « Validation V1-1.5 et autorisation V1-1.6 Interface Animaux et clôture »; isolated stack only; DEV untouched; stop at checkpoint before merge, V1-2 and DEV) + - [ ] V1-1.6 Animals and relations UI, navigation and closure — CHECKPOINT presented 2026-10-26, awaiting owner (owner brief 2026-10-26 « Validation V1-1.5 et autorisation V1-1.6 Interface Animaux et clôture »; isolated stack only; DEV untouched; stop at checkpoint before merge, V1-2 and DEV) - [x] V1-1.5 closure: owner validated (CONFORME 11/11, security PASS, check:all green); reserves accepted for V1-1 (search not kept on back, E.164 display, back/forward not guarded), kept in product follow-up - [x] owner decisions 2026-10-26: D11 drawer only for V1-1 (no tab bar, mockup kept as later UX subject); first animal from the client page (« Ajouter un animal » → /app/animals/new, client passed in navigation state, never the URL; one atomic create_animal); no relation role preselected; relation add as an in-page panel (no modal form), end / dates / void as ModalDialog confirmations; U3 date fills and locks the year; D12 tiles not in the brief's scope → not built, reported - [x] access layer: records.ts + `duplicate_relation`, `already_ended`; `animals.ts` (search POST with probe row and species_filter, read by id with explicit columns and uuid gate, create with optional initial relation, update, archive); `relations.ts` (an animal's relations by one select with the client embedded, voided left out, explicit columns; create, end, dates, void); unit tests + real-PostgREST sandbox suite @@ -489,10 +489,12 @@ Order (BDR-071): P0 docs + decisions → V1-1 clients and animals → V1-2 sheet - [x] unit tests (schema, birth, other, sex, relation fields, access mapping, screens: states, idempotent retry, conflict, archive, relations, counts, session) + Playwright `e2e/shell/animals.spec.ts` (brief §17 items 1-24, FR/EN, desktop + 375, axe, URLs free of fixture values) - [ ] gates (typecheck, test:run, lint, build, e2e:ui, e2e:shell, db:sandbox test-db/test/types --check, import:equine --check, rust:check, check:all), counter-checks, impeccable detect, fresh verifier + security audit - [x] local gates: typecheck, lint, test:run (60 + 127 + 566), e2e:shell 82, db:sandbox test-db 919 / types match / test 61, import:equine --check 0 diff, check:all green 17:19:26 (rust:check, build, e2e:ui PASSED), impeccable detect 0; counter-checks 12 unit + 2 browser all caught - - [ ] fresh verifier + security audit (contract `.claude/tasks/contracts/2026-10-26-v1-1-6-animals-ui.md`) + - [x] fresh verifier + security audit: security PASS (MEDIUM pre-existing sandbox literal password, LOWs); verifier ECARTS (client journey late replay → dropLateReplays) → ECARTS (pgTAP 014 #237 uuid read as date → test fixed) → CONFORME 12/12 - Found: `Card` dropped `aria-labelledby` since Step 7 (V1-1.5 section cards unnamed), fixed; Button takes `ref` + - Pending owner: M1-M3 on DEV (SUPABASE.md §3.3, now with restore check) + browser acceptance on DEV; V1-1.6 validation; merge go + - Owner action: delete the rehearsal dump left in the session scratchpad (rm refused by the safety check) - Follow-up at merge: CHANGELOG Unreleased entry for V1-1 (the section describes develop only) - - [ ] docs: contract §11.8 as built + D11 + closure inventory, SUPABASE.md §3.3 DEV procedure reviewed, FRONTEND_ARCHITECTURE, BROWSER_TESTS, TEST_STRATEGY, design README (tab bar not reproduced), CLAUDE.md; BDR, EVAL, journal; commits pushed; checkpoint (brief §23, 23 points) + - [x] docs: contract §11.8 as built + D11 + closure inventory, SUPABASE.md §3.3 DEV procedure reviewed, FRONTEND_ARCHITECTURE, BROWSER_TESTS, TEST_STRATEGY, design README (tab bar not reproduced), CLAUDE.md; BDR, EVAL, journal; commits pushed; checkpoint (brief §23, 23 points) - Objective: animal screens, relation panels on both pages, journeys 1 to 7, D11 navigation, D12 tiles, Definition of Done (contract §12.6) - Depends: V1-1.5; U3, D11, D12 - Files: `apps/app/src/app/routes/app/animals/*`; `apps/app/src/animals/*`; `apps/app/src/components/{animals,relations}/*`; `AppLayout.tsx`, `DashboardRoute.tsx`; i18n; tests; `apps/app/e2e/{animals,relations}.spec.ts`; `docs/design/README.md`, `CLAUDE.md`, contract "as built", `SUPABASE.md`, CHANGELOG Unreleased diff --git a/docs/development/V1-1_OWNERS_ANIMALS.md b/docs/development/V1-1_OWNERS_ANIMALS.md index ad20bb46..e63c0b84 100644 --- a/docs/development/V1-1_OWNERS_ANIMALS.md +++ b/docs/development/V1-1_OWNERS_ANIMALS.md @@ -1360,7 +1360,13 @@ date that does not fill the year, a dialog closing on failure, a preselected role, an archived origin client, no grouping per animal, the species filter dropped, a default sex, an end before the start, a conflict without reload) caught by the unit suites; `Card` dropping its name and a request id per -attempt caught by the browser journeys. +attempt caught by the browser journeys. Gates: security audit PASS (no +HIGH; LOW: an operator can still ask Playwright for a trace on the command +line); independent verifier CONFORME 12/12 at the third round. It found the +client journey failing after its end on a late reload (fixed for every shell +suite) and a pgTAP check of V1-1.4 reading a workspace uuid as a date (« …2012-… »), +which would have stopped `db:test` in the DEV procedure (fixed in the test, no +migration). ---