chore(memory): R3 final checks recorded (BDR-056, BLK-012)
This commit is contained in:
1 parent
9bd9acaf58
commit
9bd612c062
8 files changed
+253
No files matched your search
@@ -95,3 +95,10 @@ Friction: 0279953 picked `core.stopped` from `CoreRuntime.stopped` alone: with s
|
||||
Root cause: terminal-state message not bound to persistence status (`saveFailed` existed, unread); retry labels audited only on the 8 alerts + canvas the patch touched, not every failure surface; runtime exit from `unavailable` only via explicit `retry()` called by useSheet alone.
|
||||
Solution: 6371523 (BDR-055): `isUnsaved` selector drives variant + copy; CoreStoppedNotice on all core pages; runtime self-restart below cap; FAILED not held; ESLint census. Verifier CONFORME 12/12 (pass 2), security PASS 2 LOW.
|
||||
Status: resolved 2026-10-16. Residuals: saveFailed also on refused archive (over-warns); offline restart never stops (copy on banner); beforeunload only in editor; trap-every-load draft → reload loop; GC finalizer of trapped-instance SheetHandle throws "memory access out of bounds" later (harmless, tests retain handles).
|
||||
|
||||
## BLK-012 | 2026-10-17 | Rescue copy not restorable; trapping draft stuck tab; work loss outside editor
|
||||
|
||||
Friction: JSON copy (6371523) had no in-app restore (Home picker PDF only; devtools only). Draft trapping `draft.restore` → CoreUnavailable reload each load, New report/Import FAILED, every re-read spent a recovery. beforeunload only in editor; New report / Import replaced bilan in progress (memory or slot) silently.
|
||||
Root cause: copy shipped without restore path (round trip never tested in app); `internal` from draft read treated as transient core failure, no memory of trapping input; guard scoped to one route; session replacement unguarded since MVP.
|
||||
Solution: 9bd9aca (BDR-056). Evidence: round trip identical (3 golden reports, slot + import); fuzz 37k draft.restore 0 traps, OOM only ~50 MB drafts (5 MB worst = 0.4-0.8 GB wasm). Verifier CONFORME 10/10, security PASS 2 LOW, check:all green.
|
||||
Status: resolved 2026-10-17. Residuals: GC finalizer throws "memory access out of bounds" after stack-overflow trap (console only, live instance unaffected 50/50), ≤ 3 dead instances retained (~13.5 MB typical, ~4.5 MB each) until reload; raw lone surrogate in archive text quarantines readable draft (unreachable, session.rs); copy lacks archive envelope; iOS Safari likely ignores beforeunload (dialog + copy are protection there); Retry clicked during ms-long recovery → reload screen; re-importing copy of trapping draft re-traps (spends recovery); copy near 16 MiB may OOM low-memory device; storage full + confirmed replace + reload restores replaced draft; `internal` may come from handle rebuild (Retry reopens).
|
||||
@@ -430,3 +430,9 @@ Status: closed (decisions); R3 still awaiting owner LAN confirmation, not merged
|
||||
Owner audit of 0279953 (stopped state) not satisfactory → owner choices (AskUserQuestion 2026-10-15): stopped + `isUnsaved` (saveFailed && report) → `core.stopped_unsaved` + "Télécharger une copie" (in-memory report JSON, `lib/download.ts`, no core); save fine → `core.stopped` + `core.reload` button; copy button also on `editor.save_failed` banner (any engine state); `beforeunload` guard in editor while unsaved; "plusieurs erreurs" (counter = page lifetime, not successive). One `CoreStoppedNotice`: editor banner slot, top of Home / New report, CoreUnavailable full page; canvas stopped text without button. Runtime: failed recovery below cap restarted by next call / `ready()` (`restartable` = unavailable && !stopped && generation > 0), compiled module kept, restart not counted (cap = traps); deferred status listeners. Core failure reading unread draft → FAILED, never held. ESLint census on failure keys. Commit 6371523.
|
||||
Alt rejected: counting failed restarts toward cap (offline → stopped, reload offline fails too); retry button on every page (new UI, owner already removed dead retries); copy only once stopped (offline restart loop never reaches stopped, no rescue).
|
||||
Status: closed; R3 still awaiting owner LAN confirmation, not merged, R4 not started.
|
||||
|
||||
## BDR-056 | 2026-10-17 | R3 final checks: rescue copy importable, trapping draft held, replace confirmed, guard app-wide
|
||||
|
||||
Owner brief 2026-10-16 + AskUserQuestion: (1) Home import also takes JSON rescue copy: sniff first KiB (`%PDF-` → PDF; `{` / .json → copy), cap MAX_ATTACHMENT_BYTES 16 MiB before read, fatal UTF-8, pure `readRescueCopy` → core `draft.restore` (no JS parse), then existing hydrateImport branch; UNREADABLE_DRAFT_KINDS → `invalid_copy`. (2) `internal` reading draft → held `engine_failure` row (+ archive companion), `TrapMemory` keyed on (draft, archive) pair: no re-read by mount / New report / Import, only panel Retry (`retryTrapped`); any discard clears; `held_blocked_engine` alert. SUPERSEDES BDR-055 "never held" for `internal` only (`core_unavailable` etc. stay FAILED). (3) ReplaceSessionDialog (Annuler / Ouvrir le bilan en cours / Remplacer, copy when unsaved) on New report submit + Home pick when report in memory or draft slot; Home picker clicked synchronously. (4) `useUnsavedGuard` once in App. Commit 9bd9aca.
|
||||
Alt rejected: new store action openCopy (dup of hydrateImport, session change before validation); JS JSON.parse of copy (depth; core reads raw text); copy cap MAX_PDF_BYTES (50 MiB file cap, not JSON bound); trapped memory on draft text only (archive parsed in same call); fixing GC finalizer via glue internals.
|
||||
Status: closed; R3 awaiting owner LAN validation, not merged, no R4, release 0.2.0 untouched.
|
||||
@@ -178,3 +178,10 @@ Method: fresh general-purpose auditor on commit only (5 owner axes); claims re-r
|
||||
Result: audit NOT satisfactory (3 defects: unsaved promise, 4 dead retries, recovery dead end) — all fixed 6371523; app 374 tests, core-wasm 37; verifier pass 1 ECARTS(3) (2 untested surfaces, helper out of scope) → pass 2 CONFORME 12/12; security PASS 2 LOW; docs NONE.
|
||||
Anomalies: previous session's commit + CHANGELOG claimed "never a retry that cannot work" without surface census; challengers converged on dead end the plan fixed only on canvas; confirm pass found offline restart never reaching stopped → copy moved to save banner (owner choice). Executor found latent GC finalizer throw (not fixed).
|
||||
Action: R3 stays unmerged until owner LAN confirmation; R4 not started.
|
||||
|
||||
## EVAL-024 | 2026-10-17 | R3 final checks — measurements, challengers ×3 + confirm, verifier, security, check:all
|
||||
|
||||
Method: scratch round-trip test (3 golden reports); fuzz agent (37k draft.restore on shipped wasm + 40 worst cases, OOM threshold); GC agent (Node --expose-gc, 50 recoveries, WeakRef probes, mitigations in scratch); owner AskUserQuestion ×3; plan → 3 blind challengers → rev 2 → confirm → rev 3; bugfixer with negative controls; gates.sh 4/4; verifier; security; check:all; doc-syncer.
|
||||
Result: copy restorable in app; loop impossible with real drafts, defended anyway; work-loss paths closed; app 405 tests, check:all green (~75 s cached); verifier CONFORME 10/10 (1 floor ASSERT_DROP = guard test moved, authorized by plan); security PASS 2 LOW; docs NONE.
|
||||
Anomalies: challengers caught trap re-read spending recoveries (2 lenses), BDR-055 contradiction, wrong "parity" cap (50 MiB file vs 16 MiB JSON) only on confirm pass; executor found Retry-during-recovery edge.
|
||||
Action: owner LAN validation, then merge on owner go; no R4, no release, no deploy.
|
||||
@@ -268,3 +268,7 @@ feature/rust-r3-anatomy-core: plan rev 2 after 3 challengers (32 findings; block
|
||||
- 2026-10-15 owner UX decisions on R3: unnamed trigger names per language (contract doc first, Rust layer, declared change applied to frozen oracles, goldens untouched); canvas engine failure (retry) vs view failure (own message, no retry). check:all green, Chromium 30/30 identical + DOM = O1 (declared), verifier CONFORME 8/8, security PASS 0 findings. Owner LAN tests in progress; no merge, no R4.
|
||||
- 2026-10-15 owner validated both UX fixes + retry on internal; asked 3-attempt cap then clear failure state: found canvas + 8 alerts would still offer retry after cap → `CoreRuntime.stopped` + `core.stopped` message, no retry. BDR-054. R3 not merged (LAN tests pending).
|
||||
- 2026-10-16 owner asked final independent audit of 0279953 (stopped state): not satisfactory (unsaved draft promise false, 4 dead retries, recovery dead end). Owner choices: unsaved variant + core-free copy, reload button, copy on save banner, beforeunload, "plusieurs erreurs". Fixed 6371523 (runtime self-restart below cap, CoreStoppedNotice on core pages, FAILED not held, ESLint census); verifier CONFORME 12/12, security PASS. BDR-055, BLK-011, LRN-057, EVAL-023. R3 not merged (LAN pending), no R4.
|
||||
|
||||
## 2026-10-17 (R3 final checks)
|
||||
|
||||
Owner brief: 5 checks before R3 close. Copy round trip proven, no in-app restore → Home import reads copy via draft.restore. Loop: fuzz 37k 0 traps (OOM ~50 MB only) → defended: trapping pair held in panel, re-read only on Retry. Work loss: guard app-wide, replace dialog on New report / Import. GC finalizer harmless, bounded, recorded. 9bd9aca; verifier 10/10, security PASS, check:all green. BDR-056, BLK-012, LRN-058, EVAL-024. R3 not merged (LAN pending), no R4, no release, no deploy.
|
||||
@@ -445,3 +445,12 @@ Apply: R4 PDF reader/writer (byte scanners, inflate), Step 13 uploads (reader in
|
||||
- Rescue must exist in every non-ready state, not only terminal one: a restart loop offline never reaches "stopped".
|
||||
- Status listeners from a state machine: notify via microtask, try/catch per listener, never inside load/recover try blocks; stable module-scope subscribe for useSyncExternalStore.
|
||||
Apply: R4 PDF worker failure states, Step 8 avatar upload errors, any capped retry or offline mode.
|
||||
|
||||
## LRN-058 | 2026-10-17 | Rescue paths need proven restore; remember trapping inputs; sniff and cap before read
|
||||
|
||||
- "Download a copy" is no rescue until an in-app restore exists and a round-trip test proves equality; reuse the reader that already parses that format (here core `draft.restore`) instead of a new parser.
|
||||
- Input that trapped a recoverable engine must be remembered (key = every input of the trapping call, e.g. draft + archive) and re-read only on explicit Retry: each re-read spends a capped recovery and pins dead-instance memory.
|
||||
- Untrusted file pick: route by content from first KiB, apply that path's cap on `file.size` before any full read, decode UTF-8 with `fatal: true` (refuse, never alter).
|
||||
- User text into i18n templates: `.replace(re, () => value)`; string replacement expands `$&`/`$'`.
|
||||
- Picker opened from a confirm dialog: call `input.click()` synchronously in the confirm handler (user activation, WebKit).
|
||||
Apply: any export/backup feature, R4 PDF reader worker failures, Step 13 uploads.
|
||||
Reference in new issue
Block a user