fix(editor): veil ignores clicks, names merged apart, honest tests
U2 Task 6 fix round 1 (review minors 1 to 9). - R-6: `Dialog` takes `veilCloses`; the annotation dialog passes false, so its veil ignores clicks centred too. Other dialogs unchanged. - Save merges each name on its own (an EN refreshed meanwhile survives an FR-only edit); the merged annotation is typed per kind, no cast. - Tests: the category change and the region row really run (a second category and a region in the fixture); EN kept under an FR edit; focus to the drawing when a filter hides the row; a centred veil ignores a click; act() around the store write; ui.Dialog restores innerHeight and visualViewport after each test. - e2e: `pickAnnotation` no longer scrolls; `scrollToTop` is explicit where a low row leaves the drawing out of view (editor-zones x3, editor-geometry). editor-geometry runs the accepted repair from the page's end, buttons pressed in place, scroll unchanged. The touch and double-click tests wait on the clicks themselves; the stray click on the veil can fail. - CreationPanel's `required.fields` recorded as a shortcut for Task 7; TODO lines updated. focusTarget comment wrapped.
This commit is contained in:
1 parent
db3f306523
commit
9a0fe3784c
12 files changed
+234
-58
No files matched your search
@@ -764,8 +764,14 @@ export async function pickAnnotation(
|
||||
const list = annotationList(page, dict)
|
||||
await expect(list).toBeVisible()
|
||||
await list.getByRole('button', { name }).click()
|
||||
// The click scrolled the page to the row, lower in the column: the drawing the next
|
||||
// steps press on is brought back into view (the overview no longer shortens the page).
|
||||
}
|
||||
|
||||
/**
|
||||
* Back to the page's top: a row click low in the overview leaves the page scrolled there
|
||||
* (the column no longer shortens on a selection, U2 Task 6), with the drawing or the strip
|
||||
* out of view for the steps that press on them by coordinates.
|
||||
*/
|
||||
export async function scrollToTop(page: Page) {
|
||||
await page.evaluate(() => window.scrollTo(0, 0))
|
||||
}
|
||||
|
||||
|
||||
Reference in new issue
Block a user