diff --git a/.claude/memory/decisions.md b/.claude/memory/decisions.md index feebaab3..31854f4e 100644 --- a/.claude/memory/decisions.md +++ b/.claude/memory/decisions.md @@ -975,8 +975,10 @@ Status: built afc1051..f8be0ad, awaiting owner final manual checks (OWNER_TRIAL ## BDR-118 — References dialog replaces citations side sheet; one tab order (2026-11-15) - **Status**: accepted Owner 2026-11-15: finding dialog keeps only « Références citées » + « X références » (view and edit). Button opens references dialog (Dialog layer, native) stacked over finding dialog, replaces side sheet (board 25). View mode read only; own « Modifier » = draft of adds/removes on current reference_ids: cite existing, remove, « Nouvelle référence » (created then cited in draft), « Modifier la référence » (stacked reference dialog). One save = one update = one Défaire. Families too (isCitable). Guard layer `citations` between finding and reference; LAYERS_TOP_DOWN derived from LAYERS. `{create}` over citations never read back from history. Tabs: one order everywhere; phone shows Général + Annotations, « Plus » vertical list with Vérification error count. Rejected: citations in finding edit form (Rev 4, owner reversed). Status: built b41c24b..ebd1d6d, awaiting owner db:trial check. +- **Status (2026-11-15)**: shipped: validated by owner db:trial 2026-11-15, R2 closed ## BDR-119 — Citations draft owns creations and explicit cite (2026-11-15) - **Status**: implemented, awaiting owner db:trial Owner pre-closure brief 2026-11-15. Reference created from references dialog edit mode held in draft (created[]), written with citations by one commitBatch (inserts + update = one undo); abandon leaves library unchanged. Dry-run applyEdit validates at draft submit. Select only browses, « Citer » button cites; save with pending choice refused. Family labels via isFamilyKey (finding key path len 1), 18 _family keys. Shared Dialog close 44px. Alternatives: write-now + delete on abandon (two undo steps, rejected); fold existing-reference edits into draft (offered to owner, not done). +- **Status (2026-11-15)**: shipped: validated by owner db:trial 2026-11-15, R2 closed; both offered choices ratified as built diff --git a/.claude/memory/journal.md b/.claude/memory/journal.md index 3d0bdb01..20ed50ac 100644 --- a/.claude/memory/journal.md +++ b/.claude/memory/journal.md @@ -568,3 +568,4 @@ R5.4: `draft/{labels,changelog,review_report,drawing,overlay,app_review,svg_comp ## 2026-11-15 - 2026-11-15 R2 owner follow-up built (Tasks 10-13 + fixes, b41c24b..ebd1d6d): references dialog with own edit mode, one tab order, vertical Plus. Gates 0, sweep 264 passed, fails = admin.spec BLK-015 + Target crashed (rerun green), GUARD OK. Waiting owner db:trial check. - R2 Rev 6 built: Citer button, draft-owned creation (commitBatch), family labels, 44px dialog close. Sweep final7 273 pass, 6 fail admin.spec BLK-015. Await owner db:trial then R2 closure. +- R2 CLOSED 2026-11-15: owner db:trial 4.13+4.14 pass, validated functional+graphic; saved-ref edit own Défaire + unsaved new ref lost on abrupt close ratified. Sweep 52d5613 273p/163s/6f admin.spec BLK-015 open (RR-13). No merge/deploy. Next R3, R4; U2 orientation kept. diff --git a/.claude/memory/learnings.md b/.claude/memory/learnings.md index 44996e08..7c981b6d 100644 --- a/.claude/memory/learnings.md +++ b/.claude/memory/learnings.md @@ -974,3 +974,6 @@ Apply: for equality binding (not secret) use sync non-crypto hash (FNV-1a 64 Big ## LRN-141 — Stacked modals: ask only removed layers; never rule silent loss into a limit (2026-11-14) Pattern: stacked modal layers + "ask all layers" guard: question appeared in lower dialog hidden under still-open upper modal (citations sheet) -> looks frozen. Also ruling "accept as documented limit" for silent loss broke owner condition; reviewer caught it. Apply: a guard asks only layers the move actually removes; before showing a question, close clean layers above the dirty one. Never rule a silent-loss case into "documented limit" when owner condition forbids silent loss: restore notice instead. Label limits owner did not see as "to confirm", never "accepted". + +## LRN-142 — Transactional dialog owns side-effect creations and explicit commit (2026-11-15) +Context: R2 closure, owner db:trial trials 2026-11-14/15 drove Rev 4-6. Pattern: in dialog that edits draft, side-effect creations (new reference) belong to draft, written with save as one batch (one undo); abandon = no write. Select browses only, explicit action button commits choice; save refuses pending uncommitted choice with message + focus. Reason: arrow keys on native select fire change, silent draft edits. Apply: any future transactional dialog (U2 annotation properties dialog). diff --git a/.claude/tasks/TODO.md b/.claude/tasks/TODO.md index 61ebd889..9ef460f4 100644 --- a/.claude/tasks/TODO.md +++ b/.claude/tasks/TODO.md @@ -706,6 +706,7 @@ Order (BDR-071): P0 docs + decisions → V1-1 clients and animals → V1-2 sheet - [x] R2.6 docs, FR/EN label table, Rust exception (Part II), db:trial manual protocol, closure - R2 BUILT 2026-11-13, awaiting owner validation: fc3fec7 R2.0, 4499bc7 R2.1, c21995b R2.2, 3baac4d R2.3, 8db6f42 R2.4, 4b7d254 R2.5, 2182307 R2.6 docs, 1bf2701 final-review fixes (all pushed). Verifier 18/20 (NOT-MET 9 admin.spec renderer crash from accumulated grants, 15 read-only flip keeps panel open), security PASS, final review ready-with-fixes → fixed, re-review ready. Owner decisions pending: read-only flip ratification, admin.spec closure before merge (fresh-run authorisation or separate fix: paginated grants / run-scoped cleanup), add-draft cancel control, V1-2_ANATOMICAL_SHEETS.md D1-D4 supersede note wording. editor-equine updated, never run. Parked: N1 silent draft loss on read-only flip of an unmatched tile, N2 pinned non-matching tile beside no-result, first-click loss below a refused field, landscape 667×375 panel 13 px, M10 locals over 5 in R2 hooks (/refactor) - [x] R2 corrections (owner brief 2026-11-13, plan rev 5/5b): C0 admin.spec diagnosis (A/B 65a8fd3 vs 52aac41 identical, dose-response proves grant accumulation, BLK-015 open, pagination = RR-13), C1 read-only flip never drops a refused draft silently (3303530, 1e19479), C2 « Annuler l'ajout » + Escape (d177992, c8109af), C3 « Ne correspond pas à la recherche » (b1fd896), C4 667×375 touch proof, test only (969a5f3..78fb2d0), C5 docs (b919cf8, c0da36d, 58228ab), final review I1 (94f8a8b, 346a8fd), verifier gap undo drop announced (cb1ad47, 538ce27). Sweep 221p/119s/5f (admin.spec only), guard OK, verifier CONFORME, security PASS. BDR-115, LRN-133..135. Awaiting owner db:trial trial; residuals: two drops one flip speak last, undo/redo overwriting a pending draft in a mounted view, rotation cramped exception (auto-scroll offered), prettier drift editor-shell-layout.spec.ts:297-302 + - [x] R2 CLOSED 2026-11-15 (owner brief « Clôture R2 »): owner db:trial checks §4.13 + §4.14 pass, R2 validated functionally and graphically; Rev 4-6 adjustments (b41c24b..54e09a7, BDR-118, BDR-119); choices ratified: saved-reference edit keeps own Défaire, unsaved new reference lost on abrupt close. Final sweep 52d5613: 273p/163s/6f (admin.spec BLK-015, stays open, RR-13), not green. No merge, no deploy. Next: R3, R4; U2 not started (orientation 2026-11-14 kept) - [x] Anomaly B FIXED `2cdee42` (owner 2026-11-12 « Décision sur l'anomalie E2E », option 1): dialog checks moved to e2e:ui on the real WorkingCopyAction (`e2e/harness/working-copy.*`, `e2e/ui/working-copy.spec.ts`), shell keeps the historical page + state-consistent button check, sandbox suite archives only its own copies (`returning id` checked). Before 4 failed; after 4 passed ×2; full admin.spec 16 passed / 8 skipped; e2e:ui 251 ×2; sandbox sheets-admin 5/5; pre-existing anatomical_sheets rows identical per id (637 → 643, 6 added by A1). Verifier CONFORME, security PASS (1 LOW: optional uuid check before interpolation). Open: cleanup creation branch not run on a fresh stack; free branch of the shell check not run on this sandbox; `editor-equine.spec.ts` set-aside still archives and restores pre-existing copies (8c315a12 included, updated_at 2026-11-12 13:40 from the R1 follow-up run): owner decision. R2.0 waits for the owner's green light on this result - [ ] editor-equine risk (owner 2026-11-12 « Validation du correctif E2E et GO R2 » §3; separate fix, NOT part of R2): `editor-equine.spec.ts` beforeAll archives every active historical working copy (`update public.anatomical_sheets … private.is_historical_working_copy(id)`), afterAll restores them, and `confirmHistoricalDrawing` may upload / confirm the historical sheet's drawing; it already changed 8c315a12's `updated_at` (2026-11-12 13:40 UTC). NOT to be run on a persistent database holding data to preserve until fixed. Before any rerun: list its writes exactly, propose a reproducible non-destructive isolation of pre-existing resources, check interactions with admin.spec and parallel suites; keep 8c315a12 and its current metadata (no artificial date restore); no sandbox reset or deletion - [ ] e2e fixture accumulation (owner 2026-11-12 §3): sheets created by the suites persist on the sandbox (admin.spec A1 `fiche-e2e-` never archived, seedDraft / seedOfficialSheet sheets, editor copies); track them (count per run, owner per fixture) and propose run-scoped cleanup limited to ids each run created diff --git a/.claude/tasks/contracts/2026-11-13-r2-ux-finish-1624.md b/.claude/tasks/contracts/2026-11-13-r2-ux-finish-1624.md index dc2bee46..678bcf5e 100644 --- a/.claude/tasks/contracts/2026-11-13-r2-ux-finish-1624.md +++ b/.claude/tasks/contracts/2026-11-13-r2-ux-finish-1624.md @@ -263,3 +263,6 @@ CLARIFICATIONS 2026-11-15 b (controller, owner pre-closure brief): the Rev 5 uni SCOPE AMENDMENT 2026-11-15 (controller): apps/app/e2e/harness/dialog.tsx joins FILE SCOPE (the ui Dialog harness gains the long-title case for criterion 35; dev-server only, never built). CLARIFICATIONS 2026-11-15 c (controller, owner pre-closure brief: « Le balayage complet présente toujours des échecs et ne doit pas être annoncé comme entièrement vert »): for criterion 10, full-sweep failures that are browser crashes (« Target crashed ») or navigation timeouts under the accumulated sandbox load, and that pass when their spec runs alone, are reported to the owner with their counts and names, as the BLK-015 family; they are not counted as fixed and the sweep is never announced green. + +## CLOSURE 2026-11-15 (owner brief « Clôture R2 ») +Owner: db:trial manual checks done, all pass; R2 validated functionally and graphically, no further correction. Choices ratified: « Modifier la référence » on a saved reference keeps its own dialog and Défaire; an unsaved new reference is lost on an abrupt browser close (as other unsaved forms). Criteria 1-36: MET, with criterion 10 reported as is: final sweep 52d5613 273 passed, 163 skipped, 6 failed (admin.spec, BLK-015 open, RR-13); never announced green. Status: CLOSED. No merge, no deployment authorized. diff --git a/.claude/tasks/plans/2026-11-13-r2-ux-finish-1624.md b/.claude/tasks/plans/2026-11-13-r2-ux-finish-1624.md index 53bd4e75..109931fb 100644 --- a/.claude/tasks/plans/2026-11-13-r2-ux-finish-1624.md +++ b/.claude/tasks/plans/2026-11-13-r2-ux-finish-1624.md @@ -489,3 +489,6 @@ Controller rulings (autonomous mandate, reported to the owner): (cite through `created()` → the draft path). - T16: document the durability change (a pending reference lives only in the open form until « Enregistrer », protected by the leave guards and beforeunload, no recovery copy), next to the other draft limits. + +## Closure 2026-11-15 +Owner validated R2 after the §4.13 and §4.14 db:trial checks; both offered choices ratified as built. Plan complete; no further task.