From 953ae41b86e79d5b2a82bc3f89b5e30670cb8668 Mon Sep 17 00:00:00 2001 From: bchanot Date: Wed, 11 Nov 2026 14:43:41 +0100 Subject: [PATCH] docs(supabase): db:trial app comment and TODO review tick The cmd_app shortcut comment matches SUPABASE.md on the rotate-secrets 401 window; TODO ticks the reviews and lists the app no-lock shortcut. --- .claude/tasks/TODO.md | 3 ++- scripts/db-trial.sh | 7 ++++--- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/.claude/tasks/TODO.md b/.claude/tasks/TODO.md index 85244c72..9ed3cd32 100644 --- a/.claude/tasks/TODO.md +++ b/.claude/tasks/TODO.md @@ -694,7 +694,8 @@ Order (BDR-071): P0 docs + decisions → V1-1 clients and animals → V1-2 sheet - [ ] Test anomaly A (owner 2026-11-09, separate from U1/U2): fictitious fingerprints `'a'.repeat(64)` from worker stand-ins (`packages/supabase/tests/sandbox/sheet-fixtures.ts:115` openRound, `sheets-concurrency.sandbox.ts:168`, `sheets-perf.sandbox.ts:169`); 7 published/deprecated sandbox versions fail `check_published`. Fix: real fingerprint through the core (as e2e `fingerprintOf`, `apps/app/e2e/support/catalogue.ts:88`); never weaken the publish gate or the reader check. Needs its own go. - [ ] Test anomaly B (owner 2026-11-09, separate from U1/U2): `packages/supabase/tests/sandbox/sheets-admin.sandbox.ts:181-195` creates the historical working copy and never archives it; slot taken → `admin.spec.ts:717` fails x4. Fix test independence and cleanup; the existing copy `8c315a12-20d4-4432-9db3-7cb88b27a5b4` stays untouched until the owner authorises. Linked: RR-13, the admin.spec confirmation line above. - [ ] Test anomaly C (owner 2026-11-09, separate from U1/U2): integrity failure invisible in catalogue cards; implemented as lot R4; failure shown, never hidden or bypassed. - - [ ] Dedicated persistent manual trial stack (owner 2026-11-09, D8; brief « Après R0 — Implémentation technique », contract .claude/tasks/contracts/2026-11-09-db-trial-stack-1809.md): [x] lot A suites' guard · [x] lot A2 trial dev server target (R13) · [x] lot B1 foundation · [x] lot B2 backups, restore, migrate, rotation · [x] lot B3 accounts, grants, drawings, app · [x] lot C docs · [ ] reviews · [ ] creation checkpoint (owner go before any create) + - [ ] Dedicated persistent manual trial stack (owner 2026-11-09, D8; brief « Après R0 — Implémentation technique », contract .claude/tasks/contracts/2026-11-09-db-trial-stack-1809.md): [x] lot A suites' guard · [x] lot A2 trial dev server target (R13) · [x] lot B1 foundation · [x] lot B2 backups, restore, migrate, rotation · [x] lot B3 accounts, grants, drawings, app · [x] lot C docs · [x] reviews (verifier ECARTS owner-gated only, security PASS, code review + 2 re-reviews fixed: d3bdbbe, f2cbf68) · [ ] creation checkpoint (owner go before any create) + - shortcut: `pnpm db:trial app` takes no lock (scripts/db-trial.sh, comment above cmd_app): stop, backup, migrate, destroy, restore or rotate-* started in another terminal in the second before Vite listens on 5194 goes ahead. Upgrade: a dedicated app lock, shared by app and exclusive for those commands. - [ ] Rights screen lists every catalogue grant unbounded (list_catalog_grants, GrantList): 2 306 rows crash axe at 8 workers on a long-lived sandbox. Owner 2026-11-09 (BDR-106): own priority track RR-13, separate from U1 and U2, not implemented now. - [ ] V1-2.6 UX complement « annotations ↔ constats » (owner brief 2026-11-06 « Nouvelle exigence UX : navigation bidirectionnelle »; contract `.claude/tasks/contracts/2026-11-06-v1-2-6-findings-nav-design.md`; design only, U1 plan untouched, no code, no DEV): [x] relations audit (one link `finding_zone_id`, no new association, equine draft 1:1) · [x] boards 17-22 `docs/design/v1-2-6-constats/` · [x] study `docs/development/V1-2-6_UX_FINDINGS_NAV.md` (no U1 integration point needed, sub-step U2b proposed, risks, tests, decisions F1-F21) · [x] fresh design review APPROVE WITH FIXES (3 MUST-FIX, 16 SHOULD), fixes applied · [x] fresh verifier ECARTS(4) → ECARTS(2) → CONFORME 9/9 (round 3; 567da67 came after it, not covered) · [x] owner principle validation 2026-11-06 (brief « Validation de principe U2b et préparation des checkpoints », BDR-103): U2b retained after U2 and before U3, F1/F2/F6/F8/F22 approved, F7 for the term « Famille », F3/F4 in part · [x] decisions F1-F22 table (alternatives, consequences, state), F2 groups vs leaves, F3 field list, F4 view semantics, boards with their decisions in study §7.4, U2b entry in `V1-2-6_UX_PLAN.md` §3, LRN-119 (``), contract `.claude/tasks/contracts/2026-11-06-v1-2-6-findings-nav-decisions.md` · [x] fresh verifier on that contract: ECARTS(9) → fixed → CONFORME 11/11 (6 observations outside criteria kept for the owner) · [x] owner 2026-11-06 (brief « U1 / U2b — Derniers arbitrages avant implémentation », BDR-104): F2 leaves, F3, F4 model A, F8, F22 decided; study §6-§7 updated · [x] owner: F5, F9-F21 approved as recommended, precisions F3, F8, F11-F14, F22 (brief « Ratification finale U1 … », 2026-11-06, BDR-105); study header, §6 tests, §7 table, 7.2, 7.3, UX PLAN U2b entry, REVUE, DECISIONS pointer updated; no implementation · [ ] U2b authorisation (after U2, before U3) - [ ] follow-up candidates (owner T14): multi-tab notice; RR item for the rollback limit of the category model (new id, reconcile with develop) diff --git a/scripts/db-trial.sh b/scripts/db-trial.sh index 70674124..5d5b4ca6 100755 --- a/scripts/db-trial.sh +++ b/scripts/db-trial.sh @@ -1855,9 +1855,10 @@ app_stop() { # shortcut: app takes no lock and checks the gateway identity only at its start. refuse_while_app_runs # (stop, backup, migrate, destroy, restore, rotate-keys, rotate-secrets) sees the app only once Vite listens on 5194, # so one of them run in another terminal in the second before Vite binds goes ahead: after rotate-keys -# the app keeps the previous anon key until its expiry; after rotate-secrets its requests are refused -# (401) until app is restarted; after stop or destroy it proxies to whatever later listens on -# 127.0.0.1:58801. Holding the lock all session would lock out every other command, backup, migrate +# the app keeps the previous anon key until its expiry; after rotate-secrets a signed-in browser keeps its +# pre-rotation access token and PostgREST answers 401 to it, even after the app restarts, until auth-js refreshes it +# near its expiry (up to 3600 s) or the user signs out and in again; after stop or destroy it proxies to whatever +# later listens on 127.0.0.1:58801. Holding the lock all session would lock out every other command, backup, migrate # and the restarts included, with "another pnpm db:trial command is running", which says nothing of # the app (the commands above already refuse, naming it, once Vite listens). # Upgrade: a dedicated app lock, shared by app and exclusive for those commands.