chore(memory): U1 owner checkpoint decisions, RR-13, LRN-120 to 122
BDR-106 owner decisions at the U1 checkpoint; TODO U1 line closed up to the open owner checkpoint, admin.spec:717 confirmation and kept reservations; RR-13 rights list server paging track; contract clarification; journal.
This commit is contained in:
1 parent
b1045088c5
commit
8cb681e2fa
5 files changed
+38
-2
No files matched your search
@@ -817,3 +817,18 @@ Observation, not a routine: worktree held uncommitted format-only Prettier chang
|
||||
- **Rule**: before wrapping subtree in `<Activity>`, audit its effects. Idempotent on re-run (subscriptions, listeners, measures with cleanup) → fine. One-shot on mount (reset, focus, scroll, fetch, write) → make reveal-safe (apply once per key via ref, consume one-shot request) or keep `hidden` wrapper. `hidden` wrapper: no effect runs on switch, but hidden places re-render at normal priority (U1 plan §2 cost control). `<Activity>` stays allowed where audit passes.
|
||||
- **Future application**: U1 makes `focusId` one-shot and bans focus in mount effects; U2b search, filter panel, drawing in filter panel (`useFraming` reuse) follow same rule, so a later move to `<Activity>` stays possible.
|
||||
- **Status (2026-11-06)**: correct, amended 2026-11-06 after fresh verifier: hidden Activity keeps state (useRef values included) and DOM; refs to DOM elements detached while hidden (safelyDetachRef, react-dom 19.2.6), re-attached on reveal in layout phase before effects re-run; impact lines unchanged.
|
||||
|
||||
## LRN-120 — Never edit src while a browser suite runs against a live dev server: HMR mixes code, run unusable (2026-11-09) (2026-11-09)
|
||||
- **Context**: V1-2.6 U1 Lot H. Controller ran whole shell suite on a474dda (Playwright against live Vite dev server) while fix round 1 edited `src`. HMR served half-edited code mid-run → failures mixed old/new code, run unusable, verdict lost.
|
||||
- **Rule**: suite against a live dev server = frozen tree for its whole duration. No edit dispatch while a suite runs. Fix needed during a run → wait for run end, or work in separate worktree with own port.
|
||||
- **Apply**: SDD controller sequences implementer dispatches and suite runs; report names commit the suite ran on and confirms no edit landed during it.
|
||||
|
||||
## LRN-121 — Sandbox volume and consumed state fail browser suites independent of code: check data before bisecting (2026-11-09) (2026-11-09)
|
||||
- **Context**: V1-2.6 U1 Lots F-I. admin.spec « Target crashed » in every full run since Lot F, bisect 89da8d3 / 580ff28 / 606f7ba same failure → not code. Cause: long-lived sandbox grew 2 306 grant rows; `list_catalog_grants()` + `GrantList` unbounded; axe scan drove Chromium renderer ~2.2 GB, earlyoom killed it. Same pressure SIGTERMed DEV `pg_meta`. Fresh sandbox (owner go) → 192/0. Later second run on same sandbox: admin.spec:717 failed 4/4, single working-copy slot taken by earlier run (WorkingCopyAction.tsx:88).
|
||||
- **Rule**: suite failing outside changed files → check sandbox data volume and consumed state before bisecting code. Tests create own state or tolerate existing state. Unbounded list endpoints = latent OOM under test tooling; page server-side. Never reset sandbox just to get green (owner go per reset, BDR-105/106).
|
||||
- **Apply**: report exact counts per commit and sandbox age; RR-13 covers paging + admin scenario independence + memory check.
|
||||
|
||||
## LRN-122 — pgrep -f wait loop matches its own command line: bracket the pattern or wait on PID (2026-11-09) (2026-11-09)
|
||||
- **Context**: V1-2.6 U1 Lot I. Implementer wait loop `while pgrep -f 'playwright.shell.config'; do sleep …; done` never ended: `pgrep -f` matched the loop's own shell command line, which contains the pattern.
|
||||
- **Rule**: `pgrep -f` pattern must not match the caller: bracket trick `pgrep -f '[p]laywright.shell.config'`, or wait on a known PID (`wait $pid`, `kill -0`), or the harness Monitor / background notification.
|
||||
- **Apply**: any wait-for-process loop in briefs and scripts.
|
||||
Reference in new issue
Block a user