chore(memory): U1 owner checkpoint decisions, RR-13, LRN-120 to 122
BDR-106 owner decisions at the U1 checkpoint; TODO U1 line closed up to the open owner checkpoint, admin.spec:717 confirmation and kept reservations; RR-13 rights list server paging track; contract clarification; journal.
This commit is contained in:
1 parent
b1045088c5
commit
8cb681e2fa
5 files changed
+38
-2
No files matched your search
@@ -865,3 +865,16 @@ U2b (no implementation): F5, F9-F21 approved as recommended (a). Precisions: F3
|
||||
|
||||
Alternatives not taken: plan redesign; global sandbox reset go; U2b now.
|
||||
Status: in force. Supersedes nothing (completes BDR-104).
|
||||
|
||||
## BDR-106 — V1-2.6 U1 checkpoint: out-of-scope files + 3 rewrites accepted, checkpoint open, exact e2e 188/90/4, RR-13 rights paging track (2026-11-09) (2026-11-09)
|
||||
- **Status**: accepted 2026-11-09 by owner
|
||||
Owner brief « V1-2.6 UX — Décisions au checkpoint U1 », 2026-11-09. Owner decisions only.
|
||||
|
||||
- Accepted: 5 files outside initial FILE SCOPE (CatalogueCanvas.tsx B2a, placeVisibility.ts B2a, editingContext.ts B2b, references/filter.ts D, ShellChrome.tsx F) + 3 one-for-one assertion rewrites (editor-journey.spec.ts:14 8→4 lines, editor-recovery.spec.ts:7 4→2, editor-route-recovery.test.tsx:93 8→5; `expect(` per file unchanged 37/41/45; mapping 99b669b). Condition: justification + mapping kept in final report (`V1-2-6_UX_U1_CHECKPOINT.md` §7.2). No general scope widening for later steps.
|
||||
- U1 status: implementation done, owner validation checkpoint stays open (manual trial). Exact shell suite at da95b84: 188 pass / 90 skip / 4 fail (admin.spec.ts:717 fr/en × desktop/375). Never claim suite green on last commit. 192/0 at 81fba46 on fresh sandbox = earlier evidence only. 4 failures = probable sandbox-state dependency (single working-copy slot, WorkingCopyAction.tsx:88), confirm later by non-destructive reproduction or isolated test. No sandbox reset to get green.
|
||||
- New priority track RR-13 « Pagination côté serveur de la liste des droits et prévention de l'épuisement mémoire », separate from U1 and U2, not implemented now. Future plan: bounded server paging, deterministic order, authorization unchanged, paging + volume tests, admin scenario independence tests, memory check, DEV protected from test-suite side effects.
|
||||
- Limits kept in U1, not moved silently to U2: N4, N6, repair result/draft, local recovery copy (sessionStorage), references panel inert, widths (538 px at 1 024/1 280), trial-lan not run.
|
||||
- Doc closure authorized: LRN, TODO, BDR, journal, U1 criteria + reservations; docs-only commit + push. ChatGPT review file stays untracked. No app/Rust/SQL/worker/DEV config change, no merge, no deploy, no U2.
|
||||
|
||||
Alternatives not taken: sandbox reset for a green verdict; paging folded into U1 or U2; U1 limits moved to U2.
|
||||
Status: in force. Completes BDR-105.
|
||||
@@ -537,3 +537,6 @@ R5.4: `draft/{labels,changelog,review_report,drawing,overlay,app_review,svg_comp
|
||||
- V1-2.6 U0 (docs only, BDR-101): V1-2 contract §6.2/§6.4 (draft rounds)/§6.7/§7.4/§8.2-8.4/§12.2 O22 (save + approval/publication fixed-category checks, not built)/§16.7/§16.12/§17.12; level-1 C3-C40 notes; design README v1-2-6 validated; rules sheet-model/schemas; 5 UX docs. T17, T12, T6, T14, T1 open. Verifier ECARTS(1) x2 fixed. No code, no DEV.
|
||||
- V1-2.6 U2b principle approved by owner (BDR-103): U2b after U2; F1/F2/F6/F8/F22 decided, F7 term, F3/F4 partial; study §7 table F1-F22 with alternatives + consequences, F2 groups open (730 vs 627 leaves), F3 fields, F4 facet model; LRN-119 Activity. U1 plan 2e46c14 untouched. Docs only, no DEV.
|
||||
- V1-2.6 owner final arbitrations (BDR-104): U2b F2 leaves, F3, F4 model A, F8, F22 decided; U1 design confirmed; no implicit sandbox deletion. U1 checkpoint page (18 choices, AC3/4/5/7/17 exact, 16 MAJOR traced, reset = down + up fresh, lot criteria). Docs only, sandbox untouched.
|
||||
|
||||
## 2026-11-09
|
||||
- V1-2.6 U1 implemented: lots A-I 9ec232a..da95b84, verifier 22/22, security PASS, final review fixes 0467885/da95b84 re-review clean. Shell at da95b84 188/90/4 (admin.spec:717 working-copy slot, sandbox state). Owner checkpoint decisions BDR-106: 5 files + 3 rewrites accepted, checkpoint open, RR-13 rights paging track. LRN-120-122. U2 not started.
|
||||
@@ -817,3 +817,18 @@ Observation, not a routine: worktree held uncommitted format-only Prettier chang
|
||||
- **Rule**: before wrapping subtree in `<Activity>`, audit its effects. Idempotent on re-run (subscriptions, listeners, measures with cleanup) → fine. One-shot on mount (reset, focus, scroll, fetch, write) → make reveal-safe (apply once per key via ref, consume one-shot request) or keep `hidden` wrapper. `hidden` wrapper: no effect runs on switch, but hidden places re-render at normal priority (U1 plan §2 cost control). `<Activity>` stays allowed where audit passes.
|
||||
- **Future application**: U1 makes `focusId` one-shot and bans focus in mount effects; U2b search, filter panel, drawing in filter panel (`useFraming` reuse) follow same rule, so a later move to `<Activity>` stays possible.
|
||||
- **Status (2026-11-06)**: correct, amended 2026-11-06 after fresh verifier: hidden Activity keeps state (useRef values included) and DOM; refs to DOM elements detached while hidden (safelyDetachRef, react-dom 19.2.6), re-attached on reveal in layout phase before effects re-run; impact lines unchanged.
|
||||
|
||||
## LRN-120 — Never edit src while a browser suite runs against a live dev server: HMR mixes code, run unusable (2026-11-09) (2026-11-09)
|
||||
- **Context**: V1-2.6 U1 Lot H. Controller ran whole shell suite on a474dda (Playwright against live Vite dev server) while fix round 1 edited `src`. HMR served half-edited code mid-run → failures mixed old/new code, run unusable, verdict lost.
|
||||
- **Rule**: suite against a live dev server = frozen tree for its whole duration. No edit dispatch while a suite runs. Fix needed during a run → wait for run end, or work in separate worktree with own port.
|
||||
- **Apply**: SDD controller sequences implementer dispatches and suite runs; report names commit the suite ran on and confirms no edit landed during it.
|
||||
|
||||
## LRN-121 — Sandbox volume and consumed state fail browser suites independent of code: check data before bisecting (2026-11-09) (2026-11-09)
|
||||
- **Context**: V1-2.6 U1 Lots F-I. admin.spec « Target crashed » in every full run since Lot F, bisect 89da8d3 / 580ff28 / 606f7ba same failure → not code. Cause: long-lived sandbox grew 2 306 grant rows; `list_catalog_grants()` + `GrantList` unbounded; axe scan drove Chromium renderer ~2.2 GB, earlyoom killed it. Same pressure SIGTERMed DEV `pg_meta`. Fresh sandbox (owner go) → 192/0. Later second run on same sandbox: admin.spec:717 failed 4/4, single working-copy slot taken by earlier run (WorkingCopyAction.tsx:88).
|
||||
- **Rule**: suite failing outside changed files → check sandbox data volume and consumed state before bisecting code. Tests create own state or tolerate existing state. Unbounded list endpoints = latent OOM under test tooling; page server-side. Never reset sandbox just to get green (owner go per reset, BDR-105/106).
|
||||
- **Apply**: report exact counts per commit and sandbox age; RR-13 covers paging + admin scenario independence + memory check.
|
||||
|
||||
## LRN-122 — pgrep -f wait loop matches its own command line: bracket the pattern or wait on PID (2026-11-09) (2026-11-09)
|
||||
- **Context**: V1-2.6 U1 Lot I. Implementer wait loop `while pgrep -f 'playwright.shell.config'; do sleep …; done` never ended: `pgrep -f` matched the loop's own shell command line, which contains the pattern.
|
||||
- **Rule**: `pgrep -f` pattern must not match the caller: bracket trick `pgrep -f '[p]laywright.shell.config'`, or wait on a known PID (`wait $pid`, `kill -0`), or the harness Monitor / background notification.
|
||||
- **Apply**: any wait-for-process loop in briefs and scripts.
|
||||
Reference in new issue
Block a user