docs(docs): record the R2 follow-up of 2026-11-15
This commit is contained in:
1 parent
2579d4c7ae
commit
8c420d4b53
6 files changed
+217
-64
No files matched your search
@@ -171,6 +171,9 @@ The criteria below are the contract as written.
|
||||
|
||||
### R2 — The Références tab (D1 to D4)
|
||||
|
||||
Status (2026-11-15): built, awaiting the owner's `db:trial` check of two last adjustments (« Owner follow-up
|
||||
2026-11-15 » below, `V1-2-6_OWNER_TRIAL.md` §4.13), then R2 closure. Several lines below describe the side sheet, the
|
||||
citations in the finding's edit form or the phone tabs Annotations + Vérification: each is marked as superseded.
|
||||
Status (2026-11-14): R2 validated by the owner's trial, closed pending the final manual checks (« Owner trial and
|
||||
closure 2026-11-14 » below, `V1-2-6_OWNER_TRIAL.md` §4.12).
|
||||
Status (2026-11-13): corrected, still awaiting the owner's validation (corrections below).
|
||||
@@ -182,14 +185,17 @@ nothing deployed). Commits: `65a8fd3` (plan, rev 4 after the owner's GO), `fc3fe
|
||||
Labels: `V1-2-6_R2_LABELS.md`. Decision record: BDR-114. What the build settled against the text below:
|
||||
|
||||
- The panel opens from a finding only (owner, 2026-11-12). The family's former trigger is removed; a family keeps
|
||||
its inline list and « Retirer ».
|
||||
its inline list and « Retirer ». Superseded 2026-11-15: a family opens the references dialog like a finding, and
|
||||
neither holds an inline list.
|
||||
- « Retirer de ce constat » removes that one citation (the reference stays in the document) and marks the finding
|
||||
« À confirmer » (core rule, `edit.rs`); one « Défaire » restores the citation and the status together. Superseded
|
||||
2026-11-14: the sheet no longer removes a citation (read-only, « Modifier » and « Aller à » only, key
|
||||
`editor.references.remove_citation` deleted); a citation is removed from the finding's edit form (see « Owner trial
|
||||
and closure 2026-11-14 »).
|
||||
and closure 2026-11-14 »). Superseded 2026-11-15: the finding's edit form holds no citation; the references dialog's
|
||||
own « Modifier » cites and removes (see « Owner follow-up 2026-11-15 »).
|
||||
- Zero state: when the last citation is gone the panel stays open with « Ce constat ne cite plus aucune
|
||||
référence. » and closes on a tab change.
|
||||
référence. » and closes on a tab change. Superseded 2026-11-15: the references dialog also opens at 0 reference, and
|
||||
the line reads « Ce constat ne cite aucune référence. ».
|
||||
- Selecting a tab closes the panel. Every close (✕, Escape outside a field, scrim, tab, « Aller à », « Tout
|
||||
afficher », element gone) records one pending move applied after the exit: the focus goes back to the trigger,
|
||||
else to the active tab button.
|
||||
@@ -293,7 +299,8 @@ Behaviour:
|
||||
are read-only (disclosure, « Modifier », « Supprimer » or the cited hint). Focus returns to the opener.
|
||||
- Side sheet. The citations panel is a modal sheet at the right edge (34 rem at most) stacked over the finding dialog,
|
||||
usable by keyboard and touch. Content: read tiles, « Modifier », « Aller à », « Tout afficher » (« Retirer de ce
|
||||
constat » was removed from it on 2026-11-14).
|
||||
constat » was removed from it on 2026-11-14). Superseded 2026-11-15: a modal references dialog stacked over the
|
||||
finding dialog replaces the sheet (no sheet, no slide); its read tiles have no « Modifier ».
|
||||
- History. Tab, Annotations section, finding dialog, finding creation, sheet, reference dialog, filter are browser
|
||||
history entries (`apps/app/src/editor/history`). Back and Forward restore the view and the scroll; a reload keeps
|
||||
tab and filter, never a form. Entries carry the sheet id and a random session tag (2026-11-14: no longer the account id) and hold
|
||||
@@ -301,9 +308,10 @@ Behaviour:
|
||||
- Filter. « Tout afficher dans l'onglet Références » shows only the references the finding cites, with the chip
|
||||
« Références du constat : <nom> » and its « × », plus « Revenir au constat ». Search and sort stay usable. The
|
||||
owner's eight steps (finding A, « 2 références », sheet, « Tout afficher », filtered tab, Back, back on A with the
|
||||
sheet open) are proved at 1280 and 375 px.
|
||||
sheet open) are proved at 1280 and 375 px (since 2026-11-15 the sheet of these steps is the references dialog).
|
||||
- « Plus ». The menu is an overlay under the tab row (no layout shift, light fade), closed by a choice, an outside
|
||||
press, Escape, a tab change and, where the browser offers `CloseWatcher`, the Android Back request.
|
||||
press, Escape, a tab change and, where the browser offers `CloseWatcher`, the Android Back request. Superseded
|
||||
2026-11-15: a vertical list of full-width rows (see « Owner follow-up 2026-11-15 »).
|
||||
- Sidebar. The left menu stays in place while the page scrolls (own scroll when taller than the window).
|
||||
|
||||
Owner decisions (gate 2026-11-13): R2F-9 items 1 to 6 approved. Item 7: the clients and animals list searches are NOT
|
||||
@@ -316,7 +324,7 @@ Stated limits:
|
||||
1. Deleting a finding replaces its dialog entry, so the next Back press does nothing visible once (R2F-3). Lifted
|
||||
2026-11-14: the deletion pops the dialog entry, the first Back moves.
|
||||
2. Lifted by the final review: « Aller à » a finding or a zone opens its dialog in the same move, one history entry;
|
||||
Back returns to the place left, sheet included.
|
||||
Back returns to the place left, references dialog included (the sheet until 2026-11-15).
|
||||
3. A move made in the same instant as a pending Back can be swallowed (not reachable at human speed).
|
||||
4. « Aller à » a finding opens its dialog in view mode (accepted again by the owner, 2026-11-14).
|
||||
5. The search of the References tab is not in the history: a plain tab change keeps it, « Tout afficher » clears it;
|
||||
@@ -358,6 +366,8 @@ Adjustments:
|
||||
une référence »; the one « Enregistrer » writes the citations with the other fields as one undoable operation. The
|
||||
citations sheet is read-only for the finding (no « Retirer de ce constat »); while the form is open it lists the
|
||||
draft's references. The key `editor.references.remove_citation` is deleted (`V1-2-6_R2_LABELS.md` §9).
|
||||
Superseded 2026-11-15: the finding's edit form no longer holds citations (the references dialog's own edit mode
|
||||
does), and the sheet is a dialog.
|
||||
- Deletion and Back (`085c568`, `4018344`): the deletion closes its dialog by popping the entry, so the first Back
|
||||
moves; the first « Défaire » after a deletion restores the finding at once (Constats opens, the row is selected and
|
||||
focused). Choosing « Plus » entry puts the focus on the new tab's panel (the panels take `tabIndex=-1` and show a
|
||||
@@ -372,11 +382,12 @@ Adjustments:
|
||||
cancelable, a jump of several entries out of the editor with a dirty finding or reference dialog is cancelled and
|
||||
the top dirty dialog asks « Abandonner les modifications ? ». « Abandonner » runs the jump again with
|
||||
`traverseTo`, leaving no flag and no notice. With two dirty dialogs the question cascades from the top. Before
|
||||
the finding asks, the citations sheet and a clean reference dialog over it close, so its question is never hidden
|
||||
under them. Without the API or when the event is not cancelable, the earlier flag and notice stay.
|
||||
the finding asks, the citations dialog (a sheet until 2026-11-15) and a clean reference dialog over it close, so its
|
||||
question is never hidden under them. Without the API or when the event is not cancelable, the earlier flag and notice stay.
|
||||
- Notice after the loss elsewhere: unchanged text, now keyed by the session tag.
|
||||
- Final review, rev 4 (2026-11-14): a Back asks only the layers it removes. A Back that closes only the citations
|
||||
sheet, or a clean reference dialog over it, closes it and asks nothing, even over a dirty finding form. A Back or a
|
||||
sheet, or a clean reference dialog over it, closes it and asks nothing, even over a dirty finding form (since
|
||||
2026-11-15 a dirty citations draft is asked like the finding form). A Back or a
|
||||
jump that removes the dirty finding dialog first closes the clean layers over it, so its question is visible and
|
||||
focused. A sign-out, or a session ending, while a dialog holds unsaved text leaves one flag with no text, keyed by
|
||||
the sheet id and by a fingerprint of the account salted with a random value stored in the flag: the same account's
|
||||
@@ -396,8 +407,8 @@ Accepted limits (owner, 2026-11-14):
|
||||
Limits found during these adjustments, to be confirmed by the owner at the final checks (`V1-2-6_OWNER_TRIAL.md`
|
||||
§4.12):
|
||||
5. In the leave cascade, « Continuer la saisie » on a lower dialog keeps that draft; a draft already abandoned above
|
||||
stays dropped (the user's choice). The sheet and a clean reference dialog over the finding close before its
|
||||
question; one Back then reopens the citations sheet.
|
||||
stays dropped (the user's choice). The references dialog (a sheet until 2026-11-15) and a clean reference dialog
|
||||
over the finding close before its question; one Back then reopens the references dialog.
|
||||
6. Android Back closing « Plus » relies on `CloseWatcher` and is proved by a stub test only.
|
||||
7. BLK-015 and `admin.spec.ts`: tracked apart (RR-13), unchanged.
|
||||
|
||||
@@ -408,6 +419,53 @@ leave is confirmed where the browser can cancel it.
|
||||
Status: R2 validated, closed pending the final manual checks (`V1-2-6_OWNER_TRIAL.md` §4.12). The owner still has to
|
||||
check Android Back on a real phone.
|
||||
|
||||
#### Owner follow-up 2026-11-15
|
||||
|
||||
Status: built on `feature/v1-2-anatomical-sheets` on top of `b41c24b` (plan « Rev 5 »,
|
||||
`.claude/tasks/plans/2026-11-13-r2-ux-finish-1624.md`, contract criteria 26 to 31), awaiting the owner's `db:trial`
|
||||
check (`V1-2-6_OWNER_TRIAL.md` §4.13), then R2 closure. Nothing merged, nothing deployed.
|
||||
|
||||
The trial validated the finding dialogs and « Défaire » / « Refaire ». Two adjustments were asked.
|
||||
|
||||
Requests (owner brief 2026-11-15):
|
||||
1. References apart from the finding. The finding dialog keeps « Références citées » and « X références » in view and
|
||||
in edit mode. The button opens a references dialog stacked over it, which replaces the side sheet. View mode only
|
||||
reads. Its own « Modifier » cites an existing reference, removes one, creates one (cited in the draft), opens a
|
||||
reference's dialog, saves (one « Défaire ») or cancels. Families get it too.
|
||||
2. One tab order: Général, Annotations, Constats, Références, Vérification. On phones Général and Annotations are
|
||||
shown and the rest sits under « Plus », in that order. « Plus » is a vertical list: rows of 48 px at least, the
|
||||
active entry tinted with a check mark, light motion, the error count on « Plus » while Vérification is under it.
|
||||
|
||||
Built, by task:
|
||||
- Task 10, one tab order and the vertical « Plus » list: `ff21b03`, `da755f9` (hover tint, axe on an active row, line
|
||||
limits). `tabs.ts` shows the first two tabs on phones; `initialTab` lost its tier parameter. The active row carries
|
||||
`aria-current="true"` besides the tint and the check mark.
|
||||
- Task 11, the references dialog in view mode: `abc781d`, `2c4c771`, then `d9dbcf1` with the review minors. The trigger
|
||||
« X références » is a dialog trigger (`aria-haspopup="dialog"`). `CitationsSheet`, its motion, `FindingEditCitations`
|
||||
and the shortcut store `citationDraft.ts` are gone. The finding's edit form no longer carries `reference_ids`: its
|
||||
save never rewrites citations.
|
||||
- Task 12, the dialog's edit mode: `3dc5820`, `2579d4c`. Draft held as adds and removes, applied to the element's
|
||||
current list at save, so a reload or a change made elsewhere is never overwritten silently. « Enregistrer » writes
|
||||
one `update` of `reference_ids` (none when pristine), then back to view mode with « Modifications enregistrées » and
|
||||
the focus on « Modifier ». A new guarded layer `citations` sits between `finding` and `reference`: a dirty draft
|
||||
refuses ✕, Escape, backdrop, Back and the leave cascade like the finding form.
|
||||
- Task 13, this documentation.
|
||||
|
||||
Controller rulings (autonomous mandate, reported to the owner):
|
||||
- Families (categories) get the same dialog as findings; both hold citations.
|
||||
- View mode is read only: no « Modifier » on its tiles; « Modifier la référence » lives on the edit form's rows.
|
||||
- « Nouvelle référence » creates a reference and cites it in the draft.
|
||||
- On phones the visible tabs are the first two of the order; no arrow-key navigation in « Plus » (Tab moves, Tab out
|
||||
closes).
|
||||
- A reference created from the dialog, then the draft abandoned, stays in the library uncited. The creation is its own
|
||||
undo step, tested and documented.
|
||||
|
||||
Labels: `V1-2-6_R2_LABELS.md` §10. Browser proofs: `BROWSER_TESTS.md`. Gates at the last Task 12 commit: typecheck and
|
||||
lint 0, `test:run` 1683, `e2e:ui` 251, the touched `e2e:shell` specs green with the full-row guard clean. The full
|
||||
`e2e:shell` sweep is not rerun for Rev 5 (BLK-015 `admin.spec.ts` unchanged).
|
||||
|
||||
Status: awaiting the owner's `db:trial` check (`V1-2-6_OWNER_TRIAL.md` §4.13), then R2 closure.
|
||||
|
||||
Original plan text:
|
||||
|
||||
- Tab model: `EDITOR_TABS` gains `references` between `findings` and `verification` (`apps/app/src/editor/tabs.ts:6-11`),
|
||||
|
||||
Reference in new issue
Block a user