test(editor): reference dialog, filter and the owner journey, specs follow the dialog

This commit is contained in:
bchanot committed 2026-11-13 20:27:01 +01:00
1 parent 7a64daf251
commit 8b42816270
20 files changed
+1546 -1171

No files matched your search

@@ -86,6 +86,43 @@ describe('sanitizeView', () => {
expect(sanitizeView(odd)?.finding).toBeNull()
})
it('the reference dialog is a form: over References or the sheet, never at a reload', () => {
const edit = { edit: 'ref-a' }
const tab = { ...view('references'), reference: edit }
expect(sanitizeView(tab)?.reference).toEqual(edit)
expect(sanitizeView(tab, false)?.reference).toBeNull()
const sheet = {
...view('findings'),
finding: { key: node, citations: true },
reference: edit,
}
expect(sanitizeView(sheet)?.reference).toEqual(edit)
const noSheet = { ...sheet, finding: { key: node, citations: false } }
expect(sanitizeView(noSheet)?.reference).toBeNull()
const creation = { ...view('references'), reference: { create: true } }
expect(sanitizeView(creation)?.reference).toEqual({ create: true })
const elsewhere = { ...view('general'), reference: { create: true } }
expect(sanitizeView(elsewhere)?.reference).toBeNull()
expect(
sanitizeView({ ...tab, reference: { edit: '' } })?.reference,
).toBeNull()
})
it('the finding filter names a finding node and lives on the References tab only', () => {
const filtered = view('references', { referenceFilter: node })
expect(sanitizeView(filtered)?.referenceFilter).toEqual(node)
expect(sanitizeView(filtered, false)?.referenceFilter).toEqual(node)
expect(
sanitizeView({ ...view('general'), referenceFilter: node })
?.referenceFilter,
).toBeNull()
const zone = { kind: 'zone', id: 'z' }
expect(
sanitizeView({ ...view('references'), referenceFilter: zone })
?.referenceFilter,
).toBeNull()
})
it('drops what is no view: an unknown tab, a non-object', () => {
expect(sanitizeView({ tab: 'nowhere', section: 'views' })).toBeNull()
expect(sanitizeView('general')).toBeNull()
@@ -211,6 +248,46 @@ describe('planWrite', () => {
})
})
describe('planWrite and the reference layers', () => {
const sheet = view('findings', { finding: { key: node, citations: true } })
const dialog = { ...sheet, reference: { edit: 'ref-a' } }
const top = (v: EditorView, below: EditorView | null) =>
entry({ view: v, below })
it('the reference dialog is a layer: added pushes, removed goes back to the view below', () => {
expect(planWrite(top(sheet, null), dialog, false)).toBe('push')
expect(planWrite(top(dialog, sheet), sheet, false)).toBe('back')
expect(planWrite(top(dialog, view('general')), sheet, false)).toBe(
'replace',
)
expect(layerCount(dialog)).toBe(3)
})
it('a creation turned into its element is a replace; the filter removal is a replace hint', () => {
const creating = view('references', { reference: { create: true } })
const editing = view('references', { reference: { edit: 'ref-n' } })
expect(planWrite(top(creating, null), editing, true)).toBe('replace')
const filtered = view('references', { referenceFilter: node })
expect(planWrite(top(filtered, sheet), view('references'), true)).toBe(
'replace',
)
})
it('« Revenir au constat » goes back when the entry below shows that finding, else pushes', () => {
const filtered = view('references', { referenceFilter: node })
const dialogOnly = view('findings', {
finding: { key: node, citations: false },
})
expect(planWrite(top(filtered, sheet), dialogOnly, false, node)).toBe(
'back',
)
expect(
planWrite(top(filtered, view('general')), dialogOnly, false, node),
).toBe('push')
expect(planWrite(top(filtered, sheet), dialogOnly, false)).toBe('push')
})
})
describe('createWriteBudget', () => {
it('lets the limit through per window, then refuses until the window slides', () => {
const take = createWriteBudget(3, 1000)