From 84ce19552fce5e7a5da507d3c2f35f69cb4f5188 Mon Sep 17 00:00:00 2001 From: bchanot Date: Sun, 22 Nov 2026 21:22:15 +0100 Subject: [PATCH] =?UTF-8?q?chore(memory):=20contract=20=E2=80=94=20owner?= =?UTF-8?q?=20graphic=20validation=20of=20detail=20views=20revision=204?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../tasks/contracts/2026-11-22-detail-views-graphic-crop-0134.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.claude/tasks/contracts/2026-11-22-detail-views-graphic-crop-0134.md b/.claude/tasks/contracts/2026-11-22-detail-views-graphic-crop-0134.md index 9d79a402..816cbdd8 100644 --- a/.claude/tasks/contracts/2026-11-22-detail-views-graphic-crop-0134.md +++ b/.claude/tasks/contracts/2026-11-22-detail-views-graphic-crop-0134.md @@ -82,6 +82,7 @@ Q: Relation to the V1-2.6 UX plan / A: code fact (analysis 2026-11-22): the requ Q: Owner arbitrations on Q1-Q4 + aspect ratio (2026-11-22, second message) / A: [gated 2026-11-22] Q1 option B: bring forward only the minimum of the U6 internal access category; present the consequences (schema, Rust, SQL) before any such change. Q2 overlap allowed: annotations keep click/touch priority, the access must stay reachable even when heavily covered. Q3 new view starts empty, annotations stay on their view, any copy handled in U5; fix the contradictory caption of validated board 08. Q4 keep free-form accesses: create and edit rectangle, polygon and circle accesses; crop rectangle and access are distinct; an access may be generated at view creation then reshaped (like the head); avoid a fifth permanent button. 4:3 not validated: study free-ratio crops and their consistency in editor, bilan and PDF. Update analysis, arbitrations and mockups; final panels at readable size before graphic validation; then the implementation plan. Q: Owner review of board revision 2 (2026-11-22, third message) / A: [gated 2026-11-22] Validated: functional orientation; internal category principle (auto-created, holds generated and hand-drawn accesses, absent from anatomical categories, head access stays in Articulations); overlap + annotation priority on editor, catalogue and bilan + clickable label incl. keyboard; crop on parent, 8 handles, crop/access separation, auto access then reshape, rectangle/polygon/circle accesses, view+access in one Undo, back to parent, graphic recrop; new view empty (copy = U5); targeted PDF fix; new accesses grouped under « Accès aux vues détaillées » in the annotations list, not an ordinary category; labels hidden during recrop. To do: compatibility strategy for the `role` key (compatible evolution, versioning or controlled restriction; no silent incompatibility under one schema version without explicit justification; SQL and Rust consequences checked before applying); limit label conflicts near each other and at the drawing edge; NO arbitrary ratio bound (no 1:2-3:1), keep minimum sizes and justified technical limits; editor and bilan may keep a 4:3 space with neutral bands, nothing outside the crop in a detail view; PDF keeps proportions, no stretch; PDF fix with visual non-regression tests and a check of existing PDFs and goldens. Deliver: analysis, arbitrations and mockups updated; final panels at full resolution (creation, free crop, polygon and circle access, labels, bilan navigation, portrait and very elongated view) in an easily browsable folder or archive; graphic validation before the implementation plan. Technical solutions compatible with these decisions are delegated. Q: Owner arbitrations on board revision 3 (2026-11-22, fourth message) / A: [gated 2026-11-22] Validated: reserved id `cat-access` instead of `role: navigation` now; schema v2, no new key, no SQL migration for this feature; plan must verify: no collision with an existing category, creation by the core, uniqueness and behaviour on removal or edit, read and rewrite by an N-1 application, compatibility with existing sheets, future transition to the U6 role. Free-ratio crops validated with justified technical limits, very elongated both ways, handle manipulation by mouse and touch; whole crop with neutral bands in editor and bilan; content outside the crop never visible in a detail view. PDF option validated: views with width/height >= 3:1 use the full available width, height per real proportions; no stretch, no squash, no drawing outside the crop, no overlap with notes or other PDF elements; layout may adapt; both Rust defects fixed in the plan; existing PDF test references checked without automatic regeneration, any needed change justified and submitted. D25 validated (five fixed positions, no tab over a tab or a point, never outside the drawing, leader when moved, long names abbreviated with full name reachable) plus an accessible behaviour when no position fits, so a view is never impossible to open. Panel 15 to be redrawn with real D25 phone behaviour (close accesses, crossing leaders); panel 17 needs no artificial above-right geometry, that case is covered by tests. Graphic validation still pending on full-resolution panels 11, 15, 17, 18, 19; then the implementation plan with the usual reviews. +Q: Owner graphic validation of board revision 4 (2026-11-22, fifth message) / A: [gated 2026-11-22] Revision 4 validated graphically, no new mockup revision. Approved: rectangle selection on the parent view, eight crop handles, free ratio, crop vs access distinction, auto-generated access, independent reshaping, rectangle/polygon/circle accesses, access labels and their interaction priority, D25 placement, « Autres vues (N) » fallback, panel 15 phone behaviour (five close accesses: two tabs stay, three go to « Autres vues (3) »), recrop of existing views, nested view navigation, neutral bands and nothing outside the crop, PDF full width from 3:1. Compatibility strategy confirmed: reserved id `cat-access`, no new schema key, no SQL migration for this feature. The plan must keep explicit: (1) a view may temporarily have no access while a draft is prepared, but a detail view without an access from its parent keeps an error that blocks submission; (2) the PDF fix covers long notes, the current 60 pt floor, page breaks and no overlap with other elements, never deforms images nor shows content outside the crop. Plan must separate: Rust core changes; document compatibility and the N-1 reader; frame creation and editing; accesses and their shapes; annotation priority on the three surfaces; label placement and accessibility; parent/child navigation; PDF engine fixes; automated tests and manual trials on db:trial. Non-regression tests on historical documents and existing PDF references; new PDF references shown to the owner visually before being frozen. Keep: no change to pre-existing sandbox data, never editor-equine on the persistent sandbox, never DEV, no db:trial without an authorised checkpoint, no merge, no deploy. Usual plan reviews with autonomy on technical details; present the final plan and any arbitrations. This validation covers the design only: no code before the owner validates the technical plan. ## ACCEPTANCE CRITERIA Phase 1 (this run, before any product code):