fix(editor): slider while replacing, announced drop, review minors
Task 7 fix round 1 (review task-7-review.md). - Important 1: « Taille » shows beside « Revenir aux propriétés » while a point is replaced (still hidden under the modal dialog); it feeds the hover preview and the re-placed point (R-10). - Important 2: a creation whose view leaves the document is dropped and said, « Création abandonnée : la fiche a changé. » (dropped: 'creation', read by useDroppedNotice). - Minor 3: DrawingGuardDialog leaves a creation question to the creation dialog only while that dialog is really on screen (creationShown, set by the dialog). - Minor 7: the dialog's long className strings split into constants. - Minor 8: dead TOOL_OF removed; trace_start is a redraw's only. Tests added (no assertion removed): slider while replacing (unit, RED then GREEN; e2e under expectNoShift at three widths, last strip command inside the strip); view removed during a creation (RED then GREEN); question shown by the workspace when the dialog is not on screen (RED then GREEN); « Abandonner » while read-only; R-13 with a restored copy during a started move; leaving the route resets the work (fails with the session reset removed). The unit Back test's comment is corrected: it does pin the modal branch.
This commit is contained in:
1 parent
fe333c2bbd
commit
837ec9f436
14 files changed
+315
-29
No files matched your search
@@ -13,7 +13,7 @@ export default function DrawingGuardDialog() {
|
||||
const t = useT()
|
||||
// Over a shown creation dialog the question is that dialog's own (R-12, board 31 D).
|
||||
const question = useAnnotationWork((s) =>
|
||||
s.question?.work === 'creation' && s.creation?.dialog ? null : s.question,
|
||||
s.question?.work === 'creation' && s.creationShown ? null : s.question,
|
||||
)
|
||||
// The title stays while the dialog closes.
|
||||
const title = useRef('')
|
||||
|
||||
Reference in new issue
Block a user