chore(memory): V1-2.2 reserved ids evidence, mutations, contract, TODO

This commit is contained in:
bchanot committed 2026-10-30 17:31:01 +01:00
1 parent 6ed4d21eb3
commit 81f7639c75
5 files changed
+155

No files matched your search

@@ -0,0 +1,36 @@
# V1-2.2 reserved ids (owner brief 2026-10-30), mutation run (evidence
# .claude/audits/2026-10-30-v1-2-2-reserved-ids-evidence.md §4): each mutant is applied to its source
# file, its cargo suite runs (`features` set when the suite needs them), the file is restored. Run
# from the repo root.
import subprocess
PDF='--features pdf-read,pdf-write'
muts=[
('K1 reader skips the reserved check','crates/core/src/anatomy/svg/mod.rs',' refs::check_reserved_ids(&sanitized.root)?;\n','','svg_reserved_ids',''),
('K2 cleaning skips the reserved check','crates/core/src/anatomy/svg/clean.rs','.and_then(|()| check_reserved_ids(&read.root))','','svg_reserved_ids',''),
('K3 exact case only','crates/core/src/anatomy/svg/refs.rs','.any(|reserved| id.eq_ignore_ascii_case(reserved))','.any(|reserved| id == *reserved)','svg_reserved_ids',''),
('K4 prefix instead of exact name','crates/core/src/anatomy/svg/refs.rs','.any(|reserved| id.eq_ignore_ascii_case(reserved))','.any(|reserved| id.to_ascii_lowercase().starts_with("osteo-"))','svg_reserved_ids',''),
('K5 root id not checked','crates/core/src/anatomy/svg/refs.rs',' element.attr("id").is_some_and(is_reserved_id)\n || element',' element','svg_reserved_ids',''),
('K6 descendants not checked','crates/core/src/anatomy/svg/refs.rs',' || element.element_children().any(holds_reserved_id)',' || false','svg_reserved_ids',''),
('K7 highlight composes a reserved id','crates/core/src/anatomy/compose.rs',' if holds_reserved_id(&asset) {\n return Err(ComposeError::ReservedId);\n }\n','','svg_reserved_ids',''),
('K8 canvas composes a reserved id','crates/core/src/anatomy/compose.rs',' if holds_reserved_id(asset) {\n return Err(ComposeError::ReservedId);\n }\n','','svg_reserved_ids',''),
('K9 pre-fix composer restored (no guard, halo skipped when the drawing has one)','crates/core/src/anatomy/compose.rs',' if holds_reserved_id(&asset) {\n return Err(ComposeError::ReservedId);\n }\n','','svg_reserved_ids','',
(' if !append_to_first_defs(root) {',' if holds_reserved_id(root) {\n return;\n }\n if !append_to_first_defs(root) {')),
('K10 halo not written','crates/core/src/anatomy/compose.rs',' add_halo_filter(&mut asset);','','pdf_session',PDF),
('K11 reason renamed','crates/core/src/anatomy/svg/tree.rs','Self::ReservedId => "reserved_id"','Self::ReservedId => "dangling_reference"','svg_reserved_ids',''),
]
for name,path,old,new,suite,features,*more in muts:
src=open(path).read()
mutant=src
for o,n in [(old,new)]+list(more):
if mutant.count(o)!=1:
print(name,'ANCHOR NOT FOUND x',mutant.count(o)); mutant=None; break
mutant=mutant.replace(o,n)
if mutant is None:
continue
open(path,'w').write(mutant)
try:
r=subprocess.run(['bash','-c',f'. scripts/rust-env.sh && cargo test -q -p faunosteo-core {features} --test {suite} 2>&1 | tail -3'],capture_output=True,text=True)
out=r.stdout
print(f"{name} ({suite}): {'KILLED' if 'FAILED' in out else ('COMPILE-ERR' if 'could not compile' in out else 'SURVIVED')}", flush=True)
finally:
open(path,'w').write(src)
@@ -0,0 +1,64 @@
# V1-2.2 reserved ids: evidence (2026-10-30)
Owner brief « V1-2.2 : correction de sécurité PDF et poursuite A6 » on `2f1f076`. Contract
`.claude/tasks/contracts/2026-10-30-v1-2-2-reserved-ids.md`; docs RUST.md §12.9.
## 1. Audit
- Written by the engine next to the drawing's ids: `osteo-halo` only (`compose::compose_highlight`, PDF view,
rasterised as a document of its own, drawing ids kept). Before the fix `ensure_halo_filter` returned early when
the drawing held a `filter#osteo-halo`; otherwise the filter went into the first `<defs>` (or a new one placed first),
so an element holding the id earlier in document order won `url(#osteo-halo)`.
- Not colliding: the canvas scopes every drawing id to `fv.<view>.` (page ids never start with `fv.`); the annotation
layer writes no `id`, and its `data-*` cannot be forged (the reader removes every `data-*`); the filter's `result`
names `haloWide` / `haloTight` resolve inside their filter only; `class="detail-zone"` styles nothing in the app CSS.
- Historical drawings: 75 committed SVG files; `osteo-overlays` in 11 of them (legacy editor group), among them
`supabase/seed/anatomical-sheets/equine/draft/assets/horse.svg` (sha256 `0ea5202f…`, the DEV object). `osteo-halo` in
none but the hostile fixture `crates/core/tests/fixtures/svg/hostile/osteo-halo-id.svg`. Hence an exact reserved set,
not an `osteo-*` namespace.
## 2. Pixel proof (Chromium 156.0.8078.4, Image + canvas as `browserRasterizer.ts`, 1200 × 943, main view, `hip` selected, halo on)
Composed SVG written by a throwaway integration test (never committed) from the equine drawing with a body injected
after the root's opening tag; pixels within ±24 per channel of `#b85a3f` counted.
| Drawing | Before (`2f1f076`) | After |
|---|---|---|
| equine, unchanged | composed, 1602 px | composed, 1602 px, SVG byte-identical |
| + `<filter id="osteo-halo"><feColorMatrix values="0 …0"/></filter>` | composed, **0 px** (marker erased) | refused `reserved_id` |
| + `<g id="osteo-halo"/><defs/>` | composed, 825 px (halo lost) | refused `reserved_id` |
## 3. Tests
`svg_reserved_ids` 9 tests; `pdf_session` + 1 (`the_pdf_refuses_a_reserved_id_and_keeps_its_own_halo`);
`anatomy_compose` R5.7 test renamed (`the_halo_filter_is_written_once_and_a_composed_root_is_refused`, ledger row
updated); `svg_clean` corpus line and `svg_sanitiser` declared divergence for `osteo-halo-id.svg`; core-wasm
`preview.test.ts` three spellings on the shipped module.
## 4. Mutations (`2026-10-30-v1-2-2-mutations-reserved-ids.py`)
11 of 11 killed: reader check removed, cleaning check removed, exact case only, `osteo-` prefix, root id unchecked,
descendants unchecked, highlight guard removed, canvas guard removed, pre-fix composer restored (guard removed and halo
skipped when the drawing holds one), halo not written, reason renamed. A first K9 (« skip the halo when the root has an
id ») survived: no tested drawing has a root id, a mutant with no meaning for the fix; replaced by the pre-fix restore.
## 5. Gates
- `pnpm rust:check`: green (fmt, clippy `-D warnings` on every feature set, 2032 tests summed over the feature passes,
ts-rs export, cargo deny).
- `pnpm check`: green (typecheck, core-wasm 65, supabase 128, app 566, lint, build). First run failed on
`r5.census.test.ts`: the ledger still named the renamed cargo test; row updated.
- Module: 559 360 → 560 015 B gzip -9 (+655 B), 1 513 522 → 1 513 968 B raw; Node's gzip 569 350 B (budget 600 000).
- `pnpm check:all` on the working tree (code as committed): green, e2e:ui PASSED, app image, worker sandbox tests and
runtime image; e2e:shell not run (needs the isolated stack, no change in its scope).
## 6. Independent reviews (fresh, Opus: the pinned Fable model was out of credits)
- Verifier: ECARTS(1) LOW, C8: a doc comment in the new `pdf_session.rs` helper held the shell expansion of `id` (an
unquoted heredoc while writing it), leaking the local uid and groups; fixed before any commit, the diff scanned for
other expansions (none). C1-C7, C9, C10 met; floor guard clean on the diff.
- Security: PASS, no regression or weakened control. Reported, pre-existing, owner decision: MEDIUM root `visibility`
(a drawing `<svg visibility="hidden">` with `visibility="visible"` children reads clean and the appended marker layer
inherits `hidden`: 0 highlight pixels in the PDF, markers gone in the canvas too); LOW root `stroke*` inheritance onto
the point hitbox; LOW the drawing chooses which `<defs>` receives the halo (sRGB vs linearRGB, cosmetic); LOW intended
behaviour change (re-export of an archive or a logo holding the id refused).