chore(memory): LRN-148 + LRN-149, BLK-016 resolved — criterion 32 owner validation · TODO +0 / -1
This commit is contained in:
1 parent
04ec232613
commit
80991badce
5 files changed
+21
-2
No files matched your search
@@ -132,3 +132,4 @@ Refs: `docs/development/BROWSER_TESTS.md` §6, `V1-2-6_U1_CORRECTIONS.md` §R2,
|
|||||||
**Real cause:** pinned column CSS budget (`--edit-column-parts`, index.css) counts ONE chip row since U2 Task 17; each extra row ~38 px (derived).
|
**Real cause:** pinned column CSS budget (`--edit-column-parts`, index.css) counts ONE chip row since U2 Task 17; each extra row ~38 px (derived).
|
||||||
**Solution:** owner 2026-11-20: single horizontally scrolling chip row (finger swipe, no page sideways scroll, keyboard reach, active view clear, discreet off-screen hint, no drawing-gesture regression); mockup before code. Test parked `test.fixme` in `editor-geometry.spec.ts`.
|
**Solution:** owner 2026-11-20: single horizontally scrolling chip row (finger swipe, no page sideways scroll, keyboard reach, active view clear, discreet off-screen hint, no drawing-gesture regression); mockup before code. Test parked `test.fixme` in `editor-geometry.spec.ts`.
|
||||||
**Status note:** open until mockup validated and implemented.
|
**Status note:** open until mockup validated and implemented.
|
||||||
|
- **Status (2026-11-22)**: resolved b4ebc2d2..7d6f7cb2, owner db:trial validation 2026-11-22
|
||||||
@@ -595,3 +595,4 @@ R5.4: `draft/{labels,changelog,review_report,drawing,overlay,app_review,svg_comp
|
|||||||
|
|
||||||
## 2026-11-22
|
## 2026-11-22
|
||||||
- Criterion 32 one scrolling view row built cbde3646..b59751d3 (ViewSwitcher one 44 px row, viewRow.ts, budget 162/154 px, thresholds 658/650). Final review fixes: reversed slide, double click ignored, 2 vacuous e2e. Verifier 13/13 + security PASS; full shell 381 pass, 13 fail = known 13. Trial step 23 probed in UI. BLK-016 open until owner check.
|
- Criterion 32 one scrolling view row built cbde3646..b59751d3 (ViewSwitcher one 44 px row, viewRow.ts, budget 162/154 px, thresholds 658/650). Final review fixes: reversed slide, double click ignored, 2 vacuous e2e. Verifier 13/13 + security PASS; full shell 381 pass, 13 fail = known 13. Trial step 23 probed in UI. BLK-016 open until owner check.
|
||||||
|
- Owner validated criterion 32 on db:trial 2026-11-22 (mouse, keyboard, tablet+phone, stability all OK); BLK-016 resolved; 2 LRN. New U2 ask: detail views by graphic crop selection, access zones on parent drawing, crop editing: analysis + mockups first.
|
||||||
@@ -999,3 +999,20 @@ Apply: single-request failure e2e; any CSS-only collapsible panel.
|
|||||||
**Pattern:** editor drawing reacts only to pointerdown/pointerup (`usePressGesture.ts` onClick from press effect); no DOM `click` listener on canvas. Assistive tech activation sending bare click (no pointer events) does nothing on drawing.
|
**Pattern:** editor drawing reacts only to pointerdown/pointerup (`usePressGesture.ts` onClick from press effect); no DOM `click` listener on canvas. Assistive tech activation sending bare click (no pointer events) does nothing on drawing.
|
||||||
**Context:** U2 trial screen-reader path: tool armed by AT click, then drawing activation ignored; only Enter keydown on focused drawing works (focus mode).
|
**Context:** U2 trial screen-reader path: tool armed by AT click, then drawing activation ignored; only Enter keydown on focused drawing works (focus mode).
|
||||||
**Application:** any create/act path for AT users needs explicit button (e.g. « Placer au centre »), never drawing activation. Do not trust read-before claims on click paths: read the press machine.
|
**Application:** any create/act path for AT users needs explicit button (e.g. « Placer au centre »), never drawing activation. Do not trust read-before claims on click paths: read the press machine.
|
||||||
|
|
||||||
|
## LRN-148 — Scroll-row reveal: judge vs pending slide target; ignore detail>1 on sliding row (2026-11-22)
|
||||||
|
**Context:** Faunosteo view chip row (`ViewSwitcher.tsx`, `viewRow.ts`): one scrolling row, smooth `scrollTo` reveal keeps focused/active chip clear of 72 px fades. Final review cbde3646..295413c5 found 2 gaps on owner requirements (keyboard chip visible; no click lost because row moves).
|
||||||
|
**Pattern 1 (reversed slide):** reveal judged "already clear" from instantaneous `scrollLeft` while smooth slide in flight → null, old slide runs on to old target → newly focused chip ends under fade (measured 47.5 px; chevron page then arrow 382 px). Fix: pending target in ref, judge vs `pending ?? scrollLeft`; clear on `scrollend`, on reach, on wheel/touchstart/pointerdown, on any instant scroll. Chevron page starts from pending too → repeated clicks add up.
|
||||||
|
**Pattern 2 (double click):** row slides after activation (reveal follows `current`) → 2nd click of dblclick lands on neighbour. Fix: chip `onClick` ignores `event.detail > 1`; keyboard (detail 0) and first click/tap (detail 1) unchanged.
|
||||||
|
**Tests:** repro e2e must NOT settle between keys and must wait out 500 ms opening window (instant reveals there hide race). RED before fix, GREEN after.
|
||||||
|
**Limits:** proven Chromium only. Engine without `scrollend` keeps stale pending until row reaches it (`shortcut:` comment). Tablet double-tap counting browser-dependent (owner tablet trial 2026-11-22 OK). Tap on another chip during slide may still hit neighbour: not handled, option "freeze row on press".
|
||||||
|
**Future:** any scroll container with animated programmatic reveal + clickable items: track pending target; guard multi-click.
|
||||||
|
Reference: commit bc82cd63, 411bdb01.
|
||||||
|
|
||||||
|
## LRN-149 — Owner trial step needing data absent from trial seed: execute it once in UI first (2026-11-22)
|
||||||
|
**Context:** criterion 32 tablet step 23 (`V1-2-6_OWNER_TRIAL.md`) written for "fiche équine (plusieurs vues aux noms longs)"; db:trial seeds equine draft with 2 views → row never overflows at tablet width → step unperformable. Doc executor missed it; fresh verifier caught it (criterion 13 NOT-MET at 58561e56).
|
||||||
|
**Pattern:** before handing owner a trial step, check trial stack seed (`scripts/db-trial.sh`, seed folder) holds data step needs. Missing → step opens with preparation sub-step, and preparation executed once in real UI on sandbox (temp Playwright probe spec, deleted after, `git status` clean) to name exact controls, fields, expected side effects.
|
||||||
|
**Probe found:** views section behind « Gérer les vues » (not a tab); exact crop labels; 6 blocking « Vérification » errors expected while views exist; « Supprimer » + confirm; « Défaire » restores. Trial draft holds owner edits: never call it disposable.
|
||||||
|
**Limits:** probe on sandbox with `equineShape` (1 view), mouse only, 1180×820; touch items stay owner trial. Never run on db:trial or DEV (Claude writes nothing on trial stack).
|
||||||
|
**Future:** any owner trial step: seed check + one UI execution before hand-over.
|
||||||
|
Reference: commit b510bf9c.
|
||||||
@@ -939,5 +939,5 @@ Apply when implementing B-phase:
|
|||||||
- [x] owner arbitrations (brief « arbitrages propriétaire et préparation de validation finale », 2026-11-02, on c2a3147): A1 BDR-095, A2 board 05 whole horse at 768 px, A3 V1-2.7 lists on failure_outcome, A4 24 common labels + owner arbitrations, A5 affected boards + contact sheet + archive -3.zip; verifier ECARTS(2) → ECARTS(1) → CONFORME 21/21 (27e5727, 74aa8f6)
|
- [x] owner arbitrations (brief « arbitrages propriétaire et préparation de validation finale », 2026-11-02, on c2a3147): A1 BDR-095, A2 board 05 whole horse at 768 px, A3 V1-2.7 lists on failure_outcome, A4 24 common labels + owner arbitrations, A5 affected boards + contact sheet + archive -3.zip; verifier ECARTS(2) → ECARTS(1) → CONFORME 21/21 (27e5727, 74aa8f6)
|
||||||
- [ ] Anomaly to diagnose (owner 2026-11-20, new, intermittent): axe colour-contrast failure on the animal archive dialog in the shell suite. Cause not concluded: do not assume it is only a measure taken during the animation. Diagnose with repeated runs, the computed colours and the animation state; no fix before the cause. Known failures outside U2 stay as documented.
|
- [ ] Anomaly to diagnose (owner 2026-11-20, new, intermittent): axe colour-contrast failure on the animal archive dialog in the shell suite. Cause not concluded: do not assume it is only a measure taken during the animation. Diagnose with repeated runs, the computed colours and the animation state; no fix before the cause. Known failures outside U2 stay as documented.
|
||||||
- [x] U2 trial adjustments (owner trial 2026-11-20; contract `.claude/tasks/contracts/2026-11-20-u2-trial-adjustments-1259.md`, plan `.claude/tasks/plans/2026-11-20-u2-trial-adjustments-1259.md`, commits 4e993058..007d9d41): « Ajouter … » buttons arm their tool on a click or tap (keyboard keeps the centre path, Enter on the drawing while armed, polite announcement); coarse handles lighter (14 / 18 / 32 × 26, hit areas kept); « − » bubble on the open side of its vertex, clear of shown « + » hit areas, on screen. Verifier CONFORME 15/15, security PASS, final review fixes applied. Awaiting the owner's targeted check on db:trial.
|
- [x] U2 trial adjustments (owner trial 2026-11-20; contract `.claude/tasks/contracts/2026-11-20-u2-trial-adjustments-1259.md`, plan `.claude/tasks/plans/2026-11-20-u2-trial-adjustments-1259.md`, commits 4e993058..007d9d41): « Ajouter … » buttons arm their tool on a click or tap (keyboard keeps the centre path, Enter on the drawing while armed, polite announcement); coarse handles lighter (14 / 18 / 32 × 26, hit areas kept); « − » bubble on the open side of its vertex, clear of shown « + » hit areas, on screen. Verifier CONFORME 15/15, security PASS, final review fixes applied. Awaiting the owner's targeted check on db:trial.
|
||||||
- [ ] Criterion 32, one scrolling view row (owner GO 2026-11-21, plan `.claude/tasks/plans/2026-11-21-chip-row-criterion-32-1400.md` rev 3, contract `.claude/tasks/contracts/2026-11-21-chip-row-criterion-32-1400.md`): BUILT cbde3646..HEAD on feature/v1-2-anatomical-sheets (ViewSwitcher one row in a fixed 44 px band, viewRow.ts, pinned budget 162/154 px, thresholds 658/650 px; criterion 32 e2e re-enabled, green at the four windows). Verifier 13/13 at 295413c5; final review fixes bc82cd63..7d6f7cb2 (reversed slide, double click, two e2e checks that could not fail). Open: owner's final check on db:trial incl. tablet step 23 (V1-2-6_OWNER_TRIAL.md); BLK-016 stays open until then.
|
- [x] Criterion 32, one scrolling view row (owner GO 2026-11-21, plan `.claude/tasks/plans/2026-11-21-chip-row-criterion-32-1400.md` rev 3, contract `.claude/tasks/contracts/2026-11-21-chip-row-criterion-32-1400.md`): BUILT cbde3646..HEAD on feature/v1-2-anatomical-sheets (ViewSwitcher one row in a fixed 44 px band, viewRow.ts, pinned budget 162/154 px, thresholds 658/650 px; criterion 32 e2e re-enabled, green at the four windows). Verifier 13/13 at 295413c5; final review fixes bc82cd63..7d6f7cb2 (reversed slide, double click, two e2e checks that could not fail). Owner validated 2026-11-22 (db:trial A1-A6, B1-B6, C1-C8, D1-D4 all OK); BLK-016 resolved.
|
||||||
- [x] Anomaly `editor-annotations.spec.ts:370` (Refaire hold bubble under load) RESOLVED e9f750e4: cause = the test (scrollIntoView then press without the `settleScroll` wait every sibling bubble test uses since b5dcb766); its scroll event arrived after the press under --workers=2 load and closed the bubble (closed by any scroll, by design, kept by the owner 2026-11-20). Proof: instrumented run before (bubble on 1505.0 ms, late scroll 1509.1, off 1510.5), 3/3 instrumented runs after (trusted scroll before pointerdown, bubble stays) + clean run 39/39. Contract `.claude/tasks/contracts/2026-11-20-held-bubble-stale-scroll-1708.md`.
|
- [x] Anomaly `editor-annotations.spec.ts:370` (Refaire hold bubble under load) RESOLVED e9f750e4: cause = the test (scrollIntoView then press without the `settleScroll` wait every sibling bubble test uses since b5dcb766); its scroll event arrived after the press under --workers=2 load and closed the bubble (closed by any scroll, by design, kept by the owner 2026-11-20). Proof: instrumented run before (bubble on 1505.0 ms, late scroll 1509.1, off 1510.5), 3/3 instrumented runs after (trusted scroll before pointerdown, bubble stays) + clean run 39/39. Contract `.claude/tasks/contracts/2026-11-20-held-bubble-stale-scroll-1708.md`.
|
||||||
@@ -1,6 +1,6 @@
|
|||||||
# CONTRACT — chip-row-criterion-32
|
# CONTRACT — chip-row-criterion-32
|
||||||
- date: 2026-11-21 | flow: ship-feature | branch: feature/v1-2-anatomical-sheets
|
- date: 2026-11-21 | flow: ship-feature | branch: feature/v1-2-anatomical-sheets
|
||||||
- status: active
|
- status: closed (owner validation 2026-11-22)
|
||||||
- run-base: cbde3646
|
- run-base: cbde3646
|
||||||
|
|
||||||
## REQUEST (verbatim — IMMUTABLE)
|
## REQUEST (verbatim — IMMUTABLE)
|
||||||
|
|||||||
Reference in new issue
Block a user